ソースを参照

feat(transcribing) drop transcribing notifications

factor2
Saúl Ibarra Corretgé 1年前
コミット
00503d163a
3個のファイルの変更0行の追加79行の削除
  1. 0
    4
      lang/main.json
  2. 0
    62
      react/features/transcribing/actions.ts
  3. 0
    13
      react/features/transcribing/middleware.ts

+ 0
- 4
lang/main.json ファイルの表示

@@ -1355,13 +1355,9 @@
1355 1355
     },
1356 1356
     "transcribing": {
1357 1357
         "ccButtonTooltip": "Start / Stop subtitles",
1358
-        "error": "Transcribing failed. Please try again.",
1359 1358
         "expandedLabel": "Transcribing is currently on",
1360 1359
         "failedToStart": "Transcribing failed to start",
1361 1360
         "labelToolTip": "The meeting is being transcribed",
1362
-        "off": "Transcribing stopped",
1363
-        "on": "Transcribing started",
1364
-        "pending": "Preparing to transcribe the meeting...",
1365 1361
         "sourceLanguageDesc": "Currently the meeting language is set to <b>{{sourceLanguage}}</b>. <br/> You can change it from ",
1366 1362
         "sourceLanguageHere": "here",
1367 1363
         "start": "Start showing subtitles",

+ 0
- 62
react/features/transcribing/actions.ts ファイルの表示

@@ -1,9 +1,3 @@
1
-import { showErrorNotification, showNotification } from '../notifications/actions';
2
-import {
3
-    NOTIFICATION_TIMEOUT_TYPE,
4
-    TRANSCRIBING_NOTIFICATION_ID
5
-} from '../notifications/constants';
6
-
7 1
 import {
8 2
     _POTENTIAL_TRANSCRIBER_JOINED,
9 3
     _TRANSCRIBER_JOINED,
@@ -57,59 +51,3 @@ export function potentialTranscriberJoined(participantId: string) {
57 51
         transcriberJID: participantId
58 52
     };
59 53
 }
60
-
61
-/**
62
- * Signals that the pending transcribing notification should be shown on the
63
- * screen.
64
- *
65
- * @returns {showNotification}
66
- */
67
-export function showPendingTranscribingNotification() {
68
-    return showNotification({
69
-        descriptionKey: 'transcribing.pending',
70
-        titleKey: 'dialog.transcribing',
71
-        uid: TRANSCRIBING_NOTIFICATION_ID
72
-    }, NOTIFICATION_TIMEOUT_TYPE.LONG);
73
-}
74
-
75
-/**
76
- * Signals that the started transcribing notification should be shown on the
77
- * screen.
78
- *
79
- * @returns {showNotification}
80
- */
81
-export function showStartedTranscribingNotification() {
82
-    return showNotification({
83
-        descriptionKey: 'transcribing.on',
84
-        titleKey: 'dialog.transcribing',
85
-        uid: TRANSCRIBING_NOTIFICATION_ID
86
-    }, NOTIFICATION_TIMEOUT_TYPE.SHORT);
87
-}
88
-
89
-/**
90
- * Signals that the stopped transcribing notification should be shown on the
91
- * screen.
92
- *
93
- * @returns {showNotification}
94
- */
95
-export function showStoppedTranscribingNotification() {
96
-    return showNotification({
97
-        descriptionKey: 'transcribing.off',
98
-        titleKey: 'dialog.transcribing',
99
-        uid: TRANSCRIBING_NOTIFICATION_ID
100
-    }, NOTIFICATION_TIMEOUT_TYPE.SHORT);
101
-}
102
-
103
-
104
-/**
105
- * Signals that the transcribing error notification should be shown.
106
- *
107
- * @returns {showErrorNotification}
108
- */
109
-export function showTranscribingError() {
110
-    return showErrorNotification({
111
-        descriptionKey: 'transcribing.error',
112
-        titleKey: 'transcribing.failedToStart',
113
-        uid: TRANSCRIBING_NOTIFICATION_ID
114
-    }, NOTIFICATION_TIMEOUT_TYPE.LONG);
115
-}

+ 0
- 13
react/features/transcribing/middleware.ts ファイルの表示

@@ -4,7 +4,6 @@ import {
4 4
     PARTICIPANT_UPDATED
5 5
 } from '../base/participants/actionTypes';
6 6
 import MiddlewareRegistry from '../base/redux/MiddlewareRegistry';
7
-import { SET_REQUESTING_SUBTITLES } from '../subtitles/actionTypes';
8 7
 import { toggleRequestingSubtitles } from '../subtitles/actions.any';
9 8
 
10 9
 import {
@@ -13,9 +12,6 @@ import {
13 12
 } from './actionTypes';
14 13
 import {
15 14
     potentialTranscriberJoined,
16
-    showPendingTranscribingNotification,
17
-    showStartedTranscribingNotification,
18
-    showStoppedTranscribingNotification,
19 15
     transcriberJoined,
20 16
     transcriberLeft
21 17
 } from './actions';
@@ -31,7 +27,6 @@ const TRANSCRIBER_DISPLAY_NAME = 'Transcriber';
31 27
 // eslint-disable-next-line no-unused-vars
32 28
 MiddlewareRegistry.register(({ dispatch, getState }) => next => action => {
33 29
     const {
34
-        isTranscribing,
35 30
         transcriberJID,
36 31
         potentialTranscriberJIDs
37 32
     } = getState()['features/transcribing'];
@@ -39,7 +34,6 @@ MiddlewareRegistry.register(({ dispatch, getState }) => next => action => {
39 34
     switch (action.type) {
40 35
     case _TRANSCRIBER_JOINED: {
41 36
         notifyTranscribingStatusChanged(true);
42
-        dispatch(showStartedTranscribingNotification());
43 37
 
44 38
         const state = getState();
45 39
         const { transcription } = state['features/base/config'];
@@ -52,7 +46,6 @@ MiddlewareRegistry.register(({ dispatch, getState }) => next => action => {
52 46
     }
53 47
     case _TRANSCRIBER_LEFT: {
54 48
         notifyTranscribingStatusChanged(false);
55
-        dispatch(showStoppedTranscribingNotification());
56 49
 
57 50
         const state = getState();
58 51
         const { transcription } = state['features/base/config'];
@@ -85,12 +78,6 @@ MiddlewareRegistry.register(({ dispatch, getState }) => next => action => {
85 78
 
86 79
         break;
87 80
     }
88
-    case SET_REQUESTING_SUBTITLES:
89
-        if (action.enabled && !isTranscribing) {
90
-            dispatch(showPendingTranscribingNotification());
91
-        }
92
-
93
-        break;
94 81
 
95 82
     }
96 83
 

読み込み中…
キャンセル
保存