Selaa lähdekoodia

fix(desktop-picker): Populate list of desktop app windows to share

Fix bug introduced via #12994 where id was changed and "-tab" was appended. Due to this the selected tab was not anymore working and empty object was returned here: 05da37b56d/react/features/desktop-picker/components/DesktopPicker.tsx (L270)

Originally part of #13096 by @dudumanbogdan, but pulled ahead to fix application
window sharing via Electron desktop app.

Fixes: jitsi/jitsi-meet-electron#857
factor2
Christoph Settgast 2 vuotta sitten
vanhempi
commit
1a22b7d0dd

+ 2
- 2
react/features/desktop-picker/components/DesktopPicker.tsx Näytä tiedosto

358
                 type => {
358
                 type => {
359
                     return {
359
                     return {
360
                         accessibilityLabel: t(TAB_LABELS[type as keyof typeof TAB_LABELS]),
360
                         accessibilityLabel: t(TAB_LABELS[type as keyof typeof TAB_LABELS]),
361
-                        id: `${type}-tab`,
361
+                        id: `${type}`,
362
                         controlsId: `${type}-panel`,
362
                         controlsId: `${type}-panel`,
363
                         label: t(TAB_LABELS[type as keyof typeof TAB_LABELS])
363
                         label: t(TAB_LABELS[type as keyof typeof TAB_LABELS])
364
                     };
364
                     };
369
                 accessibilityLabel = { t('dialog.sharingTabs') }
369
                 accessibilityLabel = { t('dialog.sharingTabs') }
370
                 className = 'desktop-picker-tabs-container'
370
                 className = 'desktop-picker-tabs-container'
371
                 onChange = { this._onTabSelected }
371
                 onChange = { this._onTabSelected }
372
-                selected = { `${this.state.selectedTab}-tab` }
372
+                selected = { `${this.state.selectedTab}` }
373
                 tabs = { tabs } />);
373
                 tabs = { tabs } />);
374
     }
374
     }
375
 
375
 

Loading…
Peruuta
Tallenna