Better JitsiTrack#dispose() method to prevent memory leaks

modules/RTC/JitsiLocalTrack.js

@@ -37,7 +37,6 @@ function JitsiLocalTrack(stream, track, mediaType, videoType, resolution,
     this.resolution = resolution;
     this.deviceId = deviceId;
     this.startMuted = false;
-    this.disposed = false;
     this.initialMSID = this.getMSID();
     this.inMuteOrUnmuteProgress = false;
 
@@ -251,6 +250,7 @@ JitsiLocalTrack.prototype._setMute = function (mute, resolve, reject) {
                     }
 
                     if(!streamInfo) {
+                        // FIXME: introduce new JitsiTrackError for that
                         reject(new Error('track.no_stream_found'));
                         return;
                     }
@@ -287,9 +287,12 @@ JitsiLocalTrack.prototype._setMute = function (mute, resolve, reject) {
 /**
  * Stops sending the media track. And removes it from the HTML.
  * NOTE: Works for local tracks only.
+ *
+ * @extends JitsiTrack#dispose
  * @returns {Promise}
  */
 JitsiLocalTrack.prototype.dispose = function () {
+    var self = this;
     var promise = Promise.resolve();
 
     if (this.conference){
@@ -301,8 +304,6 @@ JitsiLocalTrack.prototype.dispose = function () {
         this.detach();
     }
 
-    this.disposed = true;
-
     RTCUtils.removeListener(RTCEvents.DEVICE_LIST_CHANGED,
         this._onDeviceListChanged);
 
@@ -311,7 +312,10 @@ JitsiLocalTrack.prototype.dispose = function () {
             this._onAudioOutputDeviceChanged);
     }
 
-    return promise;
+    return promise
+        .then(function() {
+            return JitsiTrack.prototype.dispose.call(self);
+        });
 };
 
 /**

modules/RTC/JitsiRemoteTrack.js

@@ -84,6 +84,4 @@ JitsiRemoteTrack.prototype._setVideoType = function (type) {
     this.eventEmitter.emit(JitsiTrackEvents.TRACK_VIDEOTYPE_CHANGED, type);
 };
 
-delete JitsiRemoteTrack.prototype.dispose;
-
 module.exports = JitsiRemoteTrack;

modules/RTC/JitsiTrack.js

@@ -71,6 +71,8 @@ function JitsiTrack(conference, stream, track, streamInactiveHandler, trackMedia
     this.track = track;
     this.videoType = videoType;
 
+    this.disposed = false;
+
     if(stream) {
         if (RTCBrowserType.isFirefox()) {
             implementOnEndedHandling(this);
@@ -208,10 +210,16 @@ JitsiTrack.prototype.detach = function (container) {
 };
 
 /**
- * Dispose sending the media track. And removes it from the HTML.
- * NOTE: Works for local tracks only.
+ * Removes attached event listeners.
+ *
+ * @returns {Promise}
  */
 JitsiTrack.prototype.dispose = function () {
+    this.eventEmitter.removeAllListeners();
+
+    this.disposed = true;
+
+    return Promise.resolve();
 };
 
 /**

modules/RTC/RTCUtils.js

@@ -1101,6 +1101,13 @@ var RTCUtils = {
             mediaStream.stop();
         }
 
+        // MediaStream in react-native-webrtc implementation has special
+        // "release" method to do the clean up of memory. We use it to prevent
+        // memory leaks.
+        if (mediaStream.release) {
+            mediaStream.release();
+        }
+
         // if we have done createObjectURL, lets clean it
         var url = mediaStream.jitsiObjectURL;
         if (url) {