Browse Source

Prefers local variables over instance property lookups.

master
Lyubomir Marinov 9 years ago
parent
commit
0dce3b62af
1 changed files with 5 additions and 4 deletions
  1. 5
    4
      modules/xmpp/ChatRoom.js

+ 5
- 4
modules/xmpp/ChatRoom.js View File

@@ -269,7 +269,7 @@ ChatRoom.prototype.onPresence = function (pres) {
269 269
                 if(this.lastJibri)
270 270
                     this.recording.handleJibriPresence(this.lastJibri);
271 271
             }
272
-            logger.info("Ignore focus: " + from + ", real JID: " + member.jid);
272
+            logger.info("Ignore focus: " + from + ", real JID: " + jid);
273 273
         }
274 274
         else {
275 275
             this.eventEmitter.emit(
@@ -278,15 +278,16 @@ ChatRoom.prototype.onPresence = function (pres) {
278 278
     } else {
279 279
         // Presence update for existing participant
280 280
         // Watch role change:
281
-        if (this.members[from].role != member.role) {
282
-            this.members[from].role = member.role;
281
+        var memberOfThis = this.members[from];
282
+        if (memberOfThis.role != member.role) {
283
+            memberOfThis.role = member.role;
283 284
             this.eventEmitter.emit(
284 285
                 XMPPEvents.MUC_ROLE_CHANGED, from, member.role);
285 286
         }
286 287
 
287 288
         // store the new display name
288 289
         if(member.displayName)
289
-            this.members[from].displayName = member.displayName;
290
+            memberOfThis.displayName = member.displayName;
290 291
     }
291 292
 
292 293
     // after we had fired member or room joined events, lets fire events

Loading…
Cancel
Save