Przeglądaj źródła

fix(ProxyConnectionPC): shim JitsiConference.on method

...to prevent a crash. The functionality that depends on it
is not required by ProxyConnectionPC.
master
paweldomas 5 lat temu
rodzic
commit
4e9319b10a
1 zmienionych plików z 21 dodań i 3 usunięć
  1. 21
    3
      modules/proxyconnection/ProxyConnectionPC.js

+ 21
- 3
modules/proxyconnection/ProxyConnectionPC.js Wyświetl plik

@@ -213,8 +213,8 @@ export default class ProxyConnectionPC {
213 213
         };
214 214
 
215 215
         /**
216
-         * {@code JingleSessionPC} expects an instance of
217
-         * {@code JitsiConference} to be passed in. {@code ProxyConnectionPC}
216
+         * {@link JingleSessionPC} expects an instance of
217
+         * {@link ChatRoom} to be passed in. {@link ProxyConnectionPC}
218 218
          * is instantiated outside of the {@code JitsiConference}, so it must be
219 219
          * stubbed to prevent errors.
220 220
          *
@@ -232,13 +232,31 @@ export default class ProxyConnectionPC {
232 232
             removePresenceListener: () => { /** no-op */ }
233 233
         };
234 234
 
235
+        /**
236
+         * A {@code JitsiConference} stub passed to the {@link RTC} module.
237
+         * @type {Object}
238
+         */
239
+        const conferenceStub = {
240
+            // FIXME: remove once the temporary code below is gone from
241
+            //  TraceablePeerConnection.
242
+            // TraceablePeerConnection:359
243
+            //  this.rtc.conference.on(
244
+            //         TRACK_ADDED,
245
+            //         maybeSetSenderVideoConstraints);
246
+            //     this.rtc.conference.on(
247
+            //         TRACK_MUTE_CHANGED,
248
+            //         maybeSetSenderVideoConstraints);
249
+            // eslint-disable-next-line no-empty-function
250
+            on: () => {}
251
+        };
252
+
235 253
         /**
236 254
          * Create an instance of {@code RTC} as it is required for peer
237 255
          * connection creation by {@code JingleSessionPC}. An existing instance
238 256
          * of {@code RTC} from elsewhere should not be re-used because it is
239 257
          * a stateful grouping of utilities.
240 258
          */
241
-        this._rtc = new RTC(this, {});
259
+        this._rtc = new RTC(conferenceStub, {});
242 260
 
243 261
         /**
244 262
          * Add the remote track listener here as {@code JingleSessionPC} has

Ładowanie…
Anuluj
Zapisz