瀏覽代碼

Merge pull request #1137 from jitsi/local-storage

fix(localStorage): Use JitsiLocalStorage.
master
Emil Ivov 5 年之前
父節點
當前提交
c6e8d596b0
沒有連結到貢獻者的電子郵件帳戶。
共有 3 個檔案被更改,包括 14 行新增51 行删除
  1. 11
    48
      modules/settings/Settings.js
  2. 2
    2
      package-lock.json
  3. 1
    1
      package.json

+ 11
- 48
modules/settings/Settings.js 查看文件

1
 import { getLogger } from 'jitsi-meet-logger';
1
 import { getLogger } from 'jitsi-meet-logger';
2
+import { jitsiLocalStorage } from 'js-utils';
3
+
2
 const logger = getLogger(__filename);
4
 const logger = getLogger(__filename);
3
 
5
 
4
 import UsernameGenerator from '../util/UsernameGenerator';
6
 import UsernameGenerator from '../util/UsernameGenerator';
17
      */
19
      */
18
     get callStatsUserName() {
20
     get callStatsUserName() {
19
         if (!_callStatsUserName) {
21
         if (!_callStatsUserName) {
20
-            const localStorage = getLocalStorage();
21
-
22
-            if (localStorage) {
23
-                _callStatsUserName = localStorage.getItem('callStatsUserName');
24
-            }
22
+            _callStatsUserName = jitsiLocalStorage.getItem('callStatsUserName');
25
             if (!_callStatsUserName) {
23
             if (!_callStatsUserName) {
26
                 _callStatsUserName = generateCallStatsUserName();
24
                 _callStatsUserName = generateCallStatsUserName();
27
-                if (localStorage) {
28
-                    localStorage.setItem(
29
-                        'callStatsUserName',
30
-                        _callStatsUserName);
31
-                }
25
+                jitsiLocalStorage.setItem('callStatsUserName', _callStatsUserName);
32
             }
26
             }
33
         }
27
         }
34
 
28
 
41
      */
35
      */
42
     get machineId() {
36
     get machineId() {
43
         if (!_machineId) {
37
         if (!_machineId) {
44
-            const localStorage = getLocalStorage();
45
-
46
-            if (localStorage) {
47
-                _machineId = localStorage.getItem('jitsiMeetId');
48
-            }
38
+            _machineId = jitsiLocalStorage.getItem('jitsiMeetId');
49
             if (!_machineId) {
39
             if (!_machineId) {
50
                 _machineId = generateJitsiMeetId();
40
                 _machineId = generateJitsiMeetId();
51
-                if (localStorage) {
52
-                    localStorage.setItem('jitsiMeetId', _machineId);
53
-                }
41
+                jitsiLocalStorage.setItem('jitsiMeetId', _machineId);
54
             }
42
             }
55
         }
43
         }
56
 
44
 
64
     get sessionId() {
52
     get sessionId() {
65
         // We may update sessionId in localStorage from another JitsiConference
53
         // We may update sessionId in localStorage from another JitsiConference
66
         // instance and that's why we should always re-read it.
54
         // instance and that's why we should always re-read it.
67
-        const localStorage = getLocalStorage();
68
-
69
-        return localStorage ? localStorage.getItem('sessionId') : undefined;
55
+        return jitsiLocalStorage.getItem('sessionId');
70
     },
56
     },
71
 
57
 
72
     /**
58
     /**
74
      * @param {string} sessionId session id
60
      * @param {string} sessionId session id
75
      */
61
      */
76
     set sessionId(sessionId) {
62
     set sessionId(sessionId) {
77
-        const localStorage = getLocalStorage();
78
-
79
-        if (localStorage) {
80
-            if (sessionId) {
81
-                localStorage.setItem('sessionId', sessionId);
82
-            } else {
83
-                localStorage.removeItem('sessionId');
84
-            }
63
+        if (sessionId) {
64
+            jitsiLocalStorage.setItem('sessionId', sessionId);
65
+        } else {
66
+            jitsiLocalStorage.removeItem('sessionId');
85
         }
67
         }
86
     }
68
     }
87
 };
69
 };
110
     return jitsiMeetId;
92
     return jitsiMeetId;
111
 }
93
 }
112
 
94
 
113
-/**
114
- * Gets the localStorage of the browser. (Technically, gets the localStorage of
115
- * the global object because there may be no browser but React Native for
116
- * example).
117
- * @returns {Storage} the local Storage object (if any)
118
- */
119
-function getLocalStorage() {
120
-    let storage;
121
-
122
-    try {
123
-        // eslint-disable-next-line no-invalid-this
124
-        storage = (window || this).localStorage;
125
-    } catch (error) {
126
-        logger.error(error);
127
-    }
128
-
129
-    return storage;
130
-}
131
-
132
 /**
95
 /**
133
  *
96
  *
134
  */
97
  */

+ 2
- 2
package-lock.json 查看文件

5267
       "dev": true
5267
       "dev": true
5268
     },
5268
     },
5269
     "js-utils": {
5269
     "js-utils": {
5270
-      "version": "github:jitsi/js-utils#df68966e3c65b5c57fcd2670da1326a2c77518d1",
5271
-      "from": "github:jitsi/js-utils#df68966e3c65b5c57fcd2670da1326a2c77518d1",
5270
+      "version": "github:jitsi/js-utils#0c0c4142bd559fffffaebaded80bdaba8414d6b8",
5271
+      "from": "github:jitsi/js-utils#0c0c4142bd559fffffaebaded80bdaba8414d6b8",
5272
       "requires": {
5272
       "requires": {
5273
         "bowser": "2.7.0",
5273
         "bowser": "2.7.0",
5274
         "js-md5": "0.7.3",
5274
         "js-md5": "0.7.3",

+ 1
- 1
package.json 查看文件

21
     "async": "0.9.0",
21
     "async": "0.9.0",
22
     "current-executing-script": "0.1.3",
22
     "current-executing-script": "0.1.3",
23
     "jitsi-meet-logger": "github:jitsi/jitsi-meet-logger#5ec92357570dc8f0b7ffc1528820721c84c6af8b",
23
     "jitsi-meet-logger": "github:jitsi/jitsi-meet-logger#5ec92357570dc8f0b7ffc1528820721c84c6af8b",
24
-    "js-utils": "github:jitsi/js-utils#df68966e3c65b5c57fcd2670da1326a2c77518d1",
24
+    "js-utils": "github:jitsi/js-utils#0c0c4142bd559fffffaebaded80bdaba8414d6b8",
25
     "lodash.isequal": "4.5.0",
25
     "lodash.isequal": "4.5.0",
26
     "sdp-transform": "2.3.0",
26
     "sdp-transform": "2.3.0",
27
     "strophe.js": "1.3.4",
27
     "strophe.js": "1.3.4",

Loading…
取消
儲存