Simplify, clarify source code

modules/RTC/JitsiRemoteTrack.js

@@ -30,7 +30,6 @@ JitsiRemoteTrack.prototype.constructor = JitsiRemoteTrack;
  * @param value the muted status.
  */
 JitsiRemoteTrack.prototype.setMute = function (value) {
-
     if(this.muted === value)
         return;
 

modules/RTC/JitsiTrack.js

@@ -227,8 +227,7 @@ JitsiTrack.prototype.dispose = function () {
  * Returns true if this is a video track and the source of the video is a
  * screen capture as opposed to a camera.
  */
-JitsiTrack.prototype.isScreenSharing = function(){
-
+JitsiTrack.prototype.isScreenSharing = function() {
 };
 
 /**
@@ -258,7 +257,7 @@ JitsiTrack.prototype.getId = function () {
  * @returns {boolean} whether MediaStream is active.
  */
 JitsiTrack.prototype.isActive = function () {
-    if((typeof this.stream.active !== "undefined"))
+    if(typeof this.stream.active !== "undefined")
         return this.stream.active;
     else
         return true;
@@ -289,7 +288,6 @@ JitsiTrack.prototype.off = function (eventId, handler) {
 JitsiTrack.prototype.addEventListener = JitsiTrack.prototype.on;
 JitsiTrack.prototype.removeEventListener = JitsiTrack.prototype.off;
 
-
 /**
  * Sets the audio level for the stream
  * @param audioLevel the new audio level

modules/RTC/RTCUtils.js

@@ -642,16 +642,11 @@ var RTCUtils = {
                     return SDPUtil.filter_special_chars(stream.id);
                 };
                 this.getVideoSrc = function (element) {
-                    if (!element)
-                        return null;
-                    return element.getAttribute("src");
+                    return element ? element.getAttribute("src") : null;
                 };
                 this.setVideoSrc = function (element, src) {
-                    if (!src) {
-                        src = '';
-                    }
                     if (element)
-                        element.setAttribute("src", src);
+                        element.setAttribute("src", src || '');
                 };
                 // DTLS should now be enabled by default but..
                 this.pc_constraints = {'optional': [

modules/xmpp/ChatRoom.js

@@ -704,8 +704,8 @@ ChatRoom.prototype.removeListener = function (type, listener) {
 ChatRoom.prototype.remoteTrackAdded = function(data) {
     // Will figure out current muted status by looking up owner's presence
     var pres = this.lastPresences[data.owner];
-    var mediaType = data.mediaType;
     if(pres) {
+        var mediaType = data.mediaType;
         var mutedNode = null;
         if (mediaType === MediaType.AUDIO) {
             mutedNode = filterNodeFromPresenceJSON(pres, "audiomuted");

modules/xmpp/JingleSessionPC.js

@@ -1257,7 +1257,7 @@ JingleSessionPC.prototype.remoteTrackAdded = function (stream, track) {
     }
 
     var remoteSDP = new SDP(this.peerconnection.remoteDescription.sdp);
-    var medialines = remoteSDP.media.filter(function (mediaLines){
+    var medialines = remoteSDP.media.filter(function (mediaLines) {
         return mediaLines.startsWith("m=" + mediaType);
     });
 
@@ -1268,11 +1268,8 @@ JingleSessionPC.prototype.remoteTrackAdded = function (stream, track) {
 
     var ssrclines = SDPUtil.find_lines(medialines[0], 'a=ssrc:');
     ssrclines = ssrclines.filter(function (line) {
-        if (RTCBrowserType.isTemasysPluginUsed()) {
-            return ((line.indexOf('mslabel:' + streamId) !== -1));
-        } else {
-            return ((line.indexOf('msid:' + streamId) !== -1));
-        }
+        var msid = RTCBrowserType.isTemasysPluginUsed() ? 'mslabel' : 'msid';
+        return line.indexOf(msid + ':' + streamId) !== -1;
     });
 
     var thessrc;