Start callStats as soon as second participant join the room, maybe even without established jingle session and peer connection

JitsiConference.js

@@ -944,8 +944,12 @@ function setupListeners(conference) {
                         "Failed to accept incoming Jingle session", error);
                 }
             );
-            conference.statistics.startRemoteStats(
-                    jingleSession.peerconnection);
+            // Start callstats as soon as peerconnection is initialized,
+            // do not wait for XMPPEvents.PEERCONNECTION_READY, as it may never
+            // happen in case if user doesn't have or denied permission to
+            // both camera and microphone.
+            conference.statistics.startCallStats(jingleSession, conference.settings);
+            conference.statistics.startRemoteStats(jingleSession.peerconnection);
         } else {
             // Error cause this should never happen unless something is wrong!
             var errmsg
@@ -1296,12 +1300,6 @@ function setupListeners(conference) {
                 conference.statistics.dispose();
             });
 
-        conference.room.addListener(XMPPEvents.PEERCONNECTION_READY,
-            function (session) {
-                conference.statistics.startCallStats(
-                    session, conference.settings);
-            });
-
         conference.room.addListener(XMPPEvents.CONNECTION_ICE_FAILED,
             function (pc) {
                 conference.statistics.sendIceConnectionFailedEvent(pc);

JitsiMeetJS.js

@@ -8,6 +8,7 @@ var JitsiConnectionErrors = require("./JitsiConnectionErrors");
 var JitsiConferenceErrors = require("./JitsiConferenceErrors");
 var JitsiTrackEvents = require("./JitsiTrackEvents");
 var JitsiTrackErrors = require("./JitsiTrackErrors");
+var JitsiTrackError = require("./JitsiTrackError");
 var JitsiRecorderErrors = require("./JitsiRecorderErrors");
 var Logger = require("jitsi-meet-logger");
 var MediaType = require("./service/RTC/MediaType");
@@ -219,6 +220,10 @@ var LibJitsiMeet = {
 // JitsiConnection.
 LibJitsiMeet.JitsiConnection = JitsiConnection.bind(null, LibJitsiMeet);
 
+// expose JitsiTrackError this way to give library consumers to do checks like
+// if (error instanceof JitsiMeetJS.JitsiTrackError) { }
+LibJitsiMeet.JitsiTrackError = JitsiTrackError;
+
 //Setups the promise object.
 window.Promise = window.Promise || require("es6-promise").Promise;
 

JitsiTrackError.js

@@ -62,17 +62,13 @@ function JitsiTrackError(error, options, devices) {
                 this.message = error.message
                     || TRACK_ERROR_TO_MESSAGE_MAP[
                         JitsiTrackErrors.PERMISSION_DENIED]
-                        + Object.keys(options || {}).filter(function (k) {
-                            return !!options[k];
-                        }).join(", ");
+                        + (this.gum.devices || []).join(", ");
                 break;
             case "NotFoundError":
                 this.name = JitsiTrackErrors.NOT_FOUND;
-                this.message = error.message
-                    || TRACK_ERROR_TO_MESSAGE_MAP[JitsiTrackErrors.NOT_FOUND]
-                        + Object.keys(options || {}).filter(function (k) {
-                            return !!options[k];
-                        }).join(", ");
+                this.message = TRACK_ERROR_TO_MESSAGE_MAP[
+                        JitsiTrackErrors.NOT_FOUND]
+                        + (this.gum.devices || []).join(", ");
                 break;
             case "ConstraintNotSatisfiedError":
             case "OverconstrainedError":

modules/statistics/statistics.js

@@ -28,6 +28,35 @@ function loadCallStatsAPI() {
  */
 var LOG_INTERVAL = 60000;
 
+/**
+ * callstats strips any additional fields from Error except for "name", "stack",
+ * "message" and "constraintName". So we need to bundle additional information
+ * from JitsiTrackError into error passed to callstats to preserve valuable
+ * information about error.
+ * @param {JitsiTrackError} error
+ */
+function formatJitsiTrackErrorForCallStats(error) {
+    var err = new Error();
+
+    // Just copy original stack from error
+    err.stack = error.stack;
+
+    // Combine name from error's name plus (possibly) name of original GUM error
+    err.name = (error.name || "Unknown error") + (error.gum && error.gum.error
+        && error.gum.error.name ? " - " + error.gum.error.name : "");
+
+    // Put all constraints into this field. For constraint failed errors we will
+    // still know which exactly constraint failed as it will be a part of
+    // message.
+    err.constraintName = error.gum && error.gum.constraints
+        ? JSON.stringify(error.gum.constraints) : "";
+
+    // Just copy error's message.
+    err.message = error.message;
+
+    return err;
+}
+
 function Statistics(xmpp, options) {
     this.rtpStats = null;
     this.eventEmitter = new EventEmitter();