Procházet zdrojové kódy

fix(VAD): Do not enable VAD on Chrome on iOS.

This causes the audio to not work.
release-8443
Jaya Allamsetty před 4 roky
rodič
revize
0cdfb79c2e
Žádný účet není propojen s e-mailovou adresou tvůrce revize
1 změnil soubory, kde provedl 11 přidání a 10 odebrání
  1. 11
    10
      modules/browser/BrowserCapabilities.js

+ 11
- 10
modules/browser/BrowserCapabilities.js Zobrazit soubor

@@ -37,22 +37,23 @@ export default class BrowserCapabilities extends BrowserDetection {
37 37
     }
38 38
 
39 39
     /**
40
-     * Checks if the current browser is Chromium based, that is, it's either
41
-     * Chrome / Chromium or uses it as its engine, but doesn't identify as
42
-     * Chrome.
40
+     * Checks if the current browser is Chromium based, i.e., it's either Chrome / Chromium or uses it as its engine,
41
+     * but doesn't identify as Chrome.
43 42
      *
44 43
      * This includes the following browsers:
45
-     * - Chrome and Chromium
46
-     * - Other browsers which use the Chrome engine, but are detected as Chrome,
47
-     *   such as Brave and Vivaldi
48
-     * - Browsers which are NOT Chrome but use it as their engine, and have
49
-     *   custom detection code: Opera, Electron and NW.JS
44
+     * - Chrome and Chromium.
45
+     * - Other browsers which use the Chrome engine, but are detected as Chrome, such as Brave and Vivaldi.
46
+     * - Browsers which are NOT Chrome but use it as their engine, and have custom detection code: Opera, Electron
47
+     *   and NW.JS.
48
+     * This excludes
49
+     * - Chrome on iOS since it uses WKWebView.
50 50
      */
51 51
     isChromiumBased() {
52
-        return this.isChrome()
52
+        return (this.isChrome()
53 53
             || this.isElectron()
54 54
             || this.isNWJS()
55
-            || this.isOpera();
55
+            || this.isOpera())
56
+            && !this.isWebKitBased();
56 57
     }
57 58
 
58 59
     /**

Načítá se…
Zrušit
Uložit