Kaynağa Gözat

fix(quality) Sends updated receiver constraints.

Fixes a regression for JitsiConference::setReceiverVideoConstraint and JitsiConference::setAssumedBandwidthBps.
release-8443
Jaya Allamsetty 1 yıl önce
ebeveyn
işleme
0ef83147ee

+ 1
- 1
modules/RTC/RTC.js Dosyayı Görüntüle

305
             return;
305
             return;
306
         }
306
         }
307
 
307
 
308
-        this._receiverVideoConstraints = constraints;
308
+        this._receiverVideoConstraints = cloneDeep(constraints);
309
 
309
 
310
         if (this._channel && this._channel.isOpen()) {
310
         if (this._channel && this._channel.isOpen()) {
311
             this._channel.sendReceiverVideoConstraintsMessage(constraints);
311
             this._channel.sendReceiverVideoConstraintsMessage(constraints);

+ 4
- 3
modules/qualitycontrol/ReceiveVideoController.js Dosyayı Görüntüle

74
     /**
74
     /**
75
      * Updates the source based constraints based on the maxHeight set.
75
      * Updates the source based constraints based on the maxHeight set.
76
      *
76
      *
77
+     * @param {number} maxFrameHeight - the height to be requested for remote sources.
77
      * @returns {void}
78
      * @returns {void}
78
      */
79
      */
79
-    _updateIndividualConstraints() {
80
+    _updateIndividualConstraints(maxFrameHeight) {
80
         const individualConstraints = this._receiverVideoConstraints.constraints;
81
         const individualConstraints = this._receiverVideoConstraints.constraints;
81
 
82
 
82
         if (individualConstraints && Object.keys(individualConstraints).length) {
83
         if (individualConstraints && Object.keys(individualConstraints).length) {
83
             for (const value of Object.values(individualConstraints)) {
84
             for (const value of Object.values(individualConstraints)) {
84
-                value.maxHeight = Math.min(value.maxHeight, this._maxFrameHeight);
85
+                value.maxHeight = maxFrameHeight ?? Math.min(value.maxHeight, this._maxFrameHeight);
85
             }
86
             }
86
         } else {
87
         } else {
87
             this._receiverVideoConstraints.defaultConstraints = { 'maxHeight': this._maxFrameHeight };
88
             this._receiverVideoConstraints.defaultConstraints = { 'maxHeight': this._maxFrameHeight };
184
             if (session.isP2P) {
185
             if (session.isP2P) {
185
                 session.setReceiverVideoConstraint(this._getDefaultSourceReceiverConstraints(session, maxFrameHeight));
186
                 session.setReceiverVideoConstraint(this._getDefaultSourceReceiverConstraints(session, maxFrameHeight));
186
             } else {
187
             } else {
187
-                this._updateIndividualConstraints();
188
+                this._updateIndividualConstraints(maxFrameHeight);
188
                 this._rtc.setReceiverVideoConstraints(this._receiverVideoConstraints);
189
                 this._rtc.setReceiverVideoConstraints(this._receiverVideoConstraints);
189
             }
190
             }
190
         }
191
         }

Loading…
İptal
Kaydet