fix(TPC): Make sure all RTCRtpSender:setParameters calls are sequential.

Recommit 17ade96a70 with the jvb leak fix.

modules/RTC/TPCUtils.js

@@ -108,6 +108,25 @@ export class TPCUtils {
         ];
     }
 
+    /**
+     * Updates the sender parameters in the stream encodings.
+     *
+     * @param {RTCRtpSender} sender - the sender associated with a MediaStreamTrack.
+     * @param {boolean} enable - whether the streams needs to be enabled or disabled.
+     * @returns {Promise} - A promise that resolves when the operation is successful, rejected otherwise.
+     */
+    _updateSenderEncodings(sender, enable) {
+        const parameters = sender.getParameters();
+
+        if (parameters?.encodings?.length) {
+            for (const encoding of parameters.encodings) {
+                encoding.active = enable;
+            }
+        }
+
+        return sender.setParameters(parameters);
+    }
+
     /**
      * Ensures that the ssrcs associated with a FID ssrc-group appear in the correct order, i.e.,
      * the primary ssrc first and the secondary rtx ssrc later. This is important for unified
@@ -485,13 +504,12 @@ export class TPCUtils {
             return Promise.resolve();
         }
         parameters.encodings = this._getStreamEncodings(track);
-        const promise = transceiver.sender.setParameters(parameters);
 
         if (mediaType === MediaType.VIDEO) {
-            return this.pc._updateVideoSenderParameters(promise);
+            return this.pc._updateVideoSenderParameters(() => transceiver.sender.setParameters(parameters));
         }
 
-        return promise;
+        return transceiver.sender.setParameters(parameters);
     }
 
     /**
@@ -512,19 +530,10 @@ export class TPCUtils {
         const promises = [];
 
         for (const sender of senders) {
-            const parameters = sender.getParameters();
-
-            if (parameters?.encodings?.length) {
-                for (const encoding of parameters.encodings) {
-                    encoding.active = enable;
-                }
-            }
-            const setActivePromise = sender.setParameters(parameters);
-
             if (sender.track.kind === MediaType.VIDEO) {
-                promises.push(this.pc._updateVideoSenderParameters(setActivePromise));
+                promises.push(this.pc._updateVideoSenderParameters(() => this._updateSenderEncodings(sender, enable)));
             } else {
-                promises.push(setActivePromise);
+                promises.push(this._updateSenderEncodings(sender, enable));
             }
         }
 

modules/RTC/TraceablePeerConnection.js

@@ -2671,7 +2671,8 @@ TraceablePeerConnection.prototype.setSenderVideoConstraints = function(frameHeig
 
     this._senderMaxHeights.set(sourceName, frameHeight);
 
-    return this._updateVideoSenderParameters(this._updateVideoSenderEncodings(frameHeight, localVideoTrack));
+    return this._updateVideoSenderParameters(
+        () => this._updateVideoSenderEncodings(frameHeight, localVideoTrack));
 };
 
 /**
@@ -2679,12 +2680,12 @@ TraceablePeerConnection.prototype.setSenderVideoConstraints = function(frameHeig
  * This is needed on Chrome as it resets the transaction id after executing setParameters() and can affect the next on
  * the fly updates if they are not chained.
  * https://chromium.googlesource.com/external/webrtc/+/master/pc/rtp_sender.cc#340
- * @param {Promise} promise - The promise that needs to be chained.
+ * @param {Function} nextFunction - The function to be called when the last video sender update promise is settled.
  * @returns {Promise}
  */
-TraceablePeerConnection.prototype._updateVideoSenderParameters = function(promise) {
+TraceablePeerConnection.prototype._updateVideoSenderParameters = function(nextFunction) {
     const nextPromise = this._lastVideoSenderUpdatePromise
-        .finally(() => promise);
+        .finally(nextFunction);
 
     this._lastVideoSenderUpdatePromise = nextPromise;