Selaa lähdekoodia

fix(Firefox): Enable RTX support on Firefox

Add RFC 4588 to the list of advertised features on Firefox.
Use RtxModifier only for cases when simulcast is achieved through SDP munging
This will ensure that RTX is negotiated whenever it is offered by the browser.
release-8443
Jaya Allamsetty 5 vuotta sitten
vanhempi
commit
49dd19c04a

+ 2
- 2
modules/RTC/TraceablePeerConnection.js Näytä tiedosto

@@ -2430,7 +2430,7 @@ TraceablePeerConnection.prototype._createOfferOrAnswer = function(
2430 2430
                     dumpSDP(resultSdp));
2431 2431
             }
2432 2432
 
2433
-            if (!this.options.disableRtx && browser.supportsRtx()) {
2433
+            if (!this.options.disableRtx && browser.usesSdpMungingForSimulcast()) {
2434 2434
                 // eslint-disable-next-line no-param-reassign
2435 2435
                 resultSdp = new RTCSessionDescription({
2436 2436
                     type: resultSdp.type,
@@ -2645,7 +2645,7 @@ TraceablePeerConnection.prototype.generateNewStreamSSRCInfo = function(track) {
2645 2645
             groups: []
2646 2646
         };
2647 2647
     }
2648
-    if (!this.options.disableRtx && browser.supportsRtx()) {
2648
+    if (!this.options.disableRtx) {
2649 2649
         // Specifically use a for loop here because we'll
2650 2650
         //  be adding to the list we're iterating over, so we
2651 2651
         //  only want to iterate through the items originally

+ 1
- 10
modules/browser/BrowserCapabilities.js Näytä tiedosto

@@ -148,15 +148,6 @@ export default class BrowserCapabilities extends BrowserDetection {
148 148
         return this.isFirefox() || this.isSafari();
149 149
     }
150 150
 
151
-    /**
152
-     * Checks whether the browser supports RTX.
153
-     *
154
-     * @returns {boolean}
155
-     */
156
-    supportsRtx() {
157
-        return !this.isFirefox();
158
-    }
159
-
160 151
     /**
161 152
      * Returns whether or not the current browser can support capturing video,
162 153
      * be it camera or desktop, and displaying received video.
@@ -182,7 +173,7 @@ export default class BrowserCapabilities extends BrowserDetection {
182 173
      * @returns {boolean}
183 174
      */
184 175
     usesSdpMungingForSimulcast() {
185
-        return this.isChromiumBased() || this.isSafari();
176
+        return this.isChromiumBased() || this.isReactNative() || this.isSafari();
186 177
     }
187 178
 
188 179
     /**

+ 1
- 1
modules/xmpp/xmpp.js Näytä tiedosto

@@ -147,7 +147,7 @@ export default class XMPP extends Listenable {
147 147
         this.caps.addFeature('urn:xmpp:jingle:apps:rtp:audio');
148 148
         this.caps.addFeature('urn:xmpp:jingle:apps:rtp:video');
149 149
 
150
-        if (!this.options.disableRtx && browser.supportsRtx()) {
150
+        if (!this.options.disableRtx) {
151 151
             this.caps.addFeature('urn:ietf:rfc:4588');
152 152
         }
153 153
 

Loading…
Peruuta
Tallenna