feat(RTC) drop no longer needed isDeviceListAvailable()

We require navigator.mediaDevices.enumerateDevices to exist.

JitsiMediaDevices.js

@@ -156,16 +156,6 @@ class JitsiMediaDevices extends Listenable {
         RTC.enumerateDevices(callback);
     }
 
-    /**
-     * Checks if its possible to enumerate available cameras/micropones.
-     * @returns {Promise<boolean>} a Promise which will be resolved only once
-     * the WebRTC stack is ready, either with true if the device listing is
-     * available available or with false otherwise.
-     */
-    isDeviceListAvailable() {
-        return RTC.isDeviceListAvailable();
-    }
-
     /**
      * Returns true if changing the input (camera / microphone) or output
      * (audio) device is supported and false if not.

modules/RTC/RTC.js

@@ -582,14 +582,6 @@ export default class RTC extends Listenable {
         return RTCUtils.attachMediaStream(elSelector, stream);
     }
 
-    /**
-     * Returns true if retrieving the list of input devices is supported
-     * and false if not.
-     */
-    static isDeviceListAvailable() {
-        return RTCUtils.isDeviceListAvailable();
-    }
-
     /**
      * Returns true if changing the input (camera / microphone) or output
      * (audio) device is supported and false if not.

modules/RTC/RTCUtils.js

@@ -281,30 +281,28 @@ class RTCUtils extends Listenable {
 
         screenObtainer.init(options);
 
-        if (this.isDeviceListAvailable()) {
-            this.enumerateDevices(ds => {
-                availableDevices = ds.slice(0);
-
-                logger.debug('Available devices: ', availableDevices);
-                sendDeviceListToAnalytics(availableDevices);
-
-                this.eventEmitter.emit(
-                    RTCEvents.DEVICE_LIST_AVAILABLE,
-                    availableDevices);
-
-                if (browser.supportsDeviceChangeEvent()) {
-                    navigator.mediaDevices.addEventListener(
-                        'devicechange',
-                        () => this.enumerateDevices(emptyFuncton));
-                } else {
-                    // Periodically poll enumerateDevices() method to check if
-                    // list of media devices has changed.
-                    availableDevicesPollTimer = window.setInterval(
-                        () => this.enumerateDevices(emptyFuncton),
-                        AVAILABLE_DEVICES_POLL_INTERVAL_TIME);
-                }
-            });
-        }
+        this.enumerateDevices(ds => {
+            availableDevices = ds.slice(0);
+
+            logger.debug('Available devices: ', availableDevices);
+            sendDeviceListToAnalytics(availableDevices);
+
+            this.eventEmitter.emit(
+                RTCEvents.DEVICE_LIST_AVAILABLE,
+                availableDevices);
+
+            if (browser.supportsDeviceChangeEvent()) {
+                navigator.mediaDevices.addEventListener(
+                    'devicechange',
+                    () => this.enumerateDevices(emptyFuncton));
+            } else {
+                // Periodically poll enumerateDevices() method to check if
+                // list of media devices has changed.
+                availableDevicesPollTimer = window.setInterval(
+                    () => this.enumerateDevices(emptyFuncton),
+                    AVAILABLE_DEVICES_POLL_INTERVAL_TIME);
+            }
+        });
     }
 
     /**
@@ -709,18 +707,6 @@ class RTCUtils extends Listenable {
             });
     }
 
-    /**
-     * Checks whether it is possible to enumerate available cameras/microphones.
-     *
-     * @returns {boolean} {@code true} if the device listing is available;
-     * {@code false}, otherwise.
-     */
-    isDeviceListAvailable() {
-        return Boolean(
-            navigator.mediaDevices
-                && navigator.mediaDevices.enumerateDevices);
-    }
-
     /**
      * Returns true if changing the input (camera / microphone) or output
      * (audio) device is supported and false if not.

types/hand-crafted/JitsiMediaDevices.d.ts

@@ -2,7 +2,6 @@ import { MediaType } from './service/RTC/MediaType';
 
 declare class JitsiMediaDevices {
   enumerateDevices: ( callback: ( devices: MediaDeviceInfo[] ) => void ) => void;
-  isDeviceListAvailable: () => Promise<boolean>;
   isDeviceChangeAvailable: ( deviceType: string ) => boolean;
   isDevicePermissionGranted: ( type: MediaType ) => Promise<boolean>;
   isMultipleAudioInputSupported: () => boolean;

types/hand-crafted/JitsiMeetJS.d.ts

@@ -124,10 +124,6 @@ export type JitsiMeetJSType = {
 
   createLocalTracksFromMediaStreams: ( tracksInfo: unknown[] ) => JitsiLocalTrack[]; // TODO:
 
-  // isDeviceListAvailable: () => boolean; // obsosete
-
-  // isDeviceChangeAvailable: ( deviceType: string ) => boolean; // obsosete
-
   isMultipleAudioInputSupported: () => boolean;
 
   isCollectingLocalStats: () => boolean;

types/hand-crafted/modules/RTC/RTC.d.ts

@@ -25,7 +25,6 @@ export default class RTC extends Listenable {
   setAudioMute: ( value: unknown ) => Promise<unknown>; // TODO:
   removeLocalTrack: ( track: unknown ) => void; // TODO:
   static attachMediaStream: ( elSelector: unknown, stream: unknown ) => unknown; // TODO:
-  static isDeviceListAvailable: () => unknown; // TODO:
   static isDeviceChangeAvailable: ( deviceType: string ) => boolean; // TODO: check if deviceType should be an enum
   static isWebRtcSupported: () => boolean;
   static getAudioOutputDevice: () => string;

types/hand-crafted/modules/RTC/RTCUtils.d.ts

@@ -5,7 +5,6 @@ declare class RTCUtils extends Listenable {
   init: ( options: unknown ) => void; // TODO:
   getUserMediaWithConstraints: ( um: MediaType[], options: { resolution: string, bandwidth: number, fps: number, desktopStream: string, cameraDeviceId: string, micDeviceId: string, frameRate: { min: unknown, max: unknown }, screenShareAudio: boolean, timeout: number } ) => Promise<unknown>; // TODO:
   obtainAudioAndVideoPermissions: ( options: { devices: unknown[], resolution: string, cameraDeviceId: string, micDeviceId: string, desktopSharingFrameRate: { min: unknown, max: unknown } } ) => Promise<unknown>; // TODO:
-  isDeviceListAvailable: () => boolean;
   isDeviceChangeAvailable: ( deviceType: string ) => boolean;
   stopMediaStream: ( mediaStream: MediaStream ) => void;
   isDesktopSharingEnabled: () => boolean;