feat(build) make commit hash generation process generic

This way we can use it both in Webpack and TS builds.

.gitignore

@@ -20,3 +20,6 @@ types/auto
 types/types-comparer/auto.json
 types/types-comparer/hand-crafted.json
 *.tgz
+
+# Make sure we never commit a commit hash.
+version.ts

JitsiMeetJS.ts

@@ -36,6 +36,7 @@ import * as ConnectionQualityEvents
     from './service/connectivity/ConnectionQualityEvents';
 import * as E2ePingEvents from './service/e2eping/E2ePingEvents';
 import { createGetUserMediaEvent } from './service/statistics/AnalyticsEvents';
+import { COMMIT_HASH } from './version';
 
 const logger = Logger.getLogger('JitsiMeetJS');
 
@@ -109,7 +110,7 @@ interface ICreateLocalTrackFromMediaStreamOptions {
  */
 export default {
 
-    version: '{#COMMIT_HASH#}',
+    version: COMMIT_HASH,
 
     JitsiConnection,
 

package-lock.json

@@ -44,7 +44,6 @@
         "karma-sourcemap-loader": "0.3.8",
         "karma-webpack": "5.0.0",
         "process": "0.11.10",
-        "string-replace-loader": "3.0.3",
         "typedoc": "0.28.1",
         "typescript": "5.0.4",
         "webpack": "5.98.0",
@@ -7796,51 +7795,6 @@
         "node": ">=8.0"
       }
     },
-    "node_modules/string-replace-loader": {
-      "version": "3.0.3",
-      "resolved": "https://registry.npmjs.org/string-replace-loader/-/string-replace-loader-3.0.3.tgz",
-      "integrity": "sha512-8c26Dl6H9XmKNj3mFBvaUYR7ImOxQ4YRBFuUju78wXpa1cDpyDYvKmqGg8mfkxdYexQ/BBogB7PELlLnmR08nw==",
-      "dev": true,
-      "dependencies": {
-        "loader-utils": "^2.0.0",
-        "schema-utils": "^3.0.0"
-      },
-      "peerDependencies": {
-        "webpack": "^5"
-      }
-    },
-    "node_modules/string-replace-loader/node_modules/loader-utils": {
-      "version": "2.0.4",
-      "resolved": "https://registry.npmjs.org/loader-utils/-/loader-utils-2.0.4.tgz",
-      "integrity": "sha512-xXqpXoINfFhgua9xiqD8fPFHgkoq1mmmpE92WlDbm9rNRd/EbRb+Gqf908T2DMfuHjjJlksiK2RbHVOdD/MqSw==",
-      "dev": true,
-      "dependencies": {
-        "big.js": "^5.2.2",
-        "emojis-list": "^3.0.0",
-        "json5": "^2.1.2"
-      },
-      "engines": {
-        "node": ">=8.9.0"
-      }
-    },
-    "node_modules/string-replace-loader/node_modules/schema-utils": {
-      "version": "3.1.1",
-      "resolved": "https://registry.npmjs.org/schema-utils/-/schema-utils-3.1.1.tgz",
-      "integrity": "sha512-Y5PQxS4ITlC+EahLuXaY86TXfR7Dc5lw294alXOq86JAHCihAIZfqv8nNCWvaEJvaC51uN9hbLGeV0cFBdH+Fw==",
-      "dev": true,
-      "dependencies": {
-        "@types/json-schema": "^7.0.8",
-        "ajv": "^6.12.5",
-        "ajv-keywords": "^3.5.2"
-      },
-      "engines": {
-        "node": ">= 10.13.0"
-      },
-      "funding": {
-        "type": "opencollective",
-        "url": "https://opencollective.com/webpack"
-      }
-    },
     "node_modules/string-width": {
       "version": "4.2.3",
       "resolved": "https://registry.npmjs.org/string-width/-/string-width-4.2.3.tgz",
@@ -14545,40 +14499,6 @@
         "fs-extra": "^10.0.0"
       }
     },
-    "string-replace-loader": {
-      "version": "3.0.3",
-      "resolved": "https://registry.npmjs.org/string-replace-loader/-/string-replace-loader-3.0.3.tgz",
-      "integrity": "sha512-8c26Dl6H9XmKNj3mFBvaUYR7ImOxQ4YRBFuUju78wXpa1cDpyDYvKmqGg8mfkxdYexQ/BBogB7PELlLnmR08nw==",
-      "dev": true,
-      "requires": {
-        "loader-utils": "^2.0.0",
-        "schema-utils": "^3.0.0"
-      },
-      "dependencies": {
-        "loader-utils": {
-          "version": "2.0.4",
-          "resolved": "https://registry.npmjs.org/loader-utils/-/loader-utils-2.0.4.tgz",
-          "integrity": "sha512-xXqpXoINfFhgua9xiqD8fPFHgkoq1mmmpE92WlDbm9rNRd/EbRb+Gqf908T2DMfuHjjJlksiK2RbHVOdD/MqSw==",
-          "dev": true,
-          "requires": {
-            "big.js": "^5.2.2",
-            "emojis-list": "^3.0.0",
-            "json5": "^2.1.2"
-          }
-        },
-        "schema-utils": {
-          "version": "3.1.1",
-          "resolved": "https://registry.npmjs.org/schema-utils/-/schema-utils-3.1.1.tgz",
-          "integrity": "sha512-Y5PQxS4ITlC+EahLuXaY86TXfR7Dc5lw294alXOq86JAHCihAIZfqv8nNCWvaEJvaC51uN9hbLGeV0cFBdH+Fw==",
-          "dev": true,
-          "requires": {
-            "@types/json-schema": "^7.0.8",
-            "ajv": "^6.12.5",
-            "ajv-keywords": "^3.5.2"
-          }
-        }
-      }
-    },
     "string-width": {
       "version": "4.2.3",
       "resolved": "https://registry.npmjs.org/string-width/-/string-width-4.2.3.tgz",

package.json

@@ -51,7 +51,6 @@
     "karma-sourcemap-loader": "0.3.8",
     "karma-webpack": "5.0.0",
     "process": "0.11.10",
-    "string-replace-loader": "3.0.3",
     "typedoc": "0.28.1",
     "typescript": "5.0.4",
     "webpack": "5.98.0",
@@ -59,11 +58,12 @@
     "webpack-cli": "4.9.0"
   },
   "scripts": {
-    "build": "npm run build:webpack && npm run build:tsc",
+    "build": "npm run gen-version && npm run build:webpack && npm run build:tsc",
     "build:webpack": "webpack",
-    "build:webpack-dev": "webpack --mode development",
+    "build:webpack-dev": "npm run gen-version && webpack --mode development",
     "build:tsc": "tsc --build --clean && tsc",
     "gen-types": "tsc --declaration --emitDeclarationOnly --outFile types/index.d.ts",
+    "gen-version": "node tools/gen-version.js",
     "lint": "eslint . --max-warnings 0",
     "lint-fix": "eslint . --max-warnings 0 --fix",
     "prepack": "npm run build && npm run gen-types",
@@ -71,7 +71,7 @@
     "test-watch": "karma start karma.conf.js --no-single-run",
     "typedoc": "typedoc",
     "validate": "npm ls",
-    "watch": "webpack --config webpack.config.js --watch --mode development"
+    "watch": "npm run gen-version && webpack --config webpack.config.js --watch --mode development"
   },
   "browser": "dist/umd/lib-jitsi-meet.min.js",
   "module": "dist/esm/JitsiMeetJS.js",

tools/gen-version.js

@@ -0,0 +1,21 @@
+/* global __dirname */
+
+const { execSync } = require('child_process');
+const { writeFileSync } = require('fs');
+const { join } = require('path');
+const process = require('process');
+
+const devNull = process.platform === 'win32' ? 'nul' : '/dev/null';
+const commitHash = process.env.LIB_JITSI_MEET_COMMIT_HASH
+    || execSync(`git rev-parse --short HEAD 2>${devNull} || echo development`)
+        .toString()
+        .trim();
+const outputPath = join(__dirname, '..', 'version.ts');
+
+writeFileSync(
+  outputPath,
+  `// This file is auto-generated during build
+export const COMMIT_HASH = '${commitHash}';\n`
+);
+
+console.log(`Generated commit hash: ${commitHash}`);

webpack-shared-config.js

@@ -1,16 +1,6 @@
-/* global __dirname */
-
-const { execSync } = require('child_process');
-const path = require('path');
-const process = require('process');
 const { IgnorePlugin, ProvidePlugin } = require('webpack');
 const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer');
 
-const devNull = process.platform === 'win32' ? 'nul' : '/dev/null';
-const commitHash = process.env.LIB_JITSI_MEET_COMMIT_HASH
-    || execSync(`git rev-parse --short HEAD 2>${devNull} || echo development`)
-        .toString()
-        .trim();
 
 module.exports = (minimize, analyzeBundle) => {
     return {
@@ -25,16 +15,6 @@ module.exports = (minimize, analyzeBundle) => {
         mode: minimize ? 'production' : 'development',
         module: {
             rules: [ {
-                // Version this build of the lib-jitsi-meet library.
-
-                loader: 'string-replace-loader',
-                options: {
-                    flags: 'g',
-                    replace: commitHash,
-                    search: '{#COMMIT_HASH#}'
-                },
-                test: path.join(__dirname, 'JitsiMeetJS.ts')
-            }, {
                 // Transpile ES2015 (aka ES6) to ES5.
 
                 loader: 'babel-loader',