ESLint

Our JSHint configuration is not extensive and we have excluded multiple
files from linting. Additionally, we have seen JSHint to be unable to
parse newer ECMAScript features such as the object spread operator
(proposal).

On the other hand, we have seen ESLint to beautifully work on React and
React Native source code in addition to ES2015 and later. Introduce
ESLint alongside JSHint as an intermediate step to eventually switching
from JSHint to ESLint.

As our source code does not fully follow even the JSHint rules we have,
it is very difficult to introduce ESLint with many rules. At the
beginning, introduce it with as little rules as possible. Morever,
ESLint is able to automatically fix certain rule offenders so once we
have ESLint merged we can incrementally add new rules while keeping our
commits' modification on as little subjects as possible.

.eslintignore

@@ -0,0 +1,15 @@
+# The build artifacts of the lib-jiti-meet project.
+lib-jitsi-meet.js
+lib-jitsi-meet.js.map
+lib-jitsi-meet.min.js
+lib-jitsi-meet.min.map
+
+# Third-party source code which we (1) do not want to modify or (2) try to
+# modify as little as possible.
+libs/*
+modules/RTC/adapter.screenshare.js
+
+# ESLint will by default ignore its own configuration file. However, there does
+# not seem to be a reason why we will want to risk being inconsistent with our
+# remaining JavaScript source code.
+!.eslintrc.js

.eslintrc.js

@@ -0,0 +1,34 @@
+module.exports = {
+    'env': {
+        'browser': true,
+        'commonjs': true,
+        'es6': true
+    },
+    'extends': 'eslint:recommended',
+    'globals': {
+        // The globals that (1) are accessed but not defined within many of our
+        // files, (2) are certainly defined, and (3) we would like to use
+        // without explicitly specifying them (using a comment) inside of our
+        // files.
+        '__filename': false
+    },
+    'parserOptions': {
+        'sourceType': 'module'
+    },
+    'rules': {
+        'new-cap': [
+            'error',
+            {
+                'capIsNew': false // Behave like JSHint's newcap.
+            }
+        ],
+        // While it is considered a best practice to avoid using methods on
+        // console in JavaScript that is designed to be executed in the browser
+        // and ESLint includes the rule among its set of recommended rules, (1)
+        // the general practice is to strip such calls before pushing to
+        // production and (2) we prefer to utilize console in lib-jitsi-meet
+        // (and jitsi-meet).
+        'no-console': 'off',
+        'semi': 'error'
+    }
+};

JitsiConference.js

@@ -1,5 +1,5 @@
 /* global Strophe, $, Promise */
-/* jshint -W101 */
+
 var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTC = require("./modules/RTC/RTC");
 var XMPPEvents = require("./service/xmpp/XMPPEvents");
@@ -105,7 +105,6 @@ JitsiConference.prototype._init = function (options) {
         this.statistics = new Statistics(this.xmpp, {
             callStatsID: this.options.config.callStatsID,
             callStatsSecret: this.options.config.callStatsSecret,
-            callStatsSecret: this.options.config.callStatsSecret,
             callStatsCustomScriptUrl:
                 this.options.config.callStatsCustomScriptUrl,
             roomName: this.options.name
@@ -123,7 +122,7 @@ JitsiConference.prototype._init = function (options) {
             this.eventEmitter.emit(JitsiConferenceEvents.TALK_WHILE_MUTED);
         });
     }
-}
+};
 
 /**
  * Joins the conference.
@@ -156,7 +155,8 @@ JitsiConference.prototype._leaveRoomAndRemoveParticipants = function () {
     }
 
     this.room = null;
-}
+};
+
 /**
  * Leaves the conference.
  * @returns {Promise}
@@ -534,7 +534,7 @@ JitsiConference.prototype.onTrackRemoved = function (track) {
         this.statistics.sendScreenSharingEvent(false);
 
     this.eventEmitter.emit(JitsiConferenceEvents.TRACK_REMOVED, track);
-}
+};
 
 /**
  * Removes JitsiLocalTrack object to the conference.
@@ -831,7 +831,7 @@ function (jingleSession, jingleOffer, now) {
         jingleSession.initialize(false /* initiator */,this.room);
     } catch (error) {
         GlobalOnErrorHandler.callErrorHandler(error);
-    };
+    }
 
     this.rtc.onIncommingCall(jingleSession);
     // Add local Tracks to the ChatRoom
@@ -999,14 +999,14 @@ JitsiConference.prototype.isRecordingSupported = function () {
  */
 JitsiConference.prototype.getRecordingState = function () {
     return (this.room) ? this.room.getRecordingState() : undefined;
-}
+};
 
 /**
  * Returns the url of the recorded video.
  */
 JitsiConference.prototype.getRecordingURL = function () {
     return (this.room) ? this.room.getRecordingURL() : null;
-}
+};
 
 /**
  * Starts/stops the recording
@@ -1020,7 +1020,7 @@ JitsiConference.prototype.toggleRecording = function (options) {
     this.eventEmitter.emit(
         JitsiConferenceEvents.RECORDER_STATE_CHANGED, "error",
         new Error("The conference is not created yet!"));
-}
+};
 
 /**
  * Returns true if the SIP calls are supported and false otherwise
@@ -1029,7 +1029,7 @@ JitsiConference.prototype.isSIPCallingSupported = function () {
     if(this.room)
         return this.room.isSIPCallingSupported();
     return false;
-}
+};
 
 /**
  * Dials a number.
@@ -1039,8 +1039,8 @@ JitsiConference.prototype.dial = function (number) {
     if(this.room)
         return this.room.dial(number);
     return new Promise(function(resolve, reject){
-        reject(new Error("The conference is not created yet!"))});
-}
+        reject(new Error("The conference is not created yet!"));});
+};
 
 /**
  * Hangup an existing call
@@ -1049,8 +1049,8 @@ JitsiConference.prototype.hangup = function () {
     if(this.room)
         return this.room.hangup();
     return new Promise(function(resolve, reject){
-        reject(new Error("The conference is not created yet!"))});
-}
+        reject(new Error("The conference is not created yet!"));});
+};
 
 /**
  * Returns the phone number for joining the conference.
@@ -1059,7 +1059,7 @@ JitsiConference.prototype.getPhoneNumber = function () {
     if(this.room)
         return this.room.getPhoneNumber();
     return null;
-}
+};
 
 /**
  * Returns the pin for joining the conference with phone.
@@ -1068,7 +1068,7 @@ JitsiConference.prototype.getPhonePin = function () {
     if(this.room)
         return this.room.getPhonePin();
     return null;
-}
+};
 
 /**
  * Returns the connection state for the current room. Its ice connection state
@@ -1078,7 +1078,7 @@ JitsiConference.prototype.getConnectionState = function () {
     if(this.room)
         return this.room.getConnectionState();
     return null;
-}
+};
 
 /**
  * Make all new participants mute their audio/video on join.
@@ -1169,7 +1169,7 @@ JitsiConference.prototype.setLocalParticipantProperty = function(name, value) {
 JitsiConference.prototype.sendFeedback =
 function(overallFeedback, detailedFeedback){
     this.statistics.sendFeedback(overallFeedback, detailedFeedback);
-}
+};
 
 /**
  * Returns true if the callstats integration is enabled, otherwise returns
@@ -1180,7 +1180,7 @@ function(overallFeedback, detailedFeedback){
  */
 JitsiConference.prototype.isCallstatsEnabled = function () {
     return this.statistics.isCallstatsEnabled();
-}
+};
 
 
 /**
@@ -1196,7 +1196,7 @@ JitsiConference.prototype._onTrackAttach = function(track, container) {
     }
     this.statistics.associateStreamWithVideoTag(
         ssrc, track.isLocal(), track.getUsageLabel(), container.id);
-}
+};
 
 /**
  * Reports detected audio problem with the media stream related to the passed
@@ -1252,7 +1252,7 @@ JitsiConference.prototype._reportAudioProblem = function (ssrc) {
             id: mtrack.id,
             label: mtrack.label,
             muted: mtrack.muted
-        }
+        };
         logger.log("enabled: ", mtrack.enabled);
         logger.log("id: ", mtrack.id);
         logger.log("label: ", mtrack.label);
@@ -1334,7 +1334,7 @@ JitsiConference.prototype._fireIncompatibleVersionsEvent = function () {
  */
 JitsiConference.prototype.sendEndpointMessage = function (to, payload) {
     this.rtc.sendDataChannelMessage(to, payload);
-}
+};
 
 /**
  * Sends broadcast message via the datachannels.
@@ -1343,6 +1343,6 @@ JitsiConference.prototype.sendEndpointMessage = function (to, payload) {
  */
 JitsiConference.prototype.broadcastEndpointMessage = function (payload) {
     this.sendEndpointMessage("", payload);
-}
+};
 
 module.exports = JitsiConference;

JitsiConferenceEventManager.js

@@ -158,7 +158,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function () {
         });
 
     chatRoom.addListener(XMPPEvents.CONNECTION_ICE_FAILED,
-        function (pc) {
+        function () {
             chatRoom.eventEmitter.emit(
                 XMPPEvents.CONFERENCE_SETUP_FAILED,
                 new Error("ICE fail"));

JitsiConnection.js

@@ -1,5 +1,4 @@
 var JitsiConference = require("./JitsiConference");
-import * as JitsiConnectionErrors from "./JitsiConnectionErrors";
 import * as JitsiConnectionEvents from "./JitsiConnectionEvents";
 import XMPP from "./modules/xmpp/xmpp";
 var Statistics = require("./modules/statistics/statistics");
@@ -48,7 +47,7 @@ JitsiConnection.prototype.connect = function (options) {
         options = {};
 
     this.xmpp.connect(options.id, options.password);
-}
+};
 
 /**
  * Attach to existing connection. Can be used for optimizations. For example:
@@ -59,7 +58,7 @@ JitsiConnection.prototype.connect = function (options) {
  */
 JitsiConnection.prototype.attach = function (options) {
     this.xmpp.attach(options);
-}
+};
 
 /**
  * Disconnect the client from the server.
@@ -72,7 +71,7 @@ JitsiConnection.prototype.disconnect = function () {
     var x = this.xmpp;
 
     x.disconnect.apply(x, arguments);
-}
+};
 
 /**
  * This method allows renewal of the tokens if they are expiring.
@@ -80,7 +79,7 @@ JitsiConnection.prototype.disconnect = function () {
  */
 JitsiConnection.prototype.setToken = function (token) {
     this.token = token;
-}
+};
 
 /**
  * Creates and joins new conference.
@@ -95,7 +94,7 @@ JitsiConnection.prototype.initJitsiConference = function (name, options) {
         = new JitsiConference({name: name, config: options, connection: this});
     this.conferences[name] = conference;
     return conference;
-}
+};
 
 /**
  * Subscribes the passed listener to the event.
@@ -104,7 +103,7 @@ JitsiConnection.prototype.initJitsiConference = function (name, options) {
  */
 JitsiConnection.prototype.addEventListener = function (event, listener) {
     this.xmpp.addListener(event, listener);
-}
+};
 
 /**
  * Unsubscribes the passed handler.
@@ -113,7 +112,7 @@ JitsiConnection.prototype.addEventListener = function (event, listener) {
  */
 JitsiConnection.prototype.removeEventListener = function (event, listener) {
     this.xmpp.removeListener(event, listener);
-}
+};
 
 /**
  * Returns measured connectionTimes.

JitsiMediaDevices.js

@@ -130,7 +130,7 @@ var JitsiMediaDevices = {
      * Emits an event.
      * @param {string} event - event name
      */
-    emitEvent: function (event) {
+    emitEvent: function (event) { // eslint-disable-line no-unused-vars
         eventEmitter.emit.apply(eventEmitter, arguments);
     }
 };

JitsiMeetJS.js

@@ -31,7 +31,7 @@ function getLowerResolution(resolution) {
     var order = Resolutions[resolution].order;
     var res = null;
     var resName = null;
-    for(var i in Resolutions) {
+    for(let i in Resolutions) {
         var tmp = Resolutions[i];
         if (!res || (res.order < tmp.order && tmp.order < order)) {
             resName = i;
@@ -91,7 +91,7 @@ var LibJitsiMeet = {
     mediaDevices: JitsiMediaDevices,
     analytics: null,
     init: function (options) {
-        var logObject, attr;
+        let logObject, attr;
         Statistics.init(options);
         this.analytics = Statistics.analytics;
 
@@ -119,7 +119,7 @@ var LibJitsiMeet = {
                 id: "component_version",
                 component: "lib-jitsi-meet",
                 version: this.version
-            }
+            };
             Statistics.sendLog(JSON.stringify(logObject));
         }
 
@@ -203,8 +203,8 @@ var LibJitsiMeet = {
                     "getUserMedia.success", options), options);
 
                 if(!RTC.options.disableAudioLevels)
-                    for(var i = 0; i < tracks.length; i++) {
-                        var track = tracks[i];
+                    for(let i = 0; i < tracks.length; i++) {
+                        const track = tracks[i];
                         var mStream = track.getOriginalStream();
                         if(track.getType() === MediaType.AUDIO){
                             Statistics.startLocalStats(mStream,
@@ -221,8 +221,8 @@ var LibJitsiMeet = {
                 var currentlyAvailableMediaDevices
                     = RTC.getCurrentlyAvailableMediaDevices();
                 if (currentlyAvailableMediaDevices) {
-                    for(var i = 0; i < tracks.length; i++) {
-                        var track = tracks[i];
+                    for(let i = 0; i < tracks.length; i++) {
+                        const track = tracks[i];
                         track._setRealDeviceIdFromDeviceList(
                             currentlyAvailableMediaDevices);
                     }
@@ -254,7 +254,7 @@ var LibJitsiMeet = {
                     // User cancelled action is not really an error, so only
                     // log it as an event to avoid having conference classified
                     // as partially failed
-                    var logObject = {
+                    const logObject = {
                         id: "chrome_extension_user_canceled",
                         message: error.message
                     };
@@ -263,7 +263,7 @@ var LibJitsiMeet = {
                         "getUserMedia.userCancel.extensionInstall");
                 } else if (JitsiTrackErrors.NOT_FOUND === error.name) {
                     // logs not found devices with just application log to cs
-                    var logObject = {
+                    const logObject = {
                         id: "usermedia_missing_device",
                         status: error.gum.devices
                     };

connection_optimization/external_connect.js

@@ -20,8 +20,10 @@
  * callback is going to receive one parameter which is going to be JS error
  * object with a reason for failure in it.
  */
-function createConnectionExternally(webserviceUrl, success_callback,
-    error_callback) {
+function createConnectionExternally( // eslint-disable-line no-unused-vars
+        webserviceUrl,
+        success_callback,
+        error_callback) {
     if (!window.XMLHttpRequest) {
         error_callback(new Error("XMLHttpRequest is not supported!"));
         return;

doc/example/example.js

@@ -1,3 +1,5 @@
+/* global $, JitsiMeetJS */
+
 var options = {
     hosts: {
         domain: 'jitsi-meet.example.com',
@@ -5,12 +7,11 @@ var options = {
     },
     bosh: '//jitsi-meet.example.com/http-bind', // FIXME: use xep-0156 for that
     clientNode: 'http://jitsi.org/jitsimeet', // The name of client node advertised in XEP-0115 'c' stanza
-}
+};
 
 var confOptions = {
     openSctp: true
-}
-
+};
 
 var isJoined = false;
 
@@ -103,7 +104,7 @@ function onUserLeft(id) {
         return;
     var tracks = remoteTracks[id];
     for(var i = 0; i< tracks.length; i++)
-        tracks[i].detach($("#" + id + tracks[i].getType()))
+        tracks[i].detach($("#" + id + tracks[i].getType()));
 }
 
 /**
@@ -139,12 +140,14 @@ function onConnectionSuccess(){
             room.getPhonePin());
     });
     room.join();
-};
+}
 
 /**
  * This function is called when the connection fail.
  */
-function onConnectionFailed(){console.error("Connection Failed!")};
+function onConnectionFailed() {
+    console.error("Connection Failed!");
+}
 
 /**
  * This function is called when the connection fail.
@@ -169,8 +172,9 @@ function unload() {
     room.leave();
     connection.disconnect();
 }
+
 var isVideo = true;
-function switchVideo() {
+function switchVideo() { // eslint-disable-line no-unused-vars
     isVideo = !isVideo;
     if(localTracks[1]) {
         localTracks[1].dispose();
@@ -194,15 +198,13 @@ function switchVideo() {
         });
 }
 
-function changeAudioOutput(selected) {
+function changeAudioOutput(selected) { // eslint-disable-line no-unused-vars
     JitsiMeetJS.mediaDevices.setAudioOutputDevice(selected.value);
 }
 
 $(window).bind('beforeunload', unload);
 $(window).bind('unload', unload);
 
-
-
 // JitsiMeetJS.setLogLevel(JitsiMeetJS.logLevels.ERROR);
 var initOptions = {
     disableAudioLevels: true,
@@ -229,7 +231,7 @@ var initOptions = {
     desktopSharingFirefoxMaxVersionExtRequired: -1,
     // The URL to the Firefox extension for desktop sharing.
     desktopSharingFirefoxExtensionURL: null
-}
+};
 JitsiMeetJS.init(initOptions).then(function(){
     connection = new JitsiMeetJS.JitsiConnection(null, null, options);
 
@@ -248,7 +250,6 @@ JitsiMeetJS.init(initOptions).then(function(){
     console.log(error);
 });
 
-
 if (JitsiMeetJS.mediaDevices.isDeviceChangeAvailable('output')) {
     JitsiMeetJS.mediaDevices.enumerateDevices(function(devices) {
         var audioOutputDevices = devices.filter(function(d) { return d.kind === 'audiooutput'; });
@@ -262,7 +263,7 @@ if (JitsiMeetJS.mediaDevices.isDeviceChangeAvailable('output')) {
 
             $('#audioOutputSelectWrapper').show();
         }
-    })
+    });
 }
 
 var connection = null;

modules/RTC/DataChannels.js

@@ -1,5 +1,3 @@
-/* global config, APP, Strophe */
-
 // cache datachannels to avoid garbage collection
 // https://code.google.com/p/chromium/issues/detail?id=405545
 
@@ -7,7 +5,6 @@ var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTCEvents = require("../../service/RTC/RTCEvents");
 var GlobalOnErrorHandler = require("../util/GlobalOnErrorHandler");
 
-
 /**
  * Binds "ondatachannel" event listener to given PeerConnection instance.
  * @param peerConnection WebRTC peer connection instance.
@@ -40,8 +37,7 @@ function DataChannels(peerConnection, emitter) {
      var msgData = event.data;
      logger.info("Got My Data Channel Message:", msgData, dataChannel);
      };*/
-};
-
+}
 
 /**
  * Callback triggered by PeerConnection when new data channel is opened
@@ -65,11 +61,11 @@ DataChannels.prototype.onDataChannel = function (event) {
     };
 
     dataChannel.onerror = function (error) {
-        var e = new Error("Data Channel Error:" + error);
         // FIXME: this one seems to be generated a bit too often right now
         // so we are temporarily commenting it before we have more clarity
         // on which of the errors we absolutely need to report
-        //GlobalOnErrorHandler.callErrorHandler(e);
+        //GlobalOnErrorHandler.callErrorHandler(
+        //        new Error("Data Channel Error:" + error));
         logger.error("Data Channel Error:", error, dataChannel);
     };
 
@@ -267,7 +263,7 @@ DataChannels.prototype.send = function (jsonObject) {
     })) {
         throw new Error("No opened data channels found!");
     }
-}
+};
 
 /**
  * Sends message via the datachannels.
@@ -284,6 +280,6 @@ DataChannels.prototype.sendDataChannelMessage = function (to, payload) {
         to: to,
         msgPayload: payload
     });
-}
+};
 
 module.exports = DataChannels;

modules/RTC/JitsiLocalTrack.js

@@ -164,7 +164,7 @@ JitsiLocalTrack.prototype._clearNoDataFromSourceMuteResources = function () {
         this._noDataFromSourceTimeout = null;
     }
     this._setHandler("track_unmute", undefined);
-}
+};
 
 /**
  * Called when potential camera issue is detected. Clears the handlers and
@@ -175,7 +175,7 @@ JitsiLocalTrack.prototype._onNoDataFromSourceError = function () {
     this._clearNoDataFromSourceMuteResources();
     if(this._checkForCameraIssues())
         this._fireNoDataFromSourceEvent();
-}
+};
 
 /**
  * Fires JitsiTrackEvents.NO_DATA_FROM_SOURCE and logs it to analytics and
@@ -184,7 +184,7 @@ JitsiLocalTrack.prototype._onNoDataFromSourceError = function () {
 JitsiLocalTrack.prototype._fireNoDataFromSourceEvent = function () {
     this.eventEmitter.emit(JitsiTrackEvents.NO_DATA_FROM_SOURCE);
     Statistics.sendEventToAll(this.getType() + ".no_data_from_source");
-}
+};
 
 /**
  * Sets real device ID by comparing track information with device information.
@@ -545,7 +545,7 @@ JitsiLocalTrack.prototype._setByteSent = function (bytesSent) {
         }.bind(this), 3000);
         this._testByteSent = false;
     }
-}
+};
 
 /**
  * Returns facing mode for video track from camera. For other cases (e.g. audio
@@ -595,7 +595,7 @@ JitsiLocalTrack.prototype._stopMediaStream = function () {
     this.stopStreamInProgress = true;
     RTCUtils.stopMediaStream(this.stream);
     this.stopStreamInProgress = false;
-}
+};
 
 /**
  * Detects camera issues on ended and mute events from MediaStreamTrack.
@@ -607,7 +607,7 @@ JitsiLocalTrack.prototype._checkForCameraIssues = function () {
         return false;
 
     return !this._isReceivingData();
-}
+};
 
 /**
  * Checks whether the attached MediaStream is reveiving data from source or
@@ -631,6 +631,6 @@ JitsiLocalTrack.prototype._isReceivingData = function () {
     return this.stream.getTracks().some(track =>
         ((!("readyState" in track) || track.readyState === "live")
             && (!("muted" in track) || track.muted === false)));
-}
+};
 
 module.exports = JitsiLocalTrack;

modules/RTC/JitsiRemoteTrack.js

@@ -1,8 +1,8 @@
-/* global __filename, module */
-var logger = require("jitsi-meet-logger").getLogger(__filename);
+/* global Strophe */
 
 var JitsiTrack = require("./JitsiTrack");
 import * as JitsiTrackEvents from "../../JitsiTrackEvents";
+var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTCBrowserType = require("./RTCBrowserType");
 var RTCEvents = require("../../service/RTC/RTCEvents");
 var Statistics = require("../statistics/statistics");

modules/RTC/JitsiTrack.js

@@ -1,7 +1,6 @@
 /* global __filename, module */
 var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTCBrowserType = require("./RTCBrowserType");
-var RTCEvents = require("../../service/RTC/RTCEvents");
 var RTCUtils = require("./RTCUtils");
 import * as JitsiTrackEvents from "../../JitsiTrackEvents";
 var EventEmitter = require("events");
@@ -113,7 +112,7 @@ JitsiTrack.prototype._setHandler = function (type, handler) {
             track[trackHandler2Prop[type]] = handler;
         }, this);
     }
-}
+};
 
 /**
  * Sets the stream property of JitsiTrack object and sets all stored handlers
@@ -126,7 +125,7 @@ JitsiTrack.prototype._setStream = function (stream) {
         typeof(this.handlers[type]) === "function" &&
             this._setHandler(type, this.handlers[type]);
     }, this);
-}
+};
 
 /**
  * Returns the type (audio or video) of this track.
@@ -275,6 +274,7 @@ JitsiTrack.prototype.detach = function (container) {
  *        method has been called previously on video or audio HTML element.
  * @private
  */
+// eslint-disable-next-line no-unused-vars
 JitsiTrack.prototype._attachTTFMTracker = function (container) {
 };
 

modules/RTC/RTC.js

@@ -1,10 +1,9 @@
-/* global __filename, APP, module */
+/* global Strophe */
+
 var logger = require("jitsi-meet-logger").getLogger(__filename);
 var EventEmitter = require("events");
-var RTCBrowserType = require("./RTCBrowserType");
 var RTCEvents = require("../../service/RTC/RTCEvents.js");
 var RTCUtils = require("./RTCUtils.js");
-var JitsiTrack = require("./JitsiTrack");
 var JitsiLocalTrack = require("./JitsiLocalTrack.js");
 import JitsiTrackError from "../../JitsiTrackError";
 import * as JitsiTrackErrors from "../../JitsiTrackErrors";
@@ -184,7 +183,7 @@ RTC.addListener = function (eventType, listener) {
 };
 
 RTC.removeListener = function (eventType, listener) {
-    RTCUtils.removeListener(eventType, listener)
+    RTCUtils.removeListener(eventType, listener);
 };
 
 RTC.isRTCReady = function () {
@@ -548,7 +547,7 @@ RTC.prototype.handleRemoteTrackMute = function (type, isMuted, from) {
     if (track) {
         track.setMute(isMuted);
     }
-}
+};
 
 /**
  * Handles remote track video type events
@@ -560,7 +559,7 @@ RTC.prototype.handleRemoteTrackVideoTypeChanged = function (value, from) {
     if (videoTrack) {
         videoTrack._setVideoType(value);
     }
-}
+};
 
 /**
  * Sends message via the datachannels.
@@ -576,6 +575,6 @@ RTC.prototype.sendDataChannelMessage = function (to, payload) {
     } else {
         throw new Error("Data channels support is disabled!");
     }
-}
+};
 
 module.exports = RTC;

modules/RTC/RTCUIHelper.js

@@ -1,7 +1,7 @@
-/* global $, __filename */
+/* global $ */
+
 var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTCBrowserType = require("./RTCBrowserType");
-var RTC = require('./RTC');
 
 var RTCUIHelper = {
 
@@ -58,7 +58,7 @@ var RTCUIHelper = {
      */
     setAutoPlay: function (streamElement, autoPlay) {
         if (!RTCBrowserType.isIExplorer()) {
-            streamElement.autoplay = true;
+            streamElement.autoplay = autoPlay;
         }
     }
 };

modules/RTC/RTCUtils.js

@@ -1,9 +1,16 @@
-/* global config, require, attachMediaStream, getUserMedia,
-   RTCPeerConnection, RTCSessionDescription, RTCIceCandidate, MediaStreamTrack,
-   mozRTCPeerConnection, mozRTCSessionDescription, mozRTCIceCandidate,
-   webkitRTCPeerConnection, webkitMediaStream, webkitURL
+/* global $,
+          attachMediaStream,
+          MediaStreamTrack,
+          RTCIceCandidate,
+          RTCPeerConnection,
+          RTCSessionDescription,
+          mozRTCIceCandidate,
+          mozRTCPeerConnection,
+          mozRTCSessionDescription,
+          webkitMediaStream,
+          webkitRTCPeerConnection,
+          webkitURL
 */
-/* jshint -W101 */
 
 var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTCBrowserType = require("./RTCBrowserType");
@@ -14,7 +21,6 @@ var SDPUtil = require("../xmpp/SDPUtil");
 var EventEmitter = require("events");
 var screenObtainer = require("./ScreenObtainer");
 import JitsiTrackError from "../../JitsiTrackError";
-import * as JitsiTrackErrors from "../../JitsiTrackErrors";
 var MediaType = require("../../service/RTC/MediaType");
 var VideoType = require("../../service/RTC/VideoType");
 var CameraFacingMode = require("../../service/RTC/CameraFacingMode");
@@ -586,6 +592,7 @@ function handleLocalStream(streams, resolution) {
         if (audioVideo) {
             var audioTracks = audioVideo.getAudioTracks();
             if (audioTracks.length) {
+                // eslint-disable-next-line new-cap
                 audioStream = new webkitMediaStream();
                 for (var i = 0; i < audioTracks.length; i++) {
                     audioStream.addTrack(audioTracks[i]);
@@ -594,6 +601,7 @@ function handleLocalStream(streams, resolution) {
 
             var videoTracks = audioVideo.getVideoTracks();
             if (videoTracks.length) {
+                // eslint-disable-next-line new-cap
                 videoStream = new webkitMediaStream();
                 for (var j = 0; j < videoTracks.length; j++) {
                     videoStream.addTrack(videoTracks[j]);
@@ -670,7 +678,7 @@ function wrapAttachMediaStream(origAttachMediaStream) {
         }
 
         return res;
-    }
+    };
 }
 
 /**
@@ -777,8 +785,10 @@ var RTCUtils = {
                     }
                     return SDPUtil.filter_special_chars(id);
                 };
+                /* eslint-disable no-native-reassign */
                 RTCSessionDescription = mozRTCSessionDescription;
                 RTCIceCandidate = mozRTCIceCandidate;
+                /* eslint-enable no-native-reassign */
             } else if (RTCBrowserType.isChrome() ||
                     RTCBrowserType.isOpera() ||
                     RTCBrowserType.isNWJS() ||
@@ -842,7 +852,7 @@ var RTCUtils = {
                 //AdapterJS.WebRTCPlugin.setLogLevel(
                 //    AdapterJS.WebRTCPlugin.PLUGIN_LOG_LEVELS.VERBOSE);
                 var self = this;
-                AdapterJS.webRTCReady(function (isPlugin) {
+                AdapterJS.webRTCReady(function () {
 
                     self.peerconnection = RTCPeerConnection;
                     self.getUserMedia = window.getUserMedia;
@@ -881,10 +891,7 @@ var RTCUtils = {
                 });
             } else {
                 var errmsg = 'Browser does not appear to be WebRTC-capable';
-                try {
-                    logger.error(errmsg);
-                } catch (e) {
-                }
+                logger.error(errmsg);
                 reject(new Error(errmsg));
                 return;
             }
@@ -910,7 +917,6 @@ var RTCUtils = {
     **/
     getUserMediaWithConstraints: function ( um, success_callback, failure_callback, options) {
         options = options || {};
-        var resolution = options.resolution;
         var constraints = getConstraints(um, options);
 
         logger.info("Get media constraints", constraints);
@@ -1051,7 +1057,7 @@ var RTCUtils = {
                                 // set to not ask for permissions)
                                 self.getUserMediaWithConstraints(
                                     devices,
-                                    function (stream) {
+                                    function () {
                                         // we already failed to obtain this
                                         // media, so we are not supposed in any
                                         // way to receive success for this call

modules/RTC/ScreenObtainer.js

@@ -1,5 +1,5 @@
 /* global chrome, $, alert */
-/* jshint -W003 */
+
 var logger = require("jitsi-meet-logger").getLogger(__filename);
 var RTCBrowserType = require("./RTCBrowserType");
 var AdapterJS = require("./adapter.screenshare");
@@ -40,14 +40,14 @@ var GUM = null;
  * The error returned by chrome when trying to start inline installation from
  * popup.
  */
-var CHROME_EXTENSION_POPUP_ERROR =
-    "Inline installs can not be initiated from pop-up windows.";
+const CHROME_EXTENSION_POPUP_ERROR
+    = "Inline installs can not be initiated from pop-up windows.";
 
 /**
  * The error message returned by chrome when the extension is installed.
  */
-var CHROME_NO_EXTENSION_ERROR_MSG =
-    "Could not establish connection. Receiving end does not exist.";
+const CHROME_NO_EXTENSION_ERROR_MSG // eslint-disable-line no-unused-vars
+    = "Could not establish connection. Receiving end does not exist.";
 
 /**
  * Handles obtaining a stream from a screen capture on different browsers.

modules/statistics/AnalyticsAdapter.js

@@ -34,9 +34,9 @@ AnalyticsAdapter.prototype.sendEvent = function (action, data, label) {
         }
     }
     try {
-        this.analytics.sendEvent(
-            action, data, label, this.browserName);
-    } catch (ignored) {}
+        this.analytics.sendEvent(action, data, label, this.browserName);
+    } catch (ignored) { // eslint-disable-line no-empty
+    }
 };
 
 /**
@@ -65,4 +65,4 @@ AnalyticsAdapter.prototype.loaded = function () {
     }
 };
 
-module.exports = new AnalyticsAdapter();
+module.exports = new AnalyticsAdapter();

modules/statistics/CallStats.js

@@ -139,7 +139,7 @@ function _try_catch (f) {
 var CallStats = _try_catch(function(jingleSession, Settings, options) {
     try{
         CallStats.feedbackEnabled = false;
-        callStats = new callstats($, io, jsSHA);
+        callStats = new callstats($, io, jsSHA); // eslint-disable-line new-cap
 
         this.session = jingleSession;
         this.peerconnection = jingleSession.peerconnection.peerconnection;

modules/statistics/LocalStatsCollector.js

@@ -1,4 +1,3 @@
-/* global config */
 /**
  * Provides statistics for the local stream.
  */

modules/statistics/RTPStatsCollector.js

@@ -1,5 +1,4 @@
 /* global require */
-/* jshint -W101 */
 
 var GlobalOnErrorHandler = require("../util/GlobalOnErrorHandler");
 var logger = require("jitsi-meet-logger").getLogger(__filename);
@@ -468,7 +467,7 @@ StatsCollector.prototype._defineGetStatValueMethod = function (keys) {
         // example, if item has a stat property of type function, then it's very
         // likely that whoever defined it wanted you to call it in order to
         // retrieve the value associated with a specific key.
-        itemStatByKey = function (item, key) { return item.stat(key) };
+        itemStatByKey = function (item, key) { return item.stat(key); };
         break;
     case RTCBrowserType.RTC_BROWSER_REACT_NATIVE:
         // The implementation provided by react-native-webrtc follows the
@@ -488,14 +487,14 @@ StatsCollector.prototype._defineGetStatValueMethod = function (keys) {
         };
         break;
     default:
-        itemStatByKey = function (item, key) { return item[key] };
+        itemStatByKey = function (item, key) { return item[key]; };
     }
 
     // Compose the 2 functions defined above to get a function which retrieves
     // the value from a specific report returned by RTCPeerConnection#getStats
     // associated with a specific LibJitsiMeet browser-agnostic name.
     return function (item, name) {
-        return itemStatByKey(item, keyFromName(name))
+        return itemStatByKey(item, keyFromName(name));
     };
 };
 
@@ -540,7 +539,7 @@ StatsCollector.prototype.processStatsReport = function () {
             var conferenceStatsTransport = this.conferenceStats.transport;
             if(!conferenceStatsTransport.some(function (t) { return (
                         t.ip == ip && t.type == type && t.localip == localip
-                    )})) {
+                    );})) {
                 conferenceStatsTransport.push(
                     {ip: ip, type: type, localip: localip});
             }

modules/transcription/audioRecorder.js

@@ -1,4 +1,5 @@
-/* global APP, MediaRecorder, MediaStream, webkitMediaStream*/
+/* global MediaRecorder, MediaStream, webkitMediaStream */
+
 var RecordingResult = require("./recordingResult");
 
 /**
@@ -297,7 +298,7 @@ function createEmptyStream() {
         return new MediaStream();
     }
     else if(typeof(webkitMediaStream) !== 'undefined') {
-        return new webkitMediaStream();
+        return new webkitMediaStream(); // eslint-disable-line new-cap
     }
     else {
         throw new Error("cannot create a clean mediaStream");
@@ -307,4 +308,4 @@ function createEmptyStream() {
 /**
  * export the main object audioRecorder
  */
-module.exports = audioRecorder;
+module.exports = audioRecorder;

modules/transcription/transcriptionServices/AbstractTranscriptionService.js

@@ -41,6 +41,7 @@ TranscriptionService.prototype.send = function send(recordingResult, callback){
  * @param {function} callback function which will retrieve the answer
  *                            from the service
  */
+// eslint-disable-next-line no-unused-vars
 TranscriptionService.prototype.sendRequest = function(audioBlob, callback) {
     throw new Error("TranscriptionService.sendRequest is abstract");
 };
@@ -60,6 +61,7 @@ TranscriptionService.prototype.sendRequest = function(audioBlob, callback) {
  *                 formatted
  * @return {Array<Word>} an array of Word objects
  */
+// eslint-disable-next-line no-unused-vars
 TranscriptionService.prototype.formatResponse = function(response){
     throw new Error("TranscriptionService.format is abstract");
 };
@@ -70,8 +72,9 @@ TranscriptionService.prototype.formatResponse = function(response){
  * @param response the response from the server
  * @return {boolean} true if response is valid, false otherwise
  */
+// eslint-disable-next-line no-unused-vars
 TranscriptionService.prototype.verify = function(response){
       throw new Error("TranscriptionService.verify is abstract");
 };
 
-module.exports = TranscriptionService;
+module.exports = TranscriptionService;

modules/transcription/transcriptionServices/SphinxTranscriptionService.js

@@ -1,4 +1,4 @@
-/* global config,  XMLHttpRequest, console, APP, JSON */
+/* global config */
 
 var TranscriptionService = require("./AbstractTranscriptionService");
 var Word = require( "../word");
@@ -127,4 +127,4 @@ function getURL() {
     }
 }
 
-module.exports = SphinxService;
+module.exports = SphinxService;

modules/transcription/word.js

@@ -2,9 +2,9 @@
  * An object representing a transcribed word, with some additional information
  * @param word the word 
  * @param begin the time the word was started being uttered
- * @param end the tome the word stopped being uttered
+ * @param end the time the word stopped being uttered
  */
-var Word = function (word, begin, end, name) {
+var Word = function (word, begin, end) {
     this.word = word;
     this.begin = begin;
     this.end = end;
@@ -34,4 +34,4 @@ Word.prototype.getEndTime = function () {
     return this.end;
 };
 
-module.exports = Word;
+module.exports = Word;

modules/util/EventEmitterForwarder.js

@@ -1,5 +1,3 @@
-var EventEmitter = require("events");
-
 /**
  * Implements utility to forward events from one eventEmitter to another.
  * @param src {object} instance of EventEmitter or another class that implements

modules/xmpp/ChatRoom.js

@@ -1,5 +1,5 @@
 /* global Strophe, $, $pres, $iq, $msg */
-/* jshint -W101,-W069 */
+
 import {getLogger} from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 var XMPPEvents = require("../../service/xmpp/XMPPEvents");
@@ -9,14 +9,12 @@ var EventEmitter = require("events");
 var Recorder = require("./recording");
 var GlobalOnErrorHandler = require("../util/GlobalOnErrorHandler");
 
-var JIBRI_XMLNS = 'http://jitsi.org/protocol/jibri';
-
 var parser = {
     packet2JSON: function (packet, nodes) {
         var self = this;
-        $(packet).children().each(function (index) {
+        $(packet).children().each(function () {
             var tagName = $(this).prop("tagName");
-            var node = {
+            const node = {
                 tagName: tagName
             };
             node.attributes = {};
@@ -33,8 +31,8 @@ var parser = {
         });
     },
     JSON2packet: function (nodes, packet) {
-        for(var i = 0; i < nodes.length; i++) {
-            var node = nodes[i];
+        for(let i = 0; i < nodes.length; i++) {
+            const node = nodes[i];
             if(!node || node === null){
                 continue;
             }
@@ -56,7 +54,7 @@ var parser = {
  */
 function filterNodeFromPresenceJSON(pres, nodeName){
     var res = [];
-    for(var i = 0; i < pres.length; i++)
+    for(let i = 0; i < pres.length; i++)
         if(pres[i].tagName === nodeName)
             res.push(pres[i]);
 
@@ -83,7 +81,6 @@ function ChatRoom(connection, jid, password, XMPP, options, settings) {
         settings, {connection: this.xmpp.options, conference: this.options});
     this.initPresenceMap();
     this.session = null;
-    var self = this;
     this.lastPresences = {};
     this.phoneNumber = null;
     this.phonePin = null;
@@ -276,18 +273,18 @@ ChatRoom.prototype.onPresence = function (pres) {
     member.isHiddenDomain
         = jid && jid.indexOf("@") > 0
             && this.options.hiddenDomain
-                === jid.substring(jid.indexOf("@") + 1, jid.indexOf("/"))
+                === jid.substring(jid.indexOf("@") + 1, jid.indexOf("/"));
 
     $(pres).find(">x").remove();
     var nodes = [];
     parser.packet2JSON(pres, nodes);
     this.lastPresences[from] = nodes;
-    var jibri = null;
+    let jibri = null;
     // process nodes to extract data needed for MUC_JOINED and MUC_MEMBER_JOINED
     // events
-    for(var i = 0; i < nodes.length; i++)
+    for(let i = 0; i < nodes.length; i++)
     {
-        var node = nodes[i];
+        const node = nodes[i];
         switch(node.tagName)
         {
             case "nick":
@@ -353,9 +350,9 @@ ChatRoom.prototype.onPresence = function (pres) {
 
     // after we had fired member or room joined events, lets fire events
     // for the rest info we got in presence
-    for(var i = 0; i < nodes.length; i++)
+    for(let i = 0; i < nodes.length; i++)
     {
-        var node = nodes[i];
+        const node = nodes[i];
         switch(node.tagName)
         {
             case "nick":
@@ -376,7 +373,7 @@ ChatRoom.prototype.onPresence = function (pres) {
                 }
                 break;
             case "jibri-recording-status":
-                var jibri = node;
+                jibri = node;
                 break;
             case "call-control":
                 var att = node.attributes;
@@ -419,7 +416,7 @@ ChatRoom.prototype._initFocus = function (from, mucJid) {
             this.recording.handleJibriPresence(this.lastJibri);
     }
     logger.info("Ignore focus: " + from + ", real JID: " + mucJid);
-}
+};
 
 /**
  * Sets the special listener to be used for "command"s whose name starts with
@@ -515,8 +512,8 @@ ChatRoom.prototype.onPresenceUnavailable = function (pres, from) {
     // If the status code is 110 this means we're leaving and we would like
     // to remove everyone else from our view, so we trigger the event.
     else if (Object.keys(this.members).length > 0) {
-        for (var i in this.members) {
-            var member = this.members[i];
+        for (const i in this.members) {
+            const member = this.members[i];
             delete this.members[i];
             this.onParticipantLeft(i, member.isFocus);
         }
@@ -752,7 +749,7 @@ ChatRoom.prototype.generateNewStreamSSRCInfo = function () {
     return this.session.generateNewStreamSSRCInfo();
 };
 
-ChatRoom.prototype.setVideoMute = function (mute, callback, options) {
+ChatRoom.prototype.setVideoMute = function (mute, callback) {
     this.sendVideoInfoPresence(mute);
     if(callback)
         callback(mute);
@@ -848,14 +845,14 @@ ChatRoom.prototype.isRecordingSupported = function () {
  */
 ChatRoom.prototype.getRecordingState = function () {
     return (this.recording) ? this.recording.getState() : undefined;
-}
+};
 
 /**
  * Returns the url of the recorded video.
  */
 ChatRoom.prototype.getRecordingURL = function () {
     return (this.recording) ? this.recording.getURL() : null;
-}
+};
 
 /**
  * Starts/stops the recording

modules/xmpp/JingleSession.js

@@ -92,6 +92,7 @@ JingleSession.prototype.doInitialize = function() {};
  * Adds the ICE candidates found in the 'contents' array as remote candidates?
  * Note: currently only used on transport-info
  */
+// eslint-disable-next-line no-unused-vars
 JingleSession.prototype.addIceCandidates = function(contents) {};
 
 /**
@@ -109,6 +110,7 @@ JingleSession.prototype.active = function () {
  *
  * @param contents an array of Jingle 'content' elements.
  */
+// eslint-disable-next-line no-unused-vars
 JingleSession.prototype.addSources = function(contents) {};
 
 /**
@@ -116,6 +118,7 @@ JingleSession.prototype.addSources = function(contents) {};
  *
  * @param contents an array of Jingle 'content' elements.
  */
+// eslint-disable-next-line no-unused-vars
 JingleSession.prototype.removeSources = function(contents) {};
 
 /**
@@ -123,6 +126,7 @@ JingleSession.prototype.removeSources = function(contents) {};
  * @param reason XMPP Jingle error condition
  * @param text some meaningful error message
  */
+// eslint-disable-next-line no-unused-vars
 JingleSession.prototype.terminate = function(reason, text) {};
 
 /**
@@ -133,6 +137,7 @@ JingleSession.prototype.terminate = function(reason, text) {};
  *        object with details(which is meant more to be printed to the logger
  *        than analysed in the code, as the error is unrecoverable anyway)
  */
+// eslint-disable-next-line no-unused-vars
 JingleSession.prototype.acceptOffer = function(jingle, success, failure) {};
 
 module.exports = JingleSession;

modules/xmpp/JingleSessionPC.js

@@ -1,9 +1,9 @@
-/* jshint -W117 */
+/* global $, $iq */
+
 import {getLogger} from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 var JingleSession = require("./JingleSession");
 var TraceablePeerConnection = require("./TraceablePeerConnection");
-var MediaType = require("../../service/RTC/MediaType");
 var SDPDiffer = require("./SDPDiffer");
 var SDPUtil = require("./SDPUtil");
 var SDP = require("./SDP");
@@ -113,20 +113,19 @@ JingleSessionPC.prototype.doInitialize = function () {
     this.peerconnection.onremovestream = function (event) {
         self.remoteStreamRemoved(event.stream);
     };
-    this.peerconnection.onsignalingstatechange = function (event) {
+    this.peerconnection.onsignalingstatechange = function () {
         if (!(self && self.peerconnection)) return;
         if (self.peerconnection.signalingState === 'stable') {
             self.wasstable = true;
         }
     };
     /**
-     * The oniceconnectionstatechange event handler contains the code to execute when the iceconnectionstatechange event,
-     * of type Event, is received by this RTCPeerConnection. Such an event is sent when the value of
+     * The oniceconnectionstatechange event handler contains the code to execute
+     * when the iceconnectionstatechange event, of type Event, is received by
+     * this RTCPeerConnection. Such an event is sent when the value of
      * RTCPeerConnection.iceConnectionState changes.
-     *
-     * @param event the event containing information about the change
      */
-    this.peerconnection.oniceconnectionstatechange = function (event) {
+    this.peerconnection.oniceconnectionstatechange = function () {
         if (!(self && self.peerconnection)) return;
         var now = window.performance.now();
         self.room.connectionTimes["ice.state." +
@@ -158,7 +157,7 @@ JingleSessionPC.prototype.doInitialize = function () {
                 break;
         }
     };
-    this.peerconnection.onnegotiationneeded = function (event) {
+    this.peerconnection.onnegotiationneeded = function () {
         self.room.eventEmitter.emit(XMPPEvents.PEERCONNECTION_READY, self);
     };
 };
@@ -244,8 +243,6 @@ JingleSessionPC.prototype.sendIceCandidates = function (candidates) {
 JingleSessionPC.prototype.readSsrcInfo = function (contents) {
     var self = this;
     $(contents).each(function (idx, content) {
-        var name = $(content).attr('name');
-        var mediaType = this.getAttribute('name');
         var ssrcs = $(content).find('description>source[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]');
         ssrcs.each(function () {
             var ssrc = this.getAttribute('ssrc');
@@ -578,7 +575,7 @@ JingleSessionPC.prototype.addSource = function (elem) {
     // FIXME: dirty waiting
     if (!this.peerconnection.localDescription)
     {
-        logger.warn("addSource - localDescription not ready yet")
+        logger.warn("addSource - localDescription not ready yet");
         setTimeout(function()
             {
                 self.addSource(elem);
@@ -787,6 +784,7 @@ JingleSessionPC.prototype._modifySources = function (successCallback, queueCallb
     this.removessrc = [];
 
     sdp.raw = sdp.session + sdp.media.join('');
+
     /**
      * Implements a failure callback which reports an error message and an
      * optional error through (1) logger, (2) GlobalOnErrorHandler, and (3)
@@ -805,7 +803,7 @@ JingleSessionPC.prototype._modifySources = function (successCallback, queueCallb
         }
         GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
         queueCallback(err);
-    };
+    }
 
     var ufrag = getUfrag(sdp.raw);
     if (ufrag != self.remoteUfrag) {
@@ -915,7 +913,7 @@ JingleSessionPC.prototype.addStream = function (stream, callback, errorCallback,
             errorCallback(error);
         }
     });
-}
+};
 
 /**
  * Generate ssrc info object for a stream with the following properties:
@@ -1019,7 +1017,7 @@ JingleSessionPC.prototype.removeStream = function (stream, callback, errorCallba
             errorCallback(error);
         }
     });
-}
+};
 
 /**
  * Figures out added/removed ssrcs and send update IQs.
@@ -1484,7 +1482,7 @@ function getUfrag(sdp) {
     var ufragLines = sdp.split('\n').filter(function(line) {
         return line.startsWith("a=ice-ufrag:");});
     if (ufragLines.length > 0) {
-        return ufragLines[0].substr("a=ice-ufrag:".length)
+        return ufragLines[0].substr("a=ice-ufrag:".length);
     }
 }
 

modules/xmpp/SDP.js

@@ -1,6 +1,5 @@
-/* jshint -W117 */
-import {getLogger} from "jitsi-meet-logger";
-const logger = getLogger(__filename);
+/* global $, APP */
+
 var SDPUtil = require("./SDPUtil");
 
 // SDP STUFF
@@ -128,7 +127,7 @@ SDP.prototype.removeSessionLines = function(prefix) {
     });
     this.raw = this.session + this.media.join('');
     return lines;
-}
+};
 // remove lines matching prefix from a media section specified by mediaindex
 // TODO: non-numeric mediaindex could match mid
 SDP.prototype.removeMediaLines = function(mediaindex, prefix) {
@@ -139,12 +138,10 @@ SDP.prototype.removeMediaLines = function(mediaindex, prefix) {
     });
     this.raw = this.session + this.media.join('');
     return lines;
-}
+};
 
 // add content's to a jingle element
 SDP.prototype.toJingle = function (elem, thecreator) {
-//    logger.log("SSRC" + ssrcs["audio"] + " - " + ssrcs["video"]);
-    var self = this;
     var i, j, k, mline, ssrc, rtpmap, tmp, lines;
     // new bundle plan
     lines = SDPUtil.find_lines(this.session, 'a=group:');
@@ -400,7 +397,7 @@ SDP.prototype.transportToJingle = function (mediaindex, elem) {
         }
     }
     elem.up(); // end of transport
-}
+};
 
 SDP.prototype.rtcpFbToJingle = function (mediaindex, elem, payloadtype) { // XEP-0293
     var lines = SDPUtil.find_lines(this.media[mediaindex], 'a=rtcp-fb:' + payloadtype);
@@ -482,7 +479,6 @@ SDP.prototype.fromJingle = function (jingle) {
 SDP.prototype.jingle2media = function (content) {
     var media = '',
         desc = content.find('description'),
-        ssrc = desc.attr('ssrc'),
         self = this,
         tmp;
     var sctp = content.find(

modules/xmpp/TraceablePeerConnection.js

@@ -1,5 +1,6 @@
-/* global $ */
-import {getLogger} from "jitsi-meet-logger";
+/* global mozRTCPeerConnection, webkitRTCPeerConnection */
+
+import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 var RTC = require('../RTC/RTC');
 var RTCBrowserType = require("../RTC/RTCBrowserType.js");
@@ -187,7 +188,7 @@ TraceablePeerConnection.prototype.ssrcReplacement = function (desc) {
             var ssrcOperation = SSRCs[0];
             switch(ssrcOperation.type) {
                 case "mute":
-                case "addMuted":
+                case "addMuted": {
                 //FIXME: If we want to support multiple streams we have to add
                 // recv-only ssrcs for the
                 // muted streams on every change until the stream is unmuted
@@ -195,8 +196,8 @@ TraceablePeerConnection.prototype.ssrcReplacement = function (desc) {
                 // in the SDP
                     if(!bLine.ssrcs)
                         bLine.ssrcs = [];
-                    var groups = ssrcOperation.ssrc.groups;
-                    var ssrc = null;
+                    const groups = ssrcOperation.ssrc.groups;
+                    let ssrc = null;
                     if(groups && groups.length) {
                         ssrc = groups[0].primarySSRC;
                     } else if(ssrcOperation.ssrc.ssrcs &&
@@ -219,14 +220,15 @@ TraceablePeerConnection.prototype.ssrcReplacement = function (desc) {
                     // only 1 video stream that is muted.
                     this.recvOnlySSRCs[bLine.type] = ssrc;
                     break;
-                case "unmute":
+                }
+                case "unmute": {
                     if(!ssrcOperation.ssrc || !ssrcOperation.ssrc.ssrcs ||
                         !ssrcOperation.ssrc.ssrcs.length)
                         break;
                     var ssrcMap = {};
                     var ssrcLastIdx = ssrcOperation.ssrc.ssrcs.length - 1;
                     for(var i = 0; i < bLine.ssrcs.length; i++) {
-                        var ssrc = bLine.ssrcs[i];
+                        const ssrc = bLine.ssrcs[i];
                         if (ssrc.attribute !== 'msid' &&
                             ssrc.value !== ssrcOperation.msid) {
                             continue;
@@ -237,7 +239,7 @@ TraceablePeerConnection.prototype.ssrcReplacement = function (desc) {
                         if(ssrcLastIdx < 0)
                             break;
                     }
-                    var groups = ssrcOperation.ssrc.groups;
+                    const groups = ssrcOperation.ssrc.groups;
                     if (typeof bLine.ssrcGroups !== 'undefined' &&
                         Array.isArray(bLine.ssrcGroups) && groups &&
                         groups.length) {
@@ -278,8 +280,9 @@ TraceablePeerConnection.prototype.ssrcReplacement = function (desc) {
                     // Storing the unmuted SSRCs.
                     permSSRCs.push(ssrcOperation);
                     break;
+                }
                 default:
-                break;
+                    break;
             }
             SSRCs = this.replaceSSRCs[bLine.type].splice(0,1);
         }
@@ -288,7 +291,7 @@ TraceablePeerConnection.prototype.ssrcReplacement = function (desc) {
 
         if (!Array.isArray(bLine.ssrcs) || bLine.ssrcs.length === 0)
         {
-            var ssrc = this.recvOnlySSRCs[bLine.type]
+            const ssrc = this.recvOnlySSRCs[bLine.type]
                 = this.recvOnlySSRCs[bLine.type] ||
                     RandomUtil.randomInt(1, 0xffffffff);
             bLine.ssrcs = [{
@@ -636,6 +639,7 @@ TraceablePeerConnection.prototype.createAnswer
 };
 
 TraceablePeerConnection.prototype.addIceCandidate
+        // eslint-disable-next-line no-unused-vars
         = function (candidate, successCallback, failureCallback) {
     //var self = this;
     this.trace('addIceCandidate', JSON.stringify(candidate, null, ' '));

modules/xmpp/recording.js

@@ -1,6 +1,6 @@
-/* global $, $iq, config, connection, focusMucJid, messageHandler,
-   Toolbar, Util, Promise */
-import {getLogger} from "jitsi-meet-logger";
+/* global $, $iq */
+
+import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 var XMPPEvents = require("../../service/xmpp/XMPPEvents");
 var JitsiRecorderErrors = require("../../JitsiRecorderErrors");
@@ -116,7 +116,7 @@ Recording.prototype.setRecordingJibri
 };
 
 Recording.prototype.setRecordingJirecon =
-    function (state, callback, errCallback, options) {
+    function (state, callback, errCallback) {
 
     if (state == this.state){
         errCallback(new Error("Invalid state!"));

modules/xmpp/strophe.emuc.js

@@ -1,7 +1,9 @@
-/* jshint -W117 */
 /* a simple MUC connection plugin
  * can only handle a single MUC room
  */
+
+/* global $, Strophe */
+
 import {getLogger} from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 import ChatRoom from "./ChatRoom";
@@ -35,7 +37,6 @@ class MucConnectionPlugin extends ConnectionPlugin {
             const errmsg = "You are already in the room!";
             logger.error(errmsg);
             throw new Error(errmsg);
-            return;
         }
         this.rooms[roomJid] = new ChatRoom(this.connection, jid,
             password, this.xmpp, options, settings);

modules/xmpp/strophe.jingle.js

@@ -1,9 +1,9 @@
-/* jshint -W117 */
-import {getLogger} from "jitsi-meet-logger";
+/* global $, $iq, Strophe */
+
+import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 import JingleSession from "./JingleSessionPC";
 import XMPPEvents from "../../service/xmpp/XMPPEvents";
-import RTCBrowserType from "../RTC/RTCBrowserType";
 import GlobalOnErrorHandler from "../util/GlobalOnErrorHandler";
 import Statistics from "../statistics/statistics";
 import ConnectionPlugin from "./ConnectionPlugin";
@@ -76,7 +76,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
         const now = window.performance.now();
         // see http://xmpp.org/extensions/xep-0166.html#concepts-session
         switch (action) {
-            case 'session-initiate':
+            case 'session-initiate': {
                 logger.log("(TIME) received session-initiate:\t", now);
                 const startMuted = $(iq).find('jingle>startmuted');
                 if (startMuted && startMuted.length > 0) {
@@ -112,7 +112,8 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                 Statistics.analytics.sendEvent(
                     'xmpp.session-initiate', now);
                 break;
-            case 'session-terminate':
+            }
+            case 'session-terminate': {
                 logger.log('terminating...', sess.sid);
                 let reasonCondition = null;
                 let reasonText = null;
@@ -125,6 +126,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                 this.eventEmitter.emit(XMPPEvents.CALL_ENDED,
                     sess, reasonCondition, reasonText);
                 break;
+            }
             case 'transport-replace':
                 logger.info("(TIME) Start transport replace", now);
                 Statistics.analytics.sendEvent(
@@ -203,7 +205,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                             iceservers.push(dict);
                             break;
                         case 'turn':
-                        case 'turns':
+                        case 'turns': {
                             dict.url = type + ':';
                             const username = el.attr('username');
                             // https://code.google.com/p/webrtc/issues/detail?id=1508
@@ -234,6 +236,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                                 || dict.credential;
                             iceservers.push(dict);
                             break;
+                        }
                     }
                 });
                 self.ice_config.iceServers = iceservers;
@@ -251,7 +254,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
         const data = {};
         Object.keys(this.sessions).forEach((sid) => {
             const session = self.sessions[sid];
-            const pc = session.peerconnection
+            const pc = session.peerconnection;
             if (pc && pc.updateLog) {
                 // FIXME: should probably be a .dump call
                 data["jingle_" + sid] = {

modules/xmpp/strophe.ping.js

@@ -1,9 +1,9 @@
 /* global $, $iq, Strophe */
-import {getLogger} from "jitsi-meet-logger";
+
+import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
-import GlobalOnErrorHandler from "../util/GlobalOnErrorHandler";
-import XMPPEvents from "../../service/xmpp/XMPPEvents";
 import ConnectionPlugin from "./ConnectionPlugin";
+import GlobalOnErrorHandler from "../util/GlobalOnErrorHandler";
 
 /**
  * Ping every 10 sec
@@ -103,7 +103,7 @@ class PingConnectionPlugin extends ConnectionPlugin {
             return;
         }
         this.intervalId = window.setInterval(() => {
-            this.ping(remoteJid, (result) => {
+            this.ping(remoteJid, () => {
                 this.failedPings = 0;
             }, (error) => {
                 this.failedPings += 1;

modules/xmpp/strophe.rayo.js

@@ -1,5 +1,6 @@
-/* jshint -W117 */
-import {getLogger} from "jitsi-meet-logger";
+/* global $, $iq, Strophe */
+
+import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 import ConnectionPlugin from "./ConnectionPlugin";
 
@@ -32,7 +33,7 @@ class RayoConnectionPlugin extends ConnectionPlugin {
                 to: focusMucJid
             });
             req.c('dial', {
-                xmlns: self.RAYO_XMLNS,
+                xmlns: RAYO_XMLNS,
                 to: to,
                 from: from
             });

modules/xmpp/xmpp.js

@@ -1,14 +1,12 @@
-/* global $, APP, config, Strophe */
-import {getLogger} from "jitsi-meet-logger";
+/* global $, $msg, Base64, Strophe */
+
+import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 import EventEmitter from "events";
 import Pako from "pako";
 import RandomUtil from "../util/RandomUtil";
-import RTCEvents from "../../service/RTC/RTCEvents";
-import XMPPEvents from "../../service/xmpp/XMPPEvents";
 import * as JitsiConnectionErrors from "../../JitsiConnectionErrors";
 import * as JitsiConnectionEvents from "../../JitsiConnectionEvents";
-import RTC from "../RTC/RTC";
 import RTCBrowserType from "../RTC/RTCBrowserType";
 import initEmuc from "./strophe.emuc";
 import initJingle from "./strophe.jingle";
@@ -24,7 +22,7 @@ function createConnection(token, bosh = '/http-bind') {
     }
 
     return new Strophe.Connection(bosh);
-};
+}
 
 export default class XMPP {
     constructor(options, token) {
@@ -273,7 +271,7 @@ export default class XMPP {
 
     removeListener (type, listener) {
         this.eventEmitter.removeListener(type, listener);
-    };
+    }
 
     /**
      * Sends 'data' as a log message to the focus. Returns true iff a message

package.json

@@ -35,6 +35,7 @@
     "babel-polyfill": "*",
     "babel-preset-es2015": "*",
     "babel-register": "*",
+    "eslint": "*",
     "jshint": "^2.8.0",
     "precommit-hook": "^3.0.0",
     "string-replace-loader": "*",
@@ -42,7 +43,7 @@
   },
   "scripts": {
     "install": "webpack -p",
-    "lint": "jshint .",
+    "lint": "jshint . && eslint .",
     "validate": "npm ls"
   },
   "pre-commit": [