Sfoglia il codice sorgente

fix(Firefox): Enable simulcast support on Firefox

Get rid of the experimental flag for simulcast support, update js-utils for detecting Edge on Android
master
Jaya Allamsetty 5 anni fa
parent
commit
4870efe459

+ 1
- 3
modules/RTC/TraceablePeerConnection.js Vedi File

@@ -42,8 +42,6 @@ const DESKSTOP_SHARE_RATE = 500000;
42 42
  * @param {boolean} options.disableSimulcast if set to 'true' will disable
43 43
  * the simulcast.
44 44
  * @param {boolean} options.disableRtx if set to 'true' will disable the RTX
45
- * @param {boolean} options.enableFirefoxSimulcast if set to 'true' will enable
46
- * experimental simulcast support on Firefox.
47 45
  * @param {boolean} options.capScreenshareBitrate if set to 'true' simulcast will
48 46
  * be disabled for screenshare and a max bitrate of 500Kbps will applied on the
49 47
  * stream.
@@ -434,7 +432,7 @@ TraceablePeerConnection.prototype._getDesiredMediaDirection = function(
434 432
  * <tt>false</tt> if it's turned off.
435 433
  */
436 434
 TraceablePeerConnection.prototype.isSimulcastOn = function() {
437
-    return !browser.isFirefox() && !this.options.disableSimulcast;
435
+    return !this.options.disableSimulcast;
438 436
 };
439 437
 
440 438
 /**

+ 0
- 4
modules/xmpp/JingleSessionPC.js Vedi File

@@ -56,8 +56,6 @@ const DEFAULT_MAX_STATS = 300;
56 56
  * @property {boolean} p2p.preferH264 - Described in the config.js[1].
57 57
  * @property {boolean} preferH264 - Described in the config.js[1].
58 58
  * @property {Object} testing - Testing and/or experimental options.
59
- * @property {boolean} testing.enableFirefoxSimulcast - Described in the
60
- * config.js[1].
61 59
  * @property {boolean} webrtcIceUdpDisable - Described in the config.js[1].
62 60
  * @property {boolean} webrtcIceTcpDisable - Described in the config.js[1].
63 61
  *
@@ -316,8 +314,6 @@ export default class JingleSessionPC extends JingleSession {
316 314
                 = options.disableSimulcast
317 315
                     || (options.preferH264 && !options.disableH264);
318 316
             pcOptions.preferH264 = options.preferH264;
319
-            pcOptions.enableFirefoxSimulcast
320
-                = options.testing && options.testing.enableFirefoxSimulcast;
321 317
             pcOptions.enableLayerSuspension = options.enableLayerSuspension;
322 318
 
323 319
             // disable simulcast for screenshare and set the max bitrate to

+ 2
- 2
package-lock.json Vedi File

@@ -5498,8 +5498,8 @@
5498 5498
       "dev": true
5499 5499
     },
5500 5500
     "js-utils": {
5501
-      "version": "github:jitsi/js-utils#8567f86ec2774ae1d1c47b22e3435928cf5d9771",
5502
-      "from": "github:jitsi/js-utils#8567f86ec2774ae1d1c47b22e3435928cf5d9771",
5501
+      "version": "github:jitsi/js-utils#df68966e3c65b5c57fcd2670da1326a2c77518d1",
5502
+      "from": "github:jitsi/js-utils#df68966e3c65b5c57fcd2670da1326a2c77518d1",
5503 5503
       "requires": {
5504 5504
         "bowser": "2.7.0",
5505 5505
         "js-md5": "0.7.3",

+ 1
- 1
package.json Vedi File

@@ -21,7 +21,7 @@
21 21
     "async": "0.9.0",
22 22
     "current-executing-script": "0.1.3",
23 23
     "jitsi-meet-logger": "github:jitsi/jitsi-meet-logger#5ec92357570dc8f0b7ffc1528820721c84c6af8b",
24
-    "js-utils": "github:jitsi/js-utils#8567f86ec2774ae1d1c47b22e3435928cf5d9771",
24
+    "js-utils": "github:jitsi/js-utils#df68966e3c65b5c57fcd2670da1326a2c77518d1",
25 25
     "lodash.isequal": "4.5.0",
26 26
     "sdp-transform": "2.3.0",
27 27
     "strophe.js": "1.3.4",

Loading…
Annulla
Salva