fix(eslint): Add guard-for-in rule

.eslintrc.js

@@ -76,6 +76,7 @@ module.exports = {
         'default-case': 0,
         'dot-location': [ 'error', 'property' ],
         'dot-notation': 2,
+        'guard-for-in': 2,
         'no-caller': 2,
         'no-case-declarations': 2,
         'no-div-regex': 0,

JitsiConferenceEventManager.js

@@ -69,20 +69,18 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
     // send some analytics events
     chatRoom.addListener(XMPPEvents.MUC_JOINED,
         () => {
-            let key, value;
-
             this.conference.connectionIsInterrupted = false;
 
-            for (key in chatRoom.connectionTimes) {
-                value = chatRoom.connectionTimes[key];
+            Object.keys(chatRoom.connectionTimes).forEach(key => {
+                const value = chatRoom.connectionTimes[key];
                 Statistics.analytics.sendEvent('conference.' + key,
                     {value});
-            }
-            for (key in chatRoom.xmpp.connectionTimes) {
-                value = chatRoom.xmpp.connectionTimes[key];
+            });
+            Object.keys(chatRoom.xmpp.connectionTimes).forEach(key => {
+                const value = chatRoom.xmpp.connectionTimes[key];
                 Statistics.analytics.sendEvent('xmpp.' + key,
                     {value});
-            }
+            });
         });
 
     this.chatRoomForwarder.forward(XMPPEvents.ROOM_JOIN_ERROR,

JitsiMeetJS.js

@@ -37,13 +37,13 @@ function getLowerResolution(resolution) {
     var order = Resolutions[resolution].order;
     var res = null;
     var resName = null;
-    for(const i in Resolutions) {
-        var tmp = Resolutions[i];
-        if (!res || (res.order < tmp.order && tmp.order < order)) {
-            resName = i;
-            res = tmp;
+    Object.keys(Resolutions).forEach(resolution => {
+        const value = Resolutions[resolution];
+        if (!res || (res.order < value.order && value.order < order)) {
+            resName = resolution;
+            res = value;
         }
-    }
+    });
     return resName;
 }
 

modules/statistics/RTPStatsCollector.js

@@ -392,6 +392,9 @@ StatsCollector.prototype.processStatsReport = function() {
     var byteSentStats = {};
 
     for (var idx in this.currentStatsReport) {
+        if(!this.currentStatsReport.hasOwnProperty(idx)) {
+            continue;
+        }
         var now = this.currentStatsReport[idx];
         try {
             var receiveBandwidth = getStatValue(now, 'receiveBandwidth');
@@ -605,7 +608,10 @@ StatsCollector.prototype.processAudioLevelReport = function() {
 
     var getStatValue = this._getStatValue;
 
-    for (var idx in this.currentAudioLevelsReport) {
+    for(var idx in this.currentAudioLevelsReport) {
+        if(!this.currentAudioLevelsReport.hasOwnProperty(idx)) {
+            continue;
+        }
         var now = this.currentAudioLevelsReport[idx];
 
         if (now.type != 'ssrc') {

modules/xmpp/Caps.js

@@ -47,9 +47,9 @@ export default class Caps extends Listenable {
             room => this._addChatRoom(room));
         emuc.addListener(XMPPEvents.EMUC_ROOM_REMOVED,
             room => this._removeChatRoom(room));
-        for(const jid in emuc.rooms) {
-            this._addChatRoom(this.emuc.rooms[jid]);
-        }
+        Object.keys(emuc.rooms).forEach(jid => {
+            this._addChatRoom(emuc.rooms[jid]);
+        });
 
         Strophe.addNamespace('CAPS', 'http://jabber.org/protocol/caps');
         this.disco.addFeature(Strophe.NS.CAPS);

modules/xmpp/ChatRoom.js

@@ -507,19 +507,19 @@ export default class ChatRoom extends Listenable {
         var isKick = $(pres).find(
                 '>x[xmlns="http://jabber.org/protocol/muc#user"]>status[code="307"]'
             ).length !== 0;
-
+        const membersKeys = Object.keys(this.members);
         if (!isSelfPresence) {
             delete this.members[from];
             this.onParticipantLeft(from, false);
-        } else if (Object.keys(this.members).length > 0) {
+        } else if (membersKeys.length > 0) {
             // If the status code is 110 this means we're leaving and we would
             // like to remove everyone else from our view, so we trigger the
             // event.
-            for (const i in this.members) {
-                const member = this.members[i];
-                delete this.members[i];
-                this.onParticipantLeft(i, member.isFocus);
-            }
+            membersKeys.forEach(jid => {
+                const member = this.members[jid];
+                delete this.members[jid];
+                this.onParticipantLeft(jid, member.isFocus);
+            });
             this.connection.emuc.doLeave(this.roomjid);
 
             // we fire muc_left only if this is not a kick,