Fixes the issue with not able to send feedback after JitsiConference.leave

modules/statistics/CallStats.js

@@ -74,6 +74,7 @@ function initCallback (err, msg) {
 
     CallStats.initializeFailed = false;
     CallStats.initialized = true;
+    CallStats.feedbackEnabled = true;
 
     // notify callstats about failures if there were any
     if (CallStats.reportsQueue.length) {
@@ -137,12 +138,8 @@ function _try_catch (f) {
  */
 var CallStats = _try_catch(function(jingleSession, Settings, options) {
     try{
-        //check weather that should work with more than 1 peerconnection
-        if(!callStats) {
-            callStats = new callstats($, io, jsSHA);
-        } else {
-            return;
-        }
+        CallStats.feedbackEnabled = false;
+        callStats = new callstats($, io, jsSHA);
 
         this.session = jingleSession;
         this.peerconnection = jingleSession.peerconnection.peerconnection;
@@ -197,6 +194,12 @@ CallStats.initializeInProgress = false;
  */
 CallStats.initializeFailed = false;
 
+/**
+ * Shows weather sending feedback is enabled or not
+ * @type {boolean}
+ */
+CallStats.feedbackEnabled = false;
+
 /**
  * Checks whether we need to re-initialize callstats and starts the process.
  * @private
@@ -406,7 +409,7 @@ CallStats.prototype.sendIceConnectionFailedEvent = _try_catch(function (pc, cs){
  */
 CallStats.prototype.sendFeedback = _try_catch(
 function(overallFeedback, detailedFeedback) {
-    if(!CallStats.initialized) {
+    if(!CallStats.feedbackEnabled) {
         return;
     }
     var feedbackString =    '{"userID":"' + this.userID + '"' +
@@ -523,7 +526,9 @@ CallStats.sendApplicationLog = _try_catch(function (e, cs) {
  * Clears allocated resources.
  */
 CallStats.dispose = function () {
-    callStats = null;
+    // The next line is commented because we need to be able to send feedback
+    // even after the conference has been destroyed.
+    // callStats = null;
     CallStats.initialized = false;
     CallStats.initializeFailed = false;
     CallStats.initializeInProgress = false;

modules/statistics/statistics.js

@@ -270,8 +270,11 @@ Statistics.prototype.startCallStats = function (session, settings) {
 Statistics.prototype.stopCallStats = function () {
     if(this.callstats) {
         var index = Statistics.callsStatsInstances.indexOf(this.callstats);
-        Statistics.callsStatsInstances.splice(index, 1);
-        this.callstats = null;
+        if(index > -1)
+            Statistics.callsStatsInstances.splice(index, 1);
+        // The next line is commented because we need to be able to send
+        // feedback even after the conference has been destroyed.
+        // this.callstats = null;
         CallStats.dispose();
     }
 };