[eslint] newline-after-var, newline-before-return, newline-per-chained-call

.eslintrc.js

@@ -149,6 +149,9 @@ module.exports = {
         'multiline-ternary': 0,
         'new-cap': 2,
         'new-parens': 2,
+        'newline-after-var': 2,
+        'newline-before-return': 2,
+        'newline-per-chained-call': 2,
         'no-array-constructor': 2,
         'no-bitwise': 2,
         'no-continue': 2,

JitsiConference.js

@@ -40,6 +40,7 @@ function JitsiConference(options) {
         const errmsg
             = 'Invalid conference name (no conference name passed or it '
                 + 'contains invalid characters like capital letters)!';
+
         logger.error(errmsg);
         throw new Error(errmsg);
     }
@@ -184,7 +185,9 @@ JitsiConference.prototype.leave = function() {
     // leave the conference
     if (this.room) {
         const room = this.room;
+
         this.room = null;
+
         return room.leave().catch(() => {
             // remove all participants because currently the conference won't
             // be usable anyway. This is done on success automatically by the
@@ -249,6 +252,7 @@ JitsiConference.prototype.getExternalAuthUrl = function(urlForPopup) {
     return new Promise((resolve, reject) => {
         if (!this.isExternalAuthEnabled()) {
             reject();
+
             return;
         }
         if (urlForPopup) {
@@ -266,9 +270,11 @@ JitsiConference.prototype.getExternalAuthUrl = function(urlForPopup) {
  */
 JitsiConference.prototype.getLocalTracks = function(mediaType) {
     let tracks = [];
+
     if (this.rtc) {
         tracks = this.rtc.getLocalTracks(mediaType);
     }
+
     return tracks;
 };
 
@@ -416,15 +422,18 @@ JitsiConference.prototype.getTranscriber = function() {
         this.transcriber = new Transcriber();
         // add all existing local audio tracks to the transcriber
         const localAudioTracks = this.getLocalTracks(MediaType.AUDIO);
+
         for (const localAudio of localAudioTracks) {
             this.transcriber.addTrack(localAudio);
         }
         // and all remote audio tracks
         const remoteAudioTracks = this.rtc.getRemoteTracks(MediaType.AUDIO);
+
         for (const remoteTrack of remoteAudioTracks) {
             this.transcriber.addTrack(remoteTrack);
         }
     }
+
     return this.transcriber;
 };
 
@@ -439,12 +448,14 @@ JitsiConference.prototype.addTrack = function(track) {
     if (track.isVideoTrack()) {
         // Ensure there's exactly 1 local video track in the conference.
         const localVideoTrack = this.rtc.getLocalVideoTrack();
+
         if (localVideoTrack) {
             // Don't be excessively harsh and severe if the API client happens
             // to attempt to add the same local video track twice.
             if (track === localVideoTrack) {
                 return Promise.resolve(track);
             }
+
             return Promise.reject(new Error(
                     'cannot add second video track to the conference'));
 
@@ -538,6 +549,7 @@ JitsiConference.prototype.replaceTrack = function(oldTrack, newTrack) {
         // Set up the ssrcHandler for the new track before we add it at the lower levels
         newTrack.ssrcHandler = function(conference, ssrcMap) {
             const trackSSRCInfo = ssrcMap.get(this.getMSID());
+
             if (trackSSRCInfo) {
                 this._setSSRC(trackSSRCInfo);
                 conference.rtc.removeListener(
@@ -548,6 +560,7 @@ JitsiConference.prototype.replaceTrack = function(oldTrack, newTrack) {
         this.rtc.addListener(RTCEvents.SENDRECV_STREAMS_CHANGED,
             newTrack.ssrcHandler);
     }
+
     // Now replace the stream at the lower levels
     return this._doReplaceTrack(oldTrack, newTrack)
         .then(() => {
@@ -558,6 +571,7 @@ JitsiConference.prototype.replaceTrack = function(oldTrack, newTrack) {
                 // Now handle the addition of the newTrack at the JitsiConference level
                 this._setupNewTrack(newTrack);
             }
+
             return Promise.resolve();
         }, error => Promise.reject(new Error(error)));
 };
@@ -577,6 +591,7 @@ JitsiConference.prototype._doReplaceTrack = function(oldTrack, newTrack) {
     if (this.jingleSession) {
         return this.jingleSession.replaceTrack(oldTrack, newTrack);
     }
+
     return Promise.resolve();
 
 };
@@ -595,6 +610,7 @@ JitsiConference.prototype._setupNewTrack = function(newTrack) {
                 d =>
                     d.kind === `${newTrack.getTrack().kind}input`
                         && d.label === newTrack.getTrack().label);
+
         if (device) {
             Statistics.sendActiveDeviceListEvent(
                 RTC.getEventDataForActiveDevice(device));
@@ -693,8 +709,10 @@ JitsiConference.prototype._generateNewStreamSSRCInfo = function() {
     if (!this.jingleSession) {
         logger.warn('The call haven\'t been started. '
             + 'Cannot generate ssrc info at the moment!');
+
         return null;
     }
+
     return this.jingleSession.generateNewStreamSSRCInfo();
 };
 
@@ -726,6 +744,8 @@ JitsiConference.prototype.lock = function(password) {
     }
 
     const conference = this;
+
+
     return new Promise((resolve, reject) => {
         conference.room.lockRoom(
             password || '',
@@ -778,6 +798,7 @@ JitsiConference.prototype.setLastN = function(lastN) {
         throw new Error(`Invalid value for lastN: ${lastN}`);
     }
     const n = Number(lastN);
+
     if (n < -1) {
         throw new RangeError('lastN cannot be smaller than -1');
     }
@@ -804,10 +825,12 @@ JitsiConference.prototype.getParticipantCount
     = function(countHidden = false) {
 
         let participants = this.getParticipants();
+
         if (!countHidden) {
             participants = participants.filter(p => !p.isHidden());
         }
-    // Add one for the local participant.
+
+        // Add one for the local participant.
         return participants.length + 1;
     };
 
@@ -826,6 +849,7 @@ JitsiConference.prototype.getParticipantById = function(id) {
  */
 JitsiConference.prototype.kickParticipant = function(id) {
     const participant = this.getParticipantById(id);
+
     if (!participant) {
         return;
     }
@@ -838,6 +862,7 @@ JitsiConference.prototype.kickParticipant = function(id) {
  */
 JitsiConference.prototype.muteParticipant = function(id) {
     const participant = this.getParticipantById(id);
+
     if (!participant) {
         return;
     }
@@ -858,10 +883,12 @@ JitsiConference.prototype.muteParticipant = function(id) {
 JitsiConference.prototype.onMemberJoined
     = function(jid, nick, role, isHidden) {
         const id = Strophe.getResourceFromJid(jid);
+
         if (id === 'focus' || this.myUserId() === id) {
             return;
         }
         const participant = new JitsiParticipant(jid, this, nick, isHidden);
+
         participant._role = role;
         this.participants[id] = participant;
         this.eventEmitter.emit(JitsiConferenceEvents.USER_JOINED, id, participant);
@@ -873,10 +900,12 @@ JitsiConference.prototype.onMemberJoined
 
 JitsiConference.prototype.onMemberLeft = function(jid) {
     const id = Strophe.getResourceFromJid(jid);
+
     if (id === 'focus' || this.myUserId() === id) {
         return;
     }
     const participant = this.participants[id];
+
     delete this.participants[id];
 
     const removedTracks = this.rtc.removeRemoteTracks(id);
@@ -895,6 +924,7 @@ JitsiConference.prototype.onMemberLeft = function(jid) {
 JitsiConference.prototype.onUserRoleChanged = function(jid, role) {
     const id = Strophe.getResourceFromJid(jid);
     const participant = this.getParticipantById(id);
+
     if (!participant) {
         return;
     }
@@ -905,6 +935,7 @@ JitsiConference.prototype.onUserRoleChanged = function(jid, role) {
 JitsiConference.prototype.onDisplayNameChanged = function(jid, displayName) {
     const id = Strophe.getResourceFromJid(jid);
     const participant = this.getParticipantById(id);
+
     if (!participant) {
         return;
     }
@@ -927,8 +958,10 @@ JitsiConference.prototype.onDisplayNameChanged = function(jid, displayName) {
 JitsiConference.prototype.onRemoteTrackAdded = function(track) {
     const id = track.getParticipantId();
     const participant = this.getParticipantById(id);
+
     if (!participant) {
         logger.error(`No participant found for id: ${id}`);
+
         return;
     }
 
@@ -940,6 +973,7 @@ JitsiConference.prototype.onRemoteTrackAdded = function(track) {
     }
 
     const emitter = this.eventEmitter;
+
     track.addEventListener(
         JitsiTrackEvents.TRACK_MUTE_CHANGED,
         () => emitter.emit(JitsiConferenceEvents.TRACK_MUTE_CHANGED, track));
@@ -1006,6 +1040,7 @@ JitsiConference.prototype.onIncomingCall
         // Error cause this should never happen unless something is wrong!
         const errmsg = `Rejecting session-initiate from non-focus user: ${
                  jingleSession.peerjid}`;
+
         GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
         logger.error(errmsg);
 
@@ -1032,6 +1067,7 @@ JitsiConference.prototype.onIncomingCall
     }
     // add info whether call is cross-region
     let crossRegion = null;
+
     if (window.jitsiRegionInfo) {
         crossRegion = window.jitsiRegionInfo.CrossRegion;
     }
@@ -1060,6 +1096,7 @@ JitsiConference.prototype.onIncomingCall
          *  problems between sdp-interop and trying to keep the ssrcs
          *  consistent
          */
+
         if (localTrack.isVideoTrack() && localTrack.isMuted() && !RTCBrowserType.isFirefox()) {
             /**
              * Handles issues when the stream is added before the peerconnection
@@ -1152,6 +1189,7 @@ JitsiConference.prototype.onCallEnded
     // will learn what their SSRC from the new PeerConnection which will be
     // created on incoming call event.
     const self = this;
+
     this.getLocalTracks().forEach(localTrack => {
         // Reset SSRC as it will no longer be valid
         localTrack._setSSRC(null);
@@ -1209,18 +1247,23 @@ JitsiConference.prototype.sendTones = function(tones, duration, pause) {
     if (!this.dtmfManager) {
         if (!this.jingleSession) {
             logger.warn('cannot sendTones: no jingle session');
+
             return;
         }
 
         const peerConnection = this.jingleSession.peerconnection;
+
         if (!peerConnection) {
             logger.warn('cannot sendTones: no peer connection');
+
             return;
         }
 
         const localAudio = this.getLocalAudioTrack();
+
         if (!localAudio) {
             logger.warn('cannot sendTones: no local audio stream');
+
             return;
         }
         this.dtmfManager = new JitsiDTMFManager(localAudio, peerConnection);
@@ -1236,6 +1279,7 @@ JitsiConference.prototype.isRecordingSupported = function() {
     if (this.room) {
         return this.room.isRecordingSupported();
     }
+
     return false;
 };
 
@@ -1276,6 +1320,7 @@ JitsiConference.prototype.isSIPCallingSupported = function() {
     if (this.room) {
         return this.room.isSIPCallingSupported();
     }
+
     return false;
 };
 
@@ -1287,6 +1332,7 @@ JitsiConference.prototype.dial = function(number) {
     if (this.room) {
         return this.room.dial(number);
     }
+
     return new Promise((resolve, reject) => {
         reject(new Error('The conference is not created yet!'));
     });
@@ -1299,6 +1345,7 @@ JitsiConference.prototype.hangup = function() {
     if (this.room) {
         return this.room.hangup();
     }
+
     return new Promise((resolve, reject) => {
         reject(new Error('The conference is not created yet!'));
     });
@@ -1311,6 +1358,7 @@ JitsiConference.prototype.getPhoneNumber = function() {
     if (this.room) {
         return this.room.getPhoneNumber();
     }
+
     return null;
 };
 
@@ -1321,6 +1369,7 @@ JitsiConference.prototype.getPhonePin = function() {
     if (this.room) {
         return this.room.getPhonePin();
     }
+
     return null;
 };
 
@@ -1332,6 +1381,7 @@ JitsiConference.prototype.getConnectionState = function() {
     if (this.jingleSession) {
         return this.jingleSession.getIceConnectionState();
     }
+
     return null;
 };
 
@@ -1386,11 +1436,13 @@ JitsiConference.prototype.getLogs = function() {
     const data = this.xmpp.getJingleLog();
 
     const metadata = {};
+
     metadata.time = new Date();
     metadata.url = window.location.href;
     metadata.ua = navigator.userAgent;
 
     const log = this.xmpp.getXmppLog();
+
     if (log) {
         metadata.xmpp = log;
     }
@@ -1446,6 +1498,7 @@ JitsiConference.prototype.isCallstatsEnabled = function() {
  */
 JitsiConference.prototype._onTrackAttach = function(track, container) {
     const ssrc = track.getSSRC();
+
     if (!container.id || !ssrc) {
         return;
     }

JitsiConferenceEventManager.js

@@ -37,6 +37,7 @@ function JitsiConferenceEventManager(conference) {
 JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
     const conference = this.conference;
     const chatRoom = conference.room;
+
     this.chatRoomForwarder = new EventEmitterForwarder(chatRoom,
         this.conference.eventEmitter);
 
@@ -72,10 +73,12 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
 
             Object.keys(chatRoom.connectionTimes).forEach(key => {
                 const value = chatRoom.connectionTimes[key];
+
                 Statistics.analytics.sendEvent(`conference.${key}`, {value});
             });
             Object.keys(chatRoom.xmpp.connectionTimes).forEach(key => {
                 const value = chatRoom.xmpp.connectionTimes[key];
+
                 Statistics.analytics.sendEvent(`xmpp.${key}`, {value});
             });
         });
@@ -154,6 +157,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
 
     const eventLogHandler
         = reason => Statistics.sendEventToAll(`conference.error.${reason}`);
+
     chatRoom.addListener(XMPPEvents.SESSION_ACCEPT_TIMEOUT,
         eventLogHandler.bind(null, 'sessionAcceptTimeout'));
 
@@ -185,6 +189,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
 
     chatRoom.setParticipantPropertyListener((node, from) => {
         const participant = conference.getParticipantById(from);
+
         if (!participant) {
             return;
         }
@@ -229,6 +234,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
                         id: 'recorder_status',
                         status
                     };
+
                     if (error) {
                         logObject.error = error;
                     }
@@ -252,6 +258,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
     chatRoom.addListener(XMPPEvents.MESSAGE_RECEIVED,
         (jid, displayName, txt, myJid, ts) => {
             const id = Strophe.getResourceFromJid(jid);
+
             conference.eventEmitter.emit(JitsiConferenceEvents.MESSAGE_RECEIVED,
                 id, txt, ts);
         });
@@ -260,6 +267,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
         (jid, status) => {
             const id = Strophe.getResourceFromJid(jid);
             const participant = conference.getParticipantById(id);
+
             if (!participant || participant._status === status) {
                 return;
             }
@@ -281,10 +289,12 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
 
     chatRoom.addPresenceListener('startmuted', (data, from) => {
         let isModerator = false;
+
         if (conference.myUserId() === from && conference.isModerator()) {
             isModerator = true;
         } else {
             const participant = conference.getParticipantById(from);
+
             if (participant && participant.isModerator()) {
                 isModerator = true;
             }
@@ -334,6 +344,7 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
     chatRoom.addPresenceListener('devices', (data, from) => {
         let isAudioAvailable = false;
         let isVideoAvailable = false;
+
         data.children.forEach(config => {
             if (config.tagName === 'audio') {
                 isAudioAvailable = config.value === 'true';
@@ -344,10 +355,12 @@ JitsiConferenceEventManager.prototype.setupChatRoomListeners = function() {
         });
 
         let availableDevices;
+
         if (conference.myUserId() === from) {
             availableDevices = conference.availableDevices;
         } else {
             const participant = conference.getParticipantById(from);
+
             if (!participant) {
                 return;
             }
@@ -420,6 +433,7 @@ JitsiConferenceEventManager.prototype.setupRTCListeners = function() {
 
     rtc.addListener(RTCEvents.DATA_CHANNEL_OPEN, () => {
         const now = window.performance.now();
+
         logger.log('(TIME) data channel opened ', now);
         conference.room.connectionTimes['data.channel.opened'] = now;
         Statistics.analytics.sendEvent('conference.dataChannel.open',
@@ -439,6 +453,7 @@ JitsiConferenceEventManager.prototype.setupRTCListeners = function() {
     rtc.addListener(RTCEvents.ENDPOINT_MESSAGE_RECEIVED,
         (from, payload) => {
             const participant = conference.getParticipantById(from);
+
             if (participant) {
                 conference.eventEmitter.emit(
                     JitsiConferenceEvents.ENDPOINT_MESSAGE_RECEIVED,
@@ -479,10 +494,12 @@ JitsiConferenceEventManager.prototype.setupRTCListeners = function() {
  */
 JitsiConferenceEventManager.prototype.setupXMPPListeners = function() {
     const conference = this.conference;
+
     conference.xmpp.caps.addListener(XMPPEvents.PARTCIPANT_FEATURES_CHANGED,
         from => {
             const participant = conference.getParticipantId(
                 Strophe.getResourceFromJid(from));
+
             if(participant) {
                 conference.eventEmitter.emit(
                     JitsiConferenceEvents.PARTCIPANT_FEATURES_CHANGED,
@@ -521,12 +538,14 @@ JitsiConferenceEventManager.prototype.setupXMPPListeners = function() {
  */
 JitsiConferenceEventManager.prototype.setupStatisticsListeners = function() {
     const conference = this.conference;
+
     if(!conference.statistics) {
         return;
     }
 
     conference.statistics.addAudioLevelListener((ssrc, level) => {
         const resource = conference.rtc.getResourceBySSRC(ssrc);
+
         if (!resource) {
             return;
         }
@@ -554,12 +573,14 @@ JitsiConferenceEventManager.prototype.setupStatisticsListeners = function() {
             }
 
             const id = conference.rtc.getResourceBySSRC(ssrc);
+
             if (!id) {
                 return;
             }
 
             // ssrc to resolution map for user id
             const idResolutions = id2resolution[id] || {};
+
             idResolutions[ssrc] = resolution;
 
             id2resolution[id] = idResolutions;
@@ -574,6 +595,7 @@ JitsiConferenceEventManager.prototype.setupStatisticsListeners = function() {
     conference.statistics.addByteSentStatsListener(stats => {
         conference.getLocalTracks(MediaType.AUDIO).forEach(track => {
             const ssrc = track.getSSRC();
+
             if (!ssrc || !stats.hasOwnProperty(ssrc)) {
                 return;
             }

JitsiConnection.js

@@ -1,4 +1,5 @@
 const JitsiConference = require('./JitsiConference');
+
 import * as JitsiConnectionEvents from './JitsiConnectionEvents';
 import XMPP from './modules/xmpp/xmpp';
 const Statistics = require('./modules/statistics/statistics');

JitsiMediaDevices.js

@@ -102,6 +102,7 @@ const JitsiMediaDevices = {
     setAudioOutputDevice(deviceId) {
 
         const availableDevices = RTC.getCurrentlyAvailableMediaDevices();
+
         if (availableDevices && availableDevices.length > 0) {
             // if we have devices info report device to stats
             // normally this will not happen on startup as this method is called

JitsiMeetJS.js

@@ -37,13 +37,16 @@ function getLowerResolution(resolution) {
     const order = Resolutions[resolution].order;
     let res = null;
     let resName = null;
+
     Object.keys(Resolutions).forEach(resolution => {
         const value = Resolutions[resolution];
+
         if (!res || (res.order < value.order && value.order < order)) {
             resName = resolution;
             res = value;
         }
     });
+
     return resName;
 }
 
@@ -114,6 +117,7 @@ const LibJitsiMeet = {
         if (window.jitsiRegionInfo
             && Object.keys(window.jitsiRegionInfo).length > 0) {
             const logObject = {};
+
             for (const attr in window.jitsiRegionInfo) {
                 if (window.jitsiRegionInfo.hasOwnProperty(attr)) {
                     logObject[attr] = window.jitsiRegionInfo[attr];
@@ -130,6 +134,7 @@ const LibJitsiMeet = {
                 component: 'lib-jitsi-meet',
                 version: this.version
             };
+
             Statistics.sendLog(JSON.stringify(logObject));
         }
 
@@ -243,6 +248,7 @@ const LibJitsiMeet = {
                     for(let i = 0; i < tracks.length; i++) {
                         const track = tracks[i];
                         const mStream = track.getOriginalStream();
+
                         if(track.getType() === MediaType.AUDIO) {
                             Statistics.startLocalStats(mStream,
                                 track.setAudioLevel.bind(track));
@@ -258,16 +264,19 @@ const LibJitsiMeet = {
                 // set real device ids
                 const currentlyAvailableMediaDevices
                     = RTC.getCurrentlyAvailableMediaDevices();
+
                 if (currentlyAvailableMediaDevices) {
                     for(let i = 0; i < tracks.length; i++) {
                         const track = tracks[i];
+
                         track._setRealDeviceIdFromDeviceList(
                             currentlyAvailableMediaDevices);
                     }
                 }
 
                 return tracks;
-            }).catch(error => {
+            })
+            .catch(error => {
                 promiseFulfilled = true;
 
                 if(error.name === JitsiTrackErrors.UNSUPPORTED_RESOLUTION) {
@@ -296,6 +305,7 @@ const LibJitsiMeet = {
                         id: 'chrome_extension_user_canceled',
                         message: error.message
                     };
+
                     Statistics.sendLog(JSON.stringify(logObject));
                     Statistics.analytics.sendEvent(
                         'getUserMedia.userCancel.extensionInstall');
@@ -305,6 +315,7 @@ const LibJitsiMeet = {
                         id: 'usermedia_missing_device',
                         status: error.gum.devices
                     };
+
                     Statistics.sendLog(JSON.stringify(logObject));
                     Statistics.analytics.sendEvent(
                         `getUserMedia.deviceNotFound.${
@@ -316,6 +327,7 @@ const LibJitsiMeet = {
                         = addDeviceTypeToAnalyticsEvent(
                             'getUserMedia.failed',
                             options);
+
                     Statistics.analytics.sendEvent(
                         `${event}.${error.name}`,
                         {value: options});
@@ -337,6 +349,7 @@ const LibJitsiMeet = {
     isDeviceListAvailable() {
         logger.warn('This method is deprecated, use '
             + 'JitsiMeetJS.mediaDevices.isDeviceListAvailable instead');
+
         return this.mediaDevices.isDeviceListAvailable();
     },
     /**
@@ -350,6 +363,7 @@ const LibJitsiMeet = {
     isDeviceChangeAvailable(deviceType) {
         logger.warn('This method is deprecated, use '
             + 'JitsiMeetJS.mediaDevices.isDeviceChangeAvailable instead');
+
         return this.mediaDevices.isDeviceChangeAvailable(deviceType);
     },
     /**

doc/example/example.js

@@ -63,10 +63,12 @@ function onRemoteTrack(track) {
         return;
     }
     const participant = track.getParticipantId();
+
     if(!remoteTracks[participant]) {
         remoteTracks[participant] = [];
     }
     const idx = remoteTracks[participant].push(track);
+
     track.addEventListener(
         JitsiMeetJS.events.track.TRACK_AUDIO_LEVEL_CHANGED,
         audioLevel => console.log(`Audio Level remote: ${audioLevel}`));
@@ -81,6 +83,7 @@ function onRemoteTrack(track) {
             console.log(
                 `track audio output device was changed to ${deviceId}`));
     const id = participant + track.getType() + idx;
+
     if(track.getType() == 'video') {
         $('body').append(`<video autoplay='1' id='${participant}video${idx}' />`);
     } else {
@@ -106,6 +109,7 @@ function onUserLeft(id) {
         return;
     }
     const tracks = remoteTracks[id];
+
     for(let i = 0; i < tracks.length; i++) {
         tracks[i].detach($(`#${id}${tracks[i].getType()}`));
     }
@@ -181,6 +185,7 @@ function unload() {
 }
 
 let isVideo = true;
+
 function switchVideo() { // eslint-disable-line no-unused-vars
     isVideo = !isVideo;
     if(localTracks[1]) {
@@ -200,9 +205,8 @@ function switchVideo() { // eslint-disable-line no-unused-vars
                 });
             localTracks[1].attach($('#localVideo1')[0]);
             room.addTrack(localTracks[1]);
-        }).catch(error => {
-            console.log(error);
-        });
+        })
+        .catch(error => console.log(error));
 }
 
 function changeAudioOutput(selected) { // eslint-disable-line no-unused-vars
@@ -239,23 +243,33 @@ const initOptions = {
     // The URL to the Firefox extension for desktop sharing.
     desktopSharingFirefoxExtensionURL: null
 };
-JitsiMeetJS.init(initOptions).then(() => {
-    connection = new JitsiMeetJS.JitsiConnection(null, null, options);
 
-    connection.addEventListener(JitsiMeetJS.events.connection.CONNECTION_ESTABLISHED, onConnectionSuccess);
-    connection.addEventListener(JitsiMeetJS.events.connection.CONNECTION_FAILED, onConnectionFailed);
-    connection.addEventListener(JitsiMeetJS.events.connection.CONNECTION_DISCONNECTED, disconnect);
+JitsiMeetJS.init(initOptions)
+    .then(() => {
+        connection = new JitsiMeetJS.JitsiConnection(null, null, options);
+
+        connection.addEventListener(
+            JitsiMeetJS.events.connection.CONNECTION_ESTABLISHED,
+            onConnectionSuccess);
+        connection.addEventListener(
+            JitsiMeetJS.events.connection.CONNECTION_FAILED,
+            onConnectionFailed);
+        connection.addEventListener(
+            JitsiMeetJS.events.connection.CONNECTION_DISCONNECTED,
+            disconnect);
 
-    JitsiMeetJS.mediaDevices.addEventListener(JitsiMeetJS.events.mediaDevices.DEVICE_LIST_CHANGED, onDeviceListChanged);
+        JitsiMeetJS.mediaDevices.addEventListener(
+            JitsiMeetJS.events.mediaDevices.DEVICE_LIST_CHANGED,
+            onDeviceListChanged);
 
-    connection.connect();
-    JitsiMeetJS.createLocalTracks({devices: ['audio', 'video']})
-        .then(onLocalTracks).catch(error => {
-            throw error;
-        });
-}).catch(error => {
-    console.log(error);
-});
+        connection.connect();
+        JitsiMeetJS.createLocalTracks({devices: ['audio', 'video']})
+            .then(onLocalTracks)
+            .catch(error => {
+                throw error;
+            });
+    })
+    .catch(error => console.log(error));
 
 if (JitsiMeetJS.mediaDevices.isDeviceChangeAvailable('output')) {
     JitsiMeetJS.mediaDevices.enumerateDevices(devices => {

modules/DTMF/JitsiDTMFManager.js

@@ -2,6 +2,7 @@ const logger = require('jitsi-meet-logger').getLogger(__filename);
 
 function JitsiDTMFManager(localAudio, peerConnection) {
     const audioTrack = localAudio.getTrack();
+
     if (!audioTrack) {
         throw new Error('Failed to initialize DTMFSender: no audio track.');
     }

modules/RTC/DataChannels.js

@@ -139,6 +139,7 @@ DataChannels.prototype.onDataChannel = function(event) {
             } else if ('EndpointConnectivityStatusChangeEvent' === colibriClass) {
                 const endpoint = obj.endpoint;
                 const isActive = obj.active === 'true';
+
                 logger.info(
                     `Endpoint connection status changed: ${endpoint} active ? ${
                         isActive}`);
@@ -158,6 +159,7 @@ DataChannels.prototype.onDataChannel = function(event) {
     dataChannel.onclose = function() {
         logger.info('The Data Channel closed', dataChannel);
         const idx = self._dataChannels.indexOf(dataChannel);
+
         if (idx > -1) {
             self._dataChannels = self._dataChannels.splice(idx, 1);
         }
@@ -215,6 +217,7 @@ DataChannels.prototype._onXXXEndpointChanged = function(xxx, userResource) {
     const tail = xxx.substring(1);
     const lower = head.toLowerCase() + tail;
     const upper = head.toUpperCase() + tail;
+
     logger.log(
             `sending ${lower} endpoint changed notification to the bridge: `,
             userResource);
@@ -238,9 +241,11 @@ DataChannels.prototype._some = function(callback, thisArg) {
         if (thisArg) {
             return dataChannels.some(callback, thisArg);
         }
+
         return dataChannels.some(callback);
 
     }
+
     return false;
 
 };
@@ -256,6 +261,7 @@ DataChannels.prototype.send = function(jsonObject) {
     if(!this._some(dataChannel => {
         if (dataChannel.readyState == 'open') {
             dataChannel.send(JSON.stringify(jsonObject));
+
             return true;
         }
     })) {

modules/RTC/JitsiLocalTrack.js

@@ -146,9 +146,11 @@ JitsiLocalTrack.prototype._initNoDataFromSourceHandlers = function() {
     if(this.isVideoTrack() && this.videoType === VideoType.CAMERA) {
         const _onNoDataFromSourceError
             = this._onNoDataFromSourceError.bind(this);
+
         this._setHandler('track_mute', () => {
             if(this._checkForCameraIssues()) {
                 const now = window.performance.now();
+
                 this._noDataFromSourceTimeout
                     = setTimeout(_onNoDataFromSourceError, 3000);
                 this._setHandler('track_unmute', () => {
@@ -194,8 +196,10 @@ JitsiLocalTrack.prototype._onNoDataFromSourceError = function() {
 JitsiLocalTrack.prototype._fireNoDataFromSourceEvent = function() {
     this.eventEmitter.emit(JitsiTrackEvents.NO_DATA_FROM_SOURCE);
     const eventName = `${this.getType()}.no_data_from_source`;
+
     Statistics.analytics.sendEvent(eventName);
     const log = {name: eventName};
+
     if (this.isAudioTrack()) {
         log.isReceivingData = this._isReceivingData();
     }
@@ -316,6 +320,7 @@ JitsiLocalTrack.prototype._setMute = function(mute) {
             devices: [ MediaType.VIDEO ],
             facingMode: this.getCameraFacingMode()
         };
+
         if (this.resolution) {
             streamOptions.resolution = this.resolution;
         }
@@ -390,6 +395,7 @@ JitsiLocalTrack.prototype._removeStreamFromConferenceAsMute
 = function(successCallback, errorCallback) {
     if (!this.conference) {
         successCallback();
+
         return;
     }
 
@@ -474,6 +480,7 @@ JitsiLocalTrack.prototype.isMuted = function() {
     if (this.isVideoTrack() && !this.isActive()) {
         return true;
     }
+
     return !this.track || !this.track.enabled;
 
 };
@@ -517,6 +524,7 @@ JitsiLocalTrack.prototype.getSSRC = function() {
     } else if(this.ssrc && this.ssrc.ssrcs && this.ssrc.ssrcs.length) {
         return this.ssrc.ssrcs[0];
     }
+
     return null;
 
 };
@@ -549,6 +557,7 @@ JitsiLocalTrack.prototype._setByteSent = function(bytesSent) {
     // the conference(and through the XMPP chat room ???) instead
     const iceConnectionState
         = this.conference ? this.conference.getConnectionState() : null;
+
     if(this._testByteSent && 'connected' === iceConnectionState) {
         setTimeout(() => {
             if(this._bytesSent <= 0) {
@@ -636,6 +645,7 @@ JitsiLocalTrack.prototype._isReceivingData = function() {
     if(!this.stream) {
         return false;
     }
+
     // In older version of the spec there is no muted property and
     // readyState can have value muted. In the latest versions
     // readyState can have values "live" and "ended" and there is

modules/RTC/JitsiRemoteTrack.js

@@ -1,6 +1,7 @@
 /* global */
 
 const JitsiTrack = require('./JitsiTrack');
+
 import * as JitsiTrackEvents from '../../JitsiTrackEvents';
 const logger = require('jitsi-meet-logger').getLogger(__filename);
 const RTCBrowserType = require('./RTCBrowserType');
@@ -152,6 +153,7 @@ JitsiRemoteTrack.prototype._playCallback = function() {
     const type = this.isVideoTrack() ? 'video' : 'audio';
 
     const now = window.performance.now();
+
     console.log(`(TIME) Render ${type}:\t`, now);
     this.conference.getConnectionTimes()[`${type}.render`] = now;
 
@@ -160,9 +162,11 @@ JitsiRemoteTrack.prototype._playCallback = function() {
         - this.conference.getConnectionTimes()['muc.joined'])
         - (window.connectionTimes['obtainPermissions.end']
         - window.connectionTimes['obtainPermissions.start']);
+
     this.conference.getConnectionTimes()[`${type}.ttfm`] = ttfm;
     console.log(`(TIME) TTFM ${type}:\t`, ttfm);
     let eventName = `${type}.ttfm`;
+
     if(this.hasBeenMuted) {
         eventName += '.muted';
     }

modules/RTC/JitsiTrack.js

@@ -31,6 +31,7 @@ function implementOnEndedHandling(jitsiTrack) {
     }
 
     const originalStop = stream.stop;
+
     stream.stop = function() {
         originalStop.apply(stream);
         if (jitsiTrack.isActive()) {
@@ -211,6 +212,7 @@ JitsiTrack.prototype.getUsageLabel = function() {
     if (this.isAudioTrack()) {
         return 'mic';
     }
+
     return this.videoType ? this.videoType : 'default';
 
 };
@@ -267,6 +269,7 @@ JitsiTrack.prototype.attach = function(container) {
 JitsiTrack.prototype.detach = function(container) {
     for (let cs = this.containers, i = cs.length - 1; i >= 0; --i) {
         const c = cs[i];
+
         if (!container) {
             RTCUtils.attachMediaStream(c, null);
         }
@@ -322,6 +325,7 @@ JitsiTrack.prototype.getId = function() {
     if(this.stream) {
         return RTCUtils.getStreamID(this.stream);
     }
+
     return null;
 
 };
@@ -336,6 +340,7 @@ JitsiTrack.prototype.isActive = function() {
     if(typeof this.stream.active !== 'undefined') {
         return this.stream.active;
     }
+
     return true;
 
 };
@@ -386,6 +391,8 @@ JitsiTrack.prototype.setAudioLevel = function(audioLevel) {
 JitsiTrack.prototype.getMSID = function() {
     const streamId = this.getStreamId();
     const trackId = this.getTrackId();
+
+
     return streamId && trackId ? `${streamId} ${trackId}` : null;
 };
 

modules/RTC/RTC.js

@@ -18,6 +18,7 @@ const logger = getLogger(__filename);
 function createLocalTracks(tracksInfo, options) {
     const newTracks = [];
     let deviceId = null;
+
     tracksInfo.forEach(trackInfo => {
         if (trackInfo.mediaType === MediaType.AUDIO) {
             deviceId = options.micDeviceId;
@@ -33,8 +34,10 @@ function createLocalTracks(tracksInfo, options) {
                 trackInfo.resolution,
                 deviceId,
                 options.facingMode);
+
         newTracks.push(localTrack);
     });
+
     return newTracks;
 }
 
@@ -70,6 +73,7 @@ export default class RTC extends Listenable {
                 deviceId => {
                     const remoteAudioTracks
                         = this.getRemoteTracks(MediaType.AUDIO);
+
                     for (const track of remoteAudioTracks) {
                         track.setAudioOutput(deviceId);
                     }
@@ -95,6 +99,8 @@ export default class RTC extends Listenable {
         return RTCUtils.obtainAudioAndVideoPermissions(options).then(
             tracksInfo => {
                 const tracks = createLocalTracks(tracksInfo, options);
+
+
                 return tracks.some(track => !track._isReceivingData())
                     ? Promise.reject(
                         new JitsiTrackError(
@@ -201,6 +207,7 @@ export default class RTC extends Listenable {
 
     static init(options = {}) {
         this.options = options;
+
         return RTCUtils.init(this.options);
     }
 
@@ -232,6 +239,7 @@ export default class RTC extends Listenable {
 
         this.peerConnections.set(newConnection.id, newConnection);
         this.peerConnectionIdCounter += 1;
+
         return newConnection;
     }
 
@@ -244,11 +252,14 @@ export default class RTC extends Listenable {
      */
     _removePeerConnection(traceablePeerConnection) {
         const id = traceablePeerConnection.id;
+
         if (this.peerConnections.has(id)) {
             // NOTE Remote tracks are not removed here.
             this.peerConnections.delete(id);
+
             return true;
         }
+
         return false;
 
     }
@@ -269,6 +280,8 @@ export default class RTC extends Listenable {
      */
     getLocalVideoTrack() {
         const localVideo = this.getLocalTracks(MediaType.VIDEO);
+
+
         return localVideo.length ? localVideo[0] : undefined;
     }
 
@@ -278,6 +291,8 @@ export default class RTC extends Listenable {
      */
     getLocalAudioTrack() {
         const localAudio = this.getLocalTracks(MediaType.AUDIO);
+
+
         return localAudio.length ? localAudio[0] : undefined;
     }
 
@@ -289,10 +304,12 @@ export default class RTC extends Listenable {
      */
     getLocalTracks(mediaType) {
         let tracks = this.localTracks.slice();
+
         if (mediaType !== undefined) {
             tracks = tracks.filter(
                 track => track.getType() === mediaType);
         }
+
         return tracks;
     }
 
@@ -321,6 +338,7 @@ export default class RTC extends Listenable {
                 }
             }
         }
+
         return remoteTracks;
     }
 
@@ -335,6 +353,7 @@ export default class RTC extends Listenable {
         if (this.remoteTracks[resource]) {
             return this.remoteTracks[resource][type];
         }
+
         return null;
 
     }
@@ -366,16 +385,20 @@ export default class RTC extends Listenable {
      */
     setAudioMute(value) {
         const mutePromises = [];
+
         this.getLocalTracks(MediaType.AUDIO).forEach(audioTrack => {
             // this is a Promise
             mutePromises.push(value ? audioTrack.mute() : audioTrack.unmute());
         });
-        // we return a Promise from all Promises so we can wait for their execution
+
+        // We return a Promise from all Promises so we can wait for their
+        // execution.
         return Promise.all(mutePromises);
     }
 
     removeLocalTrack(track) {
         const pos = this.localTracks.indexOf(track);
+
         if (pos === -1) {
             return;
         }
@@ -435,6 +458,7 @@ export default class RTC extends Listenable {
 
             delete this.remoteTracks[owner];
         }
+
         return removedTracks;
     }
 
@@ -460,8 +484,10 @@ export default class RTC extends Listenable {
                         && mediaTrack.getStreamId() == streamId
                         && mediaTrack.getTrackId() == trackId) {
                         result = mediaTrack;
+
                         return true;
                     }
+
                     return false;
 
                 });
@@ -637,6 +663,7 @@ export default class RTC extends Listenable {
             return;
         }
         const audioTrack = this.getRemoteAudioTrack(resource);
+
         if(audioTrack) {
             audioTrack.setAudioLevel(audioLevel);
         }
@@ -654,6 +681,8 @@ export default class RTC extends Listenable {
         }
 
         const track = this.getRemoteTrackBySSRC(ssrc);
+
+
         return track ? track.getParticipantId() : null;
     }
 
@@ -676,6 +705,7 @@ export default class RTC extends Listenable {
      */
     handleRemoteTrackMute(type, isMuted, from) {
         const track = this.getRemoteTrackByType(type, from);
+
         if (track) {
             track.setMute(isMuted);
         }
@@ -688,6 +718,7 @@ export default class RTC extends Listenable {
      */
     handleRemoteTrackVideoTypeChanged(value, from) {
         const videoTrack = this.getRemoteVideoTrack(from);
+
         if (videoTrack) {
             videoTrack._setVideoType(value);
         }

modules/RTC/RTCBrowserType.js

@@ -34,11 +34,13 @@ const RTCBrowserType = {
      */
     getBrowserName() {
         let browser;
+
         if (RTCBrowserType.isAndroid()) {
             browser = 'android';
         } else {
             browser = currentBrowser.split('rtc_browser.')[1];
         }
+
         return browser;
     },
 
@@ -199,20 +201,27 @@ function detectChrome() {
         // We can assume that user agent is chrome, because it's
         // enforced when 'ext' streaming method is set
         const ver = parseInt(userAgent.match(/chrome\/(\d+)\./)[1], 10);
+
         logger.log(`This appears to be Chrome, ver: ${ver}`);
+
         return ver;
     }
+
     return null;
 }
 
 function detectOpera() {
     const userAgent = navigator.userAgent;
+
     if (userAgent.match(/Opera|OPR/)) {
         currentBrowser = RTCBrowserType.RTC_BROWSER_OPERA;
         const version = userAgent.match(/(Opera|OPR) ?\/?(\d+)\.?/)[2];
+
         logger.info(`This appears to be Opera, ver: ${version}`);
+
         return version;
     }
+
     return null;
 }
 
@@ -221,9 +230,12 @@ function detectFirefox() {
         currentBrowser = RTCBrowserType.RTC_BROWSER_FIREFOX;
         const version = parseInt(
             navigator.userAgent.match(/Firefox\/([0-9]+)\./)[1], 10);
+
         logger.log(`This appears to be Firefox, ver: ${version}`);
+
         return version;
     }
+
     return null;
 }
 
@@ -231,9 +243,11 @@ function detectSafari() {
     if (/^((?!chrome).)*safari/i.test(navigator.userAgent)) {
         currentBrowser = RTCBrowserType.RTC_BROWSER_SAFARI;
         logger.info('This appears to be Safari');
+
         // FIXME detect Safari version when needed
         return 1;
     }
+
     return null;
 }
 
@@ -242,19 +256,23 @@ function detectIE() {
     const ua = window.navigator.userAgent;
 
     const msie = ua.indexOf('MSIE ');
+
     if (msie > 0) {
         // IE 10 or older => return version number
         version = parseInt(ua.substring(msie + 5, ua.indexOf('.', msie)), 10);
     }
 
     const trident = ua.indexOf('Trident/');
+
     if (!version && trident > 0) {
         // IE 11 => return version number
         const rv = ua.indexOf('rv:');
+
         version = parseInt(ua.substring(rv + 3, ua.indexOf('.', rv)), 10);
     }
 
     const edge = ua.indexOf('Edge/');
+
     if (!version && edge > 0) {
         // IE 12 => return version number
         version = parseInt(ua.substring(edge + 5, ua.indexOf('.', edge)), 10);
@@ -264,6 +282,7 @@ function detectIE() {
         currentBrowser = RTCBrowserType.RTC_BROWSER_IEXPLORER;
         logger.info(`This appears to be IExplorer, ver: ${version}`);
     }
+
     return version;
 }
 
@@ -272,23 +291,31 @@ function detectIE() {
  */
 function detectElectron() {
     const userAgent = navigator.userAgent;
+
     if (userAgent.match(/Electron/)) {
         currentBrowser = RTCBrowserType.RTC_BROWSER_ELECTRON;
         const version = userAgent.match(/Electron\/([\d.]+)/)[1];
+
         logger.info(`This appears to be Electron, ver: ${version}`);
+
         return version;
     }
+
     return null;
 }
 
 function detectNWJS() {
     const userAgent = navigator.userAgent;
+
     if (userAgent.match(/JitsiMeetNW/)) {
         currentBrowser = RTCBrowserType.RTC_BROWSER_NWJS;
         const version = userAgent.match(/JitsiMeetNW\/([\d.]+)/)[1];
+
         logger.info(`This appears to be JitsiMeetNW, ver: ${version}`);
+
         return version;
     }
+
     return null;
 }
 
@@ -299,9 +326,11 @@ function detectReactNative() {
     // If we're remote debugging a React Native app, it may be treated as
     // Chrome. Check navigator.product as well and always return some version
     // even if we can't get the real one.
+
     if (match || navigator.product === 'ReactNative') {
         currentBrowser = RTCBrowserType.RTC_BROWSER_REACT_NATIVE;
         let name;
+
         if (match && match.length > 2) {
             name = match[1];
             version = match[2];
@@ -313,6 +342,7 @@ function detectReactNative() {
         // We're not running in a React Native environment.
         version = null;
     }
+
     return version;
 }
 
@@ -329,6 +359,7 @@ function detectBrowser() {
         detectSafari
     ];
     // Try all browser detectors
+
     for (let i = 0; i < detectors.length; i++) {
         version = detectors[i]();
         if (version) {
@@ -337,6 +368,7 @@ function detectBrowser() {
     }
     logger.warn('Browser type defaults to Safari ver 1');
     currentBrowser = RTCBrowserType.RTC_BROWSER_SAFARI;
+
     return 1;
 }
 

modules/RTC/RTCUIHelper.js

@@ -23,17 +23,20 @@ const RTCUIHelper = {
      */
     findVideoElement(containerElement) {
         const videoElemName = RTCUIHelper.getVideoElementName();
+
         if (!RTCBrowserType.isTemasysPluginUsed()) {
             return $(containerElement).find(videoElemName)[0];
         }
         const matching = $(containerElement).find(
                 ` ${videoElemName}>param[value="video"]`);
+
         if (matching.length) {
             if (matching.length > 1) {
                 logger.warn(
                         'Container with more than one video elements: ',
                         containerElement);
             }
+
             return matching.parent()[0];
         }
 

modules/RTC/RTCUtils.js

@@ -66,6 +66,7 @@ let rawEnumerateDevicesWithCallback = undefined;
  * ready. Otherwise it is too early to assume that the devices listing is not
  * supported.
  */
+
 function initRawEnumerateDevicesWithCallback() {
     rawEnumerateDevicesWithCallback = navigator.mediaDevices
         && navigator.mediaDevices.enumerateDevices
@@ -265,6 +266,7 @@ function getConstraints(um, options) {
             const errmsg
                 = '\'screen\' WebRTC media source is supported only in Chrome'
                     + ' and with Temasys plugin';
+
             GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
             logger.error(errmsg);
         }
@@ -333,8 +335,15 @@ function compareAvailableMediaDevices(newDevices) {
         return true;
     }
 
-    return newDevices.map(mediaDeviceInfoToJSON).sort().join('')
-        !== currentlyAvailableMediaDevices.map(mediaDeviceInfoToJSON).sort().join('');
+    return (
+        newDevices
+                .map(mediaDeviceInfoToJSON)
+                .sort()
+                .join('')
+            !== currentlyAvailableMediaDevices
+                .map(mediaDeviceInfoToJSON)
+                .sort()
+                .join(''));
 
     function mediaDeviceInfoToJSON(info) {
         return JSON.stringify({
@@ -538,6 +547,7 @@ function obtainDevices(options) {
 
     const device = options.devices.splice(0, 1);
     const devices = [];
+
     devices.push(device);
     options.deviceGUM[device](
         stream => {
@@ -578,8 +588,10 @@ function handleLocalStream(streams, resolution) {
         // (with a result which meets our requirements expressed bellow) calling
         // getUserMedia once for both audio and video.
         const audioVideo = streams.audioVideo;
+
         if (audioVideo) {
             const audioTracks = audioVideo.getAudioTracks();
+
             if (audioTracks.length) {
                 // eslint-disable-next-line new-cap
                 audioStream = new webkitMediaStream();
@@ -589,6 +601,7 @@ function handleLocalStream(streams, resolution) {
             }
 
             const videoTracks = audioVideo.getVideoTracks();
+
             if (videoTracks.length) {
                 // eslint-disable-next-line new-cap
                 videoStream = new webkitMediaStream();
@@ -693,6 +706,7 @@ function wrapAttachMediaStream(origAttachMediaStream) {
 function defaultSetVideoSrc(element, stream) {
     // srcObject
     let srcObjectPropertyName = 'srcObject';
+
     if (!(srcObjectPropertyName in element)) {
         srcObjectPropertyName = 'mozSrcObject';
         if (!(srcObjectPropertyName in element)) {
@@ -701,11 +715,13 @@ function defaultSetVideoSrc(element, stream) {
     }
     if (srcObjectPropertyName) {
         element[srcObjectPropertyName] = stream;
+
         return;
     }
 
     // src
     let src;
+
     if (stream) {
         src = stream.jitsiObjectURL;
         // Save the created URL for stream so we can reuse it and not keep
@@ -738,6 +754,7 @@ class RTCUtils extends Listenable {
         return new Promise((resolve, reject) => {
             if (RTCBrowserType.isFirefox()) {
                 const FFversion = RTCBrowserType.getFirefoxVersion();
+
                 if (FFversion < 40) {
                     rejectWithWebRTCNotSupported(
                         `Firefox version too old: ${FFversion}.`
@@ -766,17 +783,21 @@ class RTCUtils extends Listenable {
                             element.play();
                         }
                     }
+
                     return element;
                 });
                 this.getStreamID = function(stream) {
                     let id = stream.id;
+
                     if (!id) {
                         let tracks = stream.getVideoTracks();
+
                         if (!tracks || tracks.length === 0) {
                             tracks = stream.getAudioTracks();
                         }
                         id = tracks[0].id;
                     }
+
                     return SDPUtil.filter_special_chars(id);
                 };
                 RTCSessionDescription = mozRTCSessionDescription; // eslint-disable-line
@@ -789,6 +810,7 @@ class RTCUtils extends Listenable {
 
                 this.peerconnection = webkitRTCPeerConnection;
                 const getUserMedia = navigator.webkitGetUserMedia.bind(navigator);
+
                 if (navigator.mediaDevices) {
                     this.getUserMedia = wrapGetUserMedia(getUserMedia);
                     this.enumerateDevices = wrapEnumerateDevices(
@@ -800,6 +822,7 @@ class RTCUtils extends Listenable {
                 }
                 this.attachMediaStream = wrapAttachMediaStream((element, stream) => {
                     defaultSetVideoSrc(element, stream);
+
                     return element;
                 });
                 this.getStreamID = function(stream) {
@@ -813,6 +836,7 @@ class RTCUtils extends Listenable {
                     // XXX The return statement is affected by automatic
                     // semicolon insertion (ASI). No line terminator is allowed
                     // between the return keyword and the expression.
+
                     return (
                         typeof id === 'number'
                             ? id
@@ -859,11 +883,13 @@ class RTCUtils extends Listenable {
                             // The container must be visible in order to play or
                             // attach the stream when Temasys plugin is in use
                             const containerSel = $(element);
+
                             if (RTCBrowserType.isTemasysPluginUsed()
                                     && !containerSel.is(':visible')) {
                                 containerSel.show();
                             }
                             const video = stream.getVideoTracks().length > 0;
+
                             if (video && !$(element).is(':visible')) {
                                 throw new Error(
                                     'video element must be visible to attach'
@@ -982,6 +1008,8 @@ class RTCUtils extends Listenable {
 
         options = options || {};
         const dsOptions = options.desktopSharingExtensionExternalInstallation;
+
+
         return new Promise((resolve, reject) => {
             const successCallback = function(stream) {
                 resolve(handleLocalStream(stream, options.resolution));
@@ -1032,6 +1060,7 @@ class RTCUtils extends Listenable {
                 });
             } else {
                 const hasDesktop = options.devices.indexOf('desktop') > -1;
+
                 if (hasDesktop) {
                     options.devices.splice(options.devices.indexOf('desktop'), 1);
                 }
@@ -1138,6 +1167,7 @@ class RTCUtils extends Listenable {
         if (!rtcReady) {
             throw new Error('WebRTC not ready yet');
         }
+
         return Boolean(navigator.mediaDevices
             && navigator.mediaDevices.enumerateDevices
             && typeof MediaStreamTrack !== 'undefined'
@@ -1156,11 +1186,13 @@ class RTCUtils extends Listenable {
         if (rtcReady) {
             return Promise.resolve();
         }
+
         return new Promise(resolve => {
             const listener = () => {
                 eventEmitter.removeListener(RTCEvents.RTC_READY, listener);
                 resolve();
             };
+
             eventEmitter.addListener(RTCEvents.RTC_READY, listener);
                 // We have no failed event, so... it either resolves or nothing
                 // happens
@@ -1223,6 +1255,7 @@ class RTCUtils extends Listenable {
 
         // if we have done createObjectURL, lets clean it
         const url = mediaStream.jitsiObjectURL;
+
         if (url) {
             delete mediaStream.jitsiObjectURL;
             (URL || webkitURL).revokeObjectURL(url);
@@ -1293,7 +1326,9 @@ class RTCUtils extends Listenable {
             'label':    device.label,
             'groupId':  device.groupId
         };
+
         devices.push(deviceData);
+
         return { deviceList: devices };
     }
 }

modules/RTC/ScreenObtainer.js

@@ -3,6 +3,7 @@
 const GlobalOnErrorHandler = require('../util/GlobalOnErrorHandler');
 const logger = require('jitsi-meet-logger').getLogger(__filename);
 const RTCBrowserType = require('./RTCBrowserType');
+
 import JitsiTrackError from '../../JitsiTrackError';
 import * as JitsiTrackErrors from '../../JitsiTrackErrors';
 
@@ -70,6 +71,7 @@ const ScreenObtainer = {
      */
     init(options, gum) {
         let obtainDesktopStream = null;
+
         this.options = options = options || {};
         gumFunction = gum;
 
@@ -98,6 +100,7 @@ const ScreenObtainer = {
                         // I cannot find documentation about "InvalidStateError"
                         // but this is what we are receiving from GUM when the
                         // streamId for the desktop sharing is "".
+
                         if (error && error.name == 'InvalidStateError') {
                             jitsiError = new JitsiTrackError(
                                 JitsiTrackErrors.CHROME_EXTENSION_USER_CANCELED
@@ -187,6 +190,7 @@ const ScreenObtainer = {
     obtainScreenOnFirefox(options, callback, errorCallback) {
         let extensionRequired = false;
         const { desktopSharingFirefoxMaxVersionExtRequired } = this.options;
+
         if (desktopSharingFirefoxMaxVersionExtRequired === -1
             || (desktopSharingFirefoxMaxVersionExtRequired >= 0
                 && RTCBrowserType.getFirefoxVersion()
@@ -199,6 +203,7 @@ const ScreenObtainer = {
 
         if (!extensionRequired || firefoxExtInstalled === true) {
             obtainWebRTCScreen(options, callback, errorCallback);
+
             return;
         }
 
@@ -220,6 +225,7 @@ const ScreenObtainer = {
                 300);
             logger.log(
                 'Waiting for detection of jidesha on firefox to finish.');
+
             return;
         }
 
@@ -264,7 +270,8 @@ const ScreenObtainer = {
                             .then(() => {
                                 doGetStreamFromExtension(this.options,
                                     streamCallback, failCallback);
-                            }).catch(() => {
+                            })
+                            .catch(() => {
                                 this.handleExtensionInstallationError(options,
                                     streamCallback, failCallback);
                             });
@@ -290,6 +297,7 @@ const ScreenObtainer = {
             options.listener('waitingForExtension', webStoreInstallUrl);
             this.checkForChromeExtensionOnInterval(options, streamCallback,
                 failCallback, e);
+
             return;
         }
 
@@ -306,6 +314,7 @@ const ScreenObtainer = {
         if (options.checkAgain() === false) {
             failCallback(new JitsiTrackError(
                 JitsiTrackErrors.CHROME_EXTENSION_INSTALLATION_ERROR));
+
             return;
         }
         waitForExtensionAfterInstall(this.options, options.interval, 1)
@@ -314,7 +323,8 @@ const ScreenObtainer = {
                 options.listener('extensionFound');
                 this.obtainScreenFromExtension(options,
                     streamCallback, failCallback);
-            }).catch(() => {
+            })
+            .catch(() => {
                 this.checkForChromeExtensionOnInterval(options,
                     streamCallback, failCallback);
             });
@@ -358,6 +368,7 @@ function isUpdateRequired(minVersion, extVersion) {
         const s2 = extVersion.split('.');
 
         const len = Math.max(s1.length, s2.length);
+
         for (let i = 0; i < len; i++) {
             let n1 = 0,
                 n2 = 0;
@@ -382,6 +393,7 @@ function isUpdateRequired(minVersion, extVersion) {
     } catch (e) {
         GlobalOnErrorHandler.callErrorHandler(e);
         logger.error('Failed to parse extension version', e);
+
         return true;
     }
 }
@@ -390,6 +402,7 @@ function checkChromeExtInstalled(callback, options) {
     if (typeof chrome === 'undefined' || !chrome || !chrome.runtime) {
         // No API, so no extension for sure
         callback(false, false);
+
         return;
     }
     chrome.runtime.sendMessage(
@@ -401,15 +414,18 @@ function checkChromeExtInstalled(callback, options) {
                 logger.warn(
                     'Extension not installed?: ', chrome.runtime.lastError);
                 callback(false, false);
+
                 return;
             }
             // Check installed extension version
             const extVersion = response.version;
+
             logger.log(`Extension version is: ${extVersion}`);
             const updateRequired
                 = isUpdateRequired(
                     options.desktopSharingChromeMinExtVersion,
                     extVersion);
+
             callback(!updateRequired, updateRequired);
         }
     );
@@ -428,11 +444,13 @@ function doGetStreamFromExtension(options, streamCallback, failCallback) {
             if (!response) {
                 // possibly re-wraping error message to make code consistent
                 const lastError = chrome.runtime.lastError;
+
                 failCallback(lastError instanceof Error
                     ? lastError
                     : new JitsiTrackError(
                         JitsiTrackErrors.CHROME_EXTENSION_GENERIC_ERROR,
                         lastError));
+
                 return;
             }
             logger.log('Response from extension: ', response);
@@ -481,6 +499,7 @@ function waitForExtensionAfterInstall(options, waitInterval, retries) {
     if(retries === 0) {
         return Promise.reject();
     }
+
     return new Promise((resolve, reject) => {
         let currentRetries = retries;
         const interval = window.setInterval(() => {
@@ -523,6 +542,7 @@ function onGetStreamResponse(response, onSuccess, onFailure) {
         if(response.streamId === '') {
             onFailure(new JitsiTrackError(
                 JitsiTrackErrors.CHROME_EXTENSION_USER_CANCELED));
+
             return;
         }
 
@@ -546,10 +566,12 @@ function initFirefoxExtensionDetection(options) {
     }
     if (!options.desktopSharingFirefoxExtId) {
         firefoxExtInstalled = false;
+
         return;
     }
 
     const img = document.createElement('img');
+
     img.onload = () => {
         logger.log('Detected firefox screen sharing extension.');
         firefoxExtInstalled = true;
@@ -566,6 +588,7 @@ function initFirefoxExtensionDetection(options) {
     const src
         = `chrome://${options.desktopSharingFirefoxExtId.replace('@', '.')
             }/content/${document.location.hostname}.png`;
+
     img.setAttribute('src', src);
 }
 

modules/RTC/TraceablePeerConnection.js

@@ -46,6 +46,7 @@ function TraceablePeerConnection(rtc, id, signalingLayer, ice_config,
      * <tt>TracablePeerConnection</tt>.
      * @type {RTC}
      */
+
     this.rtc = rtc;
     /**
      * The peer connection identifier assigned by the RTC module.
@@ -59,6 +60,7 @@ function TraceablePeerConnection(rtc, id, signalingLayer, ice_config,
     this.signalingLayer = signalingLayer;
     this.options = options;
     let RTCPeerConnectionType = null;
+
     if (RTCBrowserType.isFirefox()) {
         RTCPeerConnectionType = mozRTCPeerConnection;
     } else if (RTCBrowserType.isTemasysPluginUsed()) {
@@ -75,8 +77,10 @@ function TraceablePeerConnection(rtc, id, signalingLayer, ice_config,
      */
     this.maxstats = 0;
     const Interop = require('sdp-interop').Interop;
+
     this.interop = new Interop();
     const Simulcast = require('sdp-simulcast');
+
     this.simulcast = new Simulcast({numOfLayers: SIMULCAST_LAYERS,
         explodeRemoteSimulcast: false});
     this.sdpConsistency = new SdpConsistency();
@@ -171,9 +175,11 @@ function TraceablePeerConnection(rtc, id, signalingLayer, ice_config,
             self.peerconnection.getStats(stats => {
                 const results = stats.result();
                 const now = new Date();
+
                 for (let i = 0; i < results.length; ++i) {
                     results[i].names().forEach(name => {
                         const id = `${results[i].id}-${name}`;
+
                         if (!self.stats[id]) {
                             self.stats[id] = {
                                 startTime: now,
@@ -216,6 +222,7 @@ TraceablePeerConnection.prototype._remoteStreamAdded = function(stream) {
     if (!RTC.isUserStream(stream)) {
         logger.info(
             'Ignored remote \'stream added\' event for non-user stream', stream);
+
         return;
     }
     // Bind 'addtrack'/'removetrack' event handlers
@@ -230,10 +237,12 @@ TraceablePeerConnection.prototype._remoteStreamAdded = function(stream) {
     }
     // Call remoteTrackAdded for each track in the stream
     const streamAudioTracks = stream.getAudioTracks();
+
     for (const audioTrack of streamAudioTracks) {
         this._remoteTrackAdded(stream, audioTrack);
     }
     const streamVideoTracks = stream.getVideoTracks();
+
     for (const videoTrack of streamVideoTracks) {
         this._remoteTrackAdded(stream, videoTrack);
     }
@@ -261,6 +270,7 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
             new Error(
                 `MediaType undefined for remote track, stream id: ${streamId}`
             ));
+
         // Abort
         return;
     }
@@ -269,11 +279,13 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
     const mediaLines
         = remoteSDP.media.filter(
             mediaLines => mediaLines.startsWith(`m=${mediaType}`));
+
     if (!mediaLines.length) {
         GlobalOnErrorHandler.callErrorHandler(
             new Error(
                 `No media lines for type ${mediaType
                      } found in remote SDP for remote track: ${streamId}`));
+
         // Abort
         return;
     }
@@ -284,6 +296,8 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
         line => {
             const msid
                 = RTCBrowserType.isTemasysPluginUsed() ? 'mslabel' : 'msid';
+
+
             return line.indexOf(`${msid}:${streamId}`) !== -1;
         });
     if (!ssrcLines.length) {
@@ -291,6 +305,7 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
             new Error(
                 `No SSRC lines for streamId ${streamId
                      } for remote track, media type: ${mediaType}`));
+
         // Abort
         return;
     }
@@ -306,6 +321,7 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
                 `No SSRC owner known for: ${trackSsrc
                      } for remote track, msid: ${streamId
                      } media type: ${mediaType}`));
+
         // Abort
         return;
     }
@@ -318,6 +334,7 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
     if (!peerMediaInfo) {
         GlobalOnErrorHandler.callErrorHandler(
             new Error(`No peer media info available for: ${ownerEndpointId}`));
+
         // Abort
         return;
     }
@@ -337,16 +354,20 @@ TraceablePeerConnection.prototype._remoteTrackAdded = function(stream, track) {
 TraceablePeerConnection.prototype._remoteStreamRemoved = function(stream) {
     if (!RTC.isUserStream(stream)) {
         const id = RTC.getStreamID(stream);
+
         logger.info(
             `Ignored remote 'stream removed' event for non-user stream ${id}`);
+
         return;
     }
     // Call remoteTrackRemoved for each track in the stream
     const streamVideoTracks = stream.getVideoTracks();
+
     for (const videoTrack of streamVideoTracks) {
         this._remoteTrackRemoved(stream, videoTrack);
     }
     const streamAudioTracks = stream.getAudioTracks();
+
     for (const audioTrack of streamAudioTracks) {
         this._remoteTrackRemoved(stream, audioTrack);
     }
@@ -369,6 +390,7 @@ TraceablePeerConnection.prototype._remoteTrackRemoved
     if (!streamId) {
         GlobalOnErrorHandler.callErrorHandler(
             new Error('Remote track removal failed - no stream ID'));
+
         // Abort
         return;
     }
@@ -376,6 +398,7 @@ TraceablePeerConnection.prototype._remoteTrackRemoved
     if (!trackId) {
         GlobalOnErrorHandler.callErrorHandler(
             new Error('Remote track removal failed - no track ID'));
+
         // Abort
         return;
     }
@@ -427,6 +450,7 @@ function extractSSRCMap(desc) {
     if (typeof desc !== 'object' || desc === null
         || typeof desc.sdp !== 'string') {
         logger.warn('An empty description was passed as an argument.');
+
         return ssrcMap;
     }
 
@@ -451,6 +475,7 @@ function extractSSRCMap(desc) {
                                      .map(ssrcStr => parseInt(ssrcStr));
                     const primarySSRC = groupSSRCs[0];
                     // Note that group.semantics is already present
+
                     group.ssrcs = groupSSRCs;
                     if (!groupsMap.has(primarySSRC)) {
                         groupsMap.set(primarySSRC, []);
@@ -500,6 +525,7 @@ const normalizePlanB = function(desc) {
     if (typeof desc !== 'object' || desc === null
         || typeof desc.sdp !== 'string') {
         logger.warn('An empty description was passed as an argument.');
+
         return desc;
     }
 
@@ -534,6 +560,7 @@ const normalizePlanB = function(desc) {
 
             if (Array.isArray(mLine.ssrcs)) {
                 let i;
+
                 for (i = 0; i < mLine.ssrcs.length; i++) {
                     if (typeof mLine.ssrcs[i] === 'object'
                         && typeof mLine.ssrcs[i].id !== 'undefined'
@@ -555,6 +582,8 @@ const normalizePlanB = function(desc) {
     }
 
     const resStr = transform.write(session);
+
+
     return new RTCSessionDescription({
         type: desc.type,
         sdp: resStr
@@ -579,10 +608,12 @@ const getters = {
             this.trace('getLocalDescription::postTransform (Plan B)',
                 dumpSDP(desc));
         }
+
         return desc;
     },
     remoteDescription() {
         let desc = this.peerconnection.remoteDescription;
+
         this.trace('getRemoteDescription::preTransform', dumpSDP(desc));
 
         // if we're running on FF, transform to Plan B first.
@@ -591,9 +622,11 @@ const getters = {
             this.trace(
                 'getRemoteDescription::postTransform (Plan B)', dumpSDP(desc));
         }
+
         return desc;
     }
 };
+
 Object.keys(getters).forEach(prop => {
     Object.defineProperty(
         TraceablePeerConnection.prototype,
@@ -612,17 +645,21 @@ TraceablePeerConnection.prototype.addStream = function(stream, ssrcInfo) {
         this.sdpConsistency.setPrimarySsrc(ssrcInfo.ssrcs[0]);
         const simGroup
             = ssrcInfo.groups.find(groupInfo => groupInfo.semantics === 'SIM');
+
         if (simGroup) {
             this.simulcast.setSsrcCache(simGroup.ssrcs);
         }
         const fidGroups
             = ssrcInfo.groups.filter(
                 groupInfo => groupInfo.semantics === 'FID');
+
         if (fidGroups) {
             const rtxSsrcMapping = new Map();
+
             fidGroups.forEach(fidGroup => {
                 const primarySsrc = fidGroup.ssrcs[0];
                 const rtxSsrc = fidGroup.ssrcs[1];
+
                 rtxSsrcMapping.set(primarySsrc, rtxSsrc);
             });
             this.rtxModifier.setSsrcCache(rtxSsrcMapping);
@@ -640,6 +677,7 @@ TraceablePeerConnection.prototype.removeStream = function(stream) {
 
 TraceablePeerConnection.prototype.createDataChannel = function(label, opts) {
     this.trace('createDataChannel', label, opts);
+
     return this.peerconnection.createDataChannel(label, opts);
 };
 
@@ -654,6 +692,7 @@ TraceablePeerConnection.prototype.setLocalDescription
             }
 
             const self = this;
+
             this.peerconnection.setLocalDescription(description,
         () => {
             self.trace('setLocalDescriptionOnSuccess');
@@ -681,6 +720,7 @@ TraceablePeerConnection.prototype.setRemoteDescription
             if (this.options.preferH264) {
                 const parsedSdp = transform.parse(description.sdp);
                 const videoMLine = parsedSdp.media.find(m => m.type === 'video');
+
                 SDPUtil.preferVideoCodec(videoMLine, 'h264');
                 description.sdp = transform.write(parsedSdp);
             }
@@ -700,6 +740,7 @@ TraceablePeerConnection.prototype.setRemoteDescription
             }
 
             const self = this;
+
             this.peerconnection.setRemoteDescription(description,
         () => {
             self.trace('setRemoteDescriptionOnSuccess');
@@ -727,6 +768,7 @@ TraceablePeerConnection.prototype.setRemoteDescription
 TraceablePeerConnection.prototype.generateRecvonlySsrc = function() {
     // FIXME replace with SDPUtil.generateSsrc (when it's added)
     const newSSRC = this.generateNewStreamSSRCInfo().ssrcs[0];
+
     logger.info(`Generated new recvonly SSRC: ${newSSRC}`);
     this.sdpConsistency.setPrimarySsrc(newSSRC);
 };
@@ -865,6 +907,7 @@ TraceablePeerConnection.prototype.createAnswer
                 //  details)
                 const remoteDescription = new SDP(this.remoteDescription.sdp);
                 const localDescription = new SDP(answer.sdp);
+
                 _fixAnswerRFC4145Setup(remoteDescription, localDescription);
                 answer.sdp = localDescription.raw;
 
@@ -933,6 +976,7 @@ TraceablePeerConnection.prototype.getStats = function(callback, errback) {
  */
 TraceablePeerConnection.prototype.generateNewStreamSSRCInfo = function() {
     let ssrcInfo = {ssrcs: [], groups: []};
+
     if (!this.options.disableSimulcast
         && this.simulcast.isSupported()) {
         for (let i = 0; i < SIMULCAST_LAYERS; i++) {
@@ -954,9 +998,11 @@ TraceablePeerConnection.prototype.generateNewStreamSSRCInfo = function() {
         //  only want to iterate through the items originally
         //  on the list
         const currNumSsrcs = ssrcInfo.ssrcs.length;
+
         for (let i = 0; i < currNumSsrcs; ++i) {
             const primarySsrc = ssrcInfo.ssrcs[i];
             const rtxSsrc = SDPUtil.generateSsrc();
+
             ssrcInfo.ssrcs.push(rtxSsrc);
             ssrcInfo.groups.push({
                 ssrcs: [primarySsrc, rtxSsrc],
@@ -964,6 +1010,7 @@ TraceablePeerConnection.prototype.generateNewStreamSSRCInfo = function() {
             });
         }
     }
+
     return ssrcInfo;
 };
 

modules/connectivity/ConnectionQuality.js

@@ -54,6 +54,7 @@ function getTarget(simulcast, resolution, millisSinceStart) {
     if (simulcast) {
         // Find the first format with height no bigger than ours.
         let simulcastFormat = kSimulcastFormats.find(f => f.height <= height);
+
         if (simulcastFormat) {
             // Sum the target fields from all simulcast layers for the given
             // resolution (e.g. 720p + 360p + 180p).
@@ -71,6 +72,7 @@ function getTarget(simulcast, resolution, millisSinceStart) {
         // See GetMaxDefaultVideoBitrateKbps in
         // media/engine/webrtcvideoengine2.cc from webrtc.org
         const pixels = resolution.width * resolution.height;
+
         if (pixels <= 320 * 240) {
             target = 600;
         } else if (pixels <= 640 * 480) {
@@ -97,6 +99,7 @@ function rampUp(millisSinceStart) {
     if (millisSinceStart > 60000) {
         return Number.MAX_SAFE_INTEGER;
     }
+
     // According to GCC the send side bandwidth estimation grows with at most
     // 8% per second.
     // https://tools.ietf.org/html/draft-ietf-rmcat-gcc-02#section-5.5
@@ -252,6 +255,7 @@ export default class ConnectionQuality {
         let quality = 100;
         let packetLoss;
         // TODO: take into account packet loss for received streams
+
         if (this._localStats.packetLoss) {
             packetLoss = this._localStats.packetLoss.upload;
 
@@ -306,6 +310,7 @@ export default class ConnectionQuality {
             // expected sending bitrate in perfect conditions
             let target
                 = getTarget(this._simulcast, resolution, millisSinceStart);
+
             target = 0.9 * target;
 
             quality = 100 * this._localStats.bitrate.upload / target;
@@ -323,6 +328,7 @@ export default class ConnectionQuality {
             const diffSeconds
                 = (window.performance.now() - this._lastConnectionQualityUpdate)
                     / 1000;
+
             quality
                 = Math.min(
                     quality,
@@ -359,6 +365,7 @@ export default class ConnectionQuality {
         // resolution instead. Consider removing this.
         const localVideoTrack
             = this._conference.getLocalVideoTrack();
+
         if (localVideoTrack && localVideoTrack.resolution) {
             data.resolution = localVideoTrack.resolution;
         }

modules/connectivity/ParticipantConnectionStatus.js

@@ -321,6 +321,7 @@ export default class ParticipantConnectionStatus {
      */
     figureOutConnectionStatus(id) {
         const participant = this.conference.getParticipantById(id);
+
         if (!participant) {
             // Probably the participant is no longer in the conference
             // (at the time of writing this code, participant is
@@ -329,6 +330,7 @@ export default class ParticipantConnectionStatus {
             // so we don't care, but let's print the warning for
             // debugging purpose
             logger.warn(`figure out conn status - no participant for: ${id}`);
+
             return;
         }
 
@@ -364,9 +366,11 @@ export default class ParticipantConnectionStatus {
     onTrackRtcMuted(track) {
         const participantId = track.getParticipantId();
         const participant = this.conference.getParticipantById(participantId);
+
         logger.debug(`Detector track RTC muted: ${participantId}`);
         if (!participant) {
             logger.error(`No participant for id: ${participantId}`);
+
             return;
         }
         this.rtcMutedTimestamp[participantId] = Date.now();

modules/settings/Settings.js

@@ -11,6 +11,8 @@ import UsernameGenerator from '../util/UsernameGenerator';
  */
 function getLocalStorage() {
     const global = typeof window == 'undefined' ? this : window;
+
+
     return global.localStorage;
 }
 
@@ -28,6 +30,7 @@ function generateUniqueId() {
  */
 function generateJitsiMeetId() {
     const jitsiMeetId = generateUniqueId();
+
     logger.log('generated id', jitsiMeetId);
 
     return jitsiMeetId;
@@ -39,6 +42,7 @@ function generateJitsiMeetId() {
  */
 function generateCallStatsUsername() {
     const username = UsernameGenerator.generateUsername();
+
     logger.log('generated callstats uid', username);
 
     return username;
@@ -50,6 +54,7 @@ class Settings {
         this.callStatsUserName;
 
         const localStorage = getLocalStorage();
+
         if (localStorage) {
             this.userId
                 = localStorage.getItem('jitsiMeetId') || generateJitsiMeetId();
@@ -70,6 +75,7 @@ class Settings {
      */
     save() {
         const localStorage = getLocalStorage();
+
         if (localStorage) {
             localStorage.setItem('jitsiMeetId', this.userId);
             localStorage.setItem('callStatsUserName', this.callStatsUserName);
@@ -98,6 +104,7 @@ class Settings {
      */
     setSessionId(sessionId) {
         const localStorage = getLocalStorage();
+
         if (localStorage) {
             if (sessionId) {
                 localStorage.setItem('sessionId', sessionId);
@@ -122,6 +129,8 @@ class Settings {
         // We may update sessionId in localStorage from another JitsiConference
         // instance and that's why we should always re-read it.
         const localStorage = getLocalStorage();
+
+
         return localStorage ? localStorage.getItem('sessionId') : undefined;
     }
 }

modules/statistics/AnalyticsAdapter.js

@@ -35,7 +35,9 @@ class CacheAnalytics extends AnalyticsAbstract {
      */
     drainCachedEvents() {
         const eventCacheCopy = this.eventCache.slice();
+
         this.eventCache = [];
+
         return eventCacheCopy;
     }
 
@@ -74,6 +76,7 @@ class AnalyticsAdapter {
     sendEvent(action, data = {}) {
         const modifiedData = Object.assign(
             {browserName: this.browserName}, this.permanentProperties, data);
+
         this.analyticsHandlers.forEach(
             analytics => analytics.sendEvent(action, modifiedData));
     }

modules/statistics/CallStats.js

@@ -1,6 +1,7 @@
 /* global $, Strophe, callstats */
 const logger = require('jitsi-meet-logger').getLogger(__filename);
 const GlobalOnErrorHandler = require('../util/GlobalOnErrorHandler');
+
 import Settings from '../settings/Settings';
 
 const jsSHA = require('jssha');
@@ -62,6 +63,7 @@ function initCallback(err, msg) {
     // there is no lib, nothing to report to
     if (err !== 'success') {
         CallStats.initializeFailed = true;
+
         return;
     }
 
@@ -76,6 +78,7 @@ function initCallback(err, msg) {
     if(!fabricInitialized) {
         CallStats.initializeFailed = true;
         logger.log('callstats fabric not initilized', ret.message);
+
         return;
     }
 
@@ -88,6 +91,7 @@ function initCallback(err, msg) {
         CallStats.reportsQueue.forEach(function(report) {
             if (report.type === reportType.ERROR) {
                 const error = report.data;
+
                 CallStats._reportError.call(this, error.type, error.error,
                     error.pc);
             } else if (report.type === reportType.EVENT
@@ -95,6 +99,7 @@ function initCallback(err, msg) {
                 // if we have and event to report and we failed to add fabric
                 // this event will not be reported anyway, returning an error
                 const eventData = report.data;
+
                 callStats.sendFabricEvent(
                     this.peerconnection,
                     eventData.event,
@@ -102,6 +107,7 @@ function initCallback(err, msg) {
                     eventData.eventData);
             } else if (report.type === reportType.MST_WITH_USERID) {
                 const data = report.data;
+
                 callStats.associateMstWithUserID(
                     this.peerconnection,
                     data.callStatsId,

modules/statistics/LocalStatsCollector.js

@@ -63,6 +63,7 @@ function timeDomainDataToAudioLevel(samples) {
 function animateLevel(newLevel, lastLevel) {
     let value = 0;
     const diff = lastLevel - newLevel;
+
     if(diff > 0.2) {
         value = lastLevel - 0.2;
     } else if(diff < -0.4) {
@@ -101,10 +102,12 @@ LocalStatsCollector.prototype.start = function() {
     }
     context.resume();
     const analyser = context.createAnalyser();
+
     analyser.smoothingTimeConstant = WEBAUDIO_ANALYZER_SMOOTING_TIME;
     analyser.fftSize = WEBAUDIO_ANALYZER_FFT_SIZE;
 
     const source = context.createMediaStreamSource(this.stream);
+
     source.connect(analyser);
 
 
@@ -113,8 +116,10 @@ LocalStatsCollector.prototype.start = function() {
     this.intervalId = setInterval(
         () => {
             const array = new Uint8Array(analyser.frequencyBinCount);
+
             analyser.getByteTimeDomainData(array);
             const audioLevel = timeDomainDataToAudioLevel(array);
+
             if (audioLevel != self.audioLevel) {
                 self.audioLevel = animateLevel(audioLevel, self.audioLevel);
                 self.callback(self.audioLevel);

modules/statistics/RTPStatsCollector.js

@@ -3,6 +3,7 @@
 const GlobalOnErrorHandler = require('../util/GlobalOnErrorHandler');
 const logger = require('jitsi-meet-logger').getLogger(__filename);
 const RTCBrowserType = require('../RTC/RTCBrowserType');
+
 import * as StatisticsEvents from '../../service/statistics/Events';
 
 /* Whether we support the browser we are running into for logging statistics */
@@ -15,6 +16,7 @@ const browserSupported = RTCBrowserType.isChrome()
  * by RTCPeerConnection#getStats mapped by RTCBrowserType.
  */
 const KEYS_BY_BROWSER_TYPE = {};
+
 KEYS_BY_BROWSER_TYPE[RTCBrowserType.RTC_BROWSER_FIREFOX] = {
     'ssrc': 'ssrc',
     'packetsReceived': 'packetsReceived',
@@ -67,6 +69,7 @@ function calculatePacketLoss(lostPackets, totalPackets) {
     if(!totalPackets || totalPackets <= 0 || !lostPackets || lostPackets <= 0) {
         return 0;
     }
+
     return Math.round((lostPackets / totalPackets) * 100);
 }
 
@@ -180,6 +183,7 @@ function StatsCollector(
      */
     this._browserType = RTCBrowserType.getBrowserType();
     const keys = KEYS_BY_BROWSER_TYPE[this._browserType];
+
     if (!keys) {
         throw `The browser type '${this._browserType}' isn't supported!`;
     }
@@ -242,6 +246,7 @@ StatsCollector.prototype.errorCallback = function(error) {
  */
 StatsCollector.prototype.start = function(startAudioLevelStats) {
     const self = this;
+
     if(startAudioLevelStats) {
         this.audioLevelsIntervalId = setInterval(
             () => {
@@ -249,6 +254,7 @@ StatsCollector.prototype.start = function(startAudioLevelStats) {
                 self.peerconnection.getStats(
                     report => {
                         let results = null;
+
                         if (!report || !report.result
                             || typeof report.result != 'function') {
                             results = report;
@@ -274,6 +280,7 @@ StatsCollector.prototype.start = function(startAudioLevelStats) {
                 self.peerconnection.getStats(
                     report => {
                         let results = null;
+
                         if (!report || !report.result
                             || typeof report.result != 'function') {
                             // firefox
@@ -314,6 +321,7 @@ StatsCollector.prototype._defineGetStatValueMethod = function(keys) {
     // RTCPeerConnection#getStats.
     const keyFromName = function(name) {
         const key = keys[name];
+
         if (key) {
             return key;
         }
@@ -325,6 +333,7 @@ StatsCollector.prototype._defineGetStatValueMethod = function(keys) {
     // returned by RTCPeerConnection#getStats associated with a given
     // browser-specific key.
     let itemStatByKey;
+
     switch (this._browserType) {
     case RTCBrowserType.RTC_BROWSER_CHROME:
     case RTCBrowserType.RTC_BROWSER_OPERA:
@@ -345,14 +354,18 @@ StatsCollector.prototype._defineGetStatValueMethod = function(keys) {
         // Array in which each element is a key-value pair.
         itemStatByKey = function(item, key) {
             let value;
+
             item.values.some(pair => {
                 if (pair.hasOwnProperty(key)) {
                     value = pair[key];
+
                     return true;
                 }
+
                 return false;
 
             });
+
             return value;
         };
         break;
@@ -379,8 +392,10 @@ StatsCollector.prototype.processStatsReport = function() {
     }
 
     const getStatValue = this._getStatValue;
+
     function getNonNegativeStat(report, name) {
         let value = getStatValue(report, name);
+
         if (typeof value !== 'number') {
             value = Number(value);
         }
@@ -398,9 +413,11 @@ StatsCollector.prototype.processStatsReport = function() {
             continue;
         }
         const now = this.currentStatsReport[idx];
+
         try {
             const receiveBandwidth = getStatValue(now, 'receiveBandwidth');
             const sendBandwidth = getStatValue(now, 'sendBandwidth');
+
             if (receiveBandwidth || sendBandwidth) {
                 this.conferenceStats.bandwidth = {
                     'download': Math.round(receiveBandwidth / 1000),
@@ -411,6 +428,7 @@ StatsCollector.prototype.processStatsReport = function() {
 
         if(now.type == 'googCandidatePair') {
             let active, ip, localip, type;
+
             try {
                 ip = getStatValue(now, 'remoteAddress');
                 type = getStatValue(now, 'transportType');
@@ -422,6 +440,7 @@ StatsCollector.prototype.processStatsReport = function() {
             }
             // Save the address unless it has been saved already.
             const conferenceStatsTransport = this.conferenceStats.transport;
+
             if(!conferenceStatsTransport.some(
                     t =>
                         t.ip == ip && t.type == type && t.localip == localip)) {
@@ -437,6 +456,7 @@ StatsCollector.prototype.processStatsReport = function() {
 
             const local = this.currentStatsReport[now.localCandidateId];
             const remote = this.currentStatsReport[now.remoteCandidateId];
+
             this.conferenceStats.transport.push({
                 ip: `${remote.ipAddress}:${remote.portNumber}`,
                 type: local.transport,
@@ -451,6 +471,7 @@ StatsCollector.prototype.processStatsReport = function() {
 
         const before = this.previousStatsReport[idx];
         const ssrc = getStatValue(now, 'ssrc');
+
         if (!before || !ssrc) {
             continue;
         }
@@ -461,6 +482,7 @@ StatsCollector.prototype.processStatsReport = function() {
         let isDownloadStream = true;
         let key = 'packetsReceived';
         let packetsNow = getStatValue(now, key);
+
         if (typeof packetsNow === 'undefined'
             || packetsNow === null || packetsNow === '') {
             isDownloadStream = false;
@@ -496,6 +518,7 @@ StatsCollector.prototype.processStatsReport = function() {
 
         // TODO: clean this mess up!
         let nowBytesTransmitted = getStatValue(now, 'bytesSent');
+
         if(typeof nowBytesTransmitted === 'number'
             || typeof nowBytesTransmitted === 'string') {
             nowBytesTransmitted = Number(nowBytesTransmitted);
@@ -511,6 +534,7 @@ StatsCollector.prototype.processStatsReport = function() {
 
         const timeMs = now.timestamp - before.timestamp;
         let bitrateReceivedKbps = 0, bitrateSentKbps = 0;
+
         if (timeMs > 0) {
             // TODO is there any reason to round here?
             bitrateReceivedKbps = Math.round((bytesReceived * 8) / timeMs);
@@ -523,8 +547,10 @@ StatsCollector.prototype.processStatsReport = function() {
         });
 
         const resolution = {height: null, width: null};
+
         try {
             let height, width;
+
             if ((height = getStatValue(now, 'googFrameHeightReceived'))
                 && (width = getStatValue(now, 'googFrameWidthReceived'))) {
                 resolution.height = height;
@@ -555,12 +581,14 @@ StatsCollector.prototype.processStatsReport = function() {
     let bitrateDownload = 0;
     let bitrateUpload = 0;
     const resolutions = {};
+
     Object.keys(this.ssrc2stats).forEach(
         function(ssrc) {
             const ssrcStats = this.ssrc2stats[ssrc];
             // process packet loss stats
             const loss = ssrcStats.loss;
             const type = loss.isDownloadStream ? 'download' : 'upload';
+
             totalPackets[type] += loss.packetsTotal;
             lostPackets[type] += loss.packetsLost;
 
@@ -616,12 +644,14 @@ StatsCollector.prototype.processAudioLevelReport = function() {
         }
 
         const now = this.currentAudioLevelsReport[idx];
+
         if (now.type != 'ssrc') {
             continue;
         }
 
         const before = this.baselineAudioLevelsReport[idx];
         const ssrc = getStatValue(now, 'ssrc');
+
         if (!before) {
             logger.warn(`${ssrc} not enough data`);
             continue;
@@ -644,6 +674,7 @@ StatsCollector.prototype.processAudioLevelReport = function() {
         } catch(e) {/* not supported*/
             logger.warn('Audio Levels are not available in the statistics.');
             clearInterval(this.audioLevelsIntervalId);
+
             return;
         }
 

modules/statistics/statistics.js

@@ -2,11 +2,13 @@
 import analytics from './AnalyticsAdapter';
 const CallStats = require('./CallStats');
 const EventEmitter = require('events');
+
 import JitsiTrackError from '../../JitsiTrackError';
 const logger = require('jitsi-meet-logger').getLogger(__filename);
 const LocalStats = require('./LocalStatsCollector.js');
 const RTPStats = require('./RTPStatsCollector.js');
 const ScriptUtil = require('../util/ScriptUtil');
+
 import * as StatisticsEvents from '../../service/statistics/Events';
 
 /**
@@ -130,6 +132,7 @@ Statistics.startLocalStats = function(stream, callback) {
     }
     const localStats = new LocalStats(stream, Statistics.audioLevelsInterval,
         callback);
+
     this.localStats.push(localStats);
     localStats.start();
 };
@@ -193,6 +196,7 @@ Statistics.stopLocalStats = function(stream) {
     for(let i = 0; i < Statistics.localStats.length; i++) {
         if(Statistics.localStats[i].stream === stream) {
             const localStats = Statistics.localStats.splice(i, 1);
+
             localStats[0].stop();
             break;
         }
@@ -230,6 +234,7 @@ Statistics.prototype.startCallStats = function(session) {
 Statistics.prototype.stopCallStats = function() {
     if(this.callStatsStarted) {
         const index = Statistics.callsStatsInstances.indexOf(this.callstats);
+
         if(index > -1) {
             Statistics.callsStatsInstances.splice(index, 1);
         }

modules/transcription/audioRecorder.js

@@ -65,6 +65,7 @@ function instantiateTrackRecorder(track) {
     // Create a new stream which only holds the audio track
     const originalStream = trackRecorder.track.getOriginalStream();
     const stream = createEmptyStream();
+
     originalStream.getAudioTracks().forEach(track => stream.addTrack(track));
     // Create the MediaRecorder
     trackRecorder.recorder = new MediaRecorder(stream,
@@ -133,6 +134,7 @@ audioRecorder.prototype.addTrack = function(track) {
         // create the track recorder
         const trackRecorder = instantiateTrackRecorder(track);
         // push it to the local array of all recorders
+
         this.recorders.push(trackRecorder);
         // update the name of the trackRecorders
         this.updateNames();
@@ -161,9 +163,11 @@ audioRecorder.prototype.removeTrack = function(track) {
 
     const array = this.recorders;
     let i;
+
     for(i = 0; i < array.length; i++) {
         if(array[i].track.getParticipantId() === track.getParticipantId()) {
             const recorderToRemove = array[i];
+
             if(this.isRecording) {
                 stopRecorder(recorderToRemove);
             } else {
@@ -184,6 +188,7 @@ audioRecorder.prototype.removeTrack = function(track) {
  */
 audioRecorder.prototype.updateNames = function() {
     const conference = this.jitsiConference;
+
     this.recorders.forEach(trackRecorder => {
         if(trackRecorder.track.isLocal()) {
             trackRecorder.name = 'the transcriber';
@@ -191,6 +196,7 @@ audioRecorder.prototype.updateNames = function() {
             const id = trackRecorder.track.getParticipantId();
             const participant = conference.getParticipantById(id);
             const newName = participant.getDisplayName();
+
             if(newName !== 'undefined') {
                 trackRecorder.name = newName;
             }
@@ -232,10 +238,12 @@ audioRecorder.prototype.stop = function() {
  */
 audioRecorder.prototype.download = function() {
     const t = this;
+
     this.recorders.forEach(trackRecorder => {
         const blob = new Blob(trackRecorder.data, {type: t.fileType});
         const url = URL.createObjectURL(blob);
         const a = document.createElement('a');
+
         document.body.appendChild(a);
         a.style = 'display: none';
         a.href = url;
@@ -260,6 +268,7 @@ audioRecorder.prototype.getRecordingResults = function() {
 
     const array = [];
     const t = this;
+
     this.recorders.forEach(
           recorder =>
               array.push(
@@ -267,6 +276,7 @@ audioRecorder.prototype.getRecordingResults = function() {
                       new Blob(recorder.data, {type: t.fileType}),
                       recorder.name,
                       recorder.startTime)));
+
     return array;
 };
 

modules/transcription/transcriber.js

@@ -79,6 +79,7 @@ transcriber.prototype.stop = function stop(callback) {
     const t = this;
 
     const callBack = blobCallBack.bind(this);
+
     this.audioRecorder.getRecordingResults().forEach(recordingResult => {
         t.transcriptionService.send(recordingResult, callBack);
         t.counter++;
@@ -109,11 +110,13 @@ const blobCallBack = function(answer) {
         let offset = answer.startTime.getUTCMilliseconds()
             - this.startTime.getUTCMilliseconds();
         // transcriber time will always be earlier
+
         if (offset < 0) {
             offset = 0; // presume 0 if it somehow not earlier
         }
 
         let array = '[';
+
         answer.wordArray.forEach(wordObject => {
             wordObject.begin += offset;
             wordObject.end += offset;
@@ -164,6 +167,7 @@ transcriber.prototype.merge = function() {
     // arrays of Word objects
     const potentialWords = []; // array of the first Word objects
     // check if any arrays are already empty and remove them
+
     hasPopulatedArrays(arrays);
 
     // populate all the potential Words for a first time
@@ -173,6 +177,7 @@ transcriber.prototype.merge = function() {
     let lowestWordArray;
     let wordToAdd;
     let foundSmaller;
+
     while(hasPopulatedArrays(arrays)) {
         // first select the lowest array;
         lowestWordArray = arrays[0];
@@ -242,6 +247,7 @@ const hasPopulatedArrays = function(twoDimensionalArray) {
             twoDimensionalArray.splice(i, 1);
         }
     }
+
     return twoDimensionalArray.length > 0;
 };
 
@@ -259,12 +265,15 @@ const pushWordToSortedArray = function(array, word) {
     } else{
         if(array[array.length - 1].begin <= word.begin) {
             array.push(word);
+
             return;
         }
         let i;
+
         for(i = 0; i < array.length; i++) {
             if(word.begin < array[i].begin) {
                 array.splice(i, 0, word);
+
                 return;
             }
         }
@@ -302,6 +311,7 @@ transcriber.prototype.getTranscription = function() {
                  FINISHED_STATE}" state. It's currently in the "${
                  this.state}" state`);
     }
+
     return this.transcription;
 };
 

modules/transcription/transcriptionServices/AbstractTranscriptionService.js

@@ -18,6 +18,7 @@ const TranscriptionService = function() {
  */
 TranscriptionService.prototype.send = function send(recordingResult, callback) {
     const t = this;
+
     this.sendRequest(recordingResult.blob, response => {
         if(t.verify(response)) {
             recordingResult.wordArray = t.formatResponse(response);

modules/transcription/transcriptionServices/SphinxTranscriptionService.js

@@ -33,6 +33,7 @@ SphinxService.prototype.sendRequest = function(audioFileBlob, callback) {
     console.log(`sending an audio file  to ${this.url}`);
     console.log(`the audio file being sent: ${audioFileBlob}`);
     const request = new XMLHttpRequest();
+
     request.onreadystatechange = function() {
         if(request.readyState === XMLHttpRequest.DONE
             && request.status === 200) {
@@ -61,12 +62,15 @@ SphinxService.prototype.formatResponse = function(response) {
     const result = JSON.parse(response).objects;
     // make sure to delete the session id object, which is always
     // the first value in the JSON array
+
     result.shift();
     const array = [];
+
     result.forEach(
         word =>
             word.filler
                 || array.push(new Word(word.word, word.start, word.end)));
+
     return array;
 };
 
@@ -83,10 +87,12 @@ SphinxService.prototype.verify = function(response) {
     }
     // test if the string can be parsed into valid JSON
     let json;
+
     try{
         json = JSON.parse(response);
     } catch (error) {
         console.log(error);
+
         return false;
     }
     // check if the JSON has a "objects" value
@@ -95,9 +101,11 @@ SphinxService.prototype.verify = function(response) {
     }
     // get the "objects" value and check for a session ID
     const array = json.objects;
+
     if(!(array[0] && array[0]['session-id'])) {
         return false;
     }
+
     // everything seems to be in order
     return true;
 };
@@ -110,10 +118,12 @@ SphinxService.prototype.verify = function(response) {
  */
 function getURL() {
     const message = 'config does not contain an url to a Sphinx4 https server';
+
     if(config.sphinxURL === undefined) {
         console.log(message);
     } else {
         const toReturn = config.sphinxURL;
+
         if(toReturn.includes !== undefined && toReturn.includes('https://')) {
             return toReturn;
         }

modules/util/AuthUtil.js

@@ -22,9 +22,11 @@ const AuthUtil = {
      */
     getTokenAuthUrl(urlPattern, roomName, roleUpgrade) {
         const url = urlPattern;
+
         if (typeof url !== 'string') {
             return null;
         }
+
         return url.replace('{room}', roomName)
             .replace('{roleUpgrade}', roleUpgrade === true);
     }

modules/util/EventEmitterForwarder.js

@@ -25,6 +25,7 @@ function EventEmitterForwarder(src, dest) {
 EventEmitterForwarder.prototype.forward = function(...args) {
     const srcEvent = args[0];
     // This will be the "this" value for emit function.
+
     args[0] = this.dest;
     // Using bind.apply to pass the arguments as Array-like object ("arguments")
     this.src.addListener(

modules/util/GlobalOnErrorHandler.js

@@ -57,6 +57,7 @@ const GlobalOnErrorHandler = {
      */
     callErrorHandler(error) {
         const errHandler = window.onerror;
+
         if(!errHandler) {
             return;
         }
@@ -68,6 +69,7 @@ const GlobalOnErrorHandler = {
      */
     callUnhandledRejectionHandler(error) {
         const errHandler = window.onunhandledrejection;
+
         if(!errHandler) {
             return;
         }

modules/util/RandomUtil.js

@@ -61,9 +61,11 @@ const RandomUtil = {
      */
     randomHexString(len) {
         let ret = '';
+
         while (len--) {
             ret += this.randomHexDigit();
         }
+
         return ret;
     },
     randomElement,

modules/util/ScriptUtil.js

@@ -34,10 +34,12 @@ const ScriptUtil = {
             // finds the src url of the current loaded script
             // and use it as base of the src supplied argument
             const scriptEl = currentExecutingScript();
+
             if(scriptEl) {
                 const scriptSrc = scriptEl.src;
                 const baseScriptSrc
                     = scriptSrc.substring(0, scriptSrc.lastIndexOf('/') + 1);
+
                 if (scriptSrc && baseScriptSrc) {
                     src = baseScriptSrc + src;
                 }

modules/version/ComponentsVersions.js

@@ -38,6 +38,7 @@ ComponentsVersions.prototype.processPresence
     = function(node, mucResource, mucJid) {
         if (node.attributes.xmlns !== 'http://jitsi.org/jitmeet') {
             logger.warn('Ignored presence versions node - invalid xmlns', node);
+
             return;
         }
 
@@ -45,23 +46,28 @@ ComponentsVersions.prototype.processPresence
             logger.warn(
                 `Received versions not from the focus user: ${node}`,
                 mucJid);
+
             return;
         }
 
         const log = [];
+
         node.children.forEach(item => {
 
             const componentName = item.attributes.name;
+
             if (componentName !== ComponentsVersions.FOCUS_COMPONENT
             && componentName !== ComponentsVersions.XMPP_SERVER_COMPONENT
             && componentName !== ComponentsVersions.VIDEOBRIDGE_COMPONENT) {
                 logger.warn(
                     `Received version for not supported component name: ${
                         componentName}`);
+
                 return;
             }
 
             const version = item.value;
+
             if (this.versions[componentName] !== version) {
                 this.versions[componentName] = version;
                 logger.info(`Got ${componentName} version: ${version}`);

modules/xmpp/Caps.js

@@ -11,9 +11,11 @@ const HASH = 'sha-1';
 
 function compareIdentities(a, b) {
     let res = 0;
+
     IDENTITY_PROPERTIES_FOR_COMPARE.some(key =>
         (res = ((a[key] > b[key]) && 1) || ((a[key] < b[key]) && -1)) !== 0
     );
+
     return res;
 }
 
@@ -43,6 +45,7 @@ export default class Caps extends Listenable {
         this.rooms = new Set();
 
         const emuc = connection.emuc;
+
         emuc.addListener(XMPPEvents.EMUC_ROOM_ADDED,
             room => this._addChatRoom(room));
         emuc.addListener(XMPPEvents.EMUC_ROOM_REMOVED,
@@ -104,13 +107,19 @@ export default class Caps extends Listenable {
     getFeatures(jid, timeout = 5000) {
         const user
             = jid in this.jidToVersion ? this.jidToVersion[jid] : null;
+
         if(!user || !(user.version in this.versionToCapabilities)) {
             const node = user ? `${user.node}#${user.version}` : null;
+
+
             return new Promise((resolve, reject) =>
                 this.disco.info(jid, node, response => {
                     const features = new Set();
-                    $(response).find('>query>feature').each((idx, el) =>
-                            features.add(el.getAttribute('var')));
+
+                    $(response)
+                        .find('>query>feature')
+                        .each(
+                            (idx, el) => features.add(el.getAttribute('var')));
                     if(user) {
                             // TODO: Maybe use the version + node + hash
                             // as keys?
@@ -121,6 +130,7 @@ export default class Caps extends Listenable {
                 }, reject , timeout)
             );
         }
+
         return Promise.resolve(this.versionToCapabilities[user.version]);
     }
 
@@ -175,6 +185,7 @@ export default class Caps extends Listenable {
     _generateVersion() {
         const identities = this.disco._identities.sort(compareIdentities);
         const features = this.disco._features.sort();
+
         this.version = b64_sha1(
             identities.reduce(
                     (accumulatedValue, identity) =>
@@ -200,11 +211,13 @@ export default class Caps extends Listenable {
         const version = caps.getAttribute('ver');
         const node = caps.getAttribute('node');
         const oldVersion = this.jidToVersion[from];
+
         this.jidToVersion[from] = {version, node};
         if(oldVersion && oldVersion.version !== version) {
             this.eventEmitter.emit(XMPPEvents.PARTCIPANT_FEATURES_CHANGED,
                 from);
         }
+
         // return true to not remove the handler from Strophe
         return true;
     }

modules/xmpp/ChatRoom.js

@@ -12,16 +12,20 @@ const logger = getLogger(__filename);
 const parser = {
     packet2JSON(packet, nodes) {
         const self = this;
+
+        // eslint-disable-next-line newline-per-chained-call
         $(packet).children().each(function() {
             const tagName = $(this).prop('tagName');
             const node = {
                 tagName
             };
+
             node.attributes = {};
             $($(this)[0].attributes).each((index, attr) => {
                 node.attributes[ attr.name ] = attr.value;
             });
             const text = Strophe.getText($(this)[0]);
+
             if (text) {
                 node.value = text;
             }
@@ -33,6 +37,7 @@ const parser = {
     json2packet(nodes, packet) {
         for(let i = 0; i < nodes.length; i++) {
             const node = nodes[i];
+
             if(node) {
                 packet.c(node.tagName, node.attributes);
                 if(node.value) {
@@ -56,6 +61,7 @@ const parser = {
  */
 function filterNodeFromPresenceJSON(pres, nodeName) {
     const res = [];
+
     for(let i = 0; i < pres.length; i++) {
         if(pres[i].tagName === nodeName) {
             res.push(pres[i]);
@@ -65,6 +71,10 @@ function filterNodeFromPresenceJSON(pres, nodeName) {
     return res;
 }
 
+// XXX As ChatRoom constructs XMPP stanzas and Strophe is build around the idea
+// of chaining function calls, allow long function call chains.
+/* eslint-disable newline-per-chained-call */
+
 export default class ChatRoom extends Listenable {
     constructor(connection, jid, password, XMPP, options) {
         super();
@@ -131,6 +141,7 @@ export default class ChatRoom extends Listenable {
 
     sendPresence(fromJoin) {
         const to = this.presMap.to;
+
         if (!to || (!this.joined && !fromJoin)) {
             // Too early to send presence - not initialized
             return;
@@ -170,6 +181,7 @@ export default class ChatRoom extends Listenable {
     doLeave() {
         logger.log('do leave', this.myroomjid);
         const pres = $pres({to: this.myroomjid, type: 'unavailable' });
+
         this.presMap.length = 0;
 
         // XXX Strophe is asynchronously sending by default. Unfortunately, that
@@ -199,6 +211,7 @@ export default class ChatRoom extends Listenable {
                 = $(result).find('>query>feature[var="muc_passwordprotected"]')
                         .length
                     === 1;
+
             if (locked != this.locked) {
                 this.eventEmitter.emit(XMPPEvents.MUC_LOCK_CHANGED, locked);
                 this.locked = locked;
@@ -224,8 +237,10 @@ export default class ChatRoom extends Listenable {
                     '>query>x[xmlns="jabber:x:data"]'
                     + '>field[var="muc#roomconfig_whois"]').length) {
                 const errmsg = 'non-anonymous rooms not supported';
+
                 GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
                 logger.error(errmsg);
+
                 return;
             }
 
@@ -253,15 +268,19 @@ export default class ChatRoom extends Listenable {
         const from = pres.getAttribute('from');
         // Parse roles.
         const member = {};
+
         member.show = $(pres).find('>show').text();
         member.status = $(pres).find('>status').text();
         const mucUserItem
-            = $(pres).find('>x[xmlns="http://jabber.org/protocol/muc#user"]>item');
+            = $(pres).find(
+                '>x[xmlns="http://jabber.org/protocol/muc#user"]>item');
+
         member.affiliation = mucUserItem.attr('affiliation');
         member.role = mucUserItem.attr('role');
 
         // Focus recognition
         const jid = mucUserItem.attr('jid');
+
         member.jid = jid;
         member.isFocus
             = jid && jid.indexOf(`${this.moderator.getFocusUserJid()}/`) === 0;
@@ -272,13 +291,16 @@ export default class ChatRoom extends Listenable {
 
         $(pres).find('>x').remove();
         const nodes = [];
+
         parser.packet2JSON(pres, nodes);
         this.lastPresences[from] = nodes;
         let jibri = null;
         // process nodes to extract data needed for MUC_JOINED and
         // MUC_MEMBER_JOINED events
+
         for(let i = 0; i < nodes.length; i++) {
             const node = nodes[i];
+
             switch(node.tagName) {
             case 'nick':
                 member.nick = node.value;
@@ -291,6 +313,7 @@ export default class ChatRoom extends Listenable {
 
         if (from == this.myroomjid) {
             const newRole = member.affiliation == 'owner' ? member.role : 'none';
+
             if (this.role !== newRole) {
                 this.role = newRole;
                 this.eventEmitter.emit(XMPPEvents.LOCAL_ROLE_CHANGED, this.role);
@@ -299,6 +322,7 @@ export default class ChatRoom extends Listenable {
                 this.joined = true;
                 const now = this.connectionTimes['muc.joined']
                     = window.performance.now();
+
                 logger.log('(TIME) MUC joined:\t', now);
 
                 // set correct initial state of locked
@@ -323,6 +347,7 @@ export default class ChatRoom extends Listenable {
             // Presence update for existing participant
             // Watch role change:
             const memberOfThis = this.members[from];
+
             if (memberOfThis.role != member.role) {
                 memberOfThis.role = member.role;
                 this.eventEmitter.emit(
@@ -352,6 +377,7 @@ export default class ChatRoom extends Listenable {
         // for the rest info we got in presence
         for(let i = 0; i < nodes.length; i++) {
             const node = nodes[i];
+
             switch(node.tagName) {
             case 'nick':
                 if(!member.isFocus) {
@@ -375,6 +401,7 @@ export default class ChatRoom extends Listenable {
                 break;
             case 'call-control': {
                 const att = node.attributes;
+
                 if(!att) {
                     break;
                 }
@@ -435,6 +462,7 @@ export default class ChatRoom extends Listenable {
         // otherwise we can remove the presence handler from strophe
         try {
             let tagHandler = this.presHandlers[node.tagName];
+
             if (node.tagName.startsWith('jitsi_participant_')) {
                 tagHandler = this.participantPropertyListener;
             }
@@ -450,6 +478,7 @@ export default class ChatRoom extends Listenable {
 
     sendMessage(body, nickname) {
         const msg = $msg({to: this.roomjid, type: 'groupchat'});
+
         msg.c('body', body).up();
         if (nickname) {
             msg.c('nick', {xmlns: 'http://jabber.org/protocol/nick'}).t(nickname).up().up();
@@ -460,6 +489,7 @@ export default class ChatRoom extends Listenable {
 
     setSubject(subject) {
         const msg = $msg({to: this.roomjid, type: 'groupchat'});
+
         msg.c('subject', subject);
         this.connection.send(msg);
     }
@@ -491,6 +521,7 @@ export default class ChatRoom extends Listenable {
             const reasonSelect = $(pres).find(
                     '>x[xmlns="http://jabber.org/protocol/muc#user"]'
                     + '>destroy>reason');
+
             if (reasonSelect.length) {
                 reason = reasonSelect.text();
             }
@@ -499,6 +530,7 @@ export default class ChatRoom extends Listenable {
 
             this.eventEmitter.emit(XMPPEvents.MUC_DESTROYED, reason);
             this.connection.emuc.doLeave(this.roomjid);
+
             return true;
         }
 
@@ -510,6 +542,7 @@ export default class ChatRoom extends Listenable {
                 '>x[xmlns="http://jabber.org/protocol/muc#user"]>status[code="307"]'
             ).length !== 0;
         const membersKeys = Object.keys(this.members);
+
         if (!isSelfPresence) {
             delete this.members[from];
             this.onParticipantLeft(from, false);
@@ -519,6 +552,7 @@ export default class ChatRoom extends Listenable {
             // event.
             membersKeys.forEach(jid => {
                 const member = this.members[jid];
+
                 delete this.members[jid];
                 this.onParticipantLeft(jid, member.isFocus);
             });
@@ -545,15 +579,19 @@ export default class ChatRoom extends Listenable {
 
         const txt = $(msg).find('>body').text();
         const type = msg.getAttribute('type');
+
         if (type == 'error') {
             this.eventEmitter.emit(XMPPEvents.CHAT_ERROR_RECEIVED,
                 $(msg).find('>text').text(), txt);
+
             return true;
         }
 
         const subject = $(msg).find('>subject');
+
         if (subject.length) {
             const subjectText = subject.text();
+
             if (subjectText || subjectText === '') {
                 this.eventEmitter.emit(XMPPEvents.SUBJECT_CHANGED, subjectText);
                 logger.log(`Subject is changed to ${subjectText}`);
@@ -570,6 +608,7 @@ export default class ChatRoom extends Listenable {
             if (stamp) {
                 // the format is CCYYMMDDThh:mm:ss
                 const dateParts = stamp.match(/(\d{4})(\d{2})(\d{2}T\d{2}:\d{2}:\d{2})/);
+
                 stamp = `${dateParts[1]}-${dateParts[2]}-${dateParts[3]}Z`;
             }
         }
@@ -592,6 +631,7 @@ export default class ChatRoom extends Listenable {
         } else if ($(pres).find(
             '>error[type="cancel"]>not-allowed[xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"]').length) {
             const toDomain = Strophe.getDomainFromJid(pres.getAttribute('to'));
+
             if (toDomain === this.xmpp.options.hosts.anonymousdomain) {
                 // enter the room by replying with 'not-authorized'. This would
                 // result in reconnection from authorized domain.
@@ -634,6 +674,7 @@ export default class ChatRoom extends Listenable {
                     const formsubmit
                         = $iq({to: this.roomjid, type: 'set'})
                             .c('query', {xmlns: 'http://jabber.org/protocol/muc#owner'});
+
                     formsubmit.c('x', {xmlns: 'jabber:x:data', type: 'submit'});
                     formsubmit.c('field', {'var': 'FORM_TYPE'}).c('value').t('http://jabber.org/protocol/muc#roomconfig').up().up();
                     formsubmit.c('field', {'var': 'muc#roomconfig_roomsecret'}).c('value').t(key).up().up();
@@ -656,6 +697,7 @@ export default class ChatRoom extends Listenable {
 
     removeFromPresence(key) {
         const nodes = this.presMap.nodes.filter(node => key !== node.tagName);
+
         this.presMap.nodes = nodes;
     }
 
@@ -677,9 +719,11 @@ export default class ChatRoom extends Listenable {
      */
     isFocus(mucJid) {
         const member = this.members[mucJid];
+
         if (member) {
             return member.isFocus;
         }
+
         return null;
     }
 
@@ -691,6 +735,7 @@ export default class ChatRoom extends Listenable {
         if (this.members[peerJid]) {
             return this.members[peerJid].role;
         }
+
         return null;
     }
 
@@ -753,6 +798,7 @@ export default class ChatRoom extends Listenable {
     getMediaPresenceInfo(endpointId, mediaType) {
         // Will figure out current muted status by looking up owner's presence
         const pres = this.lastPresences[`${this.roomjid}/${endpointId}`];
+
         if (!pres) {
             // No presence available
             return null;
@@ -774,6 +820,7 @@ export default class ChatRoom extends Listenable {
             }
         } else {
             logger.error(`Unsupported media type: ${mediaType}`);
+
             return null;
         }
 
@@ -789,6 +836,7 @@ export default class ChatRoom extends Listenable {
         if(this.recording) {
             return this.recording.isSupported();
         }
+
         return false;
     }
 
@@ -828,6 +876,7 @@ export default class ChatRoom extends Listenable {
         if(this.moderator) {
             return this.moderator.isSipGatewayEnabled();
         }
+
         return false;
     }
 
@@ -886,15 +935,20 @@ export default class ChatRoom extends Listenable {
 
     onMute(iq) {
         const from = iq.getAttribute('from');
+
         if (from !== this.focusMucJid) {
             logger.warn('Ignored mute from non focus peer');
+
             return false;
         }
         const mute = $(iq).find('mute');
+
         if (mute.length) {
             const doMuteAudio = mute.text() === 'true';
+
             this.eventEmitter.emit(XMPPEvents.AUDIO_MUTED_BY_FOCUS, doMuteAudio);
         }
+
         return true;
     }
 
@@ -908,6 +962,7 @@ export default class ChatRoom extends Listenable {
         return new Promise((resolve, reject) => {
             const timeout = setTimeout(() => onMucLeft(true), 5000);
             const eventEmitter = this.eventEmitter;
+
             function onMucLeft(doReject = false) {
                 eventEmitter.removeListener(XMPPEvents.MUC_LEFT, onMucLeft);
                 clearTimeout(timeout);
@@ -924,3 +979,5 @@ export default class ChatRoom extends Listenable {
         });
     }
 }
+
+/* eslint-enable newline-per-chained-call */

modules/xmpp/JingleSession.js

@@ -73,6 +73,7 @@ export default class JingleSession {
             const errmsg
                 = `attempt to initiate on session ${this.sid}
                    in state ${this.state}`;
+
             logger.error(errmsg);
             throw new Error(errmsg);
         }

modules/xmpp/JingleSessionPC.js

@@ -2,6 +2,7 @@
 
 import {getLogger} from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import JingleSession from './JingleSession';
 const SDPDiffer = require('./SDPDiffer');
 const SDPUtil = require('./SDPUtil');
@@ -124,9 +125,11 @@ export default class JingleSessionPC extends JingleSession {
             }
             // XXX this is broken, candidate is not parsed.
             const candidate = ev.candidate;
+
             if (candidate) {
                 // Discard candidates of disabled protocols.
                 let protocol = candidate.protocol;
+
                 if (typeof protocol === 'string') {
                     protocol = protocol.toLowerCase();
                     if (protocol === 'tcp' || protocol === 'ssltcp') {
@@ -173,6 +176,7 @@ export default class JingleSessionPC extends JingleSession {
                 return;
             }
             const now = window.performance.now();
+
             this.room.connectionTimes[
                     `ice.state.${this.peerconnection.iceConnectionState}`]
                 = now;
@@ -222,15 +226,19 @@ export default class JingleSessionPC extends JingleSession {
 
     sendIceCandidate(candidate) {
         const localSDP = new SDP(this.peerconnection.localDescription.sdp);
+
         if (candidate && !this.lasticecandidate) {
             const ice
                 = SDPUtil.iceparams(
                     localSDP.media[candidate.sdpMLineIndex], localSDP.session);
             const jcand = SDPUtil.candidateToJingle(candidate.candidate);
+
             if (!(ice && jcand)) {
                 const errorMesssage = 'failed to get ice && jcand';
+
                 GlobalOnErrorHandler.callErrorHandler(new Error(errorMesssage));
                 logger.error(errorMesssage);
+
                 return;
             }
             ice.xmlns = 'urn:xmpp:jingle:transports:ice-udp:1';
@@ -266,13 +274,16 @@ export default class JingleSessionPC extends JingleSession {
                 sid: this.sid});
 
         const localSDP = new SDP(this.peerconnection.localDescription.sdp);
+
         for (let mid = 0; mid < localSDP.media.length; mid++) {
             const cands = candidates.filter(el => el.sdpMLineIndex == mid);
             const mline
                 = SDPUtil.parse_mline(localSDP.media[mid].split('\r\n')[0]);
+
             if (cands.length > 0) {
                 const ice
                     = SDPUtil.iceparams(localSDP.media[mid], localSDP.session);
+
                 ice.xmlns = 'urn:xmpp:jingle:transports:ice-udp:1';
                 cand.c('content', {
                     creator: this.initiator == this.localJid
@@ -283,6 +294,7 @@ export default class JingleSessionPC extends JingleSession {
                     const candidate
                         = SDPUtil.candidateToJingle(cands[i].candidate);
                     // Mangle ICE candidate if 'failICE' test option is enabled
+
                     if (this.failICE) {
                         candidate.ip = '1.1.1.1';
                     }
@@ -296,6 +308,7 @@ export default class JingleSessionPC extends JingleSession {
 
                 if (fingerprint_line) {
                     const tmp = SDPUtil.parse_fingerprint(fingerprint_line);
+
                     tmp.required = true;
                     cand.c(
                         'fingerprint',
@@ -325,12 +338,15 @@ export default class JingleSessionPC extends JingleSession {
                 = $(content).find(
                     'description>'
                         + 'source[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]');
+
             ssrcs.each((idx, ssrcElement) => {
                 const ssrc = ssrcElement.getAttribute('ssrc');
+
                 $(ssrcElement)
                     .find('>ssrc-info[xmlns="http://jitsi.org/jitmeet"]')
                     .each((idx, ssrcInfoElement) => {
                         const owner = ssrcInfoElement.getAttribute('owner');
+
                         if (owner && owner.length) {
                             this.ssrcOwners[ssrc]
                                 = Strophe.getResourceFromJid(owner);
@@ -392,6 +408,7 @@ export default class JingleSessionPC extends JingleSession {
     setOfferCycle(jingleOfferIq, success, failure) {
         const workFunction = finishedCallback => {
             const newRemoteSdp = this._processNewJingleOfferIq(jingleOfferIq);
+
             this._renegotiate(newRemoteSdp)
                 .then(() => {
                     finishedCallback();
@@ -403,6 +420,7 @@ export default class JingleSessionPC extends JingleSession {
                     finishedCallback(error);
                 });
         };
+
         this.modificationQueue.push(
             workFunction,
             error => {
@@ -425,6 +443,7 @@ export default class JingleSessionPC extends JingleSession {
         // the SCTP connection established with the new bridge.
         this.room.eventEmitter.emit(XMPPEvents.ICE_RESTARTING);
         const originalOffer = jingleOfferElem.clone();
+
         jingleOfferElem.find('>content[name=\'data\']').remove();
 
         // First set an offer without the 'data' section
@@ -437,6 +456,7 @@ export default class JingleSessionPC extends JingleSession {
                     () => {
                         const localSDP
                             = new SDP(this.peerconnection.localDescription.sdp);
+
                         this.sendTransportAccept(localSDP, success, failure);
                     },
                     failure);
@@ -463,6 +483,7 @@ export default class JingleSessionPC extends JingleSession {
                 initiator: this.initiator,
                 responder: this.responder,
                 sid: this.sid });
+
         if (this.webrtcIceTcpDisable) {
             localSDP.removeTcpCandidates = true;
         }
@@ -531,6 +552,7 @@ export default class JingleSessionPC extends JingleSession {
 
         localSDP.media.forEach((medialines, idx) => {
             const mline = SDPUtil.parse_mline(medialines.split('\r\n')[0]);
+
             transportAccept.c('content',
                 {
                     creator:
@@ -599,6 +621,7 @@ export default class JingleSessionPC extends JingleSession {
             .c(reason || 'success');
 
         if (text) {
+            // eslint-disable-next-line newline-per-chained-call
             sessionTerminate.up().c('text').t(text);
         }
 
@@ -638,16 +661,22 @@ export default class JingleSessionPC extends JingleSession {
      */
     _parseSsrcInfoFromSourceAdd(sourceAddElem, currentRemoteSdp) {
         const addSsrcInfo = [];
+
         $(sourceAddElem).each((idx, content) => {
             const name = $(content).attr('name');
             let lines = '';
+
             $(content)
                 .find('ssrc-group[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]')
                 .each(function() {
                     const semantics = this.getAttribute('semantics');
-                    const ssrcs = $(this).find('>source').map(function() {
-                        return this.getAttribute('ssrc');
-                    }).get();
+                    const ssrcs
+                        = $(this)
+                            .find('>source')
+                            .map(function() {
+                                return this.getAttribute('ssrc');
+                            })
+                            .get();
 
                     if (ssrcs.length) {
                         lines
@@ -659,13 +688,18 @@ export default class JingleSessionPC extends JingleSession {
             const tmp
                 = $(content).find(
                     'source[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]');
+
             tmp.each(function() {
                 const ssrc = $(this).attr('ssrc');
+
                 if (currentRemoteSdp.containsSSRC(ssrc)) {
                     logger.warn(
                         `Source-add request for existing SSRC: ${ssrc}`);
+
                     return;
                 }
+
+                // eslint-disable-next-line newline-per-chained-call
                 $(this).find('>parameter').each(function() {
                     lines += `a=ssrc:${ssrc} ${$(this).attr('name')}`;
                     if ($(this).attr('value') && $(this).attr('value').length) {
@@ -684,6 +718,7 @@ export default class JingleSessionPC extends JingleSession {
                 addSsrcInfo[idx] += lines;
             });
         });
+
         return addSsrcInfo;
     }
 
@@ -696,6 +731,7 @@ export default class JingleSessionPC extends JingleSession {
         if (!this.peerconnection.localDescription) {
             logger.warn('addSource - localDescription not ready yet');
             setTimeout(() => this.addRemoteStream(elem), 200);
+
             return;
         }
         logger.log('Processing add remote stream');
@@ -710,11 +746,13 @@ export default class JingleSessionPC extends JingleSession {
             const addSsrcInfo = this._parseSsrcInfoFromSourceAdd(elem, sdp);
 
             const newRemoteSdp = this._processRemoteAddSource(addSsrcInfo);
+
             this._renegotiate(newRemoteSdp)
                 .then(() => {
                     logger.info('Remote source-add processed');
                     const newSdp
                         = new SDP(this.peerconnection.localDescription.sdp);
+
                     logger.log('SDPs', mySdp, newSdp);
                     this.notifyMySSRCUpdate(mySdp, newSdp);
                     finishedCallback();
@@ -724,6 +762,7 @@ export default class JingleSessionPC extends JingleSession {
                     finishedCallback(error);
                 });
         };
+
         this.modificationQueue.push(workFunction);
     }
 
@@ -736,6 +775,7 @@ export default class JingleSessionPC extends JingleSession {
         if (!this.peerconnection.localDescription) {
             logger.warn('removeSource - localDescription not ready yet');
             setTimeout(() => this.removeRemoteStream(elem), 200);
+
             return;
         }
 
@@ -750,11 +790,13 @@ export default class JingleSessionPC extends JingleSession {
 
             const newRemoteSdp
                 = this._processRemoteRemoveSource(removeSsrcInfo);
+
             this._renegotiate(newRemoteSdp)
                 .then(() => {
                     logger.info('Remote source-remove processed');
                     const newSdp
                         = new SDP(this.peerconnection.localDescription.sdp);
+
                     logger.log('SDPs', mySdp, newSdp);
                     this.notifyMySSRCUpdate(mySdp, newSdp);
                     finishedCallback();
@@ -764,6 +806,7 @@ export default class JingleSessionPC extends JingleSession {
                     finishedCallback(error);
                 });
         };
+
         this.modificationQueue.push(workFunction);
     }
 
@@ -792,6 +835,7 @@ export default class JingleSessionPC extends JingleSession {
      */
     _processNewJingleOfferIq(offerIq) {
         const remoteSdp = new SDP('');
+
         if (this.webrtcIceTcpDisable) {
             remoteSdp.removeTcpCandidates = true;
         }
@@ -804,6 +848,7 @@ export default class JingleSessionPC extends JingleSession {
 
         remoteSdp.fromJingle(offerIq);
         this.readSsrcInfo($(offerIq).find('>content'));
+
         return remoteSdp;
     }
 
@@ -816,6 +861,7 @@ export default class JingleSessionPC extends JingleSession {
      */
     _processRemoteRemoveSource(removeSsrcInfo) {
         const remoteSdp = new SDP(this.peerconnection.remoteDescription.sdp);
+
         removeSsrcInfo.forEach((lines, idx) => {
             lines = lines.split('\r\n');
             lines.pop(); // remove empty last element;
@@ -838,6 +884,7 @@ export default class JingleSessionPC extends JingleSession {
      */
     _processRemoteAddSource(addSsrcInfo) {
         const remoteSdp = new SDP(this.peerconnection.remoteDescription.sdp);
+
         addSsrcInfo.forEach((lines, idx) => {
             remoteSdp.media[idx] += lines;
         });
@@ -874,6 +921,7 @@ export default class JingleSessionPC extends JingleSession {
         //  core flows like this.
         return new Promise((resolve, reject) => {
             const remoteUfrag = JingleSessionPC.getUfrag(remoteDescription.sdp);
+
             if (remoteUfrag != this.remoteUfrag) {
                 this.remoteUfrag = remoteUfrag;
                 this.room.eventEmitter.emit(
@@ -886,6 +934,7 @@ export default class JingleSessionPC extends JingleSession {
                 () => {
                     if (this.signalingState === 'closed') {
                         reject('Attempted to setRemoteDescription in state closed');
+
                         return;
                     }
                     logger.debug('Renegotiate: creating answer');
@@ -893,6 +942,7 @@ export default class JingleSessionPC extends JingleSession {
                         answer => {
                             const localUfrag
                                 = JingleSessionPC.getUfrag(answer.sdp);
+
                             if (localUfrag != this.localUfrag) {
                                 this.localUfrag = localUfrag;
                                 this.room.eventEmitter.emit(
@@ -942,6 +992,7 @@ export default class JingleSessionPC extends JingleSession {
                 // NOTE the code below assumes that no more than 1 video track
                 // can be added to the peer connection.
                 // Transition from no video to video (possibly screen sharing)
+
                 if (!oldTrack && newTrack && newTrack.isVideoTrack()) {
                     // Clearing current primary SSRC will make
                     // the SdpConsistency generate a new one which will result
@@ -964,6 +1015,7 @@ export default class JingleSessionPC extends JingleSession {
                     .then(() => {
                         const newSdp
                             = new SDP(this.peerconnection.localDescription.sdp);
+
                         this.notifyMySSRCUpdate(oldSdp, newSdp);
                         finishedCallback();
                     }, error => {
@@ -972,6 +1024,7 @@ export default class JingleSessionPC extends JingleSession {
                         finishedCallback(error);
                     });
             };
+
             this.modificationQueue.push(
                 workFunction,
                 error => {
@@ -991,6 +1044,7 @@ export default class JingleSessionPC extends JingleSession {
         const actualStream
             = stream && stream.getOriginalStream
                 ? stream.getOriginalStream() : stream;
+
         if (this.peerconnection) {
             this.peerconnection.addStream(actualStream, ssrcInfo);
         }
@@ -1008,16 +1062,22 @@ export default class JingleSessionPC extends JingleSession {
      */
     _parseSsrcInfoFromSourceRemove(sourceRemoveElem, currentRemoteSdp) {
         const removeSsrcInfo = [];
+
         $(sourceRemoveElem).each((idx, content) => {
             const name = $(content).attr('name');
             let lines = '';
+
             $(content)
                 .find('ssrc-group[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]')
                 .each(function() {
                     const semantics = this.getAttribute('semantics');
-                    const ssrcs = $(this).find('>source').map(function() {
-                        return this.getAttribute('ssrc');
-                    }).get();
+                    const ssrcs
+                        = $(this)
+                            .find('>source')
+                            .map(function() {
+                                return this.getAttribute('ssrc');
+                            })
+                            .get();
 
                     if (ssrcs.length) {
                         lines
@@ -1030,8 +1090,10 @@ export default class JingleSessionPC extends JingleSession {
             const tmp
                 = $(content).find(
                     'source[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]');
+
             tmp.each(function() {
                 const ssrc = $(this).attr('ssrc');
+
                 ssrcs.push(ssrc);
             });
             currentRemoteSdp.media.forEach((media, idx) => {
@@ -1044,6 +1106,7 @@ export default class JingleSessionPC extends JingleSession {
                 ssrcs.forEach(ssrc => {
                     const ssrcLines
                         = SDPUtil.find_lines(media, `a=ssrc:${ssrc}`);
+
                     if (ssrcLines.length) {
                         removeSsrcInfo[idx] += `${ssrcLines.join('\r\n')}\r\n`;
                     }
@@ -1051,6 +1114,7 @@ export default class JingleSessionPC extends JingleSession {
                 removeSsrcInfo[idx] += lines;
             });
         });
+
         return removeSsrcInfo;
     }
 
@@ -1078,6 +1142,7 @@ export default class JingleSessionPC extends JingleSession {
             if (!this.peerconnection) {
                 finishedCallback(
                     'Error: tried adding stream with no active peer connection');
+
                 return;
             }
             this.addStreamToPeerConnection(stream, ssrcInfo);
@@ -1090,14 +1155,17 @@ export default class JingleSessionPC extends JingleSession {
             }
             if (dontModifySources) {
                 finishedCallback();
+
                 return;
             }
             const oldSdp = new SDP(this.peerconnection.localDescription.sdp);
+
             this._renegotiate()
                 .then(() => {
                     const newSdp
                         = new SDP(this.peerconnection.localDescription.sdp);
                     // FIXME objects should not be logged
+
                     logger.log('SDPs', oldSdp, newSdp);
                     this.notifyMySSRCUpdate(oldSdp, newSdp);
                     finishedCallback();
@@ -1105,6 +1173,7 @@ export default class JingleSessionPC extends JingleSession {
                     finishedCallback(error);
                 });
         };
+
         this.modificationQueue.push(
             workFunction,
             error => {
@@ -1135,6 +1204,7 @@ export default class JingleSessionPC extends JingleSession {
         // of complications. Instead, we use the RTPSender and remove just
         // the track.
         let track = null;
+
         if (stream.getAudioTracks() && stream.getAudioTracks().length) {
             track = stream.getAudioTracks()[0];
         } else if (stream.getVideoTracks() && stream.getVideoTracks().length) {
@@ -1143,7 +1213,9 @@ export default class JingleSessionPC extends JingleSession {
 
         if (!track) {
             const msg = 'Cannot remove tracks: no tracks.';
+
             logger.log(msg);
+
             return;
         }
 
@@ -1151,8 +1223,10 @@ export default class JingleSessionPC extends JingleSession {
         this.peerconnection.peerconnection.getSenders().some(s => {
             if (s.track === track) {
                 sender = s;
+
                 return true;
             }
+
             return false;
         });
 
@@ -1173,6 +1247,7 @@ export default class JingleSessionPC extends JingleSession {
         const actualStream
             = stream && stream.getOriginalStream
                 ? stream.getOriginalStream() : stream;
+
         if (!this.peerconnection) {
             return;
         }
@@ -1196,6 +1271,7 @@ export default class JingleSessionPC extends JingleSession {
         const workFunction = finishedCallback => {
             if (!this.peerconnection) {
                 finishedCallback();
+
                 return;
             }
             if (RTCBrowserType.getBrowserType()
@@ -1205,10 +1281,12 @@ export default class JingleSessionPC extends JingleSession {
                 this.removeStreamFromPeerConnection(stream);
             }
             const oldSdp = new SDP(this.peerconnection.localDescription.sdp);
+
             this._renegotiate()
                 .then(() => {
                     const newSdp
                         = new SDP(this.peerconnection.localDescription.sdp);
+
                     if (ssrcInfo) {
                         this.modifiedSSRCs[ssrcInfo.type]
                             = this.modifiedSSRCs[ssrcInfo.type] || [];
@@ -1221,6 +1299,7 @@ export default class JingleSessionPC extends JingleSession {
                     finishedCallback(error);
                 });
         };
+
         this.modificationQueue.push(
             workFunction,
             error => {
@@ -1237,6 +1316,7 @@ export default class JingleSessionPC extends JingleSession {
 
         if (this.state !== JingleSessionState.ACTIVE) {
             logger.warn(`Skipping SSRC update in '${this.state} ' state.`);
+
             return;
         }
 
@@ -1250,6 +1330,7 @@ export default class JingleSessionPC extends JingleSession {
                 sid: this.sid
             }
             );
+
         sdpDiffer.toJingle(remove);
         const removed = this.fixJingle(remove);
 
@@ -1316,9 +1397,11 @@ export default class JingleSessionPC extends JingleSession {
 
             // Get XMPP error code and condition(reason)
             const errorElSel = $(errResponse).find('error');
+
             if (errorElSel.length) {
                 error.code = errorElSel.attr('code');
                 const errorReasonSel = $(errResponse).find('error :first');
+
                 if (errorReasonSel.length) {
                     error.reason = errorReasonSel[0].tagName;
                 }
@@ -1398,8 +1481,9 @@ export default class JingleSessionPC extends JingleSession {
      * @returns {boolean} true if the jingle has to be sent and false otherwise.
      */
     fixJingle(jingle) {
-        /* eslint-disable no-case-declarations */
+        // eslint-disable-next-line newline-per-chained-call
         const action = $(jingle.nodeTree).find('jingle').attr('action');
+
         switch (action) {
         case 'source-add':
         case 'session-accept':
@@ -1408,15 +1492,20 @@ export default class JingleSessionPC extends JingleSession {
         case 'source-remove':
             this.fixSourceRemoveJingle(jingle);
             break;
-        default:
+        default: {
             const errmsg = 'Unknown jingle action!';
+
             GlobalOnErrorHandler.callErrorHandler(errmsg);
             logger.error(errmsg);
+
             return false;
-        }/* eslint-enable no-case-declarations */
+        }
+        }
 
         const sources
             = $(jingle.tree()).find('>jingle>content>description>source');
+
+
         return sources && sources.length > 0;
     }
 
@@ -1428,23 +1517,27 @@ export default class JingleSessionPC extends JingleSession {
      */
     fixSourceAddJingle(jingle) {
         let ssrcs = this.modifiedSSRCs.unmute;
+
         this.modifiedSSRCs.unmute = [];
         if (ssrcs && ssrcs.length) {
             ssrcs.forEach(ssrcObj => {
                 const desc
                     = $(jingle.tree()).find(
                         `>jingle>content[name="${ssrcObj.mtype}"]>description`);
+
                 if (!desc || !desc.length) {
                     return;
                 }
                 ssrcObj.ssrcs.forEach(ssrc => {
                     const sourceNode = desc.find(`>source[ssrc="${ssrc}"]`);
+
                     sourceNode.remove();
                 });
                 ssrcObj.groups.forEach(group => {
                     const groupNode = desc.find(`>ssrc-group[semantics="${
                          group.semantics}"]:has(source[ssrc="${
                          group.ssrcs[0]}"])`);
+
                     groupNode.remove();
                 });
             });
@@ -1457,10 +1550,14 @@ export default class JingleSessionPC extends JingleSession {
                 const desc
                     = JingleSessionPC.createDescriptionNode(
                         jingle, ssrcObj.mtype);
+
+                // eslint-disable-next-line newline-per-chained-call
                 const cname = Math.random().toString(36).substring(2);
+
                 ssrcObj.ssrcs.forEach(ssrc => {
                     const sourceNode
                         = desc.find(`>source[ssrc="${ssrc}"]`);
+
                     sourceNode.remove();
                     const sourceXML
                         = '<source xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"'
@@ -1470,6 +1567,7 @@ export default class JingleSessionPC extends JingleSession {
                         + '<parameter xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"'
                         + ` value="${cname}" name="cname" />`
                         + '</source>';
+
                     desc.append(sourceXML);
                 });
                 ssrcObj.groups.forEach(group => {
@@ -1477,6 +1575,7 @@ export default class JingleSessionPC extends JingleSession {
                         = desc.find(
                             `>ssrc-group[semantics="${group.semantics
                                 }"]:has(source[ssrc="${group.ssrcs[0]}"])`);
+
                     groupNode.remove();
                     desc.append(
                         `<ssrc-group semantics="${group.semantics
@@ -1496,6 +1595,7 @@ export default class JingleSessionPC extends JingleSession {
      */
     fixSourceRemoveJingle(jingle) {
         let ssrcs = this.modifiedSSRCs.mute;
+
         this.modifiedSSRCs.mute = [];
         if (ssrcs && ssrcs.length) {
             ssrcs.forEach(ssrcObj => {
@@ -1504,6 +1604,7 @@ export default class JingleSessionPC extends JingleSession {
                         = $(jingle.tree()).find(
                             `>jingle>content[name="${ssrcObj.mtype
                                 }"]>description>source[ssrc="${ssrc}"]`);
+
                     sourceNode.remove();
                 });
                 ssrcObj.groups.forEach(group => {
@@ -1513,6 +1614,7 @@ export default class JingleSessionPC extends JingleSession {
                                 }"]>description>ssrc-group[semantics="${
                                 group.semantics}"]:has(source[ssrc="${
                                 group.ssrcs[0]}"])`);
+
                     groupNode.remove();
                 });
             });
@@ -1525,9 +1627,11 @@ export default class JingleSessionPC extends JingleSession {
                 const desc
                     = JingleSessionPC.createDescriptionNode(
                         jingle, ssrcObj.mtype);
+
                 ssrcObj.ssrcs.forEach(ssrc => {
                     const sourceNode
                         = desc.find(`>source[ssrc="${ssrc}"]`);
+
                     if (!sourceNode || !sourceNode.length) {
                         // Maybe we have to include cname, msid, etc here?
                         desc.append(
@@ -1540,6 +1644,7 @@ export default class JingleSessionPC extends JingleSession {
                         = desc.find(`>ssrc-group[semantics="${
                              group.semantics}"]:has(source[ssrc="${
                              group.ssrcs[0]}"])`);
+
                     if (!groupNode || !groupNode.length) {
                         desc.append(
                             `<ssrc-group semantics="${group.semantics
@@ -1563,18 +1668,21 @@ export default class JingleSessionPC extends JingleSession {
         let content = $(jingle.tree()).find(`>jingle>content[name="${mtype}"]`);
 
         if (!content || !content.length) {
-            $(jingle.tree()).find('>jingle').append(
-                `<content name="${mtype}"></content>`);
+            $(jingle.tree())
+                .find('>jingle')
+                .append(`<content name="${mtype}"></content>`);
             content = $(jingle.tree()).find(`>jingle>content[name="${mtype}"]`);
         }
 
         let desc = content.find('>description');
+
         if (!desc || !desc.length) {
             content.append(
                 `<description xmlns="urn:xmpp:jingle:apps:rtp:1" media="${
                     mtype}"></description>`);
             desc = content.find('>description');
         }
+
         return desc;
     }
 
@@ -1584,6 +1692,7 @@ export default class JingleSessionPC extends JingleSession {
     static getUfrag(sdp) {
         const ufragLines
             = sdp.split('\n').filter(line => line.startsWith('a=ice-ufrag:'));
+
         if (ufragLines.length > 0) {
             return ufragLines[0].substr('a=ice-ufrag:'.length);
         }

modules/xmpp/RtxModifier.js

@@ -28,8 +28,10 @@ function updateAssociatedRtxStream(mLine, primarySsrcInfo, rtxSsrc) {
     const primarySsrcCname = primarySsrcInfo.cname;
 
     const previousRtxSSRC = mLine.getRtxSSRC(primarySsrc);
+
     if (previousRtxSSRC === rtxSsrc) {
         logger.debug(`${rtxSsrc} was already associated with ${primarySsrc}`);
+
         return;
     }
     if (previousRtxSSRC) {
@@ -111,28 +113,34 @@ export default class RtxModifier {
     modifyRtxSsrcs(sdpStr) {
         const sdpTransformer = new SdpTransformWrap(sdpStr);
         const videoMLine = sdpTransformer.selectMedia('video');
+
         if (!videoMLine) {
             logger.error(`No 'video' media found in the sdp: ${sdpStr}`);
+
             return sdpStr;
         }
         if (videoMLine.direction === 'inactive'
                 || videoMLine.direction === 'recvonly') {
             logger.debug('RtxModifier doing nothing, video '
                 + 'm line is inactive or recvonly');
+
             return sdpStr;
         }
         if (videoMLine.getSSRCCount() < 1) {
             logger.debug('RtxModifier doing nothing, no video ssrcs present');
+
             return sdpStr;
         }
         logger.debug('Current ssrc mapping: ', this.correspondingRtxSsrcs);
         const primaryVideoSsrcs = videoMLine.getPrimaryVideoSSRCs();
+
         logger.debug('Parsed primary video ssrcs ', primaryVideoSsrcs,
             ' making sure all have rtx streams');
         for (const ssrc of primaryVideoSsrcs) {
             const msid = videoMLine.getSSRCAttrValue(ssrc, 'msid');
             const cname = videoMLine.getSSRCAttrValue(ssrc, 'cname');
             let correspondingRtxSsrc = this.correspondingRtxSsrcs.get(ssrc);
+
             if (correspondingRtxSsrc) {
                 logger.debug(
                     'Already have an associated rtx ssrc for'
@@ -143,6 +151,7 @@ export default class RtxModifier {
                 // If there's one in the sdp already for it, we'll just set
                 //  that as the corresponding one
                 const previousAssociatedRtxStream = videoMLine.getRtxSSRC(ssrc);
+
                 if (previousAssociatedRtxStream) {
                     logger.debug(
                         `Rtx stream ${previousAssociatedRtxStream} `
@@ -167,6 +176,7 @@ export default class RtxModifier {
                 },
                 correspondingRtxSsrc);
         }
+
         return sdpTransformer.toRawSDP();
     }
 
@@ -178,31 +188,38 @@ export default class RtxModifier {
     stripRtx(sdpStr) {
         const sdpTransformer = new SdpTransformWrap(sdpStr);
         const videoMLine = sdpTransformer.selectMedia('video');
+
         if (!videoMLine) {
             logger.error(`No 'video' media found in the sdp: ${sdpStr}`);
+
             return sdpStr;
         }
         if (videoMLine.direction === 'inactive'
                 || videoMLine.direction === 'recvonly') {
             logger.debug('RtxModifier doing nothing, video '
                 + 'm line is inactive or recvonly');
+
             return sdpStr;
         }
         if (videoMLine.getSSRCCount() < 1) {
             logger.debug('RtxModifier doing nothing, no video ssrcs present');
+
             return sdpStr;
         }
         if (!videoMLine.containsAnySSRCGroups()) {
             logger.debug('RtxModifier doing nothing, '
               + 'no video ssrcGroups present');
+
             return sdpStr;
         }
         const fidGroups = videoMLine.findGroups('FID');
         // Remove the fid groups from the mline
+
         videoMLine.removeGroupsBySemantics('FID');
         // Get the rtx ssrcs and remove them from the mline
         for (const fidGroup of fidGroups) {
             const rtxSsrc = parseSecondarySSRC(fidGroup);
+
             videoMLine.removeSSRC(rtxSsrc);
         }
 

modules/xmpp/RtxModifier.spec.js

@@ -12,6 +12,8 @@ import * as SDPUtil from './SDPUtil';
  */
 function numVideoSsrcs(parsedSdp) {
     const videoMLine = parsedSdp.media.find(m => m.type === 'video');
+
+
     return videoMLine.ssrcs
     .map(ssrcInfo => ssrcInfo.id)
     .filter((ssrc, index, array) => array.indexOf(ssrc) === index)
@@ -25,6 +27,8 @@ function numVideoSsrcs(parsedSdp) {
  */
 function getPrimaryVideoSsrc(parsedSdp) {
     const videoMLine = parsedSdp.media.find(m => m.type === 'video');
+
+
     return parseInt(SDPUtil.parsePrimaryVideoSsrc(videoMLine));
 }
 
@@ -38,14 +42,18 @@ function getPrimaryVideoSsrc(parsedSdp) {
  */
 function getPrimaryVideoSsrcs(parsedSdp) {
     const videoMLine = parsedSdp.media.find(m => m.type === 'video');
+
     if (numVideoSsrcs(parsedSdp) === 1) {
         return [videoMLine.ssrcs[0].id];
     }
     const simGroups = getVideoGroups(parsedSdp, 'SIM');
+
     if (simGroups.length > 1) {
         return;
     }
     const simGroup = simGroups[0];
+
+
     return SDPUtil.parseGroupSsrcs(simGroup);
 
 }
@@ -61,7 +69,9 @@ function getPrimaryVideoSsrcs(parsedSdp) {
  */
 function getVideoGroups(parsedSdp, groupSemantics) {
     const videoMLine = parsedSdp.media.find(m => m.type === 'video');
+
     videoMLine.ssrcGroups = videoMLine.ssrcGroups || [];
+
     return videoMLine.ssrcGroups
     .filter(g => g.semantics === groupSemantics);
 }
@@ -85,15 +95,18 @@ describe('RtxModifier', () => {
                 const newSdpStr = this.rtxModifier.modifyRtxSsrcs(this.transform.write(this.singleVideoSdp));
                 const newSdp = transform.parse(newSdpStr);
                 const newPrimaryVideoSsrc = getPrimaryVideoSsrc(newSdp);
+
                 expect(newPrimaryVideoSsrc).toEqual(this.primaryVideoSsrc);
           // Should now have an rtx ssrc as well
                 expect(numVideoSsrcs(newSdp)).toEqual(2);
           // Should now have an FID group
                 const fidGroups = getVideoGroups(newSdp, 'FID');
+
                 expect(fidGroups.length).toEqual(1);
 
                 const fidGroup = fidGroups[0];
                 const fidGroupPrimarySsrc = SDPUtil.parseGroupSsrcs(fidGroup)[0];
+
                 expect(fidGroupPrimarySsrc).toEqual(this.primaryVideoSsrc);
             });
 
@@ -112,6 +125,7 @@ describe('RtxModifier', () => {
                 newSdp = transform.parse(newSdpStr);
                 fidGroup = getVideoGroups(newSdp, 'FID')[0];
                 const newFidGroupRtxSsrc = SDPUtil.parseGroupSsrcs(fidGroup)[1];
+
                 expect(newFidGroupRtxSsrc).toEqual(fidGroupRtxSsrc);
             });
 
@@ -125,6 +139,7 @@ describe('RtxModifier', () => {
 
                 let fidGroup = getVideoGroups(newSdp, 'FID')[0];
                 const fidGroupRtxSsrc = SDPUtil.parseGroupSsrcs(fidGroup)[1];
+
                 this.rtxModifier.clearSsrcCache();
 
           // Now pass the original sdp through again
@@ -132,6 +147,7 @@ describe('RtxModifier', () => {
                 newSdp = transform.parse(newSdpStr);
                 fidGroup = getVideoGroups(newSdp, 'FID')[0];
                 const newFidGroupRtxSsrc = SDPUtil.parseGroupSsrcs(fidGroup)[1];
+
                 expect(newFidGroupRtxSsrc).not.toEqual(fidGroupRtxSsrc);
             });
 
@@ -141,6 +157,7 @@ describe('RtxModifier', () => {
           // -->The rtx ssrc used should be the one we set
                 const forcedRtxSsrc = 123456;
                 const ssrcCache = new Map();
+
                 ssrcCache.set(this.primaryVideoSsrc, forcedRtxSsrc);
                 this.rtxModifier.setSsrcCache(ssrcCache);
                 const newSdpStr = this.rtxModifier.modifyRtxSsrcs(this.transform.write(this.singleVideoSdp));
@@ -148,6 +165,7 @@ describe('RtxModifier', () => {
 
                 const fidGroup = getVideoGroups(newSdp, 'FID')[0];
                 const fidGroupRtxSsrc = SDPUtil.parseGroupSsrcs(fidGroup)[1];
+
                 expect(fidGroupRtxSsrc).toEqual(forcedRtxSsrc);
             });
         });
@@ -164,14 +182,17 @@ describe('RtxModifier', () => {
                 const newSdpStr = this.rtxModifier.modifyRtxSsrcs(this.transform.write(this.multipleVideoSdp));
                 const newSdp = transform.parse(newSdpStr);
                 const newPrimaryVideoSsrcs = getPrimaryVideoSsrcs(newSdp);
+
                 expect(newPrimaryVideoSsrcs).toEqual(this.primaryVideoSsrcs);
           // Should now have rtx ssrcs as well
                 expect(numVideoSsrcs(newSdp)).toEqual(this.primaryVideoSsrcs.length * 2);
           // Should now have FID groups
                 const fidGroups = getVideoGroups(newSdp, 'FID');
+
                 expect(fidGroups.length).toEqual(this.primaryVideoSsrcs.length);
                 fidGroups.forEach(fidGroup => {
                     const fidGroupPrimarySsrc = SDPUtil.parseGroupSsrcs(fidGroup)[0];
+
                     expect(this.primaryVideoSsrcs.indexOf(fidGroupPrimarySsrc)).not.toEqual(-1);
                 });
             });
@@ -186,10 +207,12 @@ describe('RtxModifier', () => {
                 const rtxMapping = new Map();
                 let fidGroups = getVideoGroups(newSdp, 'FID');
           // Save the first mapping that is made
+
                 fidGroups.forEach(fidGroup => {
                     const fidSsrcs = SDPUtil.parseGroupSsrcs(fidGroup);
                     const fidGroupPrimarySsrc = fidSsrcs[0];
                     const fidGroupRtxSsrc = fidSsrcs[1];
+
                     rtxMapping.set(fidGroupPrimarySsrc, fidGroupRtxSsrc);
                 });
           // Now pass the original sdp through again and make sure we get the same mapping
@@ -200,6 +223,7 @@ describe('RtxModifier', () => {
                     const fidSsrcs = SDPUtil.parseGroupSsrcs(fidGroup);
                     const fidGroupPrimarySsrc = fidSsrcs[0];
                     const fidGroupRtxSsrc = fidSsrcs[1];
+
                     expect(rtxMapping.has(fidGroupPrimarySsrc)).toBe(true);
                     expect(rtxMapping.get(fidGroupPrimarySsrc)).toEqual(fidGroupRtxSsrc);
                 });
@@ -216,10 +240,12 @@ describe('RtxModifier', () => {
                 const rtxMapping = new Map();
                 let fidGroups = getVideoGroups(newSdp, 'FID');
           // Save the first mapping that is made
+
                 fidGroups.forEach(fidGroup => {
                     const fidSsrcs = SDPUtil.parseGroupSsrcs(fidGroup);
                     const fidGroupPrimarySsrc = fidSsrcs[0];
                     const fidGroupRtxSsrc = fidSsrcs[1];
+
                     rtxMapping.set(fidGroupPrimarySsrc, fidGroupRtxSsrc);
                 });
 
@@ -232,6 +258,7 @@ describe('RtxModifier', () => {
                     const fidSsrcs = SDPUtil.parseGroupSsrcs(fidGroup);
                     const fidGroupPrimarySsrc = fidSsrcs[0];
                     const fidGroupRtxSsrc = fidSsrcs[1];
+
                     expect(rtxMapping.has(fidGroupPrimarySsrc)).toBe(true);
                     expect(rtxMapping.get(fidGroupPrimarySsrc)).not.toEqual(fidGroupRtxSsrc);
                 });
@@ -242,6 +269,7 @@ describe('RtxModifier', () => {
           // Call modifyRtxSsrcs
           // -->The rtx ssrc used should be the one we set
                 const rtxMapping = new Map();
+
                 this.primaryVideoSsrcs.forEach(ssrc => {
                     rtxMapping.set(ssrc, SDPUtil.generateSsrc());
                 });
@@ -251,10 +279,12 @@ describe('RtxModifier', () => {
                 const newSdp = transform.parse(newSdpStr);
 
                 const fidGroups = getVideoGroups(newSdp, 'FID');
+
                 fidGroups.forEach(fidGroup => {
                     const fidSsrcs = SDPUtil.parseGroupSsrcs(fidGroup);
                     const fidGroupPrimarySsrc = fidSsrcs[0];
                     const fidGroupRtxSsrc = fidSsrcs[1];
+
                     expect(rtxMapping.has(fidGroupPrimarySsrc)).toBe(true);
                     expect(rtxMapping.get(fidGroupPrimarySsrc)).toEqual(fidGroupRtxSsrc);
                 });
@@ -265,24 +295,30 @@ describe('RtxModifier', () => {
             it('should handle a recvonly video mline', function() {
                 const sdp = SampleSdpStrings.plainVideoSdp;
                 const videoMLine = sdp.media.find(m => m.type === 'video');
+
                 videoMLine.direction = 'recvonly';
                 const newSdpStr = this.rtxModifier.modifyRtxSsrcs(this.transform.write(sdp));
+
                 expect(newSdpStr).toEqual(this.transform.write(sdp));
             });
 
             it('should handle an inactive video mline', function() {
                 const sdp = SampleSdpStrings.plainVideoSdp;
                 const videoMLine = sdp.media.find(m => m.type === 'video');
+
                 videoMLine.direction = 'inactive';
                 const newSdpStr = this.rtxModifier.modifyRtxSsrcs(this.transform.write(sdp));
+
                 expect(newSdpStr).toEqual(this.transform.write(sdp));
             });
 
             it('should handle a video mline with no video ssrcs', function() {
                 const sdp = SampleSdpStrings.plainVideoSdp;
                 const videoMLine = sdp.media.find(m => m.type === 'video');
+
                 videoMLine.ssrcs = [];
                 const newSdpStr = this.rtxModifier.modifyRtxSsrcs(this.transform.write(sdp));
+
                 expect(newSdpStr).toEqual(this.transform.write(sdp));
             });
         });
@@ -295,12 +331,14 @@ describe('RtxModifier', () => {
             const newSdpStr = this.rtxModifier.stripRtx(sdpStr);
             const newSdp = transform.parse(newSdpStr);
             const fidGroups = getVideoGroups(newSdp, 'FID');
+
             expect(fidGroups.length).toEqual(0);
             expect(numVideoSsrcs(newSdp)).toEqual(1);
         });
         it('should do nothing to an sdp with no rtx', function() {
             const sdpStr = transform.write(SampleSdpStrings.plainVideoSdp);
             const newSdpStr = this.rtxModifier.stripRtx(sdpStr);
+
             expect(newSdpStr).toEqual(sdpStr);
         });
     });

modules/xmpp/SDP.js

@@ -5,8 +5,10 @@ const SDPUtil = require('./SDPUtil');
 // SDP STUFF
 function SDP(sdp) {
     const media = sdp.split('\r\nm=');
+
     for (let i = 1, length = media.length; i < length; i++) {
         let media_i = `m=${media[i]}`;
+
         if (i != length - 1) {
             media_i += '\r\n';
         }
@@ -46,6 +48,7 @@ SDP.prototype.getMediaSsrcMap = function() {
     const self = this;
     const media_ssrcs = {};
     let tmp;
+
     for (let mediaindex = 0; mediaindex < self.media.length; mediaindex++) {
         tmp = SDPUtil.find_lines(self.media[mediaindex], 'a=ssrc:');
         const mid = SDPUtil.parse_mid(SDPUtil.find_line(self.media[mediaindex], 'a=mid:'));
@@ -55,10 +58,12 @@ SDP.prototype.getMediaSsrcMap = function() {
             ssrcs: {},
             ssrcGroups: []
         };
+
         media_ssrcs[mediaindex] = media;
         tmp.forEach(line => {
             const linessrc = line.substring(7).split(' ')[0];
             // allocate new ChannelSsrc
+
             if(!media.ssrcs[linessrc]) {
                 media.ssrcs[linessrc] = {
                     ssrc: linessrc,
@@ -72,6 +77,7 @@ SDP.prototype.getMediaSsrcMap = function() {
             const idx = line.indexOf(' ');
             const semantics = line.substr(0, idx).substr(13);
             const ssrcs = line.substr(14 + semantics.length).split(' ');
+
             if (ssrcs.length) {
                 media.ssrcGroups.push({
                     semantics,
@@ -80,6 +86,7 @@ SDP.prototype.getMediaSsrcMap = function() {
             }
         });
     }
+
     return media_ssrcs;
 };
 /**
@@ -91,6 +98,7 @@ SDP.prototype.containsSSRC = function(ssrc) {
     // FIXME this code is really strange - improve it if you can
     const medias = this.getMediaSsrcMap();
     let result = false;
+
     Object.keys(medias).forEach(mediaindex => {
         if (result) {
             return;
@@ -99,12 +107,14 @@ SDP.prototype.containsSSRC = function(ssrc) {
             result = true;
         }
     });
+
     return result;
 };
 
 // remove iSAC and CN from SDP
 SDP.prototype.mangle = function() {
     let i, j, lines, mline, newdesc, rtpmap;
+
     for (i = 0; i < this.media.length; i++) {
         lines = this.media[i].split('\r\n');
         lines.pop(); // remove empty last element
@@ -133,10 +143,12 @@ SDP.prototype.mangle = function() {
 SDP.prototype.removeSessionLines = function(prefix) {
     const self = this;
     const lines = SDPUtil.find_lines(this.session, prefix);
+
     lines.forEach(line => {
         self.session = self.session.replace(`${line}\r\n`, '');
     });
     this.raw = this.session + this.media.join('');
+
     return lines;
 };
 // remove lines matching prefix from a media section specified by mediaindex
@@ -144,11 +156,13 @@ SDP.prototype.removeSessionLines = function(prefix) {
 SDP.prototype.removeMediaLines = function(mediaindex, prefix) {
     const self = this;
     const lines = SDPUtil.find_lines(this.media[mediaindex], prefix);
+
     lines.forEach(line => {
         self.media[mediaindex]
             = self.media[mediaindex].replace(`${line}\r\n`, '');
     });
     this.raw = this.session + this.media.join('');
+
     return lines;
 };
 
@@ -156,11 +170,13 @@ SDP.prototype.removeMediaLines = function(mediaindex, prefix) {
 SDP.prototype.toJingle = function(elem, thecreator) {
     let i, j, k, lines, mline, rtpmap, ssrc, tmp;
     // new bundle plan
+
     lines = SDPUtil.find_lines(this.session, 'a=group:');
     if (lines.length) {
         for (i = 0; i < lines.length; i++) {
             tmp = lines[i].split(' ');
             const semantics = tmp.shift().substr(8);
+
             elem.c('group', {xmlns: 'urn:xmpp:jingle:apps:grouping:0', semantics});
             for (j = 0; j < tmp.length; j++) {
                 elem.c('content', {name: tmp[j]}).up();
@@ -176,6 +192,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
             continue; // eslint-disable-line no-continue
         }
         const assrcline = SDPUtil.find_line(this.media[i], 'a=ssrc:');
+
         if (assrcline) {
             ssrc = assrcline.substring(7).split(' ')[0]; // take the first
         } else {
@@ -184,9 +201,11 @@ SDP.prototype.toJingle = function(elem, thecreator) {
 
         elem.c('content', {creator: thecreator, name: mline.media});
         const amidline = SDPUtil.find_line(this.media[i], 'a=mid:');
+
         if (amidline) {
             // prefer identifier from a=mid if present
             const mid = SDPUtil.parse_mid(amidline);
+
             elem.attrs({ name: mid });
         }
 
@@ -202,6 +221,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                 elem.c('payload-type', SDPUtil.parse_rtpmap(rtpmap));
                 // put any 'a=fmtp:' + mline.fmt[j] lines into <param name=foo value=bar/>
                 const afmtpline = SDPUtil.find_line(this.media[i], `a=fmtp:${mline.fmt[j]}`);
+
                 if (afmtpline) {
                     tmp = SDPUtil.parse_fmtp(afmtpline);
                     for (k = 0; k < tmp.length; k++) {
@@ -213,6 +233,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                 elem.up();
             }
             const crypto = SDPUtil.find_lines(this.media[i], 'a=crypto:', this.session);
+
             if (crypto.length) {
                 elem.c('encryption', {required: 1});
                 crypto.forEach(
@@ -225,24 +246,29 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                 elem.c('source', { ssrc, xmlns: 'urn:xmpp:jingle:apps:rtp:ssma:0' });
                 // FIXME: group by ssrc and support multiple different ssrcs
                 const ssrclines = SDPUtil.find_lines(this.media[i], 'a=ssrc:');
+
                 if(ssrclines.length > 0) {
                     ssrclines.forEach(line => {
                         const idx = line.indexOf(' ');
                         const linessrc = line.substr(0, idx).substr(7);
+
                         if (linessrc != ssrc) {
                             elem.up();
                             ssrc = linessrc;
                             elem.c('source', { ssrc, xmlns: 'urn:xmpp:jingle:apps:rtp:ssma:0' });
                         }
                         const kv = line.substr(idx + 1);
+
                         elem.c('parameter');
                         if (kv.indexOf(':') == -1) {
                             elem.attrs({ name: kv });
                         } else {
                             const k = kv.split(':', 2)[0];
+
                             elem.attrs({ name: k });
 
                             let v = kv.split(':', 2)[1];
+
                             v = SDPUtil.filter_special_chars(v);
                             elem.attrs({ value: v });
                         }
@@ -252,12 +278,18 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                     elem.up();
                     elem.c('source', { ssrc, xmlns: 'urn:xmpp:jingle:apps:rtp:ssma:0' });
                     elem.c('parameter');
-                    elem.attrs({name: 'cname', value:Math.random().toString(36).substring(7)});
+                    elem.attrs({
+                        name: 'cname',
+
+                        // eslint-disable-next-line newline-per-chained-call
+                        value: Math.random().toString(36).substring(7)
+                    });
                     elem.up();
                     // FIXME what case does this code handle ? remove ???
                     let msid = null;
                     // FIXME what is this ? global APP.RTC in SDP ?
                     const localTrack = APP.RTC.getLocalTracks(mline.media);
+
                     if (localTrack) {
                         // FIXME before this changes the track id was accessed,
                         // but msid stands for the stream id, makes no sense ?
@@ -280,10 +312,12 @@ SDP.prototype.toJingle = function(elem, thecreator) {
 
                 // XEP-0339 handle ssrc-group attributes
                 const ssrc_group_lines = SDPUtil.find_lines(this.media[i], 'a=ssrc-group:');
+
                 ssrc_group_lines.forEach(line => {
                     const idx = line.indexOf(' ');
                     const semantics = line.substr(0, idx).substr(13);
                     const ssrcs = line.substr(14 + semantics.length).split(' ');
+
                     if (ssrcs.length) {
                         elem.c('ssrc-group', { semantics, xmlns: 'urn:xmpp:jingle:apps:rtp:ssma:0' });
                         ssrcs.forEach(ssrc => elem.c('source', { ssrc }).up());
@@ -349,19 +383,23 @@ SDP.prototype.toJingle = function(elem, thecreator) {
         elem.up(); // end of content
     }
     elem.up();
+
     return elem;
 };
 
 SDP.prototype.transportToJingle = function(mediaindex, elem) {
     let tmp;
     const self = this;
+
     elem.c('transport');
 
     // XEP-0343 DTLS/SCTP
     const sctpmap
         = SDPUtil.find_line(this.media[mediaindex], 'a=sctpmap:', self.session);
+
     if (sctpmap) {
         const sctpAttrs = SDPUtil.parse_sctpmap(sctpmap);
+
         elem.c('sctpmap', {
             xmlns: 'urn:xmpp:jingle:transports:dtls-sctp:1',
             number: sctpAttrs[0], /* SCTP port */
@@ -376,6 +414,7 @@ SDP.prototype.transportToJingle = function(mediaindex, elem) {
     // XEP-0320
     const fingerprints
         = SDPUtil.find_lines(this.media[mediaindex], 'a=fingerprint:', this.session);
+
     fingerprints.forEach(line => {
         tmp = SDPUtil.parse_fingerprint(line);
         tmp.xmlns = 'urn:xmpp:jingle:apps:dtls:0';
@@ -395,14 +434,17 @@ SDP.prototype.transportToJingle = function(mediaindex, elem) {
         // XEP-0176
         if (SDPUtil.find_line(this.media[mediaindex], 'a=candidate:', this.session)) { // add any a=candidate lines
             const lines = SDPUtil.find_lines(this.media[mediaindex], 'a=candidate:', this.session);
+
             lines.forEach(line => {
                 const candidate = SDPUtil.candidateToJingle(line);
+
                 if (self.failICE) {
                     candidate.ip = '1.1.1.1';
                 }
                 const protocol = candidate
                         && typeof candidate.protocol === 'string'
                     ? candidate.protocol.toLowerCase() : '';
+
                 if ((self.removeTcpCandidates
                         && (protocol === 'tcp' || protocol === 'ssltcp'))
                     || (self.removeUdpCandidates && protocol === 'udp')) {
@@ -417,8 +459,10 @@ SDP.prototype.transportToJingle = function(mediaindex, elem) {
 
 SDP.prototype.rtcpFbToJingle = function(mediaindex, elem, payloadtype) { // XEP-0293
     const lines = SDPUtil.find_lines(this.media[mediaindex], `a=rtcp-fb:${payloadtype}`);
+
     lines.forEach(line => {
         const tmp = SDPUtil.parse_rtcpfb(line);
+
         if (tmp.type == 'trr-int') {
             elem.c('rtcp-fb-trr-int', {xmlns: 'urn:xmpp:jingle:apps:rtp:rtcp-fb:0', value: tmp.params[0]});
             elem.up();
@@ -435,6 +479,7 @@ SDP.prototype.rtcpFbToJingle = function(mediaindex, elem, payloadtype) { // XEP-
 SDP.prototype.rtcpFbFromJingle = function(elem, payloadtype) { // XEP-0293
     let media = '';
     let tmp = elem.find('>rtcp-fb-trr-int[xmlns="urn:xmpp:jingle:apps:rtp:rtcp-fb:0"]');
+
     if (tmp.length) {
         media += 'a=rtcp-fb:' + '*' + ' ' + 'trr-int' + ' ';
         if (tmp.attr('value')) {
@@ -452,22 +497,34 @@ SDP.prototype.rtcpFbFromJingle = function(elem, payloadtype) { // XEP-0293
         }
         media += '\r\n';
     });
+
     return media;
 };
 
 // construct an SDP from a jingle stanza
 SDP.prototype.fromJingle = function(jingle) {
     const self = this;
+
     this.raw = 'v=0\r\n'
         + 'o=- 1923518516 2 IN IP4 0.0.0.0\r\n'// FIXME
         + 's=-\r\n'
         + 't=0 0\r\n';
+
     // http://tools.ietf.org/html/draft-ietf-mmusic-sdp-bundle-negotiation-04#section-8
-    if ($(jingle).find('>group[xmlns="urn:xmpp:jingle:apps:grouping:0"]').length) {
-        $(jingle).find('>group[xmlns="urn:xmpp:jingle:apps:grouping:0"]').each((idx, group) => {
-            const contents = $(group).find('>content').map((idx, content) => content.getAttribute('name')).get();
+    const groups
+        = $(jingle).find('>group[xmlns="urn:xmpp:jingle:apps:grouping:0"]');
+
+    if (groups.length) {
+        groups.each((idx, group) => {
+            const contents
+                = $(group)
+                    .find('>content')
+                    .map((idx, content) => content.getAttribute('name'))
+                    .get();
+
             if (contents.length > 0) {
-                self.raw += `a=group:${group.getAttribute('semantics') || group.getAttribute('type')} ${contents.join(' ')}\r\n`;
+                self.raw
+                    += `a=group:${group.getAttribute('semantics') || group.getAttribute('type')} ${contents.join(' ')}\r\n`;
             }
         });
     }
@@ -475,6 +532,7 @@ SDP.prototype.fromJingle = function(jingle) {
     this.session = this.raw;
     jingle.find('>content').each(function() {
         const m = self.jingle2media($(this));
+
         self.media.push(m);
     });
 
@@ -498,6 +556,7 @@ SDP.prototype.jingle2media = function(content) {
         '>transport>sctpmap[xmlns="urn:xmpp:jingle:transports:dtls-sctp:1"]');
 
     let tmp = { media: desc.attr('media') };
+
     tmp.port = '1';
     if (content.attr('senders') == 'rejected') {
         // estos hack to reject an m-line.
@@ -514,16 +573,20 @@ SDP.prototype.jingle2media = function(content) {
         media += `a=sctpmap:${sctp.attr('number')} ${sctp.attr('protocol')}`;
 
         const streamCount = sctp.attr('streams');
+
         if (streamCount) {
             media += ` ${streamCount}\r\n`;
         } else {
             media += '\r\n';
         }
     } else {
-        tmp.fmt = desc.find('payload-type').map(
-            function() {
-                return this.getAttribute('id');
-            }).get();
+        tmp.fmt
+            = desc
+                .find('payload-type')
+                .map(function() {
+                    return this.getAttribute('id');
+                })
+                .get();
         media += `${SDPUtil.build_mline(tmp)}\r\n`;
     }
 
@@ -587,11 +650,16 @@ SDP.prototype.jingle2media = function(content) {
         media += `${SDPUtil.build_rtpmap(this)}\r\n`;
         if ($(this).find('>parameter').length) {
             media += `a=fmtp:${this.getAttribute('id')} `;
-            media += $(this).find('parameter').map(function() {
-                return (this.getAttribute('name')
-                        ? `${this.getAttribute('name')}=` : '')
-                    + this.getAttribute('value');
-            }).get().join('; ');
+            media
+                += $(this)
+                    .find('parameter')
+                    .map(function() {
+                        return (this.getAttribute('name')
+                                ? `${this.getAttribute('name')}=` : '')
+                            + this.getAttribute('value');
+                    })
+                    .get()
+                    .join('; ');
             media += '\r\n';
         }
         // xep-0293
@@ -609,6 +677,7 @@ SDP.prototype.jingle2media = function(content) {
 
     content.find('>transport[xmlns="urn:xmpp:jingle:transports:ice-udp:1"]>candidate').each(function() {
         let protocol = this.getAttribute('protocol');
+
         protocol = typeof protocol === 'string' ? protocol.toLowerCase() : '';
 
         if ((self.removeTcpCandidates
@@ -625,9 +694,13 @@ SDP.prototype.jingle2media = function(content) {
     // XEP-0339 handle ssrc-group attributes
     content.find('description>ssrc-group[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]').each(function() {
         const semantics = this.getAttribute('semantics');
-        const ssrcs = $(this).find('>source').map(function() {
-            return this.getAttribute('ssrc');
-        }).get();
+        const ssrcs
+            = $(this)
+                .find('>source')
+                .map(function() {
+                    return this.getAttribute('ssrc');
+                })
+                .get();
 
         if (ssrcs.length) {
             media += `a=ssrc-group:${semantics} ${ssrcs.join(' ')}\r\n`;
@@ -637,9 +710,12 @@ SDP.prototype.jingle2media = function(content) {
     tmp = content.find('description>source[xmlns="urn:xmpp:jingle:apps:rtp:ssma:0"]');
     tmp.each(function() {
         const ssrc = this.getAttribute('ssrc');
+
+        // eslint-disable-next-line newline-per-chained-call
         $(this).find('>parameter').each(function() {
             const name = this.getAttribute('name');
             let value = this.getAttribute('value');
+
             value = SDPUtil.filter_special_chars(value);
             media += `a=ssrc:${ssrc} ${name}`;
             if (value && value.length) {

modules/xmpp/SDPDiffer.js

@@ -36,18 +36,22 @@ SDPDiffer.prototype.getNewMedia = function() {
                 return false;
             }
         }
+
         return true;
     }
 
     const myMedias = this.mySDP.getMediaSsrcMap();
     const othersMedias = this.otherSDP.getMediaSsrcMap();
     const newMedia = {};
+
     Object.keys(othersMedias).forEach(othersMediaIdx => {
         const myMedia = myMedias[othersMediaIdx];
         const othersMedia = othersMedias[othersMediaIdx];
+
         if(!myMedia && othersMedia) {
             // Add whole channel
             newMedia[othersMediaIdx] = othersMedia;
+
             return;
         }
         // Look for new ssrcs across the channel
@@ -72,8 +76,10 @@ SDPDiffer.prototype.getNewMedia = function() {
 
             // try to match the other ssrc-group with an ssrc-group of ours
             let matched = false;
+
             for (let i = 0; i < myMedia.ssrcGroups.length; i++) {
                 const mySsrcGroup = myMedia.ssrcGroups[i];
+
                 if (otherSsrcGroup.semantics == mySsrcGroup.semantics
                     && arrayEquals.apply(otherSsrcGroup.ssrcs,
                                       [mySsrcGroup.ssrcs])) {
@@ -99,6 +105,7 @@ SDPDiffer.prototype.getNewMedia = function() {
             }
         });
     });
+
     return newMedia;
 };
 
@@ -109,9 +116,11 @@ SDPDiffer.prototype.toJingle = function(modify) {
     const sdpMediaSsrcs = this.getNewMedia();
 
     let modified = false;
+
     Object.keys(sdpMediaSsrcs).forEach(mediaindex => {
         modified = true;
         const media = sdpMediaSsrcs[mediaindex];
+
         modify.c('content', {name: media.mid});
 
         modify.c('description',
@@ -121,12 +130,14 @@ SDPDiffer.prototype.toJingle = function(modify) {
         // generate sources from lines
         Object.keys(media.ssrcs).forEach(ssrcNum => {
             const mediaSsrc = media.ssrcs[ssrcNum];
+
             modify.c('source', { xmlns: 'urn:xmpp:jingle:apps:rtp:ssma:0' });
             modify.attrs({ssrc: mediaSsrc.ssrc});
             // iterate over ssrc lines
             mediaSsrc.lines.forEach(line => {
                 const idx = line.indexOf(' ');
                 const kv = line.substr(idx + 1);
+
                 modify.c('parameter');
                 if (kv.indexOf(':') == -1) {
                     modify.attrs({ name: kv });
@@ -134,6 +145,7 @@ SDPDiffer.prototype.toJingle = function(modify) {
                     const nv = kv.split(':', 2);
                     const name = nv[0];
                     const value = SDPUtil.filter_special_chars(nv[1]);
+
                     modify.attrs({ name });
                     modify.attrs({ value });
                 }

modules/xmpp/SDPUtil.js

@@ -1,5 +1,6 @@
 import {getLogger} from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import RandomUtil from '../util/RandomUtil';
 const RTCBrowserType = require('../RTC/RTCBrowserType');
 
@@ -12,6 +13,7 @@ const SDPUtil = {
     iceparams(mediadesc, sessiondesc) {
         let data = null;
         let pwd, ufrag;
+
         if ((ufrag = SDPUtil.find_line(mediadesc, 'a=ice-ufrag:', sessiondesc))
                 && (pwd = SDPUtil.find_line(mediadesc, 'a=ice-pwd:', sessiondesc))) {
             data = {
@@ -19,6 +21,7 @@ const SDPUtil = {
                 pwd: SDPUtil.parse_icepwd(pwd)
             };
         }
+
         return data;
     },
     parse_iceufrag(line) {
@@ -47,6 +50,7 @@ const SDPUtil = {
             parts.pop();
         }
         data.fmt = parts;
+
         return data;
     },
     build_mline(mline) {
@@ -61,6 +65,7 @@ const SDPUtil = {
         data.name = parts.shift();
         data.clockrate = parts.shift();
         data.channels = parts.length ? parts.shift() : '1';
+
         return data;
     },
     /**
@@ -74,13 +79,17 @@ const SDPUtil = {
         const protocol = parts[1];
         // Stream count is optional
         const streamCount = parts.length > 2 ? parts[2] : null;
+
+
         return [sctpPort, protocol, streamCount];// SCTP port
     },
     build_rtpmap(el) {
         let line = `a=rtpmap:${el.getAttribute('id')} ${el.getAttribute('name')}/${el.getAttribute('clockrate')}`;
+
         if (el.getAttribute('channels') && el.getAttribute('channels') != '1') {
             line += `/${el.getAttribute('channels')}`;
         }
+
         return line;
     },
     parse_crypto(line) {
@@ -93,6 +102,7 @@ const SDPUtil = {
         if (parts.length) {
             data['session-params'] = parts.join(' ');
         }
+
         return data;
     },
     parse_fingerprint(line) { // RFC 4572
@@ -101,6 +111,7 @@ const SDPUtil = {
 
         data.hash = parts.shift();
         data.fingerprint = parts.shift();
+
         // TODO assert that fingerprint satisfies 2UHEX *(":" 2UHEX) ?
         return data;
     },
@@ -112,10 +123,12 @@ const SDPUtil = {
         parts = parts.join(' ').split(';');
         for (let i = 0; i < parts.length; i++) {
             let key = parts[i].split('=')[0];
+
             while (key.length && key[0] == ' ') {
                 key = key.substring(1);
             }
             const value = parts[i].split('=')[1];
+
             if (key && value) {
                 data.push({name: key, value});
             } else if (key) {
@@ -123,6 +136,7 @@ const SDPUtil = {
                 data.push({name: '', value: key});
             }
         }
+
         return data;
     },
     parse_icecandidate(line) {
@@ -157,11 +171,16 @@ const SDPUtil = {
             }
         }
         candidate.network = '1';
-        candidate.id = Math.random().toString(36).substr(2, 10); // not applicable to SDP -- FIXME: should be unique, not just random
+
+        // not applicable to SDP -- FIXME: should be unique, not just random
+        // eslint-disable-next-line newline-per-chained-call
+        candidate.id = Math.random().toString(36).substr(2, 10);
+
         return candidate;
     },
     build_icecandidate(cand) {
         let line = [`a=candidate:${cand.foundation}`, cand.component, cand.protocol, cand.priority, cand.ip, cand.port, 'typ', cand.type].join(' ');
+
         line += ' ';
         switch (cand.type) {
         case 'srflx':
@@ -188,6 +207,7 @@ const SDPUtil = {
         line += 'generation';
         line += ' ';
         line += cand.hasOwnAttribute('generation') ? cand.generation : '0';
+
         return line;
     },
     parse_ssrc(desc) {
@@ -200,22 +220,27 @@ const SDPUtil = {
         for (let i = 0; i < lines.length; i++) {
             if (lines[i].substring(0, 7) == 'a=ssrc:') {
                 const idx = lines[i].indexOf(' ');
+
                 data[lines[i].substr(idx + 1).split(':', 2)[0]] = lines[i].substr(idx + 1).split(':', 2)[1];
             }
         }
+
         return data;
     },
     parse_rtcpfb(line) {
         const parts = line.substr(10).split(' ');
         const data = {};
+
         data.pt = parts.shift();
         data.type = parts.shift();
         data.params = parts;
+
         return data;
     },
     parse_extmap(line) {
         const parts = line.substr(9).split(' ');
         const data = {};
+
         data.value = parts.shift();
         if (data.value.indexOf('/') === -1) {
             data.direction = 'both';
@@ -225,10 +250,12 @@ const SDPUtil = {
         }
         data.uri = parts.shift();
         data.params = parts;
+
         return data;
     },
     find_line(haystack, needle, sessionpart) {
         let lines = haystack.split('\r\n');
+
         for (let i = 0; i < lines.length; i++) {
             if (lines[i].substring(0, needle.length) == needle) {
                 return lines[i];
@@ -244,6 +271,7 @@ const SDPUtil = {
                 return lines[j];
             }
         }
+
         return false;
     },
     find_lines(haystack, needle, sessionpart) {
@@ -265,6 +293,7 @@ const SDPUtil = {
                 needles.push(lines[j]);
             }
         }
+
         return needles;
     },
     candidateToJingle(line) {
@@ -275,6 +304,7 @@ const SDPUtil = {
         } else if (line.substring(0, 12) != 'a=candidate:') {
             logger.log('parseCandidate called with a line that is not a candidate line');
             logger.log(line);
+
             return null;
         }
         if (line.substring(line.length - 2) == '\r\n') {// chomp it
@@ -286,6 +316,7 @@ const SDPUtil = {
         if (elems[6] != 'typ') {
             logger.log('did not find typ in the right place');
             logger.log(line);
+
             return null;
         }
         candidate.foundation = elems[0].substring(12);
@@ -317,11 +348,16 @@ const SDPUtil = {
             }
         }
         candidate.network = '1';
-        candidate.id = Math.random().toString(36).substr(2, 10); // not applicable to SDP -- FIXME: should be unique, not just random
+
+        // not applicable to SDP -- FIXME: should be unique, not just random
+        // eslint-disable-next-line newline-per-chained-call
+        candidate.id = Math.random().toString(36).substr(2, 10);
+
         return candidate;
     },
     candidateFromJingle(cand) {
         let line = 'a=candidate:';
+
         line += cand.getAttribute('foundation');
         line += ' ';
         line += cand.getAttribute('component');
@@ -329,6 +365,7 @@ const SDPUtil = {
 
         let protocol = cand.getAttribute('protocol');
         // use tcp candidates for FF
+
         if (RTCBrowserType.isFirefox() && protocol.toLowerCase() == 'ssltcp') {
             protocol = 'tcp';
         }
@@ -369,6 +406,7 @@ const SDPUtil = {
         line += 'generation';
         line += ' ';
         line += cand.getAttribute('generation') || '0';
+
         return `${line}\r\n`;
     },
 
@@ -384,11 +422,13 @@ const SDPUtil = {
             .length;
         const numGroups
             = (videoMLine.ssrcGroups && videoMLine.ssrcGroups.length) || 0;
+
         if (numSsrcs > 1 && numGroups === 0) {
             // Ambiguous, can't figure out the primary
             return;
         }
         let primarySsrc = null;
+
         if (numSsrcs === 1) {
             primarySsrc = videoMLine.ssrcs[0].id;
         } else if (numSsrcs === 2) {
@@ -396,6 +436,7 @@ const SDPUtil = {
             const fidGroup
                 = videoMLine.ssrcGroups.find(
                     group => group.semantics === 'FID');
+
             if (fidGroup) {
                 primarySsrc = fidGroup.ssrcs.split(' ')[0];
             }
@@ -404,10 +445,12 @@ const SDPUtil = {
             const simGroup
                 = videoMLine.ssrcGroups.find(
                     group => group.semantics === 'SIM');
+
             if (simGroup) {
                 primarySsrc = simGroup.ssrcs.split(' ')[0];
             }
         }
+
         return primarySsrc;
     },
 
@@ -431,6 +474,7 @@ const SDPUtil = {
     getSsrcAttribute(mLine, ssrc, attributeName) {
         for (let i = 0; i < mLine.ssrcs.length; ++i) {
             const ssrcLine = mLine.ssrcs[i];
+
             if (ssrcLine.id === ssrc
                 && ssrcLine.attribute === attributeName) {
                 return ssrcLine.value;
@@ -475,8 +519,10 @@ const SDPUtil = {
      */
     preferVideoCodec(videoMLine, codecName) {
         let payloadType = null;
+
         for (let i = 0; i < videoMLine.rtp.length; ++i) {
             const rtp = videoMLine.rtp[i];
+
             if (rtp.codec === codecName) {
                 payloadType = rtp.payload;
                 break;
@@ -485,6 +531,7 @@ const SDPUtil = {
         if (payloadType) {
             const payloadTypes = videoMLine.payloads.split(' ').map(p => parseInt(p));
             const payloadIndex = payloadTypes.indexOf(payloadType);
+
             payloadTypes.splice(payloadIndex, 1);
             payloadTypes.unshift(payloadType);
             videoMLine.payloads = payloadTypes.join(' ');

modules/xmpp/SDPUtil.spec.js

@@ -13,9 +13,11 @@ describe('SDPUtil', () => {
         it('should move a preferred codec to the front', () => {
             const sdp = SampleSdpStrings.multiCodecVideoSdp;
             const videoMLine = sdp.media.find(m => m.type === 'video');
+
             SDPUtil.preferVideoCodec(videoMLine, 'H264');
             const newPayloadTypesOrder
                 = videoMLine.payloads.split(' ').map(ptStr => parseInt(ptStr));
+
             expect(newPayloadTypesOrder[0]).toEqual(126);
         });
     });

modules/xmpp/SdpConsistency.js

@@ -61,13 +61,16 @@ export default class SdpConsistency {
     makeVideoPrimarySsrcsConsistent(sdpStr) {
         const sdpTransformer = new SdpTransformWrap(sdpStr);
         const videoMLine = sdpTransformer.selectMedia('video');
+
         if (!videoMLine) {
             logger.error(`No 'video' media found in the sdp: ${sdpStr}`);
+
             return sdpStr;
         }
         if (videoMLine.direction === 'inactive') {
             logger.info(
                 'Sdp-consistency doing nothing, video mline is inactive');
+
             return sdpStr;
         }
         if (videoMLine.direction === 'recvonly') {
@@ -84,8 +87,10 @@ export default class SdpConsistency {
             }
         } else {
             const newPrimarySsrc = videoMLine.getPrimaryVideoSsrc();
+
             if (!newPrimarySsrc) {
                 logger.info('Sdp-consistency couldn\'t parse new primary ssrc');
+
                 return sdpStr;
             }
             if (this.cachedPrimarySsrc) {
@@ -97,6 +102,7 @@ export default class SdpConsistency {
                     if (group.semantics === 'FID') {
                         const primarySsrc = parsePrimarySSRC(group);
                         const rtxSsrc = parseSecondarySSRC(group);
+
                         if (primarySsrc === newPrimarySsrc) {
                             group.ssrcs
                                 = `${this.cachedPrimarySsrc} ${rtxSsrc}`;
@@ -110,6 +116,7 @@ export default class SdpConsistency {
                         this.cachedPrimarySsrc}`);
             }
         }
+
         return sdpTransformer.toRawSDP();
     }
 }

modules/xmpp/SdpTransformUtil.js

@@ -27,6 +27,7 @@ function _getSSRCCount(mLine) {
     if (!mLine.ssrcs) {
         return 0;
     }
+
     return mLine.ssrcs
             .map(ssrcInfo => ssrcInfo.id)
             .filter((ssrc, index, array) => array.indexOf(ssrc) === index)
@@ -73,6 +74,8 @@ export class SdpTransformWrap {
     selectMedia(mediaType) {
         const selectedMLine
             = this.parsedSDP.media.find(mLine => mLine.type === mediaType);
+
+
         return selectedMLine ? new MLineWrap(selectedMLine) : null;
     }
 
@@ -109,6 +112,7 @@ class MLineWrap {
         if (!this.mLine.ssrcs) {
             this.mLine.ssrcs = [];
         }
+
         return this.mLine.ssrcs;
     }
 
@@ -136,6 +140,7 @@ class MLineWrap {
         if (!this.mLine.ssrcGroups) {
             this.mLine.ssrcGroups = [];
         }
+
         return this.mLine.ssrcGroups;
     }
 
@@ -160,6 +165,8 @@ class MLineWrap {
         const attribute = this._ssrcs.find(
             ssrcObj => ssrcObj.id == ssrcNumber
             && ssrcObj.attribute === attrName);
+
+
         return attribute && attribute.value;
     }
 
@@ -255,6 +262,7 @@ class MLineWrap {
         }
 
         const numSsrcs = _getSSRCCount(this.mLine);
+
         if (numSsrcs === 1) {
             // Not using _ssrcs on purpose here
             return this.mLine.ssrcs[0].id;
@@ -262,10 +270,12 @@ class MLineWrap {
             // Look for a SIM or FID group
         if (this.mLine.ssrcGroups) {
             const simGroup = this.findGroup('SIM');
+
             if (simGroup) {
                 return parsePrimarySSRC(simGroup);
             }
             const fidGroup = this.findGroup('FID');
+
             if (fidGroup) {
                 return parsePrimarySSRC(fidGroup);
             }
@@ -283,6 +293,8 @@ class MLineWrap {
      */
     getRtxSSRC(primarySsrc) {
         const fidGroup = this.findGroupByPrimarySSRC('FID', primarySsrc);
+
+
         return fidGroup && parseSecondarySSRC(fidGroup);
     }
 
@@ -318,10 +330,12 @@ class MLineWrap {
             if (ssrcGroupInfo.semantics === 'FID') {
                 // secondary FID streams should be filtered out
                 const secondarySsrc = parseSecondarySSRC(ssrcGroupInfo);
+
                 videoSSRCs.splice(
                     videoSSRCs.indexOf(secondarySsrc), 1);
             }
         }
+
         return videoSSRCs;
     }
 

modules/xmpp/moderator.js

@@ -5,19 +5,25 @@ const XMPPEvents = require('../../service/xmpp/XMPPEvents');
 const AuthenticationEvents
     = require('../../service/authentication/AuthenticationEvents');
 const GlobalOnErrorHandler = require('../util/GlobalOnErrorHandler');
+
 import Settings from '../settings/Settings';
 
 function createExpBackoffTimer(step) {
     let count = 1;
+
+
     return function(reset) {
         // Reset call
         if (reset) {
             count = 1;
+
             return;
         }
         // Calculate next timeout
         const timeout = Math.pow(2, count - 1);
+
         count += 1;
+
         return timeout * step;
     };
 }
@@ -49,6 +55,7 @@ function Moderator(roomName, xmpp, emitter, options) {
                 logger.warn(
                     `Ignoring sessionId from different origin: ${
                         event.origin}`);
+
                 return;
             }
             Settings.setSessionId(event.data.sessionId);
@@ -74,6 +81,7 @@ Moderator.prototype.isSipGatewayEnabled = function() {
 Moderator.prototype.onMucMemberLeft = function(jid) {
     logger.info(`Someone left is it focus ? ${jid}`);
     const resource = Strophe.getResourceFromJid(jid);
+
     if (resource === 'focus') {
         logger.info(
             'Focus has left the room - leaving conference');
@@ -96,9 +104,11 @@ Moderator.prototype.getFocusComponent = function() {
     // Get focus component address
     let focusComponent = this.options.connection.hosts.focus;
     // If not specified use default:  'focus.domain'
+
     if (!focusComponent) {
         focusComponent = `focus.${this.options.connection.hosts.domain}`;
     }
+
     return focusComponent;
 };
 
@@ -211,12 +221,15 @@ Moderator.prototype.createConferenceIq = function() {
             }).up();
     }
     elem.up();
+
     return elem;
 };
 
 
 Moderator.prototype.parseSessionId = function(resultIq) {
+    // eslint-disable-next-line newline-per-chained-call
     const sessionId = $(resultIq).find('conference').attr('session-id');
+
     if (sessionId) {
         logger.info(`Received sessionId:  ${sessionId}`);
         Settings.setSessionId(sessionId);
@@ -224,9 +237,8 @@ Moderator.prototype.parseSessionId = function(resultIq) {
 };
 
 Moderator.prototype.parseConfigOptions = function(resultIq) {
-
-    this.setFocusUserJid(
-        $(resultIq).find('conference').attr('focusjid'));
+    // eslint-disable-next-line newline-per-chained-call
+    this.setFocusUserJid($(resultIq).find('conference').attr('focusjid'));
 
     const authenticationEnabled
         = $(resultIq).find(
@@ -247,6 +259,7 @@ Moderator.prototype.parseConfigOptions = function(resultIq) {
         this.parseSessionId(resultIq);
     }
 
+    // eslint-disable-next-line newline-per-chained-call
     const authIdentity = $(resultIq).find('>conference').attr('identity');
 
     this.eventEmitter.emit(AuthenticationEvents.IDENTITY_UPDATED,
@@ -299,42 +312,50 @@ Moderator.prototype._allocateConferenceFocusError = function(error, callback) {
     // If the session is invalid, remove and try again without session ID to get
     // a new one
     const invalidSession = $(error).find('>error>session-invalid').length;
+
     if (invalidSession) {
         logger.info('Session expired! - removing');
         Settings.clearSessionId();
     }
     if ($(error).find('>error>graceful-shutdown').length) {
         this.eventEmitter.emit(XMPPEvents.GRACEFUL_SHUTDOWN);
+
         return;
     }
     // Check for error returned by the reservation system
     const reservationErr = $(error).find('>error>reservation-error');
+
     if (reservationErr.length) {
         // Trigger error event
         const errorCode = reservationErr.attr('error-code');
         const errorTextNode = $(error).find('>error>text');
         let errorMsg;
+
         if (errorTextNode) {
             errorMsg = errorTextNode.text();
         }
         this.eventEmitter.emit(
                 XMPPEvents.RESERVATION_ERROR, errorCode, errorMsg);
+
         return;
     }
     // Not authorized to create new room
     if ($(error).find('>error>not-authorized').length) {
         logger.warn('Unauthorized to start the conference', error);
         const toDomain = Strophe.getDomainFromJid(error.getAttribute('to'));
+
         if (toDomain !== this.options.connection.hosts.anonymousdomain) {
             // FIXME "is external" should come either from the focus or
             // config.js
             this.externalAuthEnabled = true;
         }
         this.eventEmitter.emit(XMPPEvents.AUTHENTICATION_REQUIRED);
+
         return;
     }
     const waitMs = this.getNextErrorTimeout();
     const errmsg = `Focus error, retry after ${waitMs}`;
+
     GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
     logger.error(errmsg, error);
     // Show message
@@ -342,6 +363,7 @@ Moderator.prototype._allocateConferenceFocusError = function(error, callback) {
     const retrySec = waitMs / 1000;
     // FIXME: message is duplicated ? Do not show in case of session invalid
     // which means just a retry
+
     if (!invalidSession) {
         this.eventEmitter.emit(
                 XMPPEvents.FOCUS_DISCONNECTED, focusComponent, retrySec);
@@ -368,6 +390,7 @@ Moderator.prototype._allocateConferenceFocusSuccess = function(
 
     // Reset the error timeout (because we haven't failed here).
     this.getNextErrorTimeout(true);
+    // eslint-disable-next-line newline-per-chained-call
     if ('true' === $(result).find('conference').attr('ready')) {
         // Reset the non-error timeout (because we've succeeded here).
         this.getNextTimeout(true);
@@ -375,6 +398,7 @@ Moderator.prototype._allocateConferenceFocusSuccess = function(
         callback();
     } else {
         const waitMs = this.getNextTimeout();
+
         logger.info(`Waiting for the focus... ${waitMs}`);
         window.setTimeout(() => this.allocateConferenceFocus(callback),
             waitMs);
@@ -389,7 +413,9 @@ Moderator.prototype.authenticate = function() {
                 this.parseSessionId(result);
                 resolve();
             }, error => {
+                // eslint-disable-next-line newline-per-chained-call
                 const code = $(error).find('>error').attr('code');
+
                 reject(error, code);
             }
         );
@@ -415,6 +441,7 @@ Moderator.prototype._getLoginUrl = function(popup, urlCb, failureCb) {
         'machine-uid': Settings.getMachineId()
     };
     let str = 'auth url'; // for logger
+
     if (popup) {
         attrs.popup = true;
         str = `POPUP ${str}`;
@@ -435,7 +462,9 @@ Moderator.prototype._getLoginUrl = function(popup, urlCb, failureCb) {
     this.connection.sendIQ(
         iq,
         result => {
+            // eslint-disable-next-line newline-per-chained-call
             let url = $(result).find('login-url').attr('url');
+
             url = decodeURIComponent(url);
             if (url) {
                 logger.info(`Got ${str}: ${url}`);
@@ -455,8 +484,10 @@ Moderator.prototype.getPopupLoginUrl = function(urlCallback, failureCallback) {
 Moderator.prototype.logout = function(callback) {
     const iq = $iq({to: this.getFocusComponent(), type: 'set'});
     const sessionId = Settings.getSessionId();
+
     if (!sessionId) {
         callback();
+
         return;
     }
     iq.c('logout', {
@@ -466,7 +497,9 @@ Moderator.prototype.logout = function(callback) {
     this.connection.sendIQ(
         iq,
         result => {
+            // eslint-disable-next-line newline-per-chained-call
             let logoutUrl = $(result).find('logout').attr('logout-url');
+
             if (logoutUrl) {
                 logoutUrl = decodeURIComponent(logoutUrl);
             }
@@ -476,6 +509,7 @@ Moderator.prototype.logout = function(callback) {
         },
         error => {
             const errmsg = 'Logout error';
+
             GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
             logger.error(errmsg, error);
         }

modules/xmpp/recording.js

@@ -54,11 +54,13 @@ Recording.action = {
 
 Recording.prototype.handleJibriPresence = function(jibri) {
     const attributes = jibri.attributes;
+
     if(!attributes) {
         return;
     }
 
     const newState = attributes.status;
+
     logger.log('Handle jibri presence : ', newState);
 
     if (newState === this.state) {
@@ -91,14 +93,16 @@ Recording.prototype.setRecordingJibri
         options = options || {};
 
     // FIXME jibri does not accept IQ without 'url' attribute set ?
-        const iq = $iq({to: this.focusMucJid, type: 'set'})
-        .c('jibri', {
-            'xmlns': 'http://jitsi.org/protocol/jibri',
-            'action': state === Recording.status.ON
-                    ? Recording.action.START
-                    : Recording.action.STOP,
-            'streamid': options.streamId,
-        }).up();
+        const iq
+            = $iq({to: this.focusMucJid, type: 'set'})
+                .c('jibri', {
+                    'xmlns': 'http://jitsi.org/protocol/jibri',
+                    'action': state === Recording.status.ON
+                            ? Recording.action.START
+                            : Recording.action.STOP,
+                    'streamid': options.streamId,
+                })
+                .up();
 
         logger.log(`Set jibri recording: ${state}`, iq.nodeTree);
         logger.log(iq.nodeTree);
@@ -106,8 +110,10 @@ Recording.prototype.setRecordingJibri
         iq,
         result => {
             logger.log('Result', result);
-            callback($(result).find('jibri').attr('state'),
-            $(result).find('jibri').attr('url'));
+
+            const jibri = $(result).find('jibri');
+
+            callback(jibri.attr('state'), jibri.attr('url'));
         },
         error => {
             logger.log('Failed to start recording, error: ', error);
@@ -128,17 +134,20 @@ Recording.prototype.setRecordingJirecon
                 ? Recording.action.START
                 : Recording.action.STOP,
             mucjid: this.roomjid});
+
         if (state === 'off') {
             iq.attrs({rid: this.jireconRid});
         }
 
         logger.log('Start recording');
         const self = this;
+
         this.connection.sendIQ(
         iq,
         result => {
             // TODO wait for an IQ with the real status, since this is
             // provisional?
+            // eslint-disable-next-line newline-per-chained-call
             self.jireconRid = $(result).find('recording').attr('rid');
             logger.log(
                 `Recording ${
@@ -163,12 +172,14 @@ Recording.prototype.setRecordingJirecon
 Recording.prototype.setRecordingColibri
 = function(state, callback, errCallback, options) {
     const elem = $iq({to: this.focusMucJid, type: 'set'});
+
     elem.c('conference', {
         xmlns: 'http://jitsi.org/protocol/colibri'
     });
     elem.c('recording', {state, token: options.token});
 
     const self = this;
+
     this.connection.sendIQ(elem,
         result => {
             logger.log('Set recording "', state, '". Result:', result);
@@ -180,7 +191,9 @@ Recording.prototype.setRecordingColibri
 
             if (newState === 'pending') {
                 self.connection.addHandler(iq => {
+                    // eslint-disable-next-line newline-per-chained-call
                     const state = $(iq).find('recording').attr('state');
+
                     if (state) {
                         self.state = newState;
                         callback(state);
@@ -209,6 +222,7 @@ Recording.prototype.setRecording
         break;
     default: {
         const errmsg = 'Unknown recording type!';
+
         GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
         logger.error(errmsg);
         break;
@@ -244,6 +258,7 @@ Recording.prototype.toggleRecording = function(options, statusChangeHandler) {
         statusChangeHandler(Recording.status.FAILED,
                             JitsiRecorderErrors.NO_TOKEN);
         logger.error('No token passed!');
+
         return;
     }
 
@@ -253,6 +268,7 @@ Recording.prototype.toggleRecording = function(options, statusChangeHandler) {
                     : Recording.status.OFF;
 
     const self = this;
+
     logger.log('Toggle recording (old state, new state): ', oldState, newState);
     this.setRecording(
         newState,

modules/xmpp/strophe.emuc.js

@@ -6,6 +6,7 @@
 
 import {getLogger} from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import ChatRoom from './ChatRoom';
 import {ConnectionPluginListenable} from './ConnectionPlugin';
 import XMPPEvents from '../../service/xmpp/XMPPEvents';
@@ -34,8 +35,10 @@ class MucConnectionPlugin extends ConnectionPluginListenable {
 
     createRoom(jid, password, options) {
         const roomJid = Strophe.getBareJidFromJid(jid);
+
         if (this.rooms[roomJid]) {
             const errmsg = 'You are already in the room!';
+
             logger.error(errmsg);
             throw new Error(errmsg);
         }
@@ -43,6 +46,7 @@ class MucConnectionPlugin extends ConnectionPluginListenable {
             password, this.xmpp, options);
         this.eventEmitter.emit(
             XMPPEvents.EMUC_ROOM_ADDED, this.rooms[roomJid]);
+
         return this.rooms[roomJid];
     }
 
@@ -61,6 +65,7 @@ class MucConnectionPlugin extends ConnectionPluginListenable {
         }
 
         const room = this.rooms[Strophe.getBareJidFromJid(from)];
+
         if(!room) {
             return;
         }
@@ -79,22 +84,26 @@ class MucConnectionPlugin extends ConnectionPluginListenable {
     onPresenceUnavailable(pres) {
         const from = pres.getAttribute('from');
         const room = this.rooms[Strophe.getBareJidFromJid(from)];
+
         if(!room) {
             return;
         }
 
         room.onPresenceUnavailable(pres, from);
+
         return true;
     }
 
     onPresenceError(pres) {
         const from = pres.getAttribute('from');
         const room = this.rooms[Strophe.getBareJidFromJid(from)];
+
         if(!room) {
             return;
         }
 
         room.onPresenceError(pres, from);
+
         return true;
     }
 
@@ -102,22 +111,26 @@ class MucConnectionPlugin extends ConnectionPluginListenable {
         // FIXME: this is a hack. but jingle on muc makes nickchanges hard
         const from = msg.getAttribute('from');
         const room = this.rooms[Strophe.getBareJidFromJid(from)];
+
         if(!room) {
             return;
         }
 
         room.onMessage(msg, from);
+
         return true;
     }
 
     onMute(iq) {
         const from = iq.getAttribute('from');
         const room = this.rooms[Strophe.getBareJidFromJid(from)];
+
         if(!room) {
             return;
         }
 
         room.onMute(iq);
+
         return true;
     }
 }

modules/xmpp/strophe.jingle.js

@@ -2,12 +2,17 @@
 
 import { getLogger } from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import JingleSessionPC from './JingleSessionPC';
 import XMPPEvents from '../../service/xmpp/XMPPEvents';
 import GlobalOnErrorHandler from '../util/GlobalOnErrorHandler';
 import Statistics from '../statistics/statistics';
 import ConnectionPlugin from './ConnectionPlugin';
 
+// XXX Strophe is build around the idea of chaining function calls so allow long
+// function call chains.
+/* eslint-disable newline-per-chained-call */
+
 class JingleConnectionPlugin extends ConnectionPlugin {
     constructor(xmpp, eventEmitter) {
         super();
@@ -39,8 +44,10 @@ class JingleConnectionPlugin extends ConnectionPlugin {
             to: fromJid,
             id: iq.getAttribute('id')
         });
+
         logger.log(`on jingle ${action} from ${fromJid}`, iq);
         let sess = this.sessions[sid];
+
         if ('session-initiate' != action) {
             if (!sess) {
                 ack.attrs({ type: 'error' });
@@ -50,6 +57,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                     .c('unknown-session', {xmlns: 'urn:xmpp:jingle:errors:1'});
                 logger.warn('invalid session id', iq);
                 this.connection.send(ack);
+
                 return true;
             }
             // local jid is not checked
@@ -61,6 +69,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                     .c('item-not-found', {xmlns: 'urn:ietf:params:xml:ns:xmpp-stanzas'}).up()
                     .c('unknown-session', {xmlns: 'urn:xmpp:jingle:errors:1'});
                 this.connection.send(ack);
+
                 return true;
             }
         } else if (sess !== undefined) {
@@ -71,17 +80,21 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                 .c('service-unavailable', {xmlns: 'urn:ietf:params:xml:ns:xmpp-stanzas'}).up();
             logger.warn('duplicate session id', sid, iq);
             this.connection.send(ack);
+
             return true;
         }
         const now = window.performance.now();
         // see http://xmpp.org/extensions/xep-0166.html#concepts-session
+
         switch (action) {
         case 'session-initiate': {
             logger.log('(TIME) received session-initiate:\t', now);
             const startMuted = $(iq).find('jingle>startmuted');
+
             if (startMuted && startMuted.length > 0) {
                 const audioMuted = startMuted.attr('audio');
                 const videoMuted = startMuted.attr('video');
+
                 this.eventEmitter.emit(XMPPEvents.START_MUTED_FROM_FOCUS,
                             audioMuted === 'true', videoMuted === 'true');
             }
@@ -105,9 +118,10 @@ class JingleConnectionPlugin extends ConnectionPlugin {
             logger.log('terminating...', sess.sid);
             let reasonCondition = null;
             let reasonText = null;
+
             if ($(iq).find('>jingle>reason').length) {
                 reasonCondition
-                        = $(iq).find('>jingle>reason>:first')[0].tagName;
+                    = $(iq).find('>jingle>reason>:first')[0].tagName;
                 reasonText = $(iq).find('>jingle>reason>text').text();
             }
             this.terminate(sess.sid, reasonCondition, reasonText);
@@ -122,6 +136,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
 
             sess.replaceTransport($(iq).find('>jingle'), () => {
                 const successTime = window.performance.now();
+
                 logger.info(
                         '(TIME) Transport replace success!', successTime);
                 Statistics.analytics.sendEvent(
@@ -151,6 +166,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
             break;
         }
         this.connection.send(ack);
+
         return true;
     }
 
@@ -181,10 +197,12 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                 .c('service', {host: `turn.${this.connection.domain}`}),
             res => {
                 const iceservers = [];
+
                 $(res).find('>services>service').each((idx, el) => {
                     el = $(el);
                     const dict = {};
                     const type = el.attr('type');
+
                     switch (type) {
                     case 'stun':
                         dict.url = `stun:${el.attr('host')}`;
@@ -198,6 +216,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                         dict.url = `${type}:`;
                         const username = el.attr('username');
                             // https://code.google.com/p/webrtc/issues/detail?id=1508
+
                         if (username) {
                             if (navigator.userAgent.match(
                                     /Chrom(e|ium)\/([0-9]+)\./)
@@ -213,10 +232,12 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                         }
                         dict.url += el.attr('host');
                         const port = el.attr('port');
+
                         if (port && port != '3478') {
                             dict.url += `:${el.attr('port')}`;
                         }
                         const transport = el.attr('transport');
+
                         if (transport && transport != 'udp') {
                             dict.url += `?transport=${transport}`;
                         }
@@ -241,9 +262,11 @@ class JingleConnectionPlugin extends ConnectionPlugin {
      */
     getLog() {
         const data = {};
+
         Object.keys(this.sessions).forEach(sid => {
             const session = this.sessions[sid];
             const pc = session.peerconnection;
+
             if (pc && pc.updateLog) {
                 // FIXME: should probably be a .dump call
                 data[`jingle_${sid}`] = {
@@ -253,12 +276,15 @@ class JingleConnectionPlugin extends ConnectionPlugin {
                 };
             }
         });
+
         return data;
     }
 }
 
+/* eslint-enable newline-per-chained-call */
 
 module.exports = function(XMPP, eventEmitter) {
-    Strophe.addConnectionPlugin('jingle',
+    Strophe.addConnectionPlugin(
+        'jingle',
         new JingleConnectionPlugin(XMPP, eventEmitter));
 };

modules/xmpp/strophe.ping.js

@@ -2,6 +2,7 @@
 
 import { getLogger } from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import ConnectionPlugin from './ConnectionPlugin';
 import GlobalOnErrorHandler from '../util/GlobalOnErrorHandler';
 
@@ -57,6 +58,7 @@ class PingConnectionPlugin extends ConnectionPlugin {
      */
     ping(jid, success, error, timeout) {
         const iq = $iq({type: 'get', to: jid});
+
         iq.c('ping', {xmlns: Strophe.NS.PING});
         this.connection.sendIQ(iq, success, error, timeout);
     }
@@ -71,6 +73,7 @@ class PingConnectionPlugin extends ConnectionPlugin {
         this.xmpp.caps.getFeatures(jid).then(features =>
             callback(features.has('urn:xmpp:ping')), error => {
             const errmsg = 'Ping feature discovery error';
+
             GlobalOnErrorHandler.callErrorHandler(
                 new Error(`${errmsg}: ${error}`));
             logger.error(errmsg, error);
@@ -88,8 +91,10 @@ class PingConnectionPlugin extends ConnectionPlugin {
     startInterval(remoteJid, interval = PING_INTERVAL) {
         if (this.intervalId) {
             const errmsg = 'Ping task scheduled already';
+
             GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
             logger.error(errmsg);
+
             return;
         }
         this.intervalId = window.setInterval(() => {
@@ -98,6 +103,7 @@ class PingConnectionPlugin extends ConnectionPlugin {
             }, error => {
                 this.failedPings += 1;
                 const errmsg = `Ping ${error ? 'error' : 'timeout'}`;
+
                 if (this.failedPings >= PING_THRESHOLD) {
                     GlobalOnErrorHandler.callErrorHandler(new Error(errmsg));
                     logger.error(errmsg, error);

modules/xmpp/strophe.rayo.js

@@ -2,6 +2,7 @@
 
 import { getLogger } from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import ConnectionPlugin from './ConnectionPlugin';
 
 const RAYO_XMLNS = 'urn:xmpp:rayo:1';
@@ -22,12 +23,14 @@ class RayoConnectionPlugin extends ConnectionPlugin {
         return new Promise((resolve, reject) => {
             if(!focusMucJid) {
                 reject(new Error('Internal error!'));
+
                 return;
             }
             const req = $iq({
                 type: 'set',
                 to: focusMucJid
             });
+
             req.c('dial', {
                 xmlns: RAYO_XMLNS,
                 to,
@@ -48,9 +51,10 @@ class RayoConnectionPlugin extends ConnectionPlugin {
             this.connection.sendIQ(req, result => {
                 logger.info('Dial result ', result);
 
+                // eslint-disable-next-line newline-per-chained-call
                 const resource = $(result).find('ref').attr('uri');
-                this.call_resource
-                    = resource.substr('xmpp:'.length);
+
+                this.call_resource = resource.substr('xmpp:'.length);
                 logger.info(`Received call resource: ${this.call_resource}`);
                 resolve();
             }, error => {
@@ -65,6 +69,7 @@ class RayoConnectionPlugin extends ConnectionPlugin {
             if (!this.call_resource) {
                 reject(new Error('No call in progress'));
                 logger.warn('No call in progress');
+
                 return;
             }
 
@@ -72,6 +77,7 @@ class RayoConnectionPlugin extends ConnectionPlugin {
                 type: 'set',
                 to: this.call_resource
             });
+
             req.c('hangup', {
                 xmlns: RAYO_XMLNS
             });

modules/xmpp/strophe.util.js

@@ -4,6 +4,7 @@
  */
 import {getLogger} from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import GlobalOnErrorHandler from '../util/GlobalOnErrorHandler';
 
 /**
@@ -68,6 +69,7 @@ export default function() {
         case Strophe.LogLevel.WARN:
             logger.warn(`Strophe: ${msg}`);
             const errStatusCapture = lastErrorStatusRegExpr.exec(msg);
+
             if (errStatusCapture && errStatusCapture.length === 2) {
                 lastErrorStatus = parseInt(errStatusCapture[1]);
                 logger.debug(

modules/xmpp/xmpp.js

@@ -2,6 +2,7 @@
 
 import { getLogger } from 'jitsi-meet-logger';
 const logger = getLogger(__filename);
+
 import RandomUtil from '../util/RandomUtil';
 import * as JitsiConnectionErrors from '../../JitsiConnectionErrors';
 import * as JitsiConnectionEvents from '../../JitsiConnectionEvents';
@@ -105,6 +106,7 @@ export default class XMPP extends Listenable {
     connectionHandler(password, status, msg) {
         const now = window.performance.now();
         const statusStr = Strophe.getStatusString(status).toLowerCase();
+
         this.connectionTimes[statusStr] = now;
         logger.log(
             `(TIME) Strophe ${statusStr}${msg ? `[${msg}]` : ''}:\t`,
@@ -119,6 +121,7 @@ export default class XMPP extends Listenable {
 
             // Schedule ping ?
             const pingJid = this.connection.domain;
+
             this.connection.ping.hasPingSupport(
                 pingJid,
                 hasPing => {
@@ -152,6 +155,7 @@ export default class XMPP extends Listenable {
             this.connection.ping.stopInterval();
             const wasIntentionalDisconnect = this.disconnectInProgress;
             const errMsg = msg ? msg : this.lastErrorMsg;
+
             this.disconnectInProgress = false;
             if (this.anonymousConnectionFailed) {
                 // prompt user for username and password
@@ -175,6 +179,7 @@ export default class XMPP extends Listenable {
                 // XXX if the last request error is within 5xx range it means it
                 // was a server failure
                 const lastErrorStatus = Strophe.getLastErrorStatus();
+
                 if (lastErrorStatus >= 500 && lastErrorStatus < 600) {
                     this.eventEmitter.emit(
                         JitsiConnectionEvents.CONNECTION_FAILED,
@@ -239,6 +244,7 @@ export default class XMPP extends Listenable {
      */
     attach(options) {
         const now = this.connectionTimes.attaching = window.performance.now();
+
         logger.log(`(TIME) Strophe Attaching\t:${now}`);
         this.connection.attach(options.jid, options.sid,
             parseInt(options.rid,10) + 1,
@@ -256,6 +262,7 @@ export default class XMPP extends Listenable {
                     || this.options.hosts.domain;
             // Force authenticated domain if room is appended with '?login=true'
             // or if we're joining with the token
+
             if (this.options.hosts.anonymousdomain
                     && (window.location.search.indexOf('login=true') !== -1
                         || this.options.token)) {
@@ -263,6 +270,7 @@ export default class XMPP extends Listenable {
             }
             jid = configDomain || window.location.hostname;
         }
+
         return this._connect(jid, password);
     }
 
@@ -297,6 +305,8 @@ export default class XMPP extends Listenable {
      */
     getJingleLog() {
         const jingle = this.connection.jingle;
+
+
         return jingle ? jingle.getLog() : {};
     }
 
@@ -334,6 +344,7 @@ export default class XMPP extends Listenable {
                 || !this.connection
                 || !this.connection.connected) {
             this.eventEmitter.emit(JitsiConnectionEvents.WRONG_STATE);
+
             return;
         }
 

service/RTC/Resolutions.js

@@ -52,4 +52,5 @@ const Resolutions = {
         order: 1
     }
 };
+
 module.exports = Resolutions;

service/RTC/VideoType.js

@@ -13,4 +13,5 @@ const VideoType = {
      */
     DESKTOP: 'desktop'
 };
+
 module.exports = VideoType;

service/authentication/AuthenticationEvents.js

@@ -9,4 +9,5 @@ const AuthenticationEvents = {
      */
     IDENTITY_UPDATED: 'authentication.identity_updated'
 };
+
 module.exports = AuthenticationEvents;

service/statistics/constants.js

@@ -1,4 +1,5 @@
 const Constants = {
     LOCAL_JID: 'local'
 };
+
 module.exports = Constants;

service/xmpp/XMPPEvents.js

@@ -156,4 +156,5 @@ const XMPPEvents = {
     // changed.
     ICE_CONNECTION_STATE_CHANGED: 'xmpp.ice_connection_state_changed'
 };
+
 module.exports = XMPPEvents;