Browse Source

ref(TPC): Cleanup flags related to low fps screenshare.

Simulcast for SS is always on in unified plan mode, the lower spatial resolution streams are turned off for low fps sharing.
tags/v0.0.2
Jaya Allamsetty 2 years ago
parent
commit
ca3e361186
2 changed files with 2 additions and 7 deletions
  1. 1
    1
      modules/RTC/TraceablePeerConnection.js
  2. 1
    6
      modules/xmpp/JingleSessionPC.js

+ 1
- 1
modules/RTC/TraceablePeerConnection.js View File

@@ -244,7 +244,7 @@ export default function TraceablePeerConnection(
244 244
     this.statsinterval = null;
245 245
 
246 246
     /**
247
-     * Flag used to indicate if simulcast is turned off and a cap of 500 Kbps is applied on screensharing.
247
+     * Flag used to indicate if low fps screenshare is desired.
248 248
      */
249 249
     this._capScreenshareBitrate = this.options.capScreenshareBitrate;
250 250
 

+ 1
- 6
modules/xmpp/JingleSessionPC.js View File

@@ -446,15 +446,10 @@ export default class JingleSessionPC extends JingleSession {
446 446
             pcOptions.disableSimulcast
447 447
                 = options.disableSimulcast || options.videoQuality?.preferredCodec === CodecMimeType.H264;
448 448
 
449
-            // Disable simulcast for low fps screenshare and enable it for high fps screenshare.
450
-            // testing.capScreenshareBitrate config.js setting has now been deprecated.
449
+            // Do not send lower spatial layers for low fps screenshare and enable them only for high fps screenshare.
451 450
             pcOptions.capScreenshareBitrate = pcOptions.disableSimulcast
452 451
                 || !(typeof options.desktopSharingFrameRate?.max === 'number'
453 452
                     && options.desktopSharingFrameRate?.max > SS_DEFAULT_FRAME_RATE);
454
-
455
-            // add the capScreenshareBitrate to the permanent properties so that it's included with every event that we
456
-            // send to the analytics backend.
457
-            Statistics.analytics.addPermanentProperties({ capScreenshareBitrate: pcOptions.capScreenshareBitrate });
458 453
         }
459 454
 
460 455
         if (options.startSilent) {

Loading…
Cancel
Save