remove jitsiRegionInfo from lib-jitsi-meet (#490)

* move all local deployment properties into  window.jitsiAnalyticsPermanentProperties property
no longer need to set jitsiRegionInfo from external_connect, now set from Jitsi meet local.html, can be customized by deployment

* change to using shorter lines by extracting longer property name into a shorter local variable name

* changed to using more generic variable name jitsiDeploymentInfo after discussion with the team
added comment describing source of this variable

JitsiConference.js

@@ -1326,8 +1326,10 @@ JitsiConference.prototype.onIncomingCall
     // add info whether call is cross-region
     let crossRegion = null;
 
-    if (window.jitsiRegionInfo) {
-        crossRegion = window.jitsiRegionInfo.CrossRegion;
+    // TODO: remove deprecated cross region property from this specific event
+    // once all existing deployments include analytics changes
+    if (window.jitsiDeploymentInfo) {
+        crossRegion = window.jitsiDeploymentInfo.CrossRegion;
     }
     Statistics.analytics.sendEvent(
         'session.initiate', {

JitsiMeetJS.js

@@ -129,13 +129,15 @@ export default {
         }
 
         // Log deployment-specific information, if available.
-        if (window.jitsiRegionInfo
-            && Object.keys(window.jitsiRegionInfo).length > 0) {
+        // Defined outside the application by individual deployments
+        const aprops = window.jitsiDeploymentInfo;
+
+        if (aprops && Object.keys(aprops).length > 0) {
             const logObject = {};
 
-            for (const attr in window.jitsiRegionInfo) {
-                if (window.jitsiRegionInfo.hasOwnProperty(attr)) {
-                    logObject[attr] = window.jitsiRegionInfo[attr];
+            for (const attr in aprops) {
+                if (aprops.hasOwnProperty(attr)) {
+                    logObject[attr] = aprops[attr];
                 }
             }
 

connection_optimization/external_connect.js

@@ -41,16 +41,6 @@ function createConnectionExternally( // eslint-disable-line no-unused-vars
             if (xhttp.status == HTTP_STATUS_OK) {
                 try {
                     var data = JSON.parse(xhttp.responseText);
-
-                    var proxyRegion = xhttp.getResponseHeader('X-Proxy-Region');
-                    var jitsiRegion = xhttp.getResponseHeader('X-Jitsi-Region');
-                    window.jitsiRegionInfo = {
-                        'ProxyRegion' : proxyRegion,
-                        'Region' : jitsiRegion,
-                        'Shard' : xhttp.getResponseHeader('X-Jitsi-Shard'),
-                        'CrossRegion': proxyRegion !== jitsiRegion ? 1 : 0
-                    };
-
                     successCallback(data);
                 } catch (e) {
                     error_callback(e);