Changes after code review

modules/RTC/RTCUtils.js

@@ -109,15 +109,24 @@ function setResolutionConstraints(constraints, resolution) {
 function getConstraints(um, options) {
     var constraints = {audio: false, video: false};
 
+    // Don't mix new and old style settings for Chromium as this leads
+    // to TypeError in new Chromium versions. @see
+    // https://bugs.chromium.org/p/chromium/issues/detail?id=614716
+    // This is a temporary solution, in future we will fully split old and
+    // new style constraints when new versions of Chromium and Firefox will
+    // have stable support of new constraints format. For more information
+    // @see https://github.com/jitsi/lib-jitsi-meet/pull/136
+    var isNewStyleConstraintsSupported =
+        RTCBrowserType.isFirefox() ||
+        RTCBrowserType.isReactNative() ||
+        RTCBrowserType.isTemasysPluginUsed();
+
     if (um.indexOf('video') >= 0) {
         // same behaviour as true
         constraints.video = { mandatory: {}, optional: [] };
 
         if (options.cameraDeviceId) {
-            // Don't mix new and old style settings for Chromium as this leads
-            // to TypeError in new Chromium versions. @see
-            // https://bugs.chromium.org/p/chromium/issues/detail?id=614716
-            if (!RTCBrowserType.isChrome() && !RTCBrowserType.isOpera()) {
+            if (isNewStyleConstraintsSupported) {
                 // New style of setting device id.
                 constraints.video.deviceId = options.cameraDeviceId;
             }
@@ -131,11 +140,7 @@ function getConstraints(um, options) {
             // TODO: Maybe use "exact" syntax if options.facingMode is defined,
             // but this probably needs to be decided when updating other
             // constraints, as we currently don't use "exact" syntax anywhere.
-
-            // Don't mix new and old style settings for Chromium as this leads
-            // to TypeError in new Chromium versions. @see
-            // https://bugs.chromium.org/p/chromium/issues/detail?id=614716
-            if (!RTCBrowserType.isChrome() && !RTCBrowserType.isOpera()) {
+            if (isNewStyleConstraintsSupported) {
                 constraints.video.facingMode = options.facingMode || 'user';
             }
 
@@ -157,10 +162,7 @@ function getConstraints(um, options) {
             // same behaviour as true
             constraints.audio = { mandatory: {}, optional: []};
             if (options.micDeviceId) {
-                // Don't mix new and old style settings for Chromium as this
-                // leads to TypeError in new Chromium versions. @see
-                // https://bugs.chromium.org/p/chromium/issues/detail?id=614716
-                if (!RTCBrowserType.isChrome() && !RTCBrowserType.isOpera()) {
+                if (isNewStyleConstraintsSupported) {
                     // New style of setting device id.
                     constraints.audio.deviceId = options.micDeviceId;
                 }