fix: Checks presence editing and make sure we send only on change.

JitsiConference.js

@@ -881,8 +881,7 @@ JitsiConference.prototype.sendPrivateTextMessage = function(
  **/
 JitsiConference.prototype.sendCommand = function(name, values) {
     if (this.room) {
-        this.room.addToPresence(name, values);
-        this.room.sendPresence();
+        this.room.addOrReplaceInPresence(name, values) && this.room.sendPresence();
     } else {
         logger.warn('Not sending a command, room not initialized.');
     }
@@ -915,11 +914,10 @@ JitsiConference.prototype.removeCommand = function(name) {
  */
 JitsiConference.prototype.setDisplayName = function(name) {
     if (this.room) {
-        this.room.addToPresence('nick', {
+        this.room.addOrReplaceInPresence('nick', {
             attributes: { xmlns: 'http://jabber.org/protocol/nick' },
             value: name
-        });
-        this.room.sendPresence();
+        }) && this.room.sendPresence();
     }
 };
 
@@ -1172,7 +1170,6 @@ JitsiConference.prototype._setupNewTrack = function(newTrack) {
         }
     }
     if (newTrack.isVideoTrack()) {
-        this.removeCommand('videoType');
         this.sendCommand('videoType', {
             value: newTrack.videoType,
             attributes: {
@@ -2370,14 +2367,13 @@ JitsiConference.prototype.setStartMutedPolicy = function(policy) {
         return;
     }
     this.startMutedPolicy = policy;
-    this.room.addToPresence('startmuted', {
+    this.room.addOrReplaceInPresence('startmuted', {
         attributes: {
             audio: policy.audio,
             video: policy.video,
             xmlns: 'http://jitsi.org/jitmeet/start-muted'
         }
-    });
-    this.room.sendPresence();
+    }) && this.room.sendPresence();
 };
 
 /**

modules/xmpp/Caps.js

@@ -162,7 +162,7 @@ export default class Caps extends Listenable {
                 });
             });
 
-            room.addToPresence('features', { children });
+            room.addOrReplaceInPresence('features', { children });
         }
     }
 
@@ -235,7 +235,7 @@ export default class Caps extends Listenable {
      * @param {ChatRoom} room the room.
      */
     _fixChatRoomPresenceMap(room) {
-        room.addToPresence('c', {
+        room.addOrReplaceInPresence('c', {
             attributes: {
                 xmlns: Strophe.NS.CAPS,
                 hash: HASH,

modules/xmpp/ChatRoom.js

@@ -1382,14 +1382,26 @@ export default class ChatRoom extends Listenable {
 
     /**
      * Adds the key to the presence map, overriding any previous value.
-     * @param key
-     * @param values
+     * @param key The key to add or replace.
+     * @param values The new values.
+     * @returns {boolean|null} <tt>true</tt> if the operation succeeded or <tt>false</tt> when no add or replce was
+     * performed as the value was already there.
      */
-    addToPresence(key, values) {
+    addOrReplaceInPresence(key, values) {
         values.tagName = key;
+
+        const matchingNodes = this.presMap.nodes.filter(node => key === node.tagName);
+
+        // if we have found just one, let's check is it the same
+        if (matchingNodes.length === 1 && isEqual(matchingNodes[0], values)) {
+            return false;
+        }
+
         this.removeFromPresence(key);
         this.presMap.nodes.push(values);
         this.presenceUpdateTime = Date.now();
+
+        return true;
     }
 
     /**
@@ -1515,7 +1527,7 @@ export default class ChatRoom extends Listenable {
      * @param mute
      */
     addAudioInfoToPresence(mute) {
-        this.addToPresence(
+        return this.addOrReplaceInPresence(
             'audiomuted',
             {
                 attributes: { 'xmlns': 'http://jitsi.org/jitmeet/audio' },
@@ -1529,10 +1541,8 @@ export default class ChatRoom extends Listenable {
      * @param callback
      */
     sendAudioInfoPresence(mute, callback) {
-        this.addAudioInfoToPresence(mute);
-
         // FIXME resend presence on CONNECTED
-        this.sendPresence();
+        this.addAudioInfoToPresence(mute) && this.sendPresence();
         if (callback) {
             callback();
         }
@@ -1543,7 +1553,7 @@ export default class ChatRoom extends Listenable {
      * @param mute
      */
     addVideoInfoToPresence(mute) {
-        this.addToPresence(
+        return this.addOrReplaceInPresence(
             'videomuted',
             {
                 attributes: { 'xmlns': 'http://jitsi.org/jitmeet/video' },
@@ -1556,8 +1566,7 @@ export default class ChatRoom extends Listenable {
      * @param mute
      */
     sendVideoInfoPresence(mute) {
-        this.addVideoInfoToPresence(mute);
-        this.sendPresence();
+        this.addVideoInfoToPresence(mute) && this.sendPresence();
     }
 
     /**

modules/xmpp/Lobby.js

@@ -153,8 +153,7 @@ export default class Lobby {
 
         if (displayName) {
             // remove previously set nickname
-            this.lobbyRoom.removeFromPresence('nick');
-            this.lobbyRoom.addToPresence('nick', {
+            this.lobbyRoom.addOrReplaceInPresence('nick', {
                 attributes: { xmlns: 'http://jabber.org/protocol/nick' },
                 value: displayName
             });
@@ -261,9 +260,8 @@ export default class Lobby {
 
                 // send our email, as we do not handle this on initial presence we need a second one
                 if (email && !isModerator) {
-                    this.lobbyRoom.removeFromPresence(EMAIL_COMMAND);
-                    this.lobbyRoom.addToPresence(EMAIL_COMMAND, { value: email });
-                    this.lobbyRoom.sendPresence();
+                    this.lobbyRoom.addOrReplaceInPresence(EMAIL_COMMAND, { value: email })
+                        && this.lobbyRoom.sendPresence();
                 }
             });
             this.lobbyRoom.addEventListener(XMPPEvents.ROOM_JOIN_ERROR, reject);