Merge pull request #465 from virtuacoplenny/lenny/ie-set-array

fix(stats): lazy initialization for statistics Sets

modules/statistics/CallStats.js

@@ -61,6 +61,12 @@ const reportType = {
     MST_WITH_USERID: 'mstWithUserID'
 };
 
+/**
+ * Set of currently existing {@link CallStats} instances.
+ * @type {Set<CallStats>}
+ */
+let _fabrics;
+
 /**
  * An instance of this class is a wrapper for the CallStats API fabric. A fabric
  * reports one peer connection the the CallStats backend and is allocated with
@@ -300,6 +306,19 @@ export default class CallStats {
         /* eslint-enable max-params */
     }
 
+    /**
+     * Returns the Set with the currently existing {@link CallStats} instances.
+     * Lazily initializes the Set to allow any Set polyfills to be applied.
+     * @type {Set<CallStats>}
+     */
+    static get fabrics() {
+        if (!_fabrics) {
+            _fabrics = new Set();
+        }
+
+        return _fabrics;
+    }
+
     /**
      * Initializes the CallStats backend. Should be called only if
      * {@link CallStats.isBackendInitialized} returns <tt>false</tt>.
@@ -703,9 +722,3 @@ CallStats.callStatsSecret = null;
  * @type {object}
  */
 CallStats.userID = null;
-
-/**
- * Set of currently existing {@link CallStats} instances.
- * @type {Set<CallStats>}
- */
-CallStats.fabrics = new Set();

modules/statistics/statistics.js

@@ -10,6 +10,12 @@ const EventEmitter = require('events');
 const logger = require('jitsi-meet-logger').getLogger(__filename);
 const ScriptUtil = require('../util/ScriptUtil');
 
+/**
+ * Stores all active {@link Statistics} instances.
+ * @type {Set<Statistics>}
+ */
+let _instances;
+
 /**
  * True if callstats API is loaded
  */
@@ -124,11 +130,20 @@ Statistics.audioLevelsInterval = 200;
 Statistics.disableThirdPartyRequests = false;
 Statistics.analytics = analytics;
 
-/**
- * Stores all active {@link Statistics} instances.
- * @type {Set<Statistics>}
- */
-Statistics.instances = new Set();
+Object.defineProperty(Statistics, 'instances', {
+    /**
+     * Returns the Set holding all active {@link Statistics} instances. Lazily
+     * initializes the Set to allow any Set polyfills to be applied.
+     * @type {Set<Statistics>}
+     */
+    get() {
+        if (!_instances) {
+            _instances = new Set();
+        }
+
+        return _instances;
+    }
+});
 
 Statistics.prototype.startRemoteStats = function(peerconnection) {
     this.stopRemoteStats();