feat(RTC) bump minimum supported Chromium version to 72

Cleanup some unused code after the bump.

modules/RTC/RTCUtils.js

@@ -755,56 +755,6 @@ function handleLocalStream(streams, resolution) {
     return res;
 }
 
-/**
- * Represents a default implementation of setting a <tt>MediaStream</tt> as the
- * source of a video element that tries to be browser-agnostic through feature
- * checking. Note though that it was not completely clear from the predating
- * browser-specific implementations what &quot;videoSrc&quot; was because one
- * implementation of {@link RTCUtils#getVideoSrc} would return
- * <tt>MediaStream</tt> (e.g. Firefox), another a <tt>string</tt> representation
- * of the <tt>URL</tt> of the <tt>MediaStream</tt> (e.g. Chrome) and the return
- * value was only used by {@link RTCUIHelper#getVideoId} which itself did not
- * appear to be used anywhere. Generally, the implementation will try to follow
- * the related standards i.e. work with the <tt>srcObject</tt> and <tt>src</tt>
- * properties of the specified <tt>element</tt> taking into account vender
- * prefixes.
- *
- * @param element the element whose video source/src is to be set to the
- * specified <tt>stream</tt>
- * @param {MediaStream} stream the <tt>MediaStream</tt> to set as the video
- * source/src of <tt>element</tt>
- */
-function defaultSetVideoSrc(element, stream) {
-    // srcObject
-    let srcObjectPropertyName = 'srcObject';
-
-    if (!(srcObjectPropertyName in element)) {
-        srcObjectPropertyName = 'mozSrcObject';
-        if (!(srcObjectPropertyName in element)) {
-            srcObjectPropertyName = null;
-        }
-    }
-    if (srcObjectPropertyName) {
-        element[srcObjectPropertyName] = stream;
-
-        return;
-    }
-
-    // src
-    let src;
-
-    if (stream) {
-        src = stream.jitsiObjectURL;
-
-        // Save the created URL for stream so we can reuse it and not keep
-        // creating URLs.
-        if (!src) {
-            stream.jitsiObjectURL = src = URL.createObjectURL(stream);
-        }
-    }
-    element.src = src || '';
-}
-
 /**
  *
  */
@@ -865,22 +815,13 @@ class RTCUtils extends Listenable {
 
             this.getStreamID = ({ id }) => id;
             this.getTrackID = ({ id }) => id;
-        } else if (browser.isChromiumBased() // this is chrome < 61
-                || browser.isReactNative()) {
-
+        } else if (browser.isReactNative()) {
             this.RTCPeerConnectionType = RTCPeerConnection;
 
-            this.attachMediaStream
-                = wrapAttachMediaStream((element, stream) => {
-                    defaultSetVideoSrc(element, stream);
-
-                    return element;
-                });
+            this.attachMediaStream = undefined; // Unused on React Native.
 
             this.getStreamID = function({ id }) {
-                // A. MediaStreams from FF endpoints have the characters '{' and
-                // '}' that make jQuery choke.
-                // B. The react-native-webrtc implementation that we use at the
+                // The react-native-webrtc implementation that we use at the
                 // time of this writing returns a number for the id of
                 // MediaStream. Let's just say that a number contains no special
                 // characters.
@@ -890,17 +831,6 @@ class RTCUtils extends Listenable {
                         : SDPUtil.filterSpecialChars(id));
             };
             this.getTrackID = ({ id }) => id;
-
-            if (!MediaStream.prototype.getVideoTracks) {
-                MediaStream.prototype.getVideoTracks = function() {
-                    return this.videoTracks;
-                };
-            }
-            if (!MediaStream.prototype.getAudioTracks) {
-                MediaStream.prototype.getAudioTracks = function() {
-                    return this.audioTracks;
-                };
-            }
         } else {
             const message = 'Endpoint does not appear to be WebRTC-capable';
 
@@ -1492,14 +1422,6 @@ class RTCUtils extends Listenable {
         if (mediaStream.release) {
             mediaStream.release();
         }
-
-        // if we have done createObjectURL, lets clean it
-        const url = mediaStream.jitsiObjectURL;
-
-        if (url) {
-            delete mediaStream.jitsiObjectURL;
-            URL.revokeObjectURL(url);
-        }
     }
 
     /**

modules/browser/BrowserCapabilities.js

@@ -3,6 +3,9 @@ import { getLogger } from 'jitsi-meet-logger';
 
 const logger = getLogger(__filename);
 
+/* Minimum required Chrome / Chromium version. This applies also to derivatives. */
+const MIN_REQUIRED_CHROME_VERSION = 72;
+
 // TODO: Move this code to js-utils.
 
 // NOTE: Now we are extending BrowserDetection in order to preserve
@@ -76,7 +79,7 @@ export default class BrowserCapabilities extends BrowserDetection {
      * @returns {boolean} true if the browser is supported, false otherwise.
      */
     isSupported() {
-        return this.isChromiumBased()
+        return (this.isChromiumBased() && this._getChromiumBasedVersion() >= MIN_REQUIRED_CHROME_VERSION)
             || this.isFirefox()
             || this.isReactNative()
             || (this.isSafari() && !this.isVersionLessThan('12.1'));
@@ -220,11 +223,9 @@ export default class BrowserCapabilities extends BrowserDetection {
         }
 
         if (this.isSafari() && typeof window.RTCRtpTransceiver !== 'undefined') {
-            // eslint-disable-next-line max-len
             // https://trac.webkit.org/changeset/236144/webkit/trunk/LayoutTests/webrtc/video-addLegacyTransceiver.html
             // eslint-disable-next-line no-undef
-            return Object.keys(RTCRtpTransceiver.prototype)
-                   .indexOf('currentDirection') > -1;
+            return Object.keys(RTCRtpTransceiver.prototype).indexOf('currentDirection') > -1;
         }
 
         return false;
@@ -239,26 +240,16 @@ export default class BrowserCapabilities extends BrowserDetection {
      * @returns {boolean}
      */
     usesNewGumFlow() {
-        const REQUIRED_CHROME_VERSION = 61;
-
-        if (this.isChrome()) {
-            return !this.isVersionLessThan(REQUIRED_CHROME_VERSION);
-        }
-
-        if (this.isFirefox() || this.isSafari()) {
+        if (this.isChromiumBased() || this.isFirefox() || this.isSafari()) {
             return true;
         }
 
-        if (this.isChromiumBased()) {
-            return this._getChromiumBasedVersion() >= REQUIRED_CHROME_VERSION;
-        }
-
         return false;
     }
 
     /**
      * Checks if the browser uses webrtc-adapter. All browsers using the new
-     * getUserMedia flow and Edge.
+     * getUserMedia flow.
      *
      * @returns {boolean}
      */
@@ -328,7 +319,7 @@ export default class BrowserCapabilities extends BrowserDetection {
      * @returns {boolean}
      */
     supportsSdpSemantics() {
-        return this.isChromiumBased() && this._getChromiumBasedVersion() >= 65;
+        return this.isChromiumBased();
     }
 
     /**