feat(jwtError): Send explicit error on auth failed with invalid jwt

modules/xmpp/StropheLastSuccess.js

@@ -7,6 +7,7 @@ export default class LastRequestTracker {
      */
     constructor() {
         this._lastSuccess = null;
+        this._lastFailedMessage = null;
     }
 
     /**
@@ -19,6 +20,12 @@ export default class LastRequestTracker {
         const originalRawInput = stropheConnection.rawInput;
 
         stropheConnection.rawInput = (...args) => {
+            const rawMessage = args[0];
+
+            if (rawMessage.includes('failure')) {
+                this._lastFailedMessage = rawMessage;
+            }
+
             // It's okay to use rawInput callback only once the connection has been established, otherwise it will
             // treat 'item-not-found' or other connection error on websocket reconnect as successful stanza received.
             if (xmppConnection.connected) {
@@ -28,6 +35,15 @@ export default class LastRequestTracker {
         };
     }
 
+    /**
+     * Returns the last raw failed incoming message on the xmpp connection.
+     *
+     * @returns {string|null}
+     */
+    getLastFailedMessage() {
+        return this._lastFailedMessage;
+    }
+
     /**
      * Returns how many milliseconds have passed since the last successful BOSH request.
      *

modules/xmpp/XmppConnection.js

@@ -67,8 +67,8 @@ export default class XmppConnection extends Listenable {
         // The default maxRetries is 5, which is too long.
         this._stropheConn.maxRetries = 3;
 
-        this._lastSuccessTracker = new LastSuccessTracker();
-        this._lastSuccessTracker.startTracking(this, this._stropheConn);
+        this._rawInputTracker = new LastSuccessTracker();
+        this._rawInputTracker.startTracking(this, this._stropheConn);
 
         this._resumeTask = new ResumeTask(this._stropheConn);
 
@@ -348,7 +348,16 @@ export default class XmppConnection extends Listenable {
      * @returns {number|null}
      */
     getTimeSinceLastSuccess() {
-        return this._lastSuccessTracker.getTimeSinceLastSuccess();
+        return this._rawInputTracker.getTimeSinceLastSuccess();
+    }
+
+    /**
+     * See {@link LastRequestTracker.getLastFailedMessage}.
+     *
+     * @returns {string|null}
+     */
+    getLastFailedMessage() {
+        return this._rawInputTracker.getLastFailedMessage();
     }
 
     /**

modules/xmpp/xmpp.js

@@ -23,6 +23,11 @@ import initStropheUtil from './strophe.util';
 
 const logger = getLogger(__filename);
 
+/**
+* Regex to extract exact error message on jwt error.
+*/
+const FAILURE_REGEX = /<failure.*><not-allowed\/><text>(.*)<\/text><\/failure>/gi;
+
 /**
  * Creates XMPP connection.
  *
@@ -403,15 +408,33 @@ export default class XMPP extends Listenable {
                 }
             }
         } else if (status === Strophe.Status.AUTHFAIL) {
+            const lastFailedRawMessage = this.getConnection().getLastFailedMessage();
+
             // wrong password or username, prompt user
             this.eventEmitter.emit(
                 JitsiConnectionEvents.CONNECTION_FAILED,
                 JitsiConnectionErrors.PASSWORD_REQUIRED,
-                msg,
+                msg || this._parseConnectionFailedMessage(lastFailedRawMessage),
                 credentials);
         }
     }
 
+    /**
+    * Parses a raw failure xmpp xml message received on auth failed.
+    *
+    * @param {string} msg - The raw failure message from xmpp.
+    * @returns {string|null} - The parsed message from the raw xmpp message.
+    */
+    _parseConnectionFailedMessage(msg) {
+        if (!msg) {
+            return null;
+        }
+
+        const matches = FAILURE_REGEX.exec(msg);
+
+        return matches ? matches[1] : null;
+    }
+
     /**
      *
      * @param jid