[eslint] prefer-rest-params

.eslintrc.js

@@ -211,6 +211,7 @@ module.exports = {
         ],
         'prefer-const': 2,
         'prefer-reflect': 0,
+        'prefer-rest-params': 2,
         'prefer-spread': 2,
         'prefer-template': 2,
         'require-yield': 2,

JitsiConnection.js

@@ -65,14 +65,12 @@ JitsiConnection.prototype.attach = function(options) {
 /**
  * Disconnect the client from the server.
  */
-JitsiConnection.prototype.disconnect = function() {
+JitsiConnection.prototype.disconnect = function(...args) {
     // XXX Forward any arguments passed to JitsiConnection.disconnect to
     // XMPP.disconnect. For example, the caller of JitsiConnection.disconnect
     // may optionally pass the event which triggered the disconnect in order to
     // provide the implementation with finer-grained context.
-    const x = this.xmpp;
-
-    x.disconnect(...arguments);
+    this.xmpp.disconnect(...args);
 };
 
 /**

JitsiMediaDevices.js

@@ -129,8 +129,8 @@ const JitsiMediaDevices = {
      * Emits an event.
      * @param {string} event - event name
      */
-    emitEvent(event) { // eslint-disable-line no-unused-vars
-        eventEmitter.emit(...arguments);
+    emitEvent(event, ...args) {
+        eventEmitter.emit(event, ...args);
     }
 };
 

modules/RTC/RTCUtils.js

@@ -650,6 +650,7 @@ function handleLocalStream(streams, resolution) {
  */
 function wrapAttachMediaStream(origAttachMediaStream) {
     return function(element, stream) {
+        // eslint-disable-next-line prefer-rest-params
         const res = origAttachMediaStream.apply(rtcUtils, arguments);
 
         if (stream

modules/statistics/CallStats.js

@@ -127,7 +127,7 @@ function initCallback(err, msg) {
 function _try_catch(f) {
     return function() {
         try {
-            f.apply(this, arguments);
+            f.apply(this, arguments); // eslint-disable-line prefer-rest-params
         } catch (e) {
             GlobalOnErrorHandler.callErrorHandler(e);
             logger.error(e);

modules/util/EventEmitterForwarder.js

@@ -22,14 +22,13 @@ function EventEmitterForwarder(src, dest) {
  * @param arguments all other passed arguments are going to be fired with
  * dstEvent.
  */
-EventEmitterForwarder.prototype.forward = function() {
-    // This line is only for fixing jshint errors.
-    const args = arguments;
+EventEmitterForwarder.prototype.forward = function(...args) {
     const srcEvent = args[0];
     // This will be the "this" value for emit function.
     args[0] = this.dest;
     // Using bind.apply to pass the arguments as Array-like object ("arguments")
-    this.src.addListener(srcEvent,
+    this.src.addListener(
+        srcEvent,
         Function.prototype.bind.apply(this.dest.emit, args));
 };