refactor(statistics): Remove unused code

modules/statistics/RTPStatsCollector.js

@@ -67,39 +67,6 @@ function calculatePacketLoss(lostPackets, totalPackets) {
     return Math.round((lostPackets/totalPackets)*100);
 }
 
-/**
- * Checks whether a certain record should be included in the logged statistics.
- */
-function acceptStat(reportId, reportType, statName) {
-    if (reportType == "googCandidatePair") {
-        if (statName == "googChannelId")
-            return false;
-
-    } else if (reportType == "ssrc") {
-        if (statName == "googTrackId" ||
-            statName == "transportId" ||
-            statName == "ssrc")
-            return false;
-    }
-
-    return true;
-}
-
-/**
- * Checks whether a certain record should be included in the logged statistics.
- */
-function acceptReport(id, type) {
-    if (type == "googComponent")
-        return false;
-
-    if (id.substring(0, 15) == "googCertificate" ||
-        id.substring(0, 9) == "googTrack" ||
-        id.substring(0, 20) == "googLibjingleSession")
-        return false;
-
-    return true;
-}
-
 /**
  * Holds "statistics" for a single SSRC.
  * @constructor
@@ -230,24 +197,6 @@ function StatsCollector(
     this.eventEmitter = eventEmitter;
     this.conferenceStats = new ConferenceStats();
 
-    /**
-     * Gather PeerConnection stats once every this many milliseconds.
-     */
-    this.GATHER_INTERVAL = 15000;
-
-    /**
-     * Gather stats and store them in this.statsToBeLogged.
-     */
-    this.gatherStatsIntervalId = null;
-
-    /**
-     * Stores the statistics which will be send to the focus to be logged.
-     */
-    this.statsToBeLogged = {
-        timestamps: [],
-        stats: {}
-    };
-
     // Updates stats interval
     this.audioLevelsIntervalMilis = audioLevelsInterval;
 
@@ -272,11 +221,6 @@ StatsCollector.prototype.stop = function () {
         clearInterval(this.statsIntervalId);
         this.statsIntervalId = null;
     }
-
-    if (this.gatherStatsIntervalId) {
-        clearInterval(this.gatherStatsIntervalId);
-        this.gatherStatsIntervalId = null;
-    }
 };
 
 /**
@@ -353,65 +297,6 @@ StatsCollector.prototype.start = function (startAudioLevelStats) {
             self.statsIntervalMilis
         );
     }
-
-    if (browserSupported
-            // logging statistics does not support firefox
-            && this._browserType !== RTCBrowserType.RTC_BROWSER_FIREFOX) {
-        this.gatherStatsIntervalId = setInterval(
-            function () {
-                self.peerconnection.getStats(
-                    function (report) {
-                        self.addStatsToBeLogged(report.result());
-                    },
-                    function () {
-                    }
-                );
-            },
-            this.GATHER_INTERVAL
-        );
-    }
-};
-
-/**
- * Converts the stats to the format used for logging, and saves the data in
- * this.statsToBeLogged.
- * @param reports Reports as given by webkitRTCPerConnection.getStats.
- */
-StatsCollector.prototype.addStatsToBeLogged = function (reports) {
-    var self = this;
-    var num_records = this.statsToBeLogged.timestamps.length;
-    this.statsToBeLogged.timestamps.push(new Date().getTime());
-    reports.forEach(function (report) {
-        if (!acceptReport(report.id, report.type))
-            return;
-        var stat = self.statsToBeLogged.stats[report.id];
-        if (!stat) {
-            stat = self.statsToBeLogged.stats[report.id] = {};
-        }
-        stat.type = report.type;
-        report.names().forEach(function (name) {
-            if (!acceptStat(report.id, report.type, name))
-                return;
-            var values = stat[name];
-            if (!values) {
-                values = stat[name] = [];
-            }
-            while (values.length < num_records) {
-                values.push(null);
-            }
-            values.push(report.stat(name));
-        });
-    });
-};
-
-StatsCollector.prototype.getCollectedStats = function () {
-    return this.statsToBeLogged;
-};
-
-StatsCollector.prototype.clearCollectedStats = function () {
-   // Reset the stats
-   this.statsToBeLogged.stats = {};
-   this.statsToBeLogged.timestamps = [];
 };
 
 /**

modules/statistics/statistics.js

@@ -58,11 +58,6 @@ function loadAnalytics(customScriptUrl) {
         });
 }
 
-/**
- * Log stats via the focus once every this many milliseconds.
- */
-var LOG_INTERVAL = 60000;
-
 /**
  * callstats strips any additional fields from Error except for "name", "stack",
  * "message" and "constraintName". So we need to bundle additional information
@@ -128,11 +123,6 @@ function Statistics(xmpp, options) {
     // Flag indicates whether or not the CallStats have been started for this
     // Statistics instance
     this.callStatsStarted = false;
-
-    /**
-     * Send the stats already saved in rtpStats to be logged via the focus.
-     */
-    this.logStatsIntervalId = null;
 }
 Statistics.audioLevelsEnabled = false;
 Statistics.audioLevelsInterval = 200;
@@ -157,14 +147,6 @@ Statistics.prototype.startRemoteStats = function (peerconnection) {
         this.rtpStats = null;
         logger.error('Failed to start collecting remote statistics: ' + e);
     }
-    if (this.rtpStats) {
-        this.logStatsIntervalId = setInterval(function () {
-            var stats = this.rtpStats.getCollectedStats();
-            if (this.xmpp.sendLogs(stats)) {
-                this.rtpStats.clearCollectedStats();
-            }
-        }.bind(this), LOG_INTERVAL);
-    }
 };
 
 Statistics.localStats = [];
@@ -233,11 +215,6 @@ Statistics.prototype.stopRemoteStats = function () {
 
     this.rtpStats.stop();
     this.rtpStats = null;
-
-    if (this.logStatsIntervalId) {
-        clearInterval(this.logStatsIntervalId);
-        this.logStatsIntervalId = null;
-    }
 };
 
 //CALSTATS METHODS

modules/xmpp/xmpp.js

@@ -3,7 +3,6 @@
 import { getLogger } from "jitsi-meet-logger";
 const logger = getLogger(__filename);
 import EventEmitter from "events";
-import Pako from "pako";
 import RandomUtil from "../util/RandomUtil";
 import * as JitsiConnectionErrors from "../../JitsiConnectionErrors";
 import * as JitsiConnectionEvents from "../../JitsiConnectionEvents";
@@ -286,36 +285,6 @@ export default class XMPP {
         this.eventEmitter.removeListener(type, listener);
     }
 
-    /**
-     * Sends 'data' as a log message to the focus. Returns true iff a message
-     * was sent.
-     * @param data
-     * @returns {boolean} true iff a message was sent.
-     */
-    sendLogs (data) {
-        if (!this.connection.emuc.focusMucJid)
-            return false;
-
-        const content = Base64.encode(
-            String.fromCharCode.apply(null,
-                Pako.deflateRaw(JSON.stringify(data))));
-        // XEP-0337-ish
-        const message = $msg({
-            to: this.connection.emuc.focusMucJid,
-            type: "normal"
-        });
-        message.c("log", {
-            xmlns: "urn:xmpp:eventlog",
-            id: "PeerConnectionStats"
-        });
-        message.c("message").t(content).up();
-        message.c("tag", {name: "deflated", value: "true"}).up();
-        message.up();
-
-        this.connection.send(message);
-        return true;
-    }
-
     /**
      * Returns the logs from strophe.jingle.
      * @returns {Object}

package.json

@@ -21,7 +21,6 @@
     "events": "*",
     "jitsi-meet-logger": "jitsi/jitsi-meet-logger",
     "jssha": "1.5.0",
-    "pako": "*",
     "retry": "0.6.1",
     "sdp-interop": "0.1.11",
     "sdp-simulcast": "0.1.7",