Browse Source

Remove conference-wide RTX/REMB/TCC/opus-red options. (#1423)

* feat: Make enableRemb signal client remb support.

* feat: Make enableTcc signal client tcc support.

* ref: Remove the enableOpusRed conference-wide option.
dev1
bgrozev 4 years ago
parent
commit
170438b257
No account linked to committer's email address
2 changed files with 7 additions and 22 deletions
  1. 0
    22
      modules/xmpp/moderator.js
  2. 7
    0
      modules/xmpp/xmpp.js

+ 0
- 22
modules/xmpp/moderator.js View File

164
             value: Boolean(config.disableRtx)
164
             value: Boolean(config.disableRtx)
165
         }).up();
165
         }).up();
166
 
166
 
167
-    if (config.enableTcc !== undefined) {
168
-        elem.c(
169
-                'property', {
170
-                    name: 'enableTcc',
171
-                    value: Boolean(config.enableTcc)
172
-                }).up();
173
-    }
174
-    if (config.enableRemb !== undefined) {
175
-        elem.c(
176
-                'property', {
177
-                    name: 'enableRemb',
178
-                    value: Boolean(config.enableRemb)
179
-                }).up();
180
-    }
181
-    if (config.enableOpusRed === true) {
182
-        elem.c(
183
-                'property', {
184
-                    name: 'enableOpusRed',
185
-                    value: true
186
-                }).up();
187
-    }
188
-
189
     if (config.audioPacketDelay !== undefined) {
167
     if (config.audioPacketDelay !== undefined) {
190
         elem.c(
168
         elem.c(
191
             'property', {
169
             'property', {

+ 7
- 0
modules/xmpp/xmpp.js View File

158
             this.caps.addFeature('http://jitsi.org/opus-red');
158
             this.caps.addFeature('http://jitsi.org/opus-red');
159
         }
159
         }
160
 
160
 
161
+        if (typeof this.options.enableRemb === 'undefined' || this.options.enableRemb) {
162
+            this.caps.addFeature('http://jitsi.org/remb');
163
+        }
164
+        if (typeof this.options.enableTcc === 'undefined' || this.options.enableTcc) {
165
+            this.caps.addFeature('http://jitsi.org/tcc');
166
+        }
167
+
161
         // this is dealt with by SDP O/A so we don't need to announce this
168
         // this is dealt with by SDP O/A so we don't need to announce this
162
         // XEP-0293
169
         // XEP-0293
163
         // this.caps.addFeature('urn:xmpp:jingle:apps:rtp:rtcp-fb:0');
170
         // this.caps.addFeature('urn:xmpp:jingle:apps:rtp:rtcp-fb:0');

Loading…
Cancel
Save