Selaa lähdekoodia

fix: remove obsolete warnings

In TraceablePeerConnection: we're no longer injecting a recvonly SSRC
when the local video track is muted, so it's normal that there is no
SSRC found in the local SDP when it's muted.

About RTPStatsCollector: at the time of adding this log statement a case
was missed when local audio track could be replaced in the P2P
connection when a new audio device is selected.
dev1
paweldomas 6 vuotta sitten
vanhempi
commit
1c5fd72b2a

+ 5
- 2
modules/RTC/TraceablePeerConnection.js Näytä tiedosto

@@ -2388,8 +2388,11 @@ TraceablePeerConnection.prototype._processLocalSSRCsMap = function(ssrcMap) {
2388 2388
                     `The local SSRC(${newSSRCNum}) for ${track} ${trackMSID}`
2389 2389
                      + `is still up to date in ${this}`);
2390 2390
             }
2391
-        } else {
2392
-            logger.warn(`No local track matched with: ${trackMSID} in ${this}`);
2391
+        } else if (!track.isVideoTrack() && !track.isMuted()) {
2392
+            // It is normal to find no SSRCs for a muted video track in
2393
+            // the local SDP as the recv-only SSRC is no longer munged in.
2394
+            // So log the warning only if it's not a muted video track.
2395
+            logger.warn(`No SSRCs found in the local SDP for ${track} MSID: ${trackMSID} in ${this}`);
2393 2396
         }
2394 2397
     }
2395 2398
 };

+ 0
- 12
modules/statistics/RTPStatsCollector.js Näytä tiedosto

@@ -815,18 +815,6 @@ StatsCollector.prototype._processAndEmitReport = function() {
815 815
             } else {
816 816
                 logger.error(`No participant ID returned by ${track}`);
817 817
             }
818
-        } else if (this.peerconnection.isP2P) {
819
-            // NOTE For JVB connection there are JVB tracks reported in
820
-            // the stats, but they do not have corresponding JitsiRemoteTrack
821
-            // instances stored in TPC. It is not trivial to figure out that
822
-            // a SSRC belongs to JVB, so we print this error ony for the P2P
823
-            // connection for the time being.
824
-            //
825
-            // Also there will be reports for tracks removed from the session,
826
-            // for the users who have left the conference.
827
-            logger.error(
828
-                `JitsiTrack not found for SSRC ${ssrc}`
829
-                    + ` in ${this.peerconnection}`);
830 818
         }
831 819
 
832 820
         ssrcStats.resetBitrate();

Loading…
Peruuta
Tallenna