feat(CodecSelection) Disable VP9 on Safari. (#1752)

* feat(CodecSelection) Disable VP9 on Safari.
Safari does not decode VP9 properly- https://bugs.webkit.org/show_bug.cgi?id=231071 and https://bugs.webkit.org/show_bug.cgi?id=231074.

* squash move VP9 support check to browser capabilities.

modules/RTC/CodecSelection.js

@@ -47,9 +47,7 @@ export class CodecSelection {
         logger.debug(`Codec preferences for the conference are JVB: ${this.jvbPreferredCodec},
             P2P: ${this.p2pPreferredCodec}`);
 
-        // Do not prefer VP9 on Firefox because of the following bug.
-        // https://bugzilla.mozilla.org/show_bug.cgi?id=1633876
-        if (browser.isFirefox() && this.jvbPreferredCodec === CodecMimeType.VP9) {
+        if (this.jvbPreferredCodec === CodecMimeType.VP9 && !browser.supportsVP9()) {
             this.jvbPreferredCodec = CodecMimeType.VP8;
         }
 
@@ -136,11 +134,9 @@ export class CodecSelection {
                 const peerMediaInfo = session.signalingLayer.getPeerMediaInfo(remote, MediaType.VIDEO);
                 const peerCodec = peerMediaInfo?.codecType;
 
-                // We do not want Firefox to switch to VP9 because of the following bug.
-                // https://bugzilla.mozilla.org/show_bug.cgi?id=1492500.
                 if (peerCodec
                     && peerCodec !== currentCodec
-                    && !(browser.isFirefox() && peerCodec === CodecMimeType.VP9)) {
+                    && (peerCodec !== CodecMimeType.VP9 || browser.supportsVP9())) {
                     selectedCodec = peerCodec;
                 }
             }

modules/browser/BrowserCapabilities.js

@@ -210,6 +210,15 @@ export default class BrowserCapabilities extends BrowserDetection {
         return !this.isFirefox();
     }
 
+    /**
+     * Returns true if VP9 is supported by the client on the browser. VP9 is currently disabled on Firefox and Safari
+     * because of issues with rendering. Please check https://bugzilla.mozilla.org/show_bug.cgi?id=1492500,
+     * https://bugs.webkit.org/show_bug.cgi?id=231071 and https://bugs.webkit.org/show_bug.cgi?id=231074 for details.
+     */
+    supportsVP9() {
+        return this.isChromiumBased() || this.isReactNative();
+    }
+
     /**
      * Checks if the browser uses SDP munging for turning on simulcast.
      *

package-lock.json

@@ -9370,6 +9370,7 @@
     },
     "@jitsi/sdp-interop": {
       "version": "git+ssh://git@github.com/jitsi/sdp-interop.git#4669790bb9020cc8f10c1d1f3823c26b08497547",
+      "integrity": "sha512-4nqEqJWyRFjHM/riI0DQRNx+mgx277iK0r5LhwVAHDZDBYbLN54vYcfZ6JepcmygQiixa8jet/gLJnikdH9wzQ==",
       "from": "@jitsi/sdp-interop@github:jitsi/sdp-interop#4669790bb9020cc8f10c1d1f3823c26b08497547",
       "requires": {
         "lodash.clonedeep": "4.5.0",
@@ -10822,6 +10823,7 @@
     },
     "eslint-config-jitsi": {
       "version": "git+ssh://git@github.com/jitsi/eslint-config-jitsi.git#974ab743dde38bf2207ad4ea5e4e89cfb98517b1",
+      "integrity": "sha512-8GoxyUSAovN1wsxMUDzaePTBOS/Lw5YMIWFXYRGwAyIltJmtCTmoFTkW/59UEecwVNYYfhP30qHWFrM3LavPLQ==",
       "dev": true,
       "from": "eslint-config-jitsi@github:jitsi/eslint-config-jitsi#974ab743dde38bf2207ad4ea5e4e89cfb98517b1",
       "requires": {}
@@ -11840,6 +11842,7 @@
     },
     "jitsi-meet-logger": {
       "version": "git+ssh://git@github.com/jitsi/jitsi-meet-logger.git#4add5bac2e4cea73a05f42b7596ee03c7f7a2567",
+      "integrity": "sha512-1WC//tMrc8lAxfldhEYFxk8EZuHwBcJgy+QDzd9E7ZJCCm5r+aUYshnx69PLwcbf7iLfKPhcuCKz8FOJRpBdXg==",
       "from": "jitsi-meet-logger@github:jitsi/jitsi-meet-logger#v1.0.0"
     },
     "js-levenshtein": {
@@ -13613,6 +13616,7 @@
     },
     "strophejs-plugin-stream-management": {
       "version": "git+ssh://git@github.com/jitsi/strophejs-plugin-stream-management.git#001cf02bef2357234e1ac5d163611b4d60bf2b6a",
+      "integrity": "sha512-ijQSXeEEmGl4dfLx8RcQDCvzg1UPtEArowaCHZr8ITdBOH/X6JxxGzy/DVeMLVSvSy73tH7pGK6iPjBqQajwdQ==",
       "from": "strophejs-plugin-stream-management@github:jitsi/strophejs-plugin-stream-management#001cf02bef2357234e1ac5d163611b4d60bf2b6a",
       "requires": {}
     },