[eslint] yoda

.eslintrc.js

@@ -128,6 +128,7 @@ module.exports = {
         'no-with': 2,
         'vars-on-top': 2,
         'wrap-iife': [ 'error', 'inside' ],
+        'yoda': 2,
 
         // Strict Mode group
         'strict': 2,

modules/RTC/DataChannels.js

@@ -84,10 +84,10 @@ DataChannels.prototype.onDataChannel = function(event) {
                 dataChannel,
                 e);
         }
-        if (('undefined' !== typeof obj) && (null !== obj)) {
+        if ((typeof obj !== 'undefined') && (obj !== null)) {
             const colibriClass = obj.colibriClass;
 
-            if ('DominantSpeakerEndpointChangeEvent' === colibriClass) {
+            if (colibriClass === 'DominantSpeakerEndpointChangeEvent') {
                 // Endpoint ID from the Videobridge.
                 const dominantSpeakerEndpoint = obj.dominantSpeakerEndpoint;
 
@@ -96,7 +96,7 @@ DataChannels.prototype.onDataChannel = function(event) {
                     dominantSpeakerEndpoint);
                 self.eventEmitter.emit(RTCEvents.DOMINANT_SPEAKER_CHANGED,
                   dominantSpeakerEndpoint);
-            } else if ('InLastNChangeEvent' === colibriClass) {
+            } else if (colibriClass === 'InLastNChangeEvent') {
                 let oldValue = obj.oldValue;
                 let newValue = obj.newValue;
 
@@ -119,7 +119,7 @@ DataChannels.prototype.onDataChannel = function(event) {
                 }
 
                 self.eventEmitter.emit(RTCEvents.LASTN_CHANGED, oldValue, newValue);
-            } else if ('LastNEndpointsChangeEvent' === colibriClass) {
+            } else if (colibriClass === 'LastNEndpointsChangeEvent') {
                 // The new/latest list of last-n endpoint IDs.
                 const lastNEndpoints = obj.lastNEndpoints;
                 // The list of endpoint IDs which are entering the list of
@@ -132,11 +132,11 @@ DataChannels.prototype.onDataChannel = function(event) {
                     lastNEndpoints, endpointsEnteringLastN, obj);
                 self.eventEmitter.emit(RTCEvents.LASTN_ENDPOINT_CHANGED,
                     lastNEndpoints, endpointsEnteringLastN, obj);
-            } else if('EndpointMessage' === colibriClass) {
+            } else if(colibriClass === 'EndpointMessage') {
                 self.eventEmitter.emit(
                     RTCEvents.ENDPOINT_MESSAGE_RECEIVED, obj.from,
                     obj.msgPayload);
-            } else if ('EndpointConnectivityStatusChangeEvent' === colibriClass) {
+            } else if (colibriClass === 'EndpointConnectivityStatusChangeEvent') {
                 const endpoint = obj.endpoint;
                 const isActive = obj.active === 'true';
 

modules/RTC/JitsiLocalTrack.js

@@ -558,7 +558,7 @@ JitsiLocalTrack.prototype._setByteSent = function(bytesSent) {
     const iceConnectionState
         = this.conference ? this.conference.getConnectionState() : null;
 
-    if(this._testByteSent && 'connected' === iceConnectionState) {
+    if(this._testByteSent && iceConnectionState === 'connected') {
         setTimeout(() => {
             if(this._bytesSent <= 0) {
                 // we are not receiving anything from the microphone

modules/xmpp/JingleSessionPC.js

@@ -1412,7 +1412,7 @@ export default class JingleSessionPC extends JingleSession {
             }
 
             error.source = null;
-            if (request && 'function' == typeof request.tree) {
+            if (request && typeof request.tree === 'function') {
                 error.source = request.tree();
             }
 

modules/xmpp/moderator.js

@@ -161,7 +161,7 @@ Moderator.prototype.createConferenceIq = function() {
     elem.c(
         'property', {
             name: 'enableLipSync',
-            value: false !== this.options.connection.enableLipSync
+            value: this.options.connection.enableLipSync !== false
         }).up();
     if (this.options.conference.audioPacketDelay !== undefined) {
         elem.c(
@@ -390,7 +390,7 @@ Moderator.prototype._allocateConferenceFocusSuccess = function(
     // Reset the error timeout (because we haven't failed here).
     this.getNextErrorTimeout(true);
     // eslint-disable-next-line newline-per-chained-call
-    if ('true' === $(result).find('conference').attr('ready')) {
+    if ($(result).find('conference').attr('ready') === 'true') {
         // Reset the non-error timeout (because we've succeeded here).
         this.getNextTimeout(true);
         // Exec callback

modules/xmpp/strophe.jingle.js

@@ -48,7 +48,7 @@ class JingleConnectionPlugin extends ConnectionPlugin {
         logger.log(`on jingle ${action} from ${fromJid}`, iq);
         let sess = this.sessions[sid];
 
-        if ('session-initiate' != action) {
+        if (action != 'session-initiate') {
             if (!sess) {
                 ack.attrs({ type: 'error' });
                 ack.c('error', {type: 'cancel'})

modules/xmpp/xmpp.js

@@ -83,7 +83,7 @@ export default class XMPP extends Listenable {
         // this.caps.addFeature('urn:ietf:rfc:5576'); // a=ssrc
 
         // Enable Lipsync ?
-        if (RTCBrowserType.isChrome() && false !== this.options.enableLipSync) {
+        if (RTCBrowserType.isChrome() && this.options.enableLipSync !== false) {
             logger.info('Lip-sync enabled !');
             this.caps.addFeature('http://jitsi.org/meet/lipsync');
         }