Depending on the type of browser within which the library is executing, we take the decision how many times to call getUserMedia (e.g. once for audio and once for video on Firefox). Upon getting a result of the call, we used to perform similar browser type checks. I see this as repetition of logic which makes it difficult to add new browser types (e.g. React Native). Try to examine the result of the call to getUserMedia and thus avoid re-checkign the browser type.dev1
|
|
||
| 467 |
|
467 |
|
| 468 |
|
468 |
|
| 469 |
|
469 |
|
| 470 |
|
|
|
| 471 |
|
|
|
| 472 |
|
|
|
|
470 |
|
|
|
471 |
|
|
|
472 |
|
|
|
473 |
|
|
|
474 |
|
|
|
475 |
|
|
|
476 |
|
|
|
477 |
|
|
|
478 |
|
|
|
479 |
|
|
|
480 |
|
|
| 473 |
|
481 |
|
| 474 |
|
482 |
|
| 475 |
|
483 |
|
|
|
||
| 487 |
|
495 |
|
| 488 |
|
496 |
|
| 489 |
|
497 |
|
|
498 |
|
|
|
499 |
|
|
|
500 |
|
|
|
501 |
|
|
|
502 |
|
|
|
503 |
|
|
| 490 |
|
504 |
|
| 491 |
|
|
|
| 492 |
|
|
|
| 493 |
|
|
|
| 494 |
|
|
|
| 495 |
|
|
|
| 496 |
|
|
|
| 497 |
|
|
|
| 498 |
|
|
|
| 499 |
|
|
|
| 500 |
|
|
|
| 501 |
|
|
|
| 502 |
|
|
|
| 503 |
|
|
|
|
505 |
|
|
|
506 |
|
|
| 504 |
|
507 |
|
| 505 |
|
508 |
|
| 506 |
|
|
|
|
509 |
|
|
| 507 |
|
510 |
|
| 508 |
|
511 |
|
| 509 |
|
512 |
|
| 510 |
|
513 |
|
| 511 |
|
514 |
|
| 512 |
|
515 |
|
| 513 |
|
|
|
| 514 |
|
|
|
|
516 |
|
|
|
517 |
|
|
| 515 |
|
518 |
|
| 516 |
|
519 |
|
| 517 |
|
520 |
|
| 518 |
|
521 |
|
| 519 |
|
522 |
|
| 520 |
|
523 |
|
| 521 |
|
|
|
| 522 |
|
|
|
|
524 |
|
|
|
525 |
|
|
| 523 |
|
526 |
|
| 524 |
|
527 |
|
| 525 |
|
528 |
|
|
|
||
| 527 |
|
530 |
|
| 528 |
|
531 |
|
| 529 |
|
532 |
|
|
533 |
|
|
| 530 |
|
534 |
|
| 531 |
|
535 |
|
| 532 |
|
536 |
|