Explorar el Código

Merge pull request #581 from jitsi/rn-callstats

[RN] Fixes problem with CallStats on mobile
dev1
Saúl Ibarra Corretgé hace 8 años
padre
commit
360ffde341
Se han modificado 2 ficheros con 8 adiciones y 3 borrados
  1. 7
    2
      modules/statistics/CallStats.js
  2. 1
    1
      package.json

+ 7
- 2
modules/statistics/CallStats.js Ver fichero

288
                 // to not log the whole log batch
288
                 // to not log the whole log batch
289
                 // FIXME check the current logging level (currently not exposed
289
                 // FIXME check the current logging level (currently not exposed
290
                 // by the logger implementation)
290
                 // by the logger implementation)
291
-                console && console.debug('reportError', pc, cs, type);
291
+                // NOTE it is not safe to log whole objects on react-native as
292
+                // those contain too many circular references and may crash
293
+                // the app.
294
+                if (!RTCBrowserType.isReactNative()) {
295
+                    console && console.debug('reportError', pc, cs, type);
296
+                }
292
             } else {
297
             } else {
293
                 logger.debug('reportError', pc, cs, type, ...args);
298
                 logger.debug('reportError', pc, cs, type, ...args);
294
             }
299
             }
506
      * @return {boolean} true if the call was successful or false otherwise.
511
      * @return {boolean} true if the call was successful or false otherwise.
507
      */
512
      */
508
     _addNewFabric() {
513
     _addNewFabric() {
509
-        logger.info('addNewFabric', this.remoteUserID, this);
514
+        logger.info('addNewFabric', this.remoteUserID);
510
         try {
515
         try {
511
             const ret
516
             const ret
512
                 = CallStats.backend.addNewFabric(
517
                 = CallStats.backend.addNewFabric(

+ 1
- 1
package.json Ver fichero

19
     "async": "0.9.0",
19
     "async": "0.9.0",
20
     "current-executing-script": "0.1.3",
20
     "current-executing-script": "0.1.3",
21
     "jitsi-meet-logger": "jitsi/jitsi-meet-logger",
21
     "jitsi-meet-logger": "jitsi/jitsi-meet-logger",
22
-    "react-native-callstats": "3.19.8",
22
+    "react-native-callstats": "3.23.0",
23
     "retry": "0.6.1",
23
     "retry": "0.6.1",
24
     "sdp-interop": "0.1.12",
24
     "sdp-interop": "0.1.12",
25
     "sdp-simulcast": "0.2.1",
25
     "sdp-simulcast": "0.2.1",

Loading…
Cancelar
Guardar