Przeglądaj źródła

Add jsdocs and optimize

dev1
Lyubomir Marinov 9 lat temu
rodzic
commit
3b4351a3cf
2 zmienionych plików z 27 dodań i 13 usunięć
  1. 13
    3
      JitsiConference.js
  2. 14
    10
      modules/RTC/RTC.js

+ 13
- 3
JitsiConference.js Wyświetl plik

629
     this.eventEmitter.emit(JitsiConferenceEvents.DISPLAY_NAME_CHANGED, id, displayName);
629
     this.eventEmitter.emit(JitsiConferenceEvents.DISPLAY_NAME_CHANGED, id, displayName);
630
 };
630
 };
631
 
631
 
632
+/**
633
+ * Notifies this JitsiConference that a JitsiRemoteTrack was added (into the
634
+ * ChatRoom of this JitsiConference).
635
+ *
636
+ * @param {JitsiRemoteTrack} track the JitsiRemoteTrack which was added to this
637
+ * JitsiConference
638
+ */
632
 JitsiConference.prototype.onTrackAdded = function (track) {
639
 JitsiConference.prototype.onTrackAdded = function (track) {
633
     var id = track.getParticipantId();
640
     var id = track.getParticipantId();
634
     var participant = this.getParticipantById(id);
641
     var participant = this.getParticipantById(id);
636
         return;
643
         return;
637
     }
644
     }
638
 
645
 
639
-    // add track to JitsiParticipant
646
+    // Add track to JitsiParticipant.
640
     participant._tracks.push(track);
647
     participant._tracks.push(track);
641
 
648
 
642
     var emitter = this.eventEmitter;
649
     var emitter = this.eventEmitter;
649
     track.addEventListener(
656
     track.addEventListener(
650
         JitsiTrackEvents.TRACK_AUDIO_LEVEL_CHANGED,
657
         JitsiTrackEvents.TRACK_AUDIO_LEVEL_CHANGED,
651
         function (audioLevel) {
658
         function (audioLevel) {
652
-            emitter.emit(JitsiConferenceEvents.TRACK_AUDIO_LEVEL_CHANGED, id, audioLevel);
659
+            emitter.emit(
660
+                JitsiConferenceEvents.TRACK_AUDIO_LEVEL_CHANGED,
661
+                id,
662
+                audioLevel);
653
         }
663
         }
654
     );
664
     );
655
 
665
 
656
-    this.eventEmitter.emit(JitsiConferenceEvents.TRACK_ADDED, track);
666
+    emitter.emit(JitsiConferenceEvents.TRACK_ADDED, track);
657
 };
667
 };
658
 
668
 
659
 JitsiConference.prototype.updateDTMFSupport = function () {
669
 JitsiConference.prototype.updateDTMFSupport = function () {

+ 14
- 10
modules/RTC/RTC.js Wyświetl plik

43
     this.options = options || {};
43
     this.options = options || {};
44
     room.addPresenceListener("videomuted", function (values, from) {
44
     room.addPresenceListener("videomuted", function (values, from) {
45
         var videoTrack = self.getRemoteVideoTrack(from);
45
         var videoTrack = self.getRemoteVideoTrack(from);
46
-        if (!videoTrack) {
47
-            return;
46
+        if (videoTrack) {
47
+            videoTrack.setMute(values.value == "true");
48
         }
48
         }
49
-        videoTrack.setMute(values.value == "true");
50
     });
49
     });
51
     room.addPresenceListener("audiomuted", function (values, from) {
50
     room.addPresenceListener("audiomuted", function (values, from) {
52
         var audioTrack = self.getRemoteAudioTrack(from);
51
         var audioTrack = self.getRemoteAudioTrack(from);
242
     }
241
     }
243
 };
242
 };
244
 
243
 
244
+/**
245
+ * Initializes a new JitsiRemoteTrack instance with the data provided by (a)
246
+ * ChatRoom to XMPPEvents.REMOTE_TRACK_ADDED.
247
+ *
248
+ * @param {Object} event the data provided by (a) ChatRoom to
249
+ * XMPPEvents.REMOTE_TRACK_ADDED to (a)
250
+ */
245
 RTC.prototype.createRemoteTrack = function (event) {
251
 RTC.prototype.createRemoteTrack = function (event) {
246
     var ownerJid = event.owner;
252
     var ownerJid = event.owner;
247
     var remoteTrack = new JitsiRemoteTrack(
253
     var remoteTrack = new JitsiRemoteTrack(
248
         this,  ownerJid, event.stream,    event.track,
254
         this,  ownerJid, event.stream,    event.track,
249
         event.mediaType, event.videoType, event.ssrc, event.muted);
255
         event.mediaType, event.videoType, event.ssrc, event.muted);
250
     var resource = Strophe.getResourceFromJid(ownerJid);
256
     var resource = Strophe.getResourceFromJid(ownerJid);
251
-    if(!this.remoteTracks[resource]) {
252
-        this.remoteTracks[resource] = {};
253
-    }
257
+    var remoteTracks
258
+        = this.remoteTracks[resource] || (this.remoteTracks[resource] = {});
254
     var mediaType = remoteTrack.getType();
259
     var mediaType = remoteTrack.getType();
255
-    if (this.remoteTracks[resource][mediaType]) {
256
-        logger.warn(
257
-            "Overwriting remote track !", resource, mediaType);
260
+    if (remoteTracks[mediaType]) {
261
+        logger.warn("Overwriting remote track!", resource, mediaType);
258
     }
262
     }
259
-    this.remoteTracks[resource][mediaType] = remoteTrack;
263
+    remoteTracks[mediaType] = remoteTrack;
260
     return remoteTrack;
264
     return remoteTrack;
261
 };
265
 };
262
 
266
 

Ładowanie…
Anuluj
Zapisz