fix: Skips sending an extra presence on join. (#1174)

* fix: Skips sending an extra presence on join.

* Renames the variable names.

JitsiConference.js

@@ -839,9 +839,6 @@ JitsiConference.prototype.removeCommand = function(name) {
  */
 JitsiConference.prototype.setDisplayName = function(name) {
     if (this.room) {
-        // remove previously set nickname
-        this.room.removeFromPresence('nick');
-
         this.room.addToPresence('nick', {
             attributes: { xmlns: 'http://jabber.org/protocol/nick' },
             value: name
@@ -2304,7 +2301,6 @@ JitsiConference.prototype.setStartMutedPolicy = function(policy) {
         return;
     }
     this.startMutedPolicy = policy;
-    this.room.removeFromPresence('startmuted');
     this.room.addToPresence('startmuted', {
         attributes: {
             audio: policy.audio,

modules/xmpp/ChatRoom.js

@@ -162,6 +162,8 @@ export default class ChatRoom extends Listenable {
                 }
             });
         }
+
+        this.presenceUpdateTime = Date.now();
     }
 
     /**
@@ -223,6 +225,10 @@ export default class ChatRoom extends Listenable {
         }
 
         parser.json2packet(this.presMap.nodes, pres);
+
+        // we store time we last synced presence state
+        this.presenceSyncTime = Date.now();
+
         this.connection.send(pres);
         if (fromJoin) {
             // XXX We're pressed for time here because we're beginning a complex
@@ -518,7 +524,10 @@ export default class ChatRoom extends Listenable {
 
                 // Re-send presence in case any presence updates were added,
                 // but blocked from sending, during the join process.
-                this.sendPresence();
+                // send the presence only if there was a modification after we had synced it
+                if (this.presenceUpdateTime >= this.presenceSyncTime) {
+                    this.sendPresence();
+                }
 
                 this.eventEmitter.emit(XMPPEvents.MUC_JOINED);
 
@@ -1143,7 +1152,7 @@ export default class ChatRoom extends Listenable {
     /* eslint-enable max-params */
 
     /**
-     *
+     * Adds the key to the presence map, overriding any previous value.
      * @param key
      * @param values
      */
@@ -1151,10 +1160,11 @@ export default class ChatRoom extends Listenable {
         values.tagName = key;
         this.removeFromPresence(key);
         this.presMap.nodes.push(values);
+        this.presenceUpdateTime = Date.now();
     }
 
     /**
-     * Retreives a value from the presence map.
+     * Retrieves a value from the presence map.
      *
      * @param {string} key - The key to find the value for.
      * @returns {Object?}
@@ -1164,13 +1174,14 @@ export default class ChatRoom extends Listenable {
     }
 
     /**
-     *
+     * Removes a key from the presence map.
      * @param key
      */
     removeFromPresence(key) {
         const nodes = this.presMap.nodes.filter(node => key !== node.tagName);
 
         this.presMap.nodes = nodes;
+        this.presenceUpdateTime = Date.now();
     }
 
     /**
@@ -1275,7 +1286,6 @@ export default class ChatRoom extends Listenable {
      * @param mute
      */
     addAudioInfoToPresence(mute) {
-        this.removeFromPresence('audiomuted');
         this.addToPresence(
             'audiomuted',
             {
@@ -1304,7 +1314,6 @@ export default class ChatRoom extends Listenable {
      * @param mute
      */
     addVideoInfoToPresence(mute) {
-        this.removeFromPresence('videomuted');
         this.addToPresence(
             'videomuted',
             {