Sfoglia il codice sorgente

fix(video-quality): do not disable encodings when sender constraints are not configured on the conference.

Fixes https://github.com/jitsi/lib-jitsi-meet/issues/1333 in applications that use lib-jitsi-meet and do not have layer suspension enabled.
dev1
Jaya Allamsetty 5 anni fa
parent
commit
400ab682be
1 ha cambiato i file con 7 aggiunte e 0 eliminazioni
  1. 7
    0
      modules/RTC/TraceablePeerConnection.js

+ 7
- 0
modules/RTC/TraceablePeerConnection.js Vedi File

@@ -2278,6 +2278,13 @@ TraceablePeerConnection.prototype.setSenderVideoConstraint = function(frameHeigh
2278 2278
 
2279 2279
     this.senderVideoMaxHeight = newHeight;
2280 2280
 
2281
+    // If layer suspension is disabled and sender constraint is not configured for the conference,
2282
+    // resolve here so that the encodings stay enabled. This can happen in custom apps built using
2283
+    // lib-jitsi-meet.
2284
+    if (newHeight === null) {
2285
+        return Promise.resolve();
2286
+    }
2287
+
2281 2288
     logger.log(`${this} senderVideoMaxHeight: ${newHeight}`);
2282 2289
 
2283 2290
     const localVideoTrack = this.getLocalVideoTrack();

Loading…
Annulla
Salva