Browse Source

fix(SignalingLayer): Skip checking for last presence if the client doesn't join muc.

* fix(SignalingLayer): Skip checking for last presence if the client doesn't join muc.
This fixes the broken wireless screensharing issue on spot clients.

* squash: change log message to a warning.
dev1
Jaya Allamsetty 2 years ago
parent
commit
462996fc2b
No account linked to committer's email address
1 changed files with 8 additions and 6 deletions
  1. 8
    6
      modules/xmpp/SignalingLayerImpl.js

+ 8
- 6
modules/xmpp/SignalingLayerImpl.js View File

301
             if (this.chatRoom) {
301
             if (this.chatRoom) {
302
                 return this.chatRoom.getMediaPresenceInfo(owner, mediaType);
302
                 return this.chatRoom.getMediaPresenceInfo(owner, mediaType);
303
             }
303
             }
304
-            logger.error('Requested peer media info, before room was set');
304
+            logger.warn('Requested peer media info, before room was set');
305
         };
305
         };
306
-        const lastPresence = this.chatRoom.getLastPresence(owner);
307
-
308
-        if (!lastPresence) {
309
-            throw new Error(`getPeerMediaInfo - no presence stored for: ${owner}`);
310
-        }
311
 
306
 
312
         if (FeatureFlags.isSourceNameSignalingEnabled()) {
307
         if (FeatureFlags.isSourceNameSignalingEnabled()) {
308
+            const lastPresence = this.chatRoom?.getLastPresence(owner);
309
+
310
+            if (!lastPresence) {
311
+                logger.warn(`getPeerMediaInfo - no presence stored for: ${owner}`);
312
+
313
+                return;
314
+            }
313
             if (!this._doesEndpointSendNewSourceInfo(owner)) {
315
             if (!this._doesEndpointSendNewSourceInfo(owner)) {
314
                 return legacyGetPeerMediaInfo();
316
                 return legacyGetPeerMediaInfo();
315
             }
317
             }

Loading…
Cancel
Save