Merge pull request #309 from jitsi/fix_jitsi_track_error

Fixes instanceof JitsiTrackError

JitsiTrackError.js

@@ -29,109 +29,111 @@ TRACK_ERROR_TO_MESSAGE_MAP[JitsiTrackErrors.TRACK_MUTE_UNMUTE_IN_PROGRESS]
 TRACK_ERROR_TO_MESSAGE_MAP[JitsiTrackErrors.NO_DATA_FROM_SOURCE]
     = "The track has stopped receiving data from it's source";
 
+
+// FIXME: Using prototype inheritance because otherwise instanceof is not
+// working properly (see https://github.com/babel/babel/issues/3083)
+
 /**
+ *
  * Represents an error that occurred to a JitsiTrack. Can represent various
  * types of errors. For error descriptions (@see JitsiTrackErrors).
  *
  * @extends Error
+ *
+ *
+ * @constructor
+ * @param {Object|string} error - error object or error name
+ * @param {Object|string} (options) - getUserMedia constraints object or
+ * error message
+ * @param {('audio'|'video'|'desktop'|'screen'|'audiooutput')[]} (devices) -
+ * list of getUserMedia requested devices
  */
-export default class JitsiTrackError extends Error {
-    /**
-     * Initializes a new JitsiTrackError instance.
-     *
-     * @constructor
-     * @param {Object|string} error - error object or error name
-     * @param {Object|string} (options) - getUserMedia constraints object or
-     * error message
-     * @param {('audio'|'video'|'desktop'|'screen'|'audiooutput')[]} (devices) -
-     * list of getUserMedia requested devices
-     */
-    constructor(error, options, devices) {
-        super();
+function JitsiTrackError(error, options, devices) {
+    if (typeof error === "object" && typeof error.name !== "undefined") {
+        /**
+         * Additional information about original getUserMedia error
+         * and constraints.
+         * @type {{
+         *     error: Object,
+         *     constraints: Object,
+         *     devices: Array.<'audio'|'video'|'desktop'|'screen'>
+         * }}
+         */
+        this.gum = {
+            error,
+            constraints: options,
+            devices: devices && Array.isArray(devices)
+                ? devices.slice(0)
+                : undefined
+        };
 
-        if (typeof error === "object" && typeof error.name !== "undefined") {
-            /**
-             * Additional information about original getUserMedia error
-             * and constraints.
-             * @type {{
-             *     error: Object,
-             *     constraints: Object,
-             *     devices: Array.<'audio'|'video'|'desktop'|'screen'>
-             * }}
-             */
-            this.gum = {
-                error,
-                constraints: options,
-                devices: devices && Array.isArray(devices)
-                    ? devices.slice(0)
-                    : undefined
-            };
+        switch (error.name) {
+        case "PermissionDeniedError":
+        case "SecurityError":
+            this.name = JitsiTrackErrors.PERMISSION_DENIED;
+            this.message
+                = TRACK_ERROR_TO_MESSAGE_MAP[this.name]
+                    + (this.gum.devices || []).join(", ");
+            break;
+        case "DevicesNotFoundError":
+        case "NotFoundError":
+            this.name = JitsiTrackErrors.NOT_FOUND;
+            this.message
+                = TRACK_ERROR_TO_MESSAGE_MAP[this.name]
+                    + (this.gum.devices || []).join(", ");
+            break;
+        case "ConstraintNotSatisfiedError":
+        case "OverconstrainedError":
+            var constraintName = error.constraintName;
 
-            switch (error.name) {
-            case "PermissionDeniedError":
-            case "SecurityError":
-                this.name = JitsiTrackErrors.PERMISSION_DENIED;
+            if (options
+                    && options.video
+                    && (!devices || devices.indexOf('video') > -1)
+                    && (constraintName === "minWidth"
+                        || constraintName === "maxWidth"
+                        || constraintName === "minHeight"
+                        || constraintName === "maxHeight"
+                        || constraintName === "width"
+                        || constraintName === "height")) {
+                this.name = JitsiTrackErrors.UNSUPPORTED_RESOLUTION;
                 this.message
                     = TRACK_ERROR_TO_MESSAGE_MAP[this.name]
-                        + (this.gum.devices || []).join(", ");
-                break;
-            case "DevicesNotFoundError":
-            case "NotFoundError":
-                this.name = JitsiTrackErrors.NOT_FOUND;
+                        + getResolutionFromFailedConstraint(
+                                constraintName,
+                                options);
+            } else {
+                this.name = JitsiTrackErrors.CONSTRAINT_FAILED;
                 this.message
                     = TRACK_ERROR_TO_MESSAGE_MAP[this.name]
-                        + (this.gum.devices || []).join(", ");
-                break;
-            case "ConstraintNotSatisfiedError":
-            case "OverconstrainedError":
-                var constraintName = error.constraintName;
-
-                if (options
-                        && options.video
-                        && (!devices || devices.indexOf('video') > -1)
-                        && (constraintName === "minWidth"
-                            || constraintName === "maxWidth"
-                            || constraintName === "minHeight"
-                            || constraintName === "maxHeight"
-                            || constraintName === "width"
-                            || constraintName === "height")) {
-                    this.name = JitsiTrackErrors.UNSUPPORTED_RESOLUTION;
-                    this.message
-                        = TRACK_ERROR_TO_MESSAGE_MAP[this.name]
-                            + getResolutionFromFailedConstraint(
-                                    constraintName,
-                                    options);
-                } else {
-                    this.name = JitsiTrackErrors.CONSTRAINT_FAILED;
-                    this.message
-                        = TRACK_ERROR_TO_MESSAGE_MAP[this.name]
-                            + error.constraintName;
-                }
-                break;
-            default:
-                this.name = JitsiTrackErrors.GENERAL;
-                this.message
-                    = error.message || TRACK_ERROR_TO_MESSAGE_MAP[this.name];
-                break;
-            }
-        } else if (typeof error === "string") {
-            if (TRACK_ERROR_TO_MESSAGE_MAP[error]) {
-                this.name = error;
-                this.message = options || TRACK_ERROR_TO_MESSAGE_MAP[error];
-            } else {
-                // this is some generic error that do not fit any of our
-                // pre-defined errors, so don't give it any specific name, just
-                // store message
-                this.message = error;
+                        + error.constraintName;
             }
+            break;
+        default:
+            this.name = JitsiTrackErrors.GENERAL;
+            this.message
+                = error.message || TRACK_ERROR_TO_MESSAGE_MAP[this.name];
+            break;
+        }
+    } else if (typeof error === "string") {
+        if (TRACK_ERROR_TO_MESSAGE_MAP[error]) {
+            this.name = error;
+            this.message = options || TRACK_ERROR_TO_MESSAGE_MAP[error];
         } else {
-            throw new Error("Invalid arguments");
+            // this is some generic error that do not fit any of our
+            // pre-defined errors, so don't give it any specific name, just
+            // store message
+            this.message = error;
         }
-
-        this.stack = error.stack || (new Error()).stack;
+    } else {
+        throw new Error("Invalid arguments");
     }
+
+    this.stack = error.stack || (new Error()).stack;
 }
 
+JitsiTrackError.prototype = Object.create(Error.prototype);
+ JitsiTrackError.prototype.constructor = JitsiTrackError;
+
 /**
  * Gets failed resolution constraint from corresponding object.
  * @param {string} failedConstraintName
@@ -152,3 +154,5 @@ function getResolutionFromFailedConstraint(failedConstraintName, constraints) {
 
     return "";
 }
+
+export default JitsiTrackError;