fix(eslint): Add no-loop-func rule

.eslintrc.js

@@ -97,6 +97,7 @@ module.exports = {
         'no-iterator': 2,
         'no-labels': 2,
         'no-lone-blocks': 2,
+        'no-loop-func': 2,
         'no-magic-numbers': 0,
         'no-multi-spaces': 2,
         'no-multi-str': 2,

modules/connectivity/ConnectionQuality.js

@@ -89,8 +89,10 @@ function getTarget(simulcast, resolution, millisSinceStart) {
             // Sum the target fields from all simulcast layers for the given
             // resolution (e.g. 720p + 360p + 180p).
             for (height = simulcastFormat.height; height >= 180; height /= 2) {
+                const targetHeight = height;
+
                 simulcastFormat
-                    = kSimulcastFormats.find(f => f.height == height);
+                    = kSimulcastFormats.find(f => f.height == targetHeight);
                 if (simulcastFormat) {
                     target += simulcastFormat.target;
                 } else {

modules/transcription/transcriber.js

@@ -191,13 +191,10 @@ transcriber.prototype.merge = function() {
     arrays.forEach(array => pushWordToSortedArray(potentialWords, array));
 
     // keep adding words to transcription until all arrays are exhausted
-    let lowestWordArray;
-    let wordToAdd;
-    let foundSmaller;
-
     while (hasPopulatedArrays(arrays)) {
         // first select the lowest array;
-        lowestWordArray = arrays[0];
+        let lowestWordArray = arrays[0];
+
         arrays.forEach(wordArray => {
             if (wordArray[0].begin < lowestWordArray[0].begin) {
                 lowestWordArray = wordArray;
@@ -205,23 +202,29 @@ transcriber.prototype.merge = function() {
         });
 
         // put the word in the transcription
-        wordToAdd = lowestWordArray.shift();
+        let wordToAdd = lowestWordArray.shift();
+
         this.updateTranscription(wordToAdd, lowestWordArray.name);
 
         // keep going until a word in another array has a smaller time
         // or the array is empty
-        while (!foundSmaller && lowestWordArray.length > 0) {
+        while (lowestWordArray.length > 0) {
+            let foundSmaller = false;
+            const wordToCompare = lowestWordArray[0].begin;
+
             arrays.forEach(wordArray => {
-                if (wordArray[0].begin < lowestWordArray[0].begin) {
+                if (wordArray[0].begin < wordToCompare) {
                     foundSmaller = true;
                 }
             });
 
             // add next word if no smaller time has been found
-            if (!foundSmaller) {
-                wordToAdd = lowestWordArray.shift();
-                this.updateTranscription(wordToAdd, null);
+            if (foundSmaller) {
+                break;
             }
+
+            wordToAdd = lowestWordArray.shift();
+            this.updateTranscription(wordToAdd, null);
         }
 
     }

modules/xmpp/SDP.js

@@ -270,6 +270,7 @@ SDP.prototype.toJingle = function(elem, thecreator) {
                 const ssrclines = SDPUtil.find_lines(this.media[i], 'a=ssrc:');
 
                 if (ssrclines.length > 0) {
+                    // eslint-disable-next-line no-loop-func
                     ssrclines.forEach(line => {
                         const idx = line.indexOf(' ');
                         const linessrc = line.substr(0, idx).substr(7);