Kaynağa Gözat

ref(video-quality): Resolve sender operations when RTCRtpSender/RTCRtpSendParameters are not found.

The constraints are applied again after renegotiation is done. This should mitigate a fail case on Safari when the RTCRtpSendParameters are not available until the simulcast streams are added via SDP munging before sLD is called.
dev1
Jaya Allamsetty 5 yıl önce
ebeveyn
işleme
7868a6c185
1 değiştirilmiş dosya ile 4 ekleme ve 4 silme
  1. 4
    4
      modules/RTC/TraceablePeerConnection.js

+ 4
- 4
modules/RTC/TraceablePeerConnection.js Dosyayı Görüntüle

@@ -2109,12 +2109,12 @@ TraceablePeerConnection.prototype.setMaxBitRate = function() {
2109 2109
     const videoSender = this.findSenderByKind(MediaType.VIDEO);
2110 2110
 
2111 2111
     if (!videoSender) {
2112
-        return Promise.reject(new Error('RTCRtpSender not found for local video'));
2112
+        return Promise.resolve();
2113 2113
     }
2114 2114
     const parameters = videoSender.getParameters();
2115 2115
 
2116 2116
     if (!(parameters.encodings && parameters.encodings.length)) {
2117
-        return Promise.reject(new Error('RTCRtpEncodingParameters not found for local video'));
2117
+        return Promise.resolve();
2118 2118
     }
2119 2119
 
2120 2120
     if (this.isSimulcastOn()) {
@@ -2258,12 +2258,12 @@ TraceablePeerConnection.prototype.setSenderVideoConstraint = function(frameHeigh
2258 2258
     const videoSender = this.findSenderByKind(MediaType.VIDEO);
2259 2259
 
2260 2260
     if (!videoSender) {
2261
-        return Promise.reject(new Error('RTCRtpSender not found for local video'));
2261
+        return Promise.resolve();
2262 2262
     }
2263 2263
     const parameters = videoSender.getParameters();
2264 2264
 
2265 2265
     if (!parameters || !parameters.encodings || !parameters.encodings.length) {
2266
-        return Promise.reject(new Error('RTCRtpSendParameters not found for local video track'));
2266
+        return Promise.resolve();
2267 2267
     }
2268 2268
 
2269 2269
     if (this.isSimulcastOn()) {

Loading…
İptal
Kaydet