Fix typos around permissions (#883)

* fix(permissions): remove space from requesting camera

Chrome errors on querying permissions with "camera "
because it does not match an expected enum.

* fix(permissions): check value of returned PermissionStatus

A permissions query returns an object with a status/status
of whether or not permission has been granted. Check that
value in addition to the existence of the object.

* fix(permissions): prevent permission being set to undefined

* ref(permissions): move permissions strings to constants

JitsiMediaDevices.js

@@ -8,6 +8,10 @@ import Statistics from './modules/statistics/statistics';
 
 import * as JitsiMediaDevicesEvents from './JitsiMediaDevicesEvents';
 
+const AUDIO_PERMISSION_NAME = 'microphone';
+const PERMISSION_GRANTED_STATUS = 'granted';
+const VIDEO_PERMISSION_NAME = 'camera';
+
 /**
  * Media devices utilities for Jitsi.
  */
@@ -47,7 +51,7 @@ class JitsiMediaDevices {
                 return;
             }
 
-            navigator.permissions.query({ name: 'camera ' })
+            navigator.permissions.query({ name: VIDEO_PERMISSION_NAME })
                 .then(() => resolve(true), () => resolve(false));
         });
     }
@@ -142,21 +146,37 @@ class JitsiMediaDevices {
                 switch (type) {
                 case MediaType.VIDEO:
                     promises.push(
-                        navigator.permissions.query({ name: 'camera' }));
+                        navigator.permissions.query({
+                            name: VIDEO_PERMISSION_NAME
+                        }));
                     break;
                 case MediaType.AUDIO:
                     promises.push(
-                        navigator.permissions.query({ name: 'microphone' }));
+                        navigator.permissions.query({
+                            name: AUDIO_PERMISSION_NAME
+                        }));
                     break;
                 default:
                     promises.push(
-                        navigator.permissions.query({ name: 'camera' }));
+                        navigator.permissions.query({
+                            name: VIDEO_PERMISSION_NAME
+                        }));
                     promises.push(
-                        navigator.permissions.query({ name: 'microphone' }));
+                        navigator.permissions.query({
+                            name: AUDIO_PERMISSION_NAME
+                        }));
                 }
 
                 Promise.all(promises).then(
-                    r => resolve(r.every(Boolean)),
+                    results => resolve(results.every(permissionStatus => {
+                        // The status attribute is deprecated, and state
+                        // should be used instead, but check both for now
+                        // for backwards compatibility.
+                        const grantStatus = permissionStatus.state
+                            || permissionStatus.status;
+
+                        return grantStatus === PERMISSION_GRANTED_STATUS;
+                    })),
                     () => resolve(false)
                 );
             });

modules/RTC/RTCUtils.js

@@ -494,8 +494,10 @@ function getTrackSSConstraints(options = {}) {
  * @param stream the stream we received from calling getUserMedia.
  */
 function updateGrantedPermissions(um, stream) {
-    const audioTracksReceived = stream && stream.getAudioTracks().length > 0;
-    const videoTracksReceived = stream && stream.getVideoTracks().length > 0;
+    const audioTracksReceived
+        = Boolean(stream) && stream.getAudioTracks().length > 0;
+    const videoTracksReceived
+        = Boolean(stream) && stream.getVideoTracks().length > 0;
     const grantedPermissions = {};
 
     if (um.indexOf('video') !== -1) {