Kaynağa Gözat

fix(JingleSession) Avoid pushing encodings configuration task to the queue.

When configureSenderVideoEncodings task is pushed to the modification queue, there might not be a setParameters call in progress and this new one will not get chanined to any promise. However, when the task finally is executed, there is a chance for another setParameters method execution to be in progress and can result in setParameters call failing. Also, these extra steps to ensure that the sender encodings are correctly encoded are no longer needed since with multi-stream mode, we do not change the source video type and the previous encodings config will still be valid.
master
Jaya Allamsetty 2 yıl önce
ebeveyn
işleme
87bce92fc6
1 değiştirilmiş dosya ile 0 ekleme ve 8 silme
  1. 0
    8
      modules/xmpp/JingleSessionPC.js

+ 0
- 8
modules/xmpp/JingleSessionPC.js Dosyayı Görüntüle

@@ -666,7 +666,6 @@ export default class JingleSessionPC extends JingleSession {
666 666
                     const oldSdp = new SDP(this.peerconnection.localDescription.sdp);
667 667
 
668 668
                     this._renegotiate()
669
-                        .then(() => this.peerconnection.configureSenderVideoEncodings())
670 669
                         .then(() => {
671 670
                             const newSdp = new SDP(this.peerconnection.localDescription.sdp);
672 671
 
@@ -2387,13 +2386,6 @@ export default class JingleSessionPC extends JingleSession {
2387 2386
                             && oldTrack.isVideoTrack()) {
2388 2387
                             newTrack.setSourceName(oldTrack.getSourceName());
2389 2388
                         }
2390
-
2391
-                        if (newTrack?.isVideoTrack()) {
2392
-                            logger.debug(`${this} replaceTrack worker: configuring video stream`);
2393
-
2394
-                            // Configure the video encodings after the track is replaced.
2395
-                            return this.peerconnection.configureSenderVideoEncodings(newTrack);
2396
-                        }
2397 2389
                     });
2398 2390
                 })
2399 2391
                 .then(() => finishedCallback(), error => finishedCallback(error));

Loading…
İptal
Kaydet