Merge pull request #110 from jitsi/restart_DC

Reopen data channels on ice restart

JitsiConference.js

@@ -942,6 +942,13 @@ function setupListeners(conference) {
         }
     });
 
+    conference.room.addListener(XMPPEvents.ICE_RESTARTING, function () {
+        // All data channels have to be closed, before ICE restart
+        // otherwise Chrome will not trigger "opened" event for the channel
+        // established with the new bridge
+        conference.rtc.closeAllDataChannels();
+    });
+
     conference.room.addListener(XMPPEvents.REMOTE_TRACK_ADDED,
         function (data) {
             var track = conference.rtc.createRemoteTrack(data);

modules/RTC/DataChannels.js

@@ -158,14 +158,24 @@ DataChannels.prototype.onDataChannel = function (event) {
     this._dataChannels.push(dataChannel);
 };
 
+/**
+ * Closes all currently opened data channels.
+ */
+DataChannels.prototype.closeAllChannels = function () {
+    this._dataChannels.forEach(function (dc){
+        // the DC will be removed from the array on 'onclose' event
+        dc.close();
+    });
+};
+
 DataChannels.prototype.handleSelectedEndpointEvent = function (userResource) {
     this.lastSelectedEndpoint = userResource;
     this._onXXXEndpointChanged("selected", userResource);
-}
+};
 
 DataChannels.prototype.handlePinnedEndpointEvent = function (userResource) {
     this._onXXXEndpointChanged("pinnned", userResource);
-}
+};
 
 /**
  * Notifies Videobridge about a change in the value of a specific
@@ -210,7 +220,7 @@ DataChannels.prototype._onXXXEndpointChanged = function (xxx, userResource) {
             return true;
         }
     });
-}
+};
 
 DataChannels.prototype._some = function (callback, thisArg) {
     var dataChannels = this._dataChannels;
@@ -223,6 +233,6 @@ DataChannels.prototype._some = function (callback, thisArg) {
     } else {
         return false;
     }
-}
+};
 
 module.exports = DataChannels;

modules/RTC/RTC.js

@@ -381,6 +381,13 @@ RTC.isDesktopSharingEnabled = function () {
     return RTCUtils.isDesktopSharingEnabled();
 };
 
+/**
+ * Closes all currently opened data channels.
+ */
+RTC.prototype.closeAllDataChannels = function () {
+    this.dataChannels.closeAllChannels();
+};
+
 RTC.prototype.dispose = function() {
 };
 

modules/xmpp/JingleSessionPC.js

@@ -491,13 +491,29 @@ JingleSessionPC._fixAnswerRFC4145Setup = function (offer, answer) {
 JingleSessionPC.prototype.replaceTransport = function (jingleOfferElem,
                                                        success,
                                                        failure) {
-    // Set offer as RD
-    this.setOfferCycle(jingleOfferElem,
-        function () {
-            // Set local description OK, now localSDP up to date
-            this.sendTransportAccept(this.localSDP, success, failure);
-        }.bind(this),
-        failure);
+    
+    // We need to first set an offer without the 'data' section to have the SCTP
+    // stack cleaned up. After that the original offer is set to have the SCTP
+    // connection established with the new bridge.
+    this.room.eventEmitter.emit(XMPPEvents.ICE_RESTARTING);
+    var originalOffer = jingleOfferElem.clone();
+    jingleOfferElem.find(">content[name='data']").remove();
+
+    var self = this;
+    // First set an offer without the 'data' section
+    this.setOfferCycle(
+        jingleOfferElem,
+        function() {
+            // Now set the original offer(with the 'data' section)
+            self.setOfferCycle(originalOffer,
+                function () {
+                    // Set local description OK, now localSDP up to date
+                    self.sendTransportAccept(self.localSDP, success, failure);
+                },
+                failure);
+        },
+        failure
+    );
 };
 
 /**

service/xmpp/XMPPEvents.js

@@ -43,6 +43,11 @@ var XMPPEvents = {
     FOCUS_DISCONNECTED: 'xmpp.focus_disconnected',
     FOCUS_LEFT: "xmpp.focus_left",
     GRACEFUL_SHUTDOWN: "xmpp.graceful_shutdown",
+    /**
+     * Event fired when 'transport-replace' Jingle message has been received,
+     * before the new offer is set on the PeerConnection.
+     */
+    ICE_RESTARTING: "rtc.ice_restarting",
     /* Event fired when XMPP error is returned to any request, it is meant to be
      * used to report 'signaling' errors to CallStats
      *