fix: Always query the main domain for features. Fixes jitsi/jitsi-meet#8173 (#1428)

* fix: Always query the main domain for features.

* squash: Always use the main domain for turn credentials and ping.

* squash: Fix tests.

modules/xmpp/XmppConnection.js

@@ -51,6 +51,7 @@ export default class XmppConnection extends Listenable {
         super();
         this._options = {
             enableWebsocketResume: typeof enableWebsocketResume === 'undefined' ? true : enableWebsocketResume,
+            pingOptions: xmppPing,
             websocketKeepAlive: typeof websocketKeepAlive === 'undefined' ? 4 * 60 * 1000 : Number(websocketKeepAlive)
         };
 
@@ -255,7 +256,7 @@ export default class XmppConnection extends Listenable {
             this._maybeStartWSKeepAlive();
             this._processDeferredIQs();
             this._resumeTask.cancel();
-            this.ping.startInterval(this.domain);
+            this.ping.startInterval(this._options.pingOptions?.domain || this.domain);
         } else if (status === Strophe.Status.DISCONNECTED) {
             this.ping.stopInterval();
 

modules/xmpp/strophe.jingle.js

@@ -305,7 +305,7 @@ export default class JingleConnectionPlugin extends ConnectionPlugin {
         //      https://code.google.com/p/webrtc/issues/detail?id=1650
         this.connection.sendIQ(
             $iq({ type: 'get',
-                to: this.connection.domain })
+                to: this.xmpp.options.hosts.domain })
                 .c('services', { xmlns: 'urn:xmpp:extdisco:1' }),
             res => {
                 const iceservers = [];

modules/xmpp/xmpp.js

@@ -106,6 +106,11 @@ export default class XMPP extends Listenable {
 
         initStropheNativePlugins();
 
+        const xmppPing = options.xmppPing || {};
+
+        // let's ping the main domain (in case a guest one is used for the connection)
+        xmppPing.domain = options.hosts.domain;
+
         this.connection = createConnection({
             enableWebsocketResume: options.enableWebsocketResume,
 
@@ -113,7 +118,7 @@ export default class XMPP extends Listenable {
             serviceUrl: options.serviceUrl || options.bosh,
             token,
             websocketKeepAlive: options.websocketKeepAlive,
-            xmppPing: options.xmppPing
+            xmppPing
         });
 
         this._initStrophePlugins();
@@ -227,15 +232,12 @@ export default class XMPP extends Listenable {
             // XmppConnection emits CONNECTED again on reconnect - a good opportunity to clear any "last error" flags
             this._resetState();
 
-            // Schedule ping ?
-            const pingJid = this.connection.domain;
-
             // FIXME no need to do it again on stream resume
-            this.caps.getFeaturesAndIdentities(pingJid)
+            this.caps.getFeaturesAndIdentities(this.options.hosts.domain)
                 .then(({ features, identities }) => {
                     if (!features.has(Strophe.NS.PING)) {
-                        logger.error(
-                            `Ping NOT supported by ${pingJid} - please enable ping in your XMPP server config`);
+                        logger.error(`Ping NOT supported by ${
+                            this.options.hosts.domain} - please enable ping in your XMPP server config`);
                     }
 
                     // check for speakerstats
@@ -539,7 +541,7 @@ export default class XMPP extends Listenable {
     ping(timeout) {
         return new Promise((resolve, reject) => {
             this.connection.ping
-                    .ping(this.connection.domain, resolve, reject, timeout);
+                    .ping(this.connection.options.hosts.domain, resolve, reject, timeout);
         });
     }