Browse Source

Merge pull request #340 from bgrozev/fix-simulcast-support-check

fix: Use the same logic as sdp-simulcast in
dev1
bbaldino 8 years ago
parent
commit
968fdaca6f
2 changed files with 5 additions and 3 deletions
  1. 4
    1
      modules/RTC/RTCBrowserType.js
  2. 1
    2
      modules/connectivity/ConnectionQuality.js

+ 4
- 1
modules/RTC/RTCBrowserType.js View File

164
      * @returns {boolean}
164
      * @returns {boolean}
165
      */
165
      */
166
     supportsSimulcast: function() {
166
     supportsSimulcast: function() {
167
-        return RTCBrowserType.isChrome();
167
+        // This mirrors what sdp-simulcast uses (which is used when deciding
168
+        // whether to actually enable simulcast or not).
169
+        // TODO: the logic should be in one single place.
170
+        return !!window.chrome;
168
     }
171
     }
169
 
172
 
170
     // Add version getters for other browsers when needed
173
     // Add version getters for other browsers when needed

+ 1
- 2
modules/connectivity/ConnectionQuality.js View File

121
 
121
 
122
         /**
122
         /**
123
          * Whether simulcast is supported. Note that even if supported, it is
123
          * Whether simulcast is supported. Note that even if supported, it is
124
-         * currently not used for screensharing, which is why we have an
125
-         * additional check.
124
+         * currently not used for screensharing.
126
          */
125
          */
127
         this._simulcast
126
         this._simulcast
128
             = !options.disableSimulcast && RTCBrowserType.supportsSimulcast();
127
             = !options.disableSimulcast && RTCBrowserType.supportsSimulcast();

Loading…
Cancel
Save