ref(feedback): return promise for submitting callstats feedback

JitsiConference.js

@@ -2251,11 +2251,12 @@ JitsiConference.prototype.getLocalParticipantProperty = function(name) {
  * @param overallFeedback an integer between 1 and 5 indicating the
  * user feedback
  * @param detailedFeedback detailed feedback from the user. Not yet used
+ * @returns {Promise} Resolves if feedback is submitted successfully.
  */
 JitsiConference.prototype.sendFeedback = function(
         overallFeedback,
         detailedFeedback) {
-    this.statistics.sendFeedback(overallFeedback, detailedFeedback);
+    return this.statistics.sendFeedback(overallFeedback, detailedFeedback);
 };
 
 /**

modules/statistics/CallStats.js

@@ -470,16 +470,29 @@ export default class CallStats {
      * @param comment detailed feedback from the user.
      */
     static sendFeedback(conferenceID, overall, comment) {
-        if (CallStats.backend) {
-            CallStats.backend.sendUserFeedback(
-                conferenceID, {
-                    userID: CallStats.userID,
-                    overall,
-                    comment
-                });
-        } else {
-            logger.error('Failed to submit feedback to CallStats - no backend');
-        }
+        return new Promise((resolve, reject) => {
+            if (CallStats.backend) {
+                CallStats.backend.sendUserFeedback(
+                    conferenceID,
+                    {
+                        userID: CallStats.userID,
+                        overall,
+                        comment
+                    },
+                    (status, message) => {
+                        if (status === 'success') {
+                            resolve(message);
+                        } else {
+                            reject(message);
+                        }
+                    });
+            } else {
+                const reason = 'Failed to submit feedback to CallStats - no backend';
+
+                logger.error(reason);
+                reject(reason);
+            }
+        });
     }
 
     /**

modules/statistics/statistics.js

@@ -670,15 +670,20 @@ Statistics.sendLog = function(m) {
  *
  * @param overall an integer between 1 and 5 indicating the user's rating.
  * @param comment the comment from the user.
+ * @returns {Promise} Resolves when callstats feedback has been submitted
+ * successfully.
  */
 Statistics.prototype.sendFeedback = function(overall, comment) {
-    CallStats.sendFeedback(this.options.confID, overall, comment);
+    // Statistics.analytics.sendEvent is currently fire and forget, without
+    // confirmation of successful send.
     Statistics.analytics.sendEvent(
         FEEDBACK,
         {
             rating: overall,
             comment
         });
+
+    return CallStats.sendFeedback(this.options.confID, overall, comment);
 };
 
 Statistics.LOCAL_JID = require('../../service/statistics/constants').LOCAL_JID;