Browse Source

ignore duplicate jibri status updates (#831)

* ignore duplicate jibri status updates

* re-add mistakenly removed return
dev1
bbaldino 7 years ago
parent
commit
9dfd76caf1
No account linked to committer's email address
1 changed files with 14 additions and 0 deletions
  1. 14
    0
      modules/recording/RecordingManager.js

+ 14
- 0
modules/recording/RecordingManager.js View File

202
             return;
202
             return;
203
         }
203
         }
204
 
204
 
205
+        // Jicofo sends updates via presence, and any extension in presence
206
+        // is sent until it is explicitly removed.  It's difficult for
207
+        // Jicofo to know when a presence has been sent once, so it won't
208
+        // remove jibri status extension.  This means we may receive the same
209
+        // status update more than once, so check for that here
210
+        if (session
211
+            && session.getStatus() === status
212
+            && session.getError() === error) {
213
+            logger.warn('Ignoring duplicate presence update: ',
214
+                JSON.stringify(jibriStatus));
215
+
216
+            return;
217
+        }
218
+
205
         if (!session) {
219
         if (!session) {
206
             session = this._createSession(sessionID, status, recordingMode);
220
             session = this._createSession(sessionID, status, recordingMode);
207
         }
221
         }

Loading…
Cancel
Save