Sfoglia il codice sorgente

fix(qualitycontrol) SenderVideoConstraintsV2 changed to SenderSourceConstraints.

The colibri class name for the source name sender constraints changed from SenderVideoConstraintsV2 to SenderSourceConstraints.
The new format is {colibriClass: 'SenderSourceConstraints', sourceName: 'b6746083-v0', maxHeight: 180}
dev1
Jaya Allamsetty 3 anni fa
parent
commit
9eb93e0ed4

+ 6
- 6
modules/RTC/BridgeChannel.js Vedi File

@@ -376,21 +376,21 @@ export default class BridgeChannel {
376 376
                 }
377 377
                 break;
378 378
             }
379
-            case 'SenderVideoConstraintsV2': {
379
+            case 'SenderSourceConstraints': {
380 380
                 if (FeatureFlags.isSourceNameSignalingEnabled()) {
381
-                    const { sourceName, idealHeight } = obj;
381
+                    const { sourceName, maxHeight } = obj;
382 382
 
383
-                    if (typeof sourceName === 'string' && typeof idealHeight === 'number') {
383
+                    if (typeof sourceName === 'string' && typeof maxHeight === 'number') {
384 384
                         // eslint-disable-next-line object-property-newline
385
-                        logger.info(`SenderVideoConstraintsV2: ${JSON.stringify({ sourceName, idealHeight })}`);
385
+                        logger.info(`SenderSourceConstraints: ${JSON.stringify({ sourceName, maxHeight })}`);
386 386
                         emitter.emit(
387 387
                             RTCEvents.SENDER_VIDEO_CONSTRAINTS_CHANGED, {
388 388
                                 sourceName,
389
-                                idealHeight
389
+                                maxHeight
390 390
                             }
391 391
                         );
392 392
                     } else {
393
-                        logger.error(`Invalid SenderVideoConstraintsV2: ${JSON.stringify(obj)}`);
393
+                        logger.error(`Invalid SenderSourceConstraints: ${JSON.stringify(obj)}`);
394 394
                     }
395 395
                 }
396 396
                 break;

+ 4
- 4
modules/qualitycontrol/SendVideoController.js Vedi File

@@ -90,16 +90,16 @@ export default class SendVideoController {
90 90
      */
91 91
     _onSenderConstraintsReceived(videoConstraints) {
92 92
         if (FeatureFlags.isSourceNameSignalingEnabled()) {
93
-            const { idealHeight, sourceName } = videoConstraints;
93
+            const { maxHeight, sourceName } = videoConstraints;
94 94
             const localVideoTracks = this._conference.getLocalVideoTracks() ?? [];
95 95
 
96 96
             for (const track of localVideoTracks) {
97 97
                 // Propagate the sender constraint only if it has changed.
98 98
                 if (track.getSourceName() === sourceName
99 99
                     && (!this._sourceSenderConstraints.has(sourceName)
100
-                    || this._sourceSenderConstraints.get(sourceName) !== idealHeight)) {
101
-                    this._sourceSenderConstraints.set(sourceName, idealHeight);
102
-                    logger.debug(`Sender constraints for source:${sourceName} changed to idealHeight:${idealHeight}`);
100
+                    || this._sourceSenderConstraints.get(sourceName) !== maxHeight)) {
101
+                    this._sourceSenderConstraints.set(sourceName, maxHeight);
102
+                    logger.debug(`Sender constraints for source:${sourceName} changed to maxHeight:${maxHeight}`);
103 103
                     this._propagateSendMaxFrameHeight(sourceName);
104 104
                 }
105 105
             }

Loading…
Annulla
Salva