Selaa lähdekoodia

fix(TPC) Remove video track from pc on mute for Firefox.

We do not want Firefox sending video when its video muted. https://bugzilla.mozilla.org/show_bug.cgi?id=1735951
dev1
Jaya Allamsetty 4 vuotta sitten
vanhempi
commit
a68af903d0
1 muutettua tiedostoa jossa 6 lisäystä ja 6 poistoa
  1. 6
    6
      modules/browser/BrowserCapabilities.js

+ 6
- 6
modules/browser/BrowserCapabilities.js Näytä tiedosto

@@ -26,14 +26,14 @@ export default class BrowserCapabilities extends BrowserDetection {
26 26
     }
27 27
 
28 28
     /**
29
-     * Tells whether or not the <tt>MediaStream/tt> is removed from
30
-     * the <tt>PeerConnection</tt> and disposed on video mute (in order to turn
31
-     * off the camera device).
32
-     * @return {boolean} <tt>true</tt> if the current browser supports this
33
-     * strategy or <tt>false</tt> otherwise.
29
+     * Tells whether or not the <tt>MediaStream/tt> is removed from the <tt>PeerConnection</tt> and disposed on video
30
+     * mute (in order to turn off the camera device). This is needed on Firefox because of the following bug
31
+     * https://bugzilla.mozilla.org/show_bug.cgi?id=1735951
32
+     *
33
+     * @return {boolean} <tt>true</tt> if the current browser supports this strategy or <tt>false</tt> otherwise.
34 34
      */
35 35
     doesVideoMuteByStreamRemove() {
36
-        return this.isChromiumBased() || this.isWebKitBased();
36
+        return this.isChromiumBased() || this.isWebKitBased() || this.isFirefox();
37 37
     }
38 38
 
39 39
     /**

Loading…
Peruuta
Tallenna